From nobody Mon Feb 9 03:15:55 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D1124B22C for ; Sat, 11 Jan 2025 09:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736586857; cv=none; b=CqG9QLR6+/6fDSuPlu9gJyuYCa1cjDww+/o0Q0LRRx+78vAZBH/5yT7p346dxi1AXNCIE1UOvj5kSrCWhF3/jWxf3iBc0dqgg4cPIAZXXV1lN1DYkATy9NwDB+l84BDbFoyPw6kVEhm3eBMgk2z/b98zEqBC0q7OUUs2tP+OZ28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736586857; c=relaxed/simple; bh=HY+qwwHxVYVMgTSwWggPa6r1h5LBQSGRSuOtSSQ7dx8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KY0RVGO2GigLilFPYGyMGkyRL8D0YB/OBJj/ODoQBcKTSJ25cZfeeFU6vL6yLxOUUg9L7Rj63oLv3JPWmXfLndJnA10/30VwWPcGxD0tsbOrQyU+PfAe/j/IAiAveByqsTLUIGYWWPFcUCpZpH4dRsLqzEaSzcyaSAra7Kw+d1M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ErnIDBlh; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ErnIDBlh" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43623f0c574so20361295e9.2 for ; Sat, 11 Jan 2025 01:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736586854; x=1737191654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uPnKQv6GFA2nYTe22sfyr+c7cIYy3zwzji8CJh7nXAo=; b=ErnIDBlhp94yKrD0DX0mlvYQfUyNUswr/VCj4HQx/dbQrYH0qIUSaf9v5F8D1CheI6 NXovqA5bzmcLSVJKpl9IM6xNy2LlqUTm4CtArhueWvrmDFZ/42nbiDHD+zP0HGIcSYVC vzcKUcD5KdgS2XqSL8TMiTn6im8kV5DXcui7Aq6SSYYp1gJrnBayFiRZCvPgYc5RFCfY 9eojssqIoEdQkvCXaqCeqPVkB/2a0zZuP9m5WOr/bFly/WbeJXDTLfEPkIQOs9x08ABr sRWamW8Jg6Vy2uqXsfm825hWYb72GZoqHiubMcIdsmU+OllAh6HhZjRBZRB+jKJbron1 JXWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736586854; x=1737191654; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uPnKQv6GFA2nYTe22sfyr+c7cIYy3zwzji8CJh7nXAo=; b=jBIXyn9PgfZAso36UwaE+pSXeqJv1up3TjzAdgGTIdIOK5agRv9MRVXpktHENNd3gy yFDe5m5tiQetGHYcVturlq/eZeT9nIGw5VUBaKG6y4Aw7BEdOe/2kpe4oDZ35MkJq49f D61TkIlXR3XIgsq9SKWex5jnoaIJ9+diynF9RmXoZIvA0Xzx/QK3UVH48RhSuk0GpWzu LRgjQPTrf3+IySD3nHUWAQsHIBO4YYuK5SoUbn/ybC1jY2Q5lg/+HHndo31MakB3uNYQ dWYoNGYv/+h9zQajFCMjJv5hTrG8ntTaoWIxj3zJjUSKPbYB3V/FIRfV4evpmFpU1TdM IJyQ== X-Forwarded-Encrypted: i=1; AJvYcCXcoBpQ10JNTQDqdb0CCbtLRVZgJgjdKQj2LZ3sBIj0YOdSKTxmSupjKOzXMKVi1K3PIkLKoBPDuZsra5M=@vger.kernel.org X-Gm-Message-State: AOJu0YyMsXXJN158YijGuTsCtrWCwR39FSjUaJwGy0LhX2gklgwneT3U KS9+92pIAYSTesa+RTKjTHnjFArI9Gbl7VuTS45eBpHvvcnRHZxq+P9Lr2fQPL0= X-Gm-Gg: ASbGncuSz1PvCDuS0wginsUKLiNvS0HAM34b+IQ51xTI3EzLPYcYBA79hhZo1iJRMzs 8CtrKGiKqYtElXJvpSdPjeYmh6gv8FcOS24sRSMIbcnIWL2dPEwsHE3+yHu4hOG4PtcJK4390U3 ZW7mnVKOtGgCe1rFsT1uA8lg8phO4iJiyA+IFIFuG0PttmVSRfwo/JAgmB6RC2T+wnpPTBwMuq/ /XvI4PTONXvbrxdNk5Z2LnQc1PlUnv5MFlnPg47Fvd54qp5V9gClPYGuSQn4kZQ X-Google-Smtp-Source: AGHT+IF70V04jqXlfPPNHdYSibQe0Nmu2xy0ReZhn3nZqlo7vx0fx+nK3tPfeB90wJcE3RM+317UQQ== X-Received: by 2002:a05:600c:4f42:b0:434:a4a6:51f8 with SMTP id 5b1f17b1804b1-436e2555edcmr135903465e9.0.1736586853509; Sat, 11 Jan 2025 01:14:13 -0800 (PST) Received: from vingu-cube.. ([2a01:e0a:f:6020:ad69:a76:1bf1:b58e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e03e5fsm76403025e9.18.2025.01.11.01.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 01:14:12 -0800 (PST) From: Vincent Guittot To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org Cc: Vincent Guittot , Phil Auld Subject: [PATCH v2] sched/fair: Encapsulate set custom slice in a __setparam_fair() function Date: Sat, 11 Jan 2025 10:14:09 +0100 Message-ID: <20250111091410.921012-1-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Similarly to dl, create a __setparam_fair() function to set parameters related to fair class and move it in the fair.c file. No functional changes expected Signed-off-by: Vincent Guittot Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Phil Auld Link: https://lore.kernel.org/r/20250110144656.484601-1-vincent.guittot@lin= aro.org --- - Fix a compilation error reported by . Move __setparam_fair= () out of CONFIG_SMP - Remove unused util_est variable kernel/sched/fair.c | 19 +++++++++++++++++++ kernel/sched/sched.h | 2 ++ kernel/sched/syscalls.c | 16 +++------------- 3 files changed, 24 insertions(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b3418b5d484f..7ec25874a819 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -37,6 +37,7 @@ #include #include #include +#include =20 #include #include @@ -51,6 +52,8 @@ =20 #include =20 +#include + #include "sched.h" #include "stats.h" #include "autogroup.h" @@ -5258,6 +5261,22 @@ static inline void update_misfit_status(struct task_= struct *p, struct rq *rq) {} =20 #endif /* CONFIG_SMP */ =20 +void __setparam_fair(struct task_struct *p, const struct sched_attr *attr) +{ + struct sched_entity *se =3D &p->se; + + p->static_prio =3D NICE_TO_PRIO(attr->sched_nice); + if (attr->sched_runtime) { + se->custom_slice =3D 1; + se->slice =3D clamp_t(u64, attr->sched_runtime, + NSEC_PER_MSEC/10, /* HZ=3D1000 * 10 */ + NSEC_PER_MSEC*100); /* HZ=3D100 / 10 */ + } else { + se->custom_slice =3D 0; + se->slice =3D sysctl_sched_base_slice; + } +} + static void place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) { diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index aef716c41edb..300db6fe53eb 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3500,6 +3500,8 @@ unsigned long scale_irq_capacity(unsigned long util, = unsigned long irq, unsigned =20 #endif /* !CONFIG_HAVE_SCHED_AVG_IRQ */ =20 +extern void __setparam_fair(struct task_struct *p, const struct sched_attr= *attr); + #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) =20 #define perf_domain_span(pd) (to_cpumask(((pd)->em_pd->cpus))) diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c index ff0e5ab4e37c..286eb72f44ae 100644 --- a/kernel/sched/syscalls.c +++ b/kernel/sched/syscalls.c @@ -300,20 +300,10 @@ static void __setscheduler_params(struct task_struct = *p, =20 p->policy =3D policy; =20 - if (dl_policy(policy)) { + if (dl_policy(policy)) __setparam_dl(p, attr); - } else if (fair_policy(policy)) { - p->static_prio =3D NICE_TO_PRIO(attr->sched_nice); - if (attr->sched_runtime) { - p->se.custom_slice =3D 1; - p->se.slice =3D clamp_t(u64, attr->sched_runtime, - NSEC_PER_MSEC/10, /* HZ=3D1000 * 10 */ - NSEC_PER_MSEC*100); /* HZ=3D100 / 10 */ - } else { - p->se.custom_slice =3D 0; - p->se.slice =3D sysctl_sched_base_slice; - } - } + else if (fair_policy(policy)) + __setparam_fair(p, attr); =20 /* rt-policy tasks do not have a timerslack */ if (rt_or_dl_task_policy(p)) { --=20 2.43.0