From nobody Mon Feb 9 21:21:00 2026 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD16C18E03A for ; Sat, 11 Jan 2025 09:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589348; cv=none; b=ONE47j0OYGB66kyxu0p1h9BYvv/SABysAhMbFe5O4i0T8yp/LN5GFZ+Y8x6cCycIC5EjnXw5mOKFPQ1GO3uy3cdS/DVrOF8hKpzGlGPl76IrnBJFNGMffqZ7qMgjlwLYwyvNHP1WOwjuVls19ubRPsbSHNAxdhwKzm6RK90aYMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589348; c=relaxed/simple; bh=hAlPOuL4YIiXg0HpbIYhah7+pVVbm4tj/0Q43k0VF20=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aR5w4jXs5JgZMkuDUeYmjDyItKuYiBsrAf7KFSY4LTUBLAbqEjpWt0pY7pRkBmMBIDppUm/wvU3sfzCtxee3SyhMK4lWIThjMkRKXyXbmt9KwAagc60nwDKKwAUlm1q6LPGpl9ik/5WELOUBnqMTMZWmd0PV0AAjWGRAlJ7nHZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Byikv/yQ; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Byikv/yQ" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6dcc42b5e30so32496216d6.1 for ; Sat, 11 Jan 2025 01:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736589346; x=1737194146; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=x7AhuqiCmj982Ah3x3XQKiIUQdsA0iVwLzLzuPzwXZk=; b=Byikv/yQr2DTWWcm+BUahySsBIeRKuBMGDKQOVY7pMU+1soqiCwRdtLWjhImdqfeuD ux5mjLck0KxKvdA290y9Myumtzfgvjger28xu0Vga6dJlT3p1adboIh/4Bva4mBOqqwF SIyE0pjS/QrGOlG6OBEfI8ZDRfv4GEXPYnj74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736589346; x=1737194146; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x7AhuqiCmj982Ah3x3XQKiIUQdsA0iVwLzLzuPzwXZk=; b=qlY9qly9NL/AQOgY1dMFYV7FvZlFqZpkZpZlMo/Vu9kBZfNgI/p0Vx/gPlFRXoaHLK Bw0uCoGWiop9BnQR9I0FDfHiNsF93S9g3Njovx9+xK1WNuRKbZ4ng45cjt38RQ+7/46T h+sxFabgwWes8nqCa3Cp1bv+b6RyelLTN4g4YPVi2HS6+fa0oTRzd9cMGU6vErtG2AaP 5dZchIF85NwB5Hjj2bg7u3LcnM2TvszEVzrj/oF5DD+mot1vfaJHZvsErQJEf6B/TZFu B9ZaIRKl6vNGc40VG0ZYzRdPgCQEiDc0Q7c4QTB3D2LL62Z+bbR6yaidKVb4JSOwH3XN qvhA== X-Forwarded-Encrypted: i=1; AJvYcCUprN3XTShSxZdRBFo77aPwTo/4PVKUoVGP0J4HbWZbhJeqgy/7nwRE5+ZOun3x1VNTRYL8JrL5gLnreH0=@vger.kernel.org X-Gm-Message-State: AOJu0YyLvQZHg4c7I37LdWkfkS2nb6sEcKO2mHl+cVNUeogjQ3BtWJ2I LtZBv+bCZaDoe4iZ0zq51XabUlMZY9WLVYqeh1AHtv6AbDwqtSZZXRyFS4XoIRl8/Q2t4zEg0wD wRQ== X-Gm-Gg: ASbGnctDv8HnJvyIcW+gqAb9+o8dw/lyKNO55ckh3fDKqe975ybZ60oXTRe6gJcXVTr Her4ceiteba0rm0ztSRbhlc1NpPiimKkXj9ut7gEBS5CICtoq8r0Pzh1WBjiLpE/DtjhQ3KCt5d tmQP05WjNfZJTrq71zK9yQ0T8LPWSOnh8tIcDqmiPY8X9FRO+toah6cOmgVadyrgacgYaEsqJb0 RWU0E5zI+7itzmUq9hE4sff3KGCj8Pqr0okQ9HVce+H7KGeh62wx4q5pz2eVGZqXPGM8JyH4lWp gO0kIUr1EPkcv+hW3XAGYE9Iqrps0YETj3Yh X-Google-Smtp-Source: AGHT+IFPc65u5Xb9RCjGLJ3Jl3Vf9y0Du5AsKFgmKuWXejd7Aufwu6k8jsIz9OTvYdbOGhoPzK7nZw== X-Received: by 2002:a05:620a:462c:b0:7b6:d0bd:c7e6 with SMTP id af79cd13be357-7bcd9759db8mr2313763885a.32.1736589334727; Sat, 11 Jan 2025 01:55:34 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce327b8besm267096785a.59.2025.01.11.01.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 01:55:33 -0800 (PST) From: Ricardo Ribalda Date: Sat, 11 Jan 2025 09:55:19 +0000 Subject: [PATCH v6 6/6] media: venus: vdec: Make the range of us_per_frame explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250111-fix-cocci-v6-6-1aa7842006cc@chromium.org> References: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> In-Reply-To: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. There is no need to do a 64 bit division here. Also, the driver only works with whole fps. Found by cocci: drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a = 64-by-32 division, please consider using div64_u64 instead. Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda Reviewed-by: Vikash Garodia Tested-by: Bryan O'Donoghue # qrb5615-rb5 --- drivers/media/platform/qcom/venus/vdec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platf= orm/qcom/venus/vdec.c index e160a5508154..aa9ba38186b8 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -484,8 +484,7 @@ static int vdec_s_parm(struct file *file, void *fh, str= uct v4l2_streamparm *a) do_div(us_per_frame, timeperframe->denominator); =20 us_per_frame =3D max(USEC_PER_SEC, us_per_frame); - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + fps =3D USEC_PER_SEC / (u32)us_per_frame; fps =3D min(VENUS_MAX_FPS, fps); =20 inst->fps =3D fps; --=20 2.47.1.613.gc27f4b7a9f-goog