From nobody Mon Feb 9 19:06:58 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C4881917D7 for ; Sat, 11 Jan 2025 09:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589331; cv=none; b=AH3q8YeiBOmJGD4aJ5CBZ9RG1023VxDtHMfQitP7klRYfDu5AASXh5s1UgoceA/hSpxawZxdx/Ikexb/NUkdhp5iEA3JDy5d5de4aDa6t19VUOxUE17j6OzKBtP3yDh6x1wdktRDFOHQQSaEqoCQJRMjEluKVhvJ0pNi9Yi4taI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589331; c=relaxed/simple; bh=+5gKBR6lmCbLgDxwlcOKTLF2APbAil9sB0eDtQkBz/w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZvXiVAPiCqKfIIN4+2yqRTLQFAflD9kDxPoJZ3hESdelDm4271ifPuKzH45WzZOZt4WsuYcC1+G36nlsgykF+feIyDQ0HHI/P+uuqUX5vedjC5U6V6jbBDAXsKD8/ojfcLYT/5/rw1X2GXqv5WrGNXUutfakkcMtFuGQBrG70ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=C96bSz6T; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="C96bSz6T" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7b8618be68bso228674885a.3 for ; Sat, 11 Jan 2025 01:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736589328; x=1737194128; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oGXizJerOok0lDZxPeMPfVFSvShgmDlyLJgvxCS81kE=; b=C96bSz6TaoQXqnsfWjFREu7KcD0EjOj6CbbnAHPSV2wqMTwI6pYbppEnh56C8ciRLt H/6p4gZMwGnmmDFNwcYC9KGNozEAzwSgg1WjdQioFifHmeBNay88+Q2Nqm16gdQZszcM ZX50gFtVpauN4oFNajPz3VpJMepN/dQNUDEQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736589328; x=1737194128; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGXizJerOok0lDZxPeMPfVFSvShgmDlyLJgvxCS81kE=; b=iZsqFjYKFCnHudwRTZ/2m+Iu8auZbt2ZCsV3Mc05JzgwecE3TlzCL0Ba5xHwnn/1kZ yInonnFxjV5QtR7nNimFrnVWUBo/GCHpnRTMcYOdiMSUqpwOqmTNXYWixDcBzpOcb2Ls SqkgvEtqMgWrk+AxkK+I/6CCp+xbsxddG+DS9iifBEwf26eKbit75O1zkipK/byJTUhg y5c4iDxJOFcKU5gI/5x79q7ditk/Hb8uE7TpHYhWCkAfQA4NEZmRMcUd4N4+r3QI317d NtI+NeOxB6MSjh5R+Ua1MocU37HWfMyTU4BtwtEJRzOrSyXywbWJEftHjecpyxKzf0ag +44Q== X-Forwarded-Encrypted: i=1; AJvYcCVQ6Criqd+doIdXAdAYJ8JukbYHYzbfWXHVQrVvmYHDpJTg+Uav/cnTiKp7N68W6YUc4Zq/1ksfEZeQGHs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyep+q87h7chdINP9qLi1Atw1uBF1DSYRRmO0vxt95O4JMATh0r En0tzb7W48sRqQuJHFrIN0wcIPA2nEdwRuj846zz8CWJGnsznnrTaiWrOwDO6A== X-Gm-Gg: ASbGnctAKudKWGCDw5CDdh4jXvpmrXVJp7Yf9pKZKAfT3qMpiNK1zCDjMzHQwlIRrBX Q0AuZIpfqrL+lZzb8Y/PA/m1voUdB3l1/ao3wHovVrHwl2EibcbBEOiLEMqjs4ngxu+kwc5Lx0A J9Y4vTNcXOsTf6AGYMcg76VryRp8tBQ+2J9spnfX5YTtXQl5aVvnflqqUgsdfnw0ze0+17Iq6pe OMF3hE+l5HX8qw5g3XliwPbr38AhBYdWvKLrI++VR9YcL5uenjShMFHYLXcaqCftOWOxkweLgOi VFyl+WYUxjuhY25yZSrehGF8t6H/klxbc3lz X-Google-Smtp-Source: AGHT+IEpVR9I5biYuCr+SXV0UBeBGfKSe31bfLKgP7VOr+BuuQiGS7W1xlNlsmHP///j6pnH4LIVBQ== X-Received: by 2002:a05:620a:462b:b0:7b6:c540:9531 with SMTP id af79cd13be357-7bcd974a281mr2043337685a.18.1736589328570; Sat, 11 Jan 2025 01:55:28 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce327b8besm267096785a.59.2025.01.11.01.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 01:55:27 -0800 (PST) From: Ricardo Ribalda Date: Sat, 11 Jan 2025 09:55:16 +0000 Subject: [PATCH v6 3/6] media: venus: venc: Clamp parm smaller than 1fps and bigger than 240 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250111-fix-cocci-v6-3-1aa7842006cc@chromium.org> References: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> In-Reply-To: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The driver uses "whole" fps in all its calculations (e.g. in load_per_instance()). Those calculation expect an fps bigger than 1, and not big enough to overflow. Clamp the parm if the user provides a value that will result in an invalid fps. Reported-by: Hans Verkuil Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147= 453e4@xs4all.nl/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0 Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files") Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/venc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platf= orm/qcom/venus/venc.c index c1c543535aaf..943d432b6568 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -411,11 +411,10 @@ static int venc_s_parm(struct file *file, void *fh, s= truct v4l2_streamparm *a) us_per_frame =3D timeperframe->numerator * (u64)USEC_PER_SEC; do_div(us_per_frame, timeperframe->denominator); =20 - if (!us_per_frame) - return -EINVAL; - + us_per_frame =3D max(USEC_PER_SEC, us_per_frame); fps =3D (u64)USEC_PER_SEC; do_div(fps, us_per_frame); + fps =3D min(VENUS_MAX_FPS, fps); =20 inst->timeperframe =3D *timeperframe; inst->fps =3D fps; --=20 2.47.1.613.gc27f4b7a9f-goog