From nobody Mon Feb 9 08:41:44 2026 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9F312905 for ; Fri, 10 Jan 2025 07:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736495919; cv=none; b=GqmEVVG0npnxEwK2S7jjhi77tSVlGcIxgZXbbUUZ/AQ/EAOekmjWfPbEpk636/Mv4Ahr/wJ/juvnSt7DKLeTX5TVS8cCmvT2XJAuZ9RU+GbZyyFr+0w0aE4lNKsMdM4B8u4SZBSUUuztyGRt6Go5gK48oFJxiciO0LtNI9qusn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736495919; c=relaxed/simple; bh=qryVKmqEDPs/X/QCRo+mHaYA0kIQMi9zzbSbBu3mTlc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=czSIHoBtqSxJQ4h7WvMW66UzbxhKjjdyk/ZtywKZxuKpH/aUYcRSHO9rWFfqXurzZEptMt8a6GvAxBCG3geULEa0GuacANWoCYbqS3L9MdXk3goWVO6fT7m+xBG0oPjw3M5w8AV8QEXzYgQEbdhCFypRWKiWU5U6q9gCv5pvedg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=IAAAYMM0; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="IAAAYMM0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-To:Resent-Cc: Resent-Message-ID:In-Reply-To:References; bh=w3q57HM3tCrrhQyYEUUJjy1ttemKnQ2AdjAw0WzC5Y0=; t=1736495917; x=1737705517; b=IAAAYMM0v8i38Ruu1aoCaLPm3knJntdFB70H0xhU+rfpqoySMvH7PetUZp4DlMekA20xvZ7HJTJ 81OCYhToTlHXxSE2SxmdkQxZZ0J3yCOjvGOdCnxCSOOzrDeCx+tUunUV49llzLB89GTWkC7wa6tYA l08r+mOspvS8QwMIn2Whwou5lhmh3ZUVA7YwbxmElNOCV6Qw0RvQAKtmfZ6s90JGcbpKuEW7EH80C /Mr/+hIbqjM+1ZRm0+qxJEOqASz+V69m0eaUcTVUJanJxYVYhX+vX8oucOFLkT1T5lmOFEzGnVidD SvriMC9noUBO6PswOhfdef33xDXJfqRcySwA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tW9uc-0000000APfo-30C2; Fri, 10 Jan 2025 08:58:34 +0100 From: Johannes Berg To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Johannes Berg , Suresh Kumar Kurmi , kernel test robot , Venkat Rao Bagalkote Subject: [PATCH] fs: debugfs: fix open proxy for unsafe files Date: Fri, 10 Jan 2025 08:58:14 +0100 Message-ID: <20250110085826.cd74f3b7a36b.I430c79c82ec3f954c2ff9665753bf6ac9e63eef8@changeid> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Johannes Berg In the previous commit referenced below, I had to split the short fops handling into different proxy fops. This necessitated knowing out-of-band whether or not the ops are short or full, when attempting to convert from fops to allocated fsdata. Unfortunately, I only converted full_proxy_open() which is used for the new full_proxy_open_regular() and full_proxy_open_short(), but forgot about the call in open_proxy_open(), used for debugfs_create_file_unsafe(). Fix that, it never has short fops. Fixes: f8f25893a477 ("fs: debugfs: differentiate short fops with proxy ops") Reported-by: Suresh Kumar Kurmi Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202501101055.bb8bf3e7-lkp@intel.com Reported-by: Venkat Rao Bagalkote Signed-off-by: Johannes Berg Tested-by: Venkat Rao Bagalkote --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index bdb4f2ca0506..16e198a26339 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -280,7 +280,7 @@ static int open_proxy_open(struct inode *inode, struct = file *filp) const struct file_operations *real_fops =3D NULL; int r; =20 - r =3D debugfs_file_get(dentry); + r =3D __debugfs_file_get(dentry, DBGFS_GET_REGULAR); if (r) return r =3D=3D -EIO ? -ENOENT : r; =20 --=20 2.47.1