From nobody Sun Feb 8 03:22:38 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56CE7621 for ; Fri, 10 Jan 2025 00:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736467513; cv=none; b=eZhRVdJ+cophAy/Jb4AnxP73WdjHZ+dazLpoFEmcDjl4xtv+FHzmMERrqBT8EhvTHSSG+akuGTIO+uNi4nANc4FKLpGFAF31SorXwBPYiSZfUgXDbgiDUj9xnW73hazlHsSNg2zaBv3G/dzfS3yJiDL9vw9jVc4xEMSqsviFmg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736467513; c=relaxed/simple; bh=Puv3zsai0jHvJDL57QYxqvx29JZ+xRqCfaIKxLB+4jA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=PMRjbEQei4sPcTl1HkelrPmxOCOl3629eVatSM06mjxeHJxcNelbeG67U/Kzh3J0sv821RFfkAS3YJxdmLYJGLARBHbeHDIlfxQ9ndF+FkGS6D/TCm36g1X06vkeG5ANpfxE89irTsQjYTKp4U8mdKK1p6UorfZKDTm3W5XOluE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=2kZB7r6x; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="2kZB7r6x" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2eeeb5b7022so2712434a91.0 for ; Thu, 09 Jan 2025 16:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736467511; x=1737072311; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=DFAwAZKpbbyO1HqTxhtTJuZCWJHAaZyMlg329c6py7M=; b=2kZB7r6xwSVgJviUy2PtKWvVv1a+A9XTJCDU1IE8dYKewTyL5iT+eeDuUZzd5ryJ0C iBKE7issUIMhK1q4xi2/Uh/nW64WFJNUT/tVmdbbIJqvpNcA/dfXtNgsWNXVCxjZAQ4b u4p0W1tzYZ1n8ZdOpUqvhzNPJekgxqcPjCzs9gAYGYcozETC5Yls3NmxPpQnZVN2SG8U hO1F+f7z/L2hPOUQqiXh/JFh8Df/ZqKQManw92scSQc8kMFaSv9+PuLPH8kRScnQDGCa dhXTxUN8288XLbjNcJW1NMu7dBTZatvXYhVDW4ABGeeuFTakAf1t0OkkpVJuRbrE96CS 4Ftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736467511; x=1737072311; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DFAwAZKpbbyO1HqTxhtTJuZCWJHAaZyMlg329c6py7M=; b=Cg+JceQkt31ozZSzlZEnXTlapeNVHHpfjWq17e0gr3fR/pC3ATqH4dpG45H14X15J1 4Bd4KSFOiLdsvBR1OLxJUTF2mid773AA36zVTC/Px4rwqrosRupQ02U8Lp03gY4t31AZ pfNouUF0j4ZcySJ9lqetdRuWpeJu27e/U28mcCuGjGOiY+IfFXtHxrmGfTokjqyigNeX rK1NqwhJK0SNstUCOXFnpx0xQexKWHL0ClbpkfGG5+hfP6aay36khM7WTS8uoMv2RnZi a/BaQeBak+Qie8jOKP8HrYtOC1eJZ41Oe3NlWcksBt9wpb2rFLU0h9vwdnJ5gVo4xzr6 CF4A== X-Gm-Message-State: AOJu0Yz3lgByso29vMw4yr1gsEs9oqE2DvAV/XR8CzPdwcW0EvsBmbdF egdJhYjqbQLfIL1g61eiD9j7bGMT67BtT8xITwqWyCb01H6/GBaZPJSyyD1y4+IhpgOHMQaIL48 93jnwsEh+Nw== X-Google-Smtp-Source: AGHT+IFyGge0YJgkSDqWbNKb5NHRIBS8d3SyABjokGwT8ECSGn8ghTxhazoXfK0AUobDkq1QbYY9p5EP6IL63A== X-Received: from pfod3.prod.google.com ([2002:aa7:8683:0:b0:725:d9ab:3f2e]) (user=cmllamas job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:ac2:b0:729:c7b:9385 with SMTP id d2e1a72fcca58-72d21f27b01mr12911352b3a.6.1736467511535; Thu, 09 Jan 2025 16:05:11 -0800 (PST) Date: Fri, 10 Jan 2025 00:05:02 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20250110000503.2396017-1-cmllamas@google.com> Subject: [PATCH] binder: log transaction code on failure From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Steven Moreland Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a transaction fails, log the 'tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts. Cc: Steven Moreland Signed-off-by: Carlos Llamas --- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index ef353ca13c35..cb4187a4e595 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *= proc, } =20 binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, - "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line= %d\n", + "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%= lld line %d\n", proc->pid, thread->pid, reply ? "reply" : (tr->flags & TF_ONE_WAY ? "async" : "call"), target_proc ? target_proc->pid : 0, target_thread ? target_thread->pid : 0, t_debug_id, return_error, return_error_param, - (u64)tr->data_size, (u64)tr->offsets_size, + tr->code, (u64)tr->data_size, (u64)tr->offsets_size, return_error_line); =20 if (target_thread) --=20 2.47.1.613.gc27f4b7a9f-goog