From nobody Sun Feb 8 14:12:35 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7B3203707 for ; Thu, 9 Jan 2025 21:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457566; cv=none; b=XkyDXzbBCI8obIby9cs4WLYzK+bdc9M2gxHznHO7Yw7vbKgfii/uUmMAwO8lOzR98dU1MQrxehZW7eftLoXEfpPmayn/Rjid1at68QLU7kWBm3rLM8dl2Vc/LZ2fLR56GM+9wUy3BA6INZnxMEIhXenc7u+Tn7OgCtttSG2WhPc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457566; c=relaxed/simple; bh=EoKKi+Z60KmqjOEZJ9LNBHGoycV+Fglx9GgRLT+IXzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mzDaLgilac7VigqPUt2weC73c1lsEmigbycYdL8LVJh2d5mHC8pfvInmNlJPZwg67aQJzEf61p17USIqi1rmLlTmxI8eOnqpUGZT9gq/lXNLPaPvsovxrgM8datw0BlH0tFv0w+rDSac13Awtgn25o0po0fpcD3U8WRtsE+JGCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=d9znHasW; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="d9znHasW" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso2524994a12.1 for ; Thu, 09 Jan 2025 13:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457562; x=1737062362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iJ26hgnRMCLZPTXr7KLkVyqRMMqeBIF3e9Y1qTU0tFU=; b=d9znHasWVC8PXqb6XKegRj8Hd/M8KprBB7+YbnFTB/xXvRaN/QCs57qFczQQ9PYj5v t2cSALZ7oD7FVW9EqywxnSrRgHMLCr7aYpv6UWHaLavab254OSbex8XWe0OVUFZ1H9P6 D07Un31kP7NAy44HODflppFTFVm8m5LHknfWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457562; x=1737062362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJ26hgnRMCLZPTXr7KLkVyqRMMqeBIF3e9Y1qTU0tFU=; b=qo4JSETFJossGzcB+JO+1VhPYs+wqQCMP+vW+nRwL9Ta2EHy82XNooXAU6g3L4KLvR QzCilbNIj6y5jnLIfefGsH5BHciBv1hKwzS+XbWgXnuQibw+xSLWXZHX8mUhgqvJOb7f lcJL+fGTcx4koNimR1LMz7xvsjsxcdU0w0KrOh520fpRugLVgQv29zgz5YCsNmMyeGQB RORxzFMhIjHjDrnglf24blVGDBLHCPc5JlaCipMPfrcTh5cRhBTAu6041lWCYUysb3x9 e3ZzBAAsBvfY38mnMzD68tx6a5ThqqD4sn0KIc0smbN2GUO1oSG+eyrPDWr7wAkhkxsb WGxw== X-Gm-Message-State: AOJu0YxGV3Lhp91xKDkSeWTg5UteAqpP9H96VK7aLyo3RWiGWosUNCCl wZMLRty8VuBnDYGLDh0iZvIRcVa9DEaaJd6nO92cMSTE/e7P6a6wXSr3ZFHTZFOuw1zifY8Afcu W X-Gm-Gg: ASbGncsXpR1x05qGW5Hn2nO4ZTwZFcIueLGQ38bp1aib6oOggCyer8j8JxzTL9ag2JC tHGRGdaTPlgLNZOXNwM4dbgzZdC1UUQyMPxwCGxcXAEq68mmSLxTCeKlLIKtyuD+IbclZmZPFJH /gt8fTnsyxIWkgapZu/jsxCHhyuXIUKKID60X5M37PjkwQqXBI8W7hxLfWgnF2exKN3uEA/Aajl c5smEeQ+jKBn+gP8DZFl2pr2jp/v3quERgaUbkWfbdglhAtDxpLVQZ+7YUjzZ9l3AUTAXhRA8Pl FycNIKluxxXKlmMC7Vyb//prDpUQjG+hq9qU1cXLbwustgFbHqqjiqRpnRJRi1gejnlkWPGVOb/ WDIYgzQpY9F00nmG+ZA== X-Google-Smtp-Source: AGHT+IEZ3Pmwpnwcw8QBt1dN5e19AnUypwazIVJ9R+ER6Nu6NohOMhjMnT0yJVMOQm16EeoH5knA9A== X-Received: by 2002:a05:6402:40cc:b0:5d0:d328:3a43 with SMTP id 4fb4d7f45d1cf-5d98a24a72fmr3294628a12.6.1736457562307; Thu, 09 Jan 2025 13:19:22 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:22 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Maxime Coquelin , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 4/4] clk: stm32f4: support spread spectrum clock generation Date: Thu, 9 Jan 2025 22:18:31 +0100 Message-ID: <20250109211908.1553072-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support spread spectrum clock generation for the main PLL, the only one for which this functionality is available. Tested on the STM32F469I-DISCO board. Signed-off-by: Dario Binacchi --- Changes in v2: - Fixup patches: 2/6 dt-bindings: reset: st,stm32-rcc: update reference due to rename 3/6 dt-bindings: clock: stm32fx: update reference due to rename to 1/6 dt-bindings: clock: convert stm32 rcc bindings to json-schema - Changes to dt-bindings: clock: convert stm32 rcc bindings to json-schema - Changes to dt-bindings: clock: st,stm32-rcc: support spread spectrum cloc= king drivers/clk/clk-stm32f4.c | 143 +++++++++++++++++++++++++++++++++++++- 1 file changed, 140 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index db1c56c8d54f..6c80c0dbb0a3 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -35,6 +35,7 @@ #define STM32F4_RCC_APB2ENR 0x44 #define STM32F4_RCC_BDCR 0x70 #define STM32F4_RCC_CSR 0x74 +#define STM32F4_RCC_SSCGR 0x80 #define STM32F4_RCC_PLLI2SCFGR 0x84 #define STM32F4_RCC_PLLSAICFGR 0x88 #define STM32F4_RCC_DCKCFGR 0x8c @@ -42,6 +43,12 @@ =20 #define STM32F4_RCC_PLLCFGR_N_MASK GENMASK(14, 6) =20 +#define STM32F4_RCC_SSCGR_SSCGEN BIT(31) +#define STM32F4_RCC_SSCGR_SPREADSEL BIT(30) +#define STM32F4_RCC_SSCGR_RESERVED_MASK GENMASK(29, 28) +#define STM32F4_RCC_SSCGR_INCSTEP_MASK GENMASK(27, 13) +#define STM32F4_RCC_SSCGR_MODPER_MASK GENMASK(12, 0) + #define NONE -1 #define NO_IDX NONE #define NO_MUX NONE @@ -512,6 +519,17 @@ static const struct clk_div_table pll_divr_table[] =3D= { { 2, 2 }, { 3, 3 }, { 4, 4 }, { 5, 5 }, { 6, 6 }, { 7, 7 }, { 0 } }; =20 +enum stm32f4_pll_ssc_mod_type { + STM32F4_PLL_SSC_CENTER_SPREAD, + STM32F4_PLL_SSC_DOWN_SPREAD, +}; + +struct stm32f4_pll_ssc { + unsigned int mod_freq; + unsigned int mod_depth; + enum stm32f4_pll_ssc_mod_type mod_type; +}; + struct stm32f4_pll { spinlock_t *lock; struct clk_gate gate; @@ -519,6 +537,8 @@ struct stm32f4_pll { u8 bit_rdy_idx; u8 status; u8 n_start; + bool ssc_enable; + struct stm32f4_pll_ssc ssc_conf; }; =20 #define to_stm32f4_pll(_gate) container_of(_gate, struct stm32f4_pll, gate) @@ -541,6 +561,7 @@ struct stm32f4_vco_data { u8 offset; u8 bit_idx; u8 bit_rdy_idx; + bool sscg; }; =20 static const struct stm32f4_vco_data vco_data[] =3D { @@ -661,6 +682,34 @@ static long stm32f4_pll_round_rate(struct clk_hw *hw, = unsigned long rate, return *prate * n; } =20 +static void stm32f4_pll_set_ssc(struct clk_hw *hw, unsigned long parent_ra= te, + unsigned int ndiv) +{ + struct clk_gate *gate =3D to_clk_gate(hw); + struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + struct stm32f4_pll_ssc *ssc =3D &pll->ssc_conf; + u32 modeper, incstep; + u32 sscgr; + + sscgr =3D readl(base + STM32F4_RCC_SSCGR); + /* reserved field must be kept at reset value */ + sscgr &=3D STM32F4_RCC_SSCGR_RESERVED_MASK; + + modeper =3D DIV_ROUND_CLOSEST(parent_rate, 4 * ssc->mod_freq); + incstep =3D DIV_ROUND_CLOSEST(((1 << 15) - 1) * ssc->mod_depth * ndiv, + 5 * 10000 * modeper); + sscgr |=3D STM32F4_RCC_SSCGR_SSCGEN | + FIELD_PREP(STM32F4_RCC_SSCGR_INCSTEP_MASK, incstep) | + FIELD_PREP(STM32F4_RCC_SSCGR_MODPER_MASK, modeper); + + if (ssc->mod_type) + sscgr |=3D STM32F4_RCC_SSCGR_SPREADSEL; + + pr_debug("%s: pll: %s: modeper: %d, incstep: %d, sscgr: 0x%08x\n", + __func__, clk_hw_get_name(hw), modeper, incstep, sscgr); + writel(sscgr, base + STM32F4_RCC_SSCGR); +} + static int stm32f4_pll_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { @@ -683,6 +732,9 @@ static int stm32f4_pll_set_rate(struct clk_hw *hw, unsi= gned long rate, =20 writel(val, base + pll->offset); =20 + if (pll->ssc_enable) + stm32f4_pll_set_ssc(hw, parent_rate, n); + if (pll_state) stm32f4_pll_enable(hw); =20 @@ -788,6 +840,87 @@ static struct clk_hw *clk_register_pll_div(const char = *name, return hw; } =20 +static int stm32f4_pll_init_ssc(struct clk_hw *hw, struct stm32f4_pll_ssc = *conf) +{ + struct clk_gate *gate =3D to_clk_gate(hw); + struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + struct clk_hw *parent; + unsigned long parent_rate; + int pll_state; + unsigned long n, val; + + parent =3D clk_hw_get_parent(hw); + if (!parent) { + pr_err("%s: failed to get clock parent\n", __func__); + return -ENODEV; + } + + parent_rate =3D clk_hw_get_rate(parent); + + pll->ssc_enable =3D true; + memcpy(&pll->ssc_conf, conf, sizeof(pll->ssc_conf)); + + pll_state =3D stm32f4_pll_is_enabled(hw); + + if (pll_state) + stm32f4_pll_disable(hw); + + val =3D readl(base + pll->offset); + n =3D FIELD_GET(STM32F4_RCC_PLLCFGR_N_MASK, val); + + pr_debug("%s: pll: %s, parent: %s, parent-rate: %lu, n: %lu\n", + __func__, clk_hw_get_name(hw), clk_hw_get_name(parent), + parent_rate, n); + + stm32f4_pll_set_ssc(hw, parent_rate, n); + + if (pll_state) + stm32f4_pll_enable(hw); + + return 0; +} + +static int stm32f4_pll_ssc_parse_dt(struct device_node *np, + struct stm32f4_pll_ssc *conf) +{ + int ret; + const char *s; + + if (!conf) + return -EINVAL; + + ret =3D of_property_read_u32(np, "st,ssc-modfreq-hz", &conf->mod_freq); + if (ret) + return ret; + + ret =3D of_property_read_u32(np, "st,ssc-moddepth-permyriad", + &conf->mod_depth); + if (ret) { + pr_err("%pOF: missing st,ssc-moddepth-permyriad\n", np); + return ret; + } + + ret =3D of_property_read_string(np, "st,ssc-modmethod", &s); + if (ret) { + pr_err("%pOF: missing st,ssc-modmethod\n", np); + return ret; + } + + if (!strcmp(s, "down-spread")) { + conf->mod_type =3D STM32F4_PLL_SSC_DOWN_SPREAD; + } else if (!strcmp(s, "center-spread")) { + conf->mod_type =3D STM32F4_PLL_SSC_CENTER_SPREAD; + } else { + pr_err("%pOF: wrong value (%s) for fsl,ssc-modmethod\n", np, s); + return -EINVAL; + } + + pr_debug("%pOF: SSCG settings: mod_freq: %d, mod_depth: %d mod_method: %s= [%d]\n", + np, conf->mod_freq, conf->mod_depth, s, conf->mod_type); + + return 0; +} + static struct clk_hw *stm32f4_rcc_register_pll(const char *pllsrc, const struct stm32f4_pll_data *data, spinlock_t *lock) { @@ -1695,7 +1828,8 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) const struct of_device_id *match; const struct stm32f4_clk_data *data; unsigned long pllm; - struct clk_hw *pll_src_hw; + struct clk_hw *pll_src_hw, *pll_vco_hw; + struct stm32f4_pll_ssc ssc_conf; =20 base =3D of_iomap(np, 0); if (!base) { @@ -1754,8 +1888,8 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) clk_hw_register_fixed_factor(NULL, "vco_in", pll_src, 0, 1, pllm); =20 - stm32f4_rcc_register_pll("vco_in", &data->pll_data[0], - &stm32f4_clk_lock); + pll_vco_hw =3D stm32f4_rcc_register_pll("vco_in", &data->pll_data[0], + &stm32f4_clk_lock); =20 clks[PLL_VCO_I2S] =3D stm32f4_rcc_register_pll("vco_in", &data->pll_data[1], &stm32f4_clk_lock); @@ -1900,6 +2034,9 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) =20 of_clk_add_hw_provider(np, stm32f4_rcc_lookup_clk, NULL); =20 + if (!stm32f4_pll_ssc_parse_dt(np, &ssc_conf)) + stm32f4_pll_init_ssc(pll_vco_hw, &ssc_conf); + return; fail: kfree(clks); --=20 2.43.0