From nobody Mon Feb 9 21:18:42 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC5F204C35 for ; Thu, 9 Jan 2025 21:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457564; cv=none; b=DXvEosnDAloduKbTeVkfc4e/RWzXij+tBQhWFb5PMGTcOJA6Olfh24OjmMSLpJrfH7LQAjgxVnkcZKAy4q7gfKN88WtkTWXlEhJ5mXHdflx++E6ACazYuvXX9TBuJwGWMc5Hyl9a8C0nfz4/Z6eup5wuCGjMHcQtcqOY6/9fDLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457564; c=relaxed/simple; bh=54AnFoYFZcZqYgavjCEUI5tS3rZv1k1LrPOchNuHl/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lygOxeYDOMnAeSjSQCK51Ja+HXgqV42pYhyeVaCqSj5+2TlGEO8Vl07N+7OX0+g0Kkv3TQx+9NZEFYl6Tel77UGDt/DP7+mXg+aOTfPdI1HUMOH7a/NAfEZdXsnSCwjti01B30zV6A12PW8yN6S+v/mnZR3yS1aa7QyM6IuRPio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=kx3vQzQe; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="kx3vQzQe" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aaef00ab172so235326666b.3 for ; Thu, 09 Jan 2025 13:19:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457560; x=1737062360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4PuckIz6TtMrm6FhKB7AMqxRoyDL7dpmszhuAU6edRg=; b=kx3vQzQekqacGs1PuiZ+nlGdz/CH/foFXOTLpYn6sJBC3cUq96I0djJ+2P3QXmaL3Z mHtsfH1mxdAUUtoK/AVh+ShpvzhlygiZUBaCnqDE6N381M+BTIpxXrlc0R35j7u/6Vi7 BoAX8fiu5i1rgZWnzxK5pE+dz8Zk/ksrHNg/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457560; x=1737062360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4PuckIz6TtMrm6FhKB7AMqxRoyDL7dpmszhuAU6edRg=; b=PLRo/k2W07lXdgMS/AAxiQcbxoneIu1Aa2ZaQmekCXHxMVZnwieL1JSAf0KMwRmgjq uIno+7QmOPC89h4KycoGlAmj2xjLXkbnifFoXVw0gfZl/wvbXBibB1p5+qLW4THVOOMs stQcs37D6mfUIu1kqGCZAnN5MVsmeOdr4RFtWwcLY9lVlSlP9YFNogARZ/M/8dnSOOQe r2/fDi3hHwhnVd18AX9fNblyIyFm6es/qni/g4++8sdHGEE6kcrHSRKDkm6kQl7q849V zW/mQnd6NQyyPFyzKJJbZk+ViwF4r6igPtfn3vJsltfypzSM1AFqjjsPERsRQDGgvNnv J5Og== X-Gm-Message-State: AOJu0YwFph6Du7+8IcnLyWNJwqjTMkXydVNB89T6Jz4ATY6ic2S0OJ3V z/aCNzny9tj7rYgIzjOqzD3YM5JyzPUFhmNc9bhvPJa2zeqEmxjwKynrEQWjVdxAqy4Ltkl3Zt6 q X-Gm-Gg: ASbGncus7oj/n5e8qEic3V2VdbnI7DtogA53qBm7Nn5CvZeF6M/VeIan4p4yQRbLmKp 4rH7QLS4ekCNT5nWguaMdlyZ0pKzyO8xuuHnhnchv/s2zrcQlzpKXPF+fu9B7ew5DJG2gwB6VpL 3/VpyKlTgZ5NjRJPhB44yDSRHoly+ZfmP+0tF2tKsx4wbl6UqiMe7Uz3vgYq7z6i9a7cdXPKfoW fmpc5kgfbOC0Idt6eZvf5kBKQ2Mu8pwmIqo2ORnR+4ctwbbLTCHgBxGbkxpVpS2YPn8g6v/kWCX 6T17uosTQ1fv2R+w4jWksVOKRLqwYkU1FfCrSEAYZ5RhLAFX/rCfuIeKaV+cx/xyk1gINVXUvCY 46IlXoHsbn2Ejf8Ufpg== X-Google-Smtp-Source: AGHT+IEJwiab5POVdxFq+KPMtd+AMk6FXjRfRzUyO6955YIp4KLeb/nmZtME/YvLjxsDXy27od+mJQ== X-Received: by 2002:a05:6402:400a:b0:5d2:7199:ac2 with SMTP id 4fb4d7f45d1cf-5d972e00032mr18870795a12.2.1736457560441; Thu, 09 Jan 2025 13:19:20 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:20 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Maxime Coquelin , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 3/4] clk: stm32f4: use FIELD helpers to access the PLLCFGR fields Date: Thu, 9 Jan 2025 22:18:30 +0100 Message-ID: <20250109211908.1553072-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use GENMASK() along with FIELD_GET() and FIELD_PREP() helpers to access the PLLCFGR fields instead of manually masking and shifting. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/clk/clk-stm32f4.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 07c13ebe327d..db1c56c8d54f 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -5,6 +5,7 @@ * Inspired by clk-asm9260.c . */ =20 +#include #include #include #include @@ -39,6 +40,8 @@ #define STM32F4_RCC_DCKCFGR 0x8c #define STM32F7_RCC_DCKCFGR2 0x90 =20 +#define STM32F4_RCC_PLLCFGR_N_MASK GENMASK(14, 6) + #define NONE -1 #define NO_IDX NONE #define NO_MUX NONE @@ -632,9 +635,11 @@ static unsigned long stm32f4_pll_recalc(struct clk_hw = *hw, { struct clk_gate *gate =3D to_clk_gate(hw); struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + unsigned long val; unsigned long n; =20 - n =3D (readl(base + pll->offset) >> 6) & 0x1ff; + val =3D readl(base + pll->offset); + n =3D FIELD_GET(STM32F4_RCC_PLLCFGR_N_MASK, val); =20 return parent_rate * n; } @@ -673,9 +678,10 @@ static int stm32f4_pll_set_rate(struct clk_hw *hw, uns= igned long rate, =20 n =3D rate / parent_rate; =20 - val =3D readl(base + pll->offset) & ~(0x1ff << 6); + val =3D readl(base + pll->offset) & ~STM32F4_RCC_PLLCFGR_N_MASK; + val |=3D FIELD_PREP(STM32F4_RCC_PLLCFGR_N_MASK, n); =20 - writel(val | ((n & 0x1ff) << 6), base + pll->offset); + writel(val, base + pll->offset); =20 if (pll_state) stm32f4_pll_enable(hw); --=20 2.43.0