From nobody Sat Feb 7 16:26:56 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A87204C11 for ; Thu, 9 Jan 2025 21:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457560; cv=none; b=QtHgHwsN8DZ2o+ifh++Syac0ckmtJIU7jaQGA4DQdOHNXPSDTbfqDuZP/pYslKRepY8oFnyY8pS3PKTQbmiqk3YoSrseiTa+0SLHNCA+OabbstHJQS39x+HgUz1go4vnHTp9Uz4WKCy0afI7wxLw5KYgRS4caz8s+nQjoSIunx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457560; c=relaxed/simple; bh=wyG+JaX0hjzVtj5U7wE3SJMUpPHpMeZ1QKtKnHeKrZ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IpxkOV3n6ng5k8j9D4zcfh1kR2DTiSbTeo5wesLHkTVdPFdQggTdFY+Xus19gcxe4jWXXjUj3PVIfNzmhRd0P1QcobirEueVYcjCQbTS6KBBf8JYtd3D9wkjW39E2Q7rI1IM30S6wLSIDdlkAqYcJ+fFUwfj35NSadsOVY5bW8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=f0gHUUWI; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="f0gHUUWI" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d3d2a30afcso2194581a12.3 for ; Thu, 09 Jan 2025 13:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457557; x=1737062357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kMDwINMgp57JdnWDRo35bVQVHIu764enuWXH+P8QtD8=; b=f0gHUUWIE1XMkPcPmr1c4Qgx2suKu0+kv4QUh7yqbwAepn0H10bHUZW7R7m0yQDJOo W2p/LzKE0Sdwcid4Y8a5boZNKhADmIWHU0AVdKnn1JrJlSr0HS7lRqEKCLkmlP/1+jxI hFjGNmMy8Ul778JWcOhCzZ56Fg83r9AGCzdB8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457557; x=1737062357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kMDwINMgp57JdnWDRo35bVQVHIu764enuWXH+P8QtD8=; b=i5YdSftOoAvZMri7aHoBjJLyyrfNhyNEHSMLmiVzZdGmSlRyTHn9/E34j/QFlr+6Pd MY9i9oa2EI6jklyZIIGcbRI1kjkNv5ry/aZ0Ap3J6ASQ38SeEp1HHphs0LNQT5njcKDP xjtZzNw12dW2uHjlmVPjf7WN6RboMCTXXq1ZjU4YXR6TT0p1R+aZfT3P+X602rW1VFd+ D6g/517bTrnkEPBnjb2a1CL6EuXBse/IQJIQiD9ypGtLh6RkmrdrN+MAt1JhbsB1wgfs x/A9Kj9Awfxi8GPOk5bvkAc30wtFh6W5qThk+6owcyyu0/ffBfi8h2GvOzZAzGMyTCtp bWwg== X-Gm-Message-State: AOJu0YzdPy6WfgfHh7QrKT4i8+Dx21jbf3Ly8BBiyKvLF7Nc7QKtzSGe 9d89/fILzBRVbfsj+EFciyEwgHidqn13ELZ/rw6btW/4TJogz4G1tRs/Vi+Vfqv9JUK8l5VUczw J X-Gm-Gg: ASbGncubL0ZKUZWsVBkw4mxeABSktDWqZOn3BHSsyDOfai4Fh1CR7XJ4RS/q1FOYBCq UcRfeW0MAw0xqy+0Gz7SS8Z/6H+jEgpCQRQcnj93IpgsTgBxlJCsh9w3q7REag5sgylShNZnWMK 1fwGFXRejijQOCY0jKzprmSQ43asAwgPLN2JEoJSL23j+/IbenHNlA2iJv/43aoPFlquuPXJI48 ik8N3L+0OsrSUJTdtAk5Rkadz1dCEEQZtAhTQwY94WslAabNKuSu9dKJX7MvbPa1ER0IGgkfzBw PTFqpOcIDyej2dGjOHSGu72bBwVs/Bfd/dBsKuqc5TA/My+rgeXu4QT1Tg6uUOH8BNoMLunN6uU BNvfyLLe06LKxuZVsPg== X-Google-Smtp-Source: AGHT+IHUAVP6+PgKfM9g4JVq2jFqpWDWI9WunzPqIfkbBNq/oJX0XMZspcKrfWFqNV5TF87Psj1xjg== X-Received: by 2002:a05:6402:3225:b0:5d9:b8a:9e08 with SMTP id 4fb4d7f45d1cf-5d972e1b768mr7727175a12.16.1736457556741; Thu, 09 Jan 2025 13:19:16 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:15 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Conor Dooley , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Philipp Zabel , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema Date: Thu, 9 Jan 2025 22:18:28 +0100 Message-ID: <20250109211908.1553072-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch converts st,stm32-rcc.txt to the JSON schema, but it does more than that. The old bindings, in fact, only covered the stm32f{4,7} platforms and not the stm32h7. Therefore, to avoid patch submission tests failing, it was necessary to add the corresponding compatible (i. e. st,stm32h743-rcc) and specify that, in this case, 3 are the clocks instead of the 2 required for the stm32f{4,7} platforms. Additionally, the old bindings made no mention of the st,syscfg property, which is used by both the stm32f{4,7} and the stm32h7 platforms. The patch also fixes the files referencing to the old st,stm32-rcc.txt. Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Fixup patches: 2/6 dt-bindings: reset: st,stm32-rcc: update reference due to rename 3/6 dt-bindings: clock: stm32fx: update reference due to rename - Update the commit message - Reduce the description section of the yaml file - List the items with description for the clocks property - Use only one example - Rename rcc to clock-controller@58024400 for the node of the example .../bindings/clock/st,stm32-rcc.txt | 138 ------------------ .../bindings/clock/st,stm32-rcc.yaml | 111 ++++++++++++++ .../bindings/reset/st,stm32-rcc.txt | 2 +- include/dt-bindings/clock/stm32fx-clock.h | 2 +- 4 files changed, 113 insertions(+), 140 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/st,stm32-rcc.txt create mode 100644 Documentation/devicetree/bindings/clock/st,stm32-rcc.ya= ml diff --git a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt b/Doc= umentation/devicetree/bindings/clock/st,stm32-rcc.txt deleted file mode 100644 index cfa04b614d8a..000000000000 --- a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt +++ /dev/null @@ -1,138 +0,0 @@ -STMicroelectronics STM32 Reset and Clock Controller -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D - -The RCC IP is both a reset and a clock controller. - -Please refer to clock-bindings.txt for common clock controller binding usa= ge. -Please also refer to reset.txt for common reset controller binding usage. - -Required properties: -- compatible: Should be: - "st,stm32f42xx-rcc" - "st,stm32f469-rcc" - "st,stm32f746-rcc" - "st,stm32f769-rcc" - -- reg: should be register base and length as documented in the - datasheet -- #reset-cells: 1, see below -- #clock-cells: 2, device nodes should specify the clock in their "clocks" - property, containing a phandle to the clock device node, an index select= ing - between gated clocks and other clocks and an index specifying the clock = to - use. -- clocks: External oscillator clock phandle - - high speed external clock signal (HSE) - - external I2S clock (I2S_CKIN) - -Example: - - rcc: rcc@40023800 { - #reset-cells =3D <1>; - #clock-cells =3D <2> - compatible =3D "st,stm32f42xx-rcc", "st,stm32-rcc"; - reg =3D <0x40023800 0x400>; - clocks =3D <&clk_hse>, <&clk_i2s_ckin>; - }; - -Specifying gated clocks -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - -The primary index must be set to 0. - -The secondary index is the bit number within the RCC register bank, starti= ng -from the first RCC clock enable register (RCC_AHB1ENR, address offset 0x30= ). - -It is calculated as: index =3D register_offset / 4 * 32 + bit_offset. -Where bit_offset is the bit offset within the register (LSB is 0, MSB is 3= 1). - -To simplify the usage and to share bit definition with the reset and clock -drivers of the RCC IP, macros are available to generate the index in -human-readble format. - -For STM32F4 series, the macro are available here: - - include/dt-bindings/mfd/stm32f4-rcc.h - -Example: - - /* Gated clock, AHB1 bit 0 (GPIOA) */ - ... { - clocks =3D <&rcc 0 STM32F4_AHB1_CLOCK(GPIOA)> - }; - - /* Gated clock, AHB2 bit 4 (CRYP) */ - ... { - clocks =3D <&rcc 0 STM32F4_AHB2_CLOCK(CRYP)> - }; - -Specifying other clocks -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - -The primary index must be set to 1. - -The secondary index is bound with the following magic numbers: - - 0 SYSTICK - 1 FCLK - 2 CLK_LSI (low-power clock source) - 3 CLK_LSE (generated from a 32.768 kHz low-speed external - crystal or ceramic resonator) - 4 CLK_HSE_RTC (HSE division factor for RTC clock) - 5 CLK_RTC (real-time clock) - 6 PLL_VCO_I2S (vco frequency of I2S pll) - 7 PLL_VCO_SAI (vco frequency of SAI pll) - 8 CLK_LCD (LCD-TFT) - 9 CLK_I2S (I2S clocks) - 10 CLK_SAI1 (audio clocks) - 11 CLK_SAI2 - 12 CLK_I2SQ_PDIV (post divisor of pll i2s q divisor) - 13 CLK_SAIQ_PDIV (post divisor of pll sai q divisor) - - 14 CLK_HSI (Internal ocscillator clock) - 15 CLK_SYSCLK (System Clock) - 16 CLK_HDMI_CEC (HDMI-CEC clock) - 17 CLK_SPDIF (SPDIF-Rx clock) - 18 CLK_USART1 (U(s)arts clocks) - 19 CLK_USART2 - 20 CLK_USART3 - 21 CLK_UART4 - 22 CLK_UART5 - 23 CLK_USART6 - 24 CLK_UART7 - 25 CLK_UART8 - 26 CLK_I2C1 (I2S clocks) - 27 CLK_I2C2 - 28 CLK_I2C3 - 29 CLK_I2C4 - 30 CLK_LPTIMER (LPTimer1 clock) - 31 CLK_PLL_SRC - 32 CLK_DFSDM1 - 33 CLK_ADFSDM1 - 34 CLK_F769_DSI -) - -Example: - - /* Misc clock, FCLK */ - ... { - clocks =3D <&rcc 1 STM32F4_APB1_CLOCK(TIM2)> - }; - - -Specifying softreset control of devices -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D - -Device nodes should specify the reset channel required in their "resets" -property, containing a phandle to the reset device node and an index speci= fying -which channel to use. -The index is the bit number within the RCC registers bank, starting from R= CC -base address. -It is calculated as: index =3D register_offset / 4 * 32 + bit_offset. -Where bit_offset is the bit offset within the register. -For example, for CRC reset: - crc =3D AHB1RSTR_offset / 4 * 32 + CRCRST_bit_offset =3D 0x10 / 4 * 32 += 12 =3D 140 - -example: - - timer2 { - resets =3D <&rcc STM32F4_APB1_RESET(TIM2)>; - }; diff --git a/Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml b/Do= cumentation/devicetree/bindings/clock/st,stm32-rcc.yaml new file mode 100644 index 000000000000..779e547700be --- /dev/null +++ b/Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml @@ -0,0 +1,111 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/st,stm32-rcc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STM32 Reset Clock Controller + +maintainers: + - Dario Binacchi + +description: | + The RCC IP is both a reset and a clock controller. + The reset phandle argument is the bit number within the RCC registers ba= nk, + starting from RCC base address. + +properties: + compatible: + oneOf: + - items: + - const: st,stm32f42xx-rcc + - const: st,stm32-rcc + - items: + - enum: + - st,stm32f469-rcc + - const: st,stm32f42xx-rcc + - const: st,stm32-rcc + - items: + - const: st,stm32f746-rcc + - const: st,stm32-rcc + - items: + - enum: + - st,stm32f769-rcc + - const: st,stm32f746-rcc + - const: st,stm32-rcc + - items: + - const: st,stm32h743-rcc + - const: st,stm32-rcc + + reg: + maxItems: 1 + + '#reset-cells': + const: 1 + + '#clock-cells': + enum: [1, 2] + + clocks: + minItems: 2 + maxItems: 3 + + st,syscfg: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle to system configuration controller. It can be used to contro= l the + power domain circuitry. + +required: + - compatible + - reg + - '#reset-cells' + - '#clock-cells' + - clocks + - st,syscfg + +allOf: + - if: + properties: + compatible: + contains: + const: st,stm32h743-rcc + then: + properties: + '#clock-cells': + const: 1 + description: | + The clock index for the specified type. + clocks: + items: + - description: high speed external (HSE) clock input + - description: low speed external (LSE) clock input + - description: Inter-IC sound (I2S) clock input + else: + properties: + '#clock-cells': + const: 2 + description: | + - The first cell is the clock type, possible values are 0 for + gated clocks and 1 otherwise. + - The second cell is the clock index for the specified type. + clocks: + items: + - description: high speed external (HSE) clock input + - description: Inter-IC sound (I2S) clock input + +additionalProperties: false + +examples: + # Reset and Clock Control Module node: + - | + clock-controller@58024400 { + compatible =3D "st,stm32h743-rcc", "st,stm32-rcc"; + reg =3D <0x58024400 0x400>; + #clock-cells =3D <1>; + #reset-cells =3D <1>; + clocks =3D <&clk_hse>, <&clk_lse>, <&clk_i2s>; + st,syscfg =3D <&pwrcfg>; + }; + +... diff --git a/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt b/Doc= umentation/devicetree/bindings/reset/st,stm32-rcc.txt index 01db34375192..384035e8e60b 100644 --- a/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt +++ b/Documentation/devicetree/bindings/reset/st,stm32-rcc.txt @@ -3,4 +3,4 @@ STMicroelectronics STM32 Peripheral Reset Controller =20 The RCC IP is both a reset and a clock controller. =20 -Please see Documentation/devicetree/bindings/clock/st,stm32-rcc.txt +Please see Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml diff --git a/include/dt-bindings/clock/stm32fx-clock.h b/include/dt-binding= s/clock/stm32fx-clock.h index e5dad050d518..b6ff9c68cb3f 100644 --- a/include/dt-bindings/clock/stm32fx-clock.h +++ b/include/dt-bindings/clock/stm32fx-clock.h @@ -10,7 +10,7 @@ * List of clocks which are not derived from system clock (SYSCLOCK) * * The index of these clocks is the secondary index of DT bindings - * (see Documentation/devicetree/bindings/clock/st,stm32-rcc.txt) + * (see Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml) * * e.g: ; --=20 2.43.0 From nobody Sat Feb 7 16:26:56 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA4C204F80 for ; Thu, 9 Jan 2025 21:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457563; cv=none; b=ECZ3nADdwS+byMwu8fkb8ESk6hwa48g/gVBCsjzRDsaCpeGJmFqw67zY1O4lU6QWct/v1EUl6MzBNQPcKmuXA9KERP4ivX4fqJXB8kDO2UZEWOPyUfNy7QsysN/U5XJyVZ3ZTH/8SZ5sT9sS7MGHQ9x8TO3qnsf7UZgly4FS4ag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457563; c=relaxed/simple; bh=lm8eiZDlfcHQJ0MS0bnwvslqyw2imRABsvWe0la5PQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cao9VnVmvyjKzx4NGr4NKUZLfRGxqD8AqnUmWICe89AdsB+3Eze7UPAMK/6aTzdE73fkJxKBAFGv0V/r+k6RorzARTmFFdbq/2SAuQmKDAwIgY3OheKi1ZPwIcIa2e9IUsex7SUQEEtK//KiFO4YVOnJwT7FW7UkmYRomOy6uCo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=KIct9FBm; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="KIct9FBm" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3bdccba49so2097335a12.1 for ; Thu, 09 Jan 2025 13:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457559; x=1737062359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=68CdHAZCqU/700PS8wNVBBVrBBOJwhpJC23uvX7+CAE=; b=KIct9FBmT7L6NKGb2ue6Mhp5HghrUBoGW3ABvKpq+cOvw4F/65fG0Z3bMZANptW1FI KdErekULAY/Ny7H6yQKPFIeJyofFUIz+Q3pu4rYML3fRJl2MPlywSmndMizvogzjd3hg 1+6EL+XcHJT8x2eI1B8TZctQ0TajEXeSAjIgI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457559; x=1737062359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=68CdHAZCqU/700PS8wNVBBVrBBOJwhpJC23uvX7+CAE=; b=cgyfHj4cj6dlAuY1iRhIRJ3dvBltivIoR6eJqndw2OEyNHUB0Z3QZ9sgHPvaJQZ7D5 cMxmgOZaZlAg81G5gm9AHG47g46N/hAvTfvCHb8+umn8WYzOygzW31MBXcozFrVw9Pvx ZUt5u0+4ooW8j3cHKsqPo9yjffXZHowC05wpoKXjR6Tt0kwggBrFHI2iZLzwpnAIfTPw LkFrH9AJ7tyrCqR20rRtv6V7urQpHliw5MzLBe93bxi4xIp6z8sI4FGEzn5/PKD+wpNo q894SgiliieQtjDMlKnDs4GQt5YM1BBH+OzeR8v4Xibr6vwoC/ZFV43MswOnbJbjwLhI ZNzw== X-Gm-Message-State: AOJu0YwF5dWleGe22SfP3PUftL52Z4zJjVKlU38phl9ShZMVe08fDHgy 86Sxtco3dCrxXpJDt7OSyKHgN/kU7kcWbZvxRcZJARtY/UeuuufyubZjGVLL+2O8YSr45PUGSRN 7 X-Gm-Gg: ASbGncvaDzsbJJuHE88HD7wbInxvEFq/g+DkYcEDNlGdRKPy16xvJco7LPQM81eminW AKxRAUIKB5ZPKy5cWfn3ldDrvuipAzm6dea12N2tqiLB//IC0yw0Y4yvKoaoMj4Q3Av7G1CIMXa TDAEwbkm9dXTlBhTnYUyeSPUnSqtJn1CVvMgTHDwm3624d+cqYTgNmLlidYTlpHiSToz6uqHO0p OjXFmpfWkFheHx7rfhMx4SguF1yBjsp0aMl7svVqYxnWSlXaBGtFu8Yae/rMRhy3Td8C1AyrABf z8qwrqIFIl4N1ySdgs4DGGDmHl6HLLRt+1kCkQH1MQvCZy64gHHJCS53UwBPUaeXnh0XC6jWEPo bjFxkRpEYEfbGhpMGVw== X-Google-Smtp-Source: AGHT+IFfiDSYYvGnEgMP2QwNnIkAkHlHP9l0zHJQ4yI1SUJQxTP9wEsEdwJ81wysyqIM0rn1EM70nA== X-Received: by 2002:a05:6402:4407:b0:5d3:d733:7ad4 with SMTP id 4fb4d7f45d1cf-5d972dfe6abmr8251883a12.3.1736457559390; Thu, 09 Jan 2025 13:19:19 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:18 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Conor Dooley , Krzysztof Kozlowski , Maxime Coquelin , Michael Turquette , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 2/4] dt-bindings: clock: st,stm32-rcc: support spread spectrum clocking Date: Thu, 9 Jan 2025 22:18:29 +0100 Message-ID: <20250109211908.1553072-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The addition of DT bindings for enabling and tuning spread spectrum clocking generation is available only for the main PLL of stm32f{4,7} platforms. Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Update the commit message - Change st,ssc-modmethod type from non-unique-string-array to string .../bindings/clock/st,stm32-rcc.yaml | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml b/Do= cumentation/devicetree/bindings/clock/st,stm32-rcc.yaml index 779e547700be..628bbbcf2875 100644 --- a/Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml +++ b/Documentation/devicetree/bindings/clock/st,stm32-rcc.yaml @@ -56,6 +56,26 @@ properties: Phandle to system configuration controller. It can be used to contro= l the power domain circuitry. =20 + st,ssc-modfreq-hz: + description: + The modulation frequency for main PLL (in Hz) + + st,ssc-moddepth-permyriad: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + The modulation rate for main PLL (in permyriad, i.e. 0.01%) + minimum: 25 + maximum: 200 + + st,ssc-modmethod: + $ref: /schemas/types.yaml#/definitions/string + description: + The modulation techniques for main PLL. + items: + enum: + - center-spread + - down-spread + required: - compatible - reg @@ -81,6 +101,10 @@ allOf: - description: high speed external (HSE) clock input - description: low speed external (LSE) clock input - description: Inter-IC sound (I2S) clock input + st,ssc-modfreq-hz: false + st,ssc-moddepth-permyriad: false + st,ssc-modmethod: false + else: properties: '#clock-cells': @@ -98,6 +122,18 @@ additionalProperties: false =20 examples: # Reset and Clock Control Module node: + - | + clock-controller@40023800 { + compatible =3D "st,stm32f42xx-rcc", "st,stm32-rcc"; + reg =3D <0x40023800 0x400>; + #clock-cells =3D <2>; + #reset-cells =3D <1>; + clocks =3D <&clk_hse>, <&clk_i2s_ckin>; + st,syscfg =3D <&pwrcfg>; + st,ssc-modfreq-hz =3D <10000>; + st,ssc-moddepth-permyriad =3D <200>; + st,ssc-modmethod =3D "center-spread"; + }; - | clock-controller@58024400 { compatible =3D "st,stm32h743-rcc", "st,stm32-rcc"; --=20 2.43.0 From nobody Sat Feb 7 16:26:56 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC5F204C35 for ; Thu, 9 Jan 2025 21:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457564; cv=none; b=DXvEosnDAloduKbTeVkfc4e/RWzXij+tBQhWFb5PMGTcOJA6Olfh24OjmMSLpJrfH7LQAjgxVnkcZKAy4q7gfKN88WtkTWXlEhJ5mXHdflx++E6ACazYuvXX9TBuJwGWMc5Hyl9a8C0nfz4/Z6eup5wuCGjMHcQtcqOY6/9fDLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457564; c=relaxed/simple; bh=54AnFoYFZcZqYgavjCEUI5tS3rZv1k1LrPOchNuHl/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lygOxeYDOMnAeSjSQCK51Ja+HXgqV42pYhyeVaCqSj5+2TlGEO8Vl07N+7OX0+g0Kkv3TQx+9NZEFYl6Tel77UGDt/DP7+mXg+aOTfPdI1HUMOH7a/NAfEZdXsnSCwjti01B30zV6A12PW8yN6S+v/mnZR3yS1aa7QyM6IuRPio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=kx3vQzQe; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="kx3vQzQe" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aaef00ab172so235326666b.3 for ; Thu, 09 Jan 2025 13:19:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457560; x=1737062360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4PuckIz6TtMrm6FhKB7AMqxRoyDL7dpmszhuAU6edRg=; b=kx3vQzQekqacGs1PuiZ+nlGdz/CH/foFXOTLpYn6sJBC3cUq96I0djJ+2P3QXmaL3Z mHtsfH1mxdAUUtoK/AVh+ShpvzhlygiZUBaCnqDE6N381M+BTIpxXrlc0R35j7u/6Vi7 BoAX8fiu5i1rgZWnzxK5pE+dz8Zk/ksrHNg/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457560; x=1737062360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4PuckIz6TtMrm6FhKB7AMqxRoyDL7dpmszhuAU6edRg=; b=PLRo/k2W07lXdgMS/AAxiQcbxoneIu1Aa2ZaQmekCXHxMVZnwieL1JSAf0KMwRmgjq uIno+7QmOPC89h4KycoGlAmj2xjLXkbnifFoXVw0gfZl/wvbXBibB1p5+qLW4THVOOMs stQcs37D6mfUIu1kqGCZAnN5MVsmeOdr4RFtWwcLY9lVlSlP9YFNogARZ/M/8dnSOOQe r2/fDi3hHwhnVd18AX9fNblyIyFm6es/qni/g4++8sdHGEE6kcrHSRKDkm6kQl7q849V zW/mQnd6NQyyPFyzKJJbZk+ViwF4r6igPtfn3vJsltfypzSM1AFqjjsPERsRQDGgvNnv J5Og== X-Gm-Message-State: AOJu0YwFph6Du7+8IcnLyWNJwqjTMkXydVNB89T6Jz4ATY6ic2S0OJ3V z/aCNzny9tj7rYgIzjOqzD3YM5JyzPUFhmNc9bhvPJa2zeqEmxjwKynrEQWjVdxAqy4Ltkl3Zt6 q X-Gm-Gg: ASbGncus7oj/n5e8qEic3V2VdbnI7DtogA53qBm7Nn5CvZeF6M/VeIan4p4yQRbLmKp 4rH7QLS4ekCNT5nWguaMdlyZ0pKzyO8xuuHnhnchv/s2zrcQlzpKXPF+fu9B7ew5DJG2gwB6VpL 3/VpyKlTgZ5NjRJPhB44yDSRHoly+ZfmP+0tF2tKsx4wbl6UqiMe7Uz3vgYq7z6i9a7cdXPKfoW fmpc5kgfbOC0Idt6eZvf5kBKQ2Mu8pwmIqo2ORnR+4ctwbbLTCHgBxGbkxpVpS2YPn8g6v/kWCX 6T17uosTQ1fv2R+w4jWksVOKRLqwYkU1FfCrSEAYZ5RhLAFX/rCfuIeKaV+cx/xyk1gINVXUvCY 46IlXoHsbn2Ejf8Ufpg== X-Google-Smtp-Source: AGHT+IEJwiab5POVdxFq+KPMtd+AMk6FXjRfRzUyO6955YIp4KLeb/nmZtME/YvLjxsDXy27od+mJQ== X-Received: by 2002:a05:6402:400a:b0:5d2:7199:ac2 with SMTP id 4fb4d7f45d1cf-5d972e00032mr18870795a12.2.1736457560441; Thu, 09 Jan 2025 13:19:20 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:20 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Maxime Coquelin , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 3/4] clk: stm32f4: use FIELD helpers to access the PLLCFGR fields Date: Thu, 9 Jan 2025 22:18:30 +0100 Message-ID: <20250109211908.1553072-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use GENMASK() along with FIELD_GET() and FIELD_PREP() helpers to access the PLLCFGR fields instead of manually masking and shifting. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/clk/clk-stm32f4.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 07c13ebe327d..db1c56c8d54f 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -5,6 +5,7 @@ * Inspired by clk-asm9260.c . */ =20 +#include #include #include #include @@ -39,6 +40,8 @@ #define STM32F4_RCC_DCKCFGR 0x8c #define STM32F7_RCC_DCKCFGR2 0x90 =20 +#define STM32F4_RCC_PLLCFGR_N_MASK GENMASK(14, 6) + #define NONE -1 #define NO_IDX NONE #define NO_MUX NONE @@ -632,9 +635,11 @@ static unsigned long stm32f4_pll_recalc(struct clk_hw = *hw, { struct clk_gate *gate =3D to_clk_gate(hw); struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + unsigned long val; unsigned long n; =20 - n =3D (readl(base + pll->offset) >> 6) & 0x1ff; + val =3D readl(base + pll->offset); + n =3D FIELD_GET(STM32F4_RCC_PLLCFGR_N_MASK, val); =20 return parent_rate * n; } @@ -673,9 +678,10 @@ static int stm32f4_pll_set_rate(struct clk_hw *hw, uns= igned long rate, =20 n =3D rate / parent_rate; =20 - val =3D readl(base + pll->offset) & ~(0x1ff << 6); + val =3D readl(base + pll->offset) & ~STM32F4_RCC_PLLCFGR_N_MASK; + val |=3D FIELD_PREP(STM32F4_RCC_PLLCFGR_N_MASK, n); =20 - writel(val | ((n & 0x1ff) << 6), base + pll->offset); + writel(val, base + pll->offset); =20 if (pll_state) stm32f4_pll_enable(hw); --=20 2.43.0 From nobody Sat Feb 7 16:26:56 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7B3203707 for ; Thu, 9 Jan 2025 21:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457566; cv=none; b=XkyDXzbBCI8obIby9cs4WLYzK+bdc9M2gxHznHO7Yw7vbKgfii/uUmMAwO8lOzR98dU1MQrxehZW7eftLoXEfpPmayn/Rjid1at68QLU7kWBm3rLM8dl2Vc/LZ2fLR56GM+9wUy3BA6INZnxMEIhXenc7u+Tn7OgCtttSG2WhPc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736457566; c=relaxed/simple; bh=EoKKi+Z60KmqjOEZJ9LNBHGoycV+Fglx9GgRLT+IXzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mzDaLgilac7VigqPUt2weC73c1lsEmigbycYdL8LVJh2d5mHC8pfvInmNlJPZwg67aQJzEf61p17USIqi1rmLlTmxI8eOnqpUGZT9gq/lXNLPaPvsovxrgM8datw0BlH0tFv0w+rDSac13Awtgn25o0po0fpcD3U8WRtsE+JGCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=d9znHasW; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="d9znHasW" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso2524994a12.1 for ; Thu, 09 Jan 2025 13:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1736457562; x=1737062362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iJ26hgnRMCLZPTXr7KLkVyqRMMqeBIF3e9Y1qTU0tFU=; b=d9znHasWVC8PXqb6XKegRj8Hd/M8KprBB7+YbnFTB/xXvRaN/QCs57qFczQQ9PYj5v t2cSALZ7oD7FVW9EqywxnSrRgHMLCr7aYpv6UWHaLavab254OSbex8XWe0OVUFZ1H9P6 D07Un31kP7NAy44HODflppFTFVm8m5LHknfWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736457562; x=1737062362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iJ26hgnRMCLZPTXr7KLkVyqRMMqeBIF3e9Y1qTU0tFU=; b=qo4JSETFJossGzcB+JO+1VhPYs+wqQCMP+vW+nRwL9Ta2EHy82XNooXAU6g3L4KLvR QzCilbNIj6y5jnLIfefGsH5BHciBv1hKwzS+XbWgXnuQibw+xSLWXZHX8mUhgqvJOb7f lcJL+fGTcx4koNimR1LMz7xvsjsxcdU0w0KrOh520fpRugLVgQv29zgz5YCsNmMyeGQB RORxzFMhIjHjDrnglf24blVGDBLHCPc5JlaCipMPfrcTh5cRhBTAu6041lWCYUysb3x9 e3ZzBAAsBvfY38mnMzD68tx6a5ThqqD4sn0KIc0smbN2GUO1oSG+eyrPDWr7wAkhkxsb WGxw== X-Gm-Message-State: AOJu0YxGV3Lhp91xKDkSeWTg5UteAqpP9H96VK7aLyo3RWiGWosUNCCl wZMLRty8VuBnDYGLDh0iZvIRcVa9DEaaJd6nO92cMSTE/e7P6a6wXSr3ZFHTZFOuw1zifY8Afcu W X-Gm-Gg: ASbGncsXpR1x05qGW5Hn2nO4ZTwZFcIueLGQ38bp1aib6oOggCyer8j8JxzTL9ag2JC tHGRGdaTPlgLNZOXNwM4dbgzZdC1UUQyMPxwCGxcXAEq68mmSLxTCeKlLIKtyuD+IbclZmZPFJH /gt8fTnsyxIWkgapZu/jsxCHhyuXIUKKID60X5M37PjkwQqXBI8W7hxLfWgnF2exKN3uEA/Aajl c5smEeQ+jKBn+gP8DZFl2pr2jp/v3quERgaUbkWfbdglhAtDxpLVQZ+7YUjzZ9l3AUTAXhRA8Pl FycNIKluxxXKlmMC7Vyb//prDpUQjG+hq9qU1cXLbwustgFbHqqjiqRpnRJRi1gejnlkWPGVOb/ WDIYgzQpY9F00nmG+ZA== X-Google-Smtp-Source: AGHT+IEZ3Pmwpnwcw8QBt1dN5e19AnUypwazIVJ9R+ER6Nu6NohOMhjMnT0yJVMOQm16EeoH5knA9A== X-Received: by 2002:a05:6402:40cc:b0:5d0:d328:3a43 with SMTP id 4fb4d7f45d1cf-5d98a24a72fmr3294628a12.6.1736457562307; Thu, 09 Jan 2025 13:19:22 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-41-6-15.retail.telecomitalia.it. [79.41.6.15]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d9900c4b56sm925567a12.32.2025.01.09.13.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 13:19:22 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Alexandre Torgue , Maxime Coquelin , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v2 4/4] clk: stm32f4: support spread spectrum clock generation Date: Thu, 9 Jan 2025 22:18:31 +0100 Message-ID: <20250109211908.1553072-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> References: <20250109211908.1553072-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Support spread spectrum clock generation for the main PLL, the only one for which this functionality is available. Tested on the STM32F469I-DISCO board. Signed-off-by: Dario Binacchi --- Changes in v2: - Fixup patches: 2/6 dt-bindings: reset: st,stm32-rcc: update reference due to rename 3/6 dt-bindings: clock: stm32fx: update reference due to rename to 1/6 dt-bindings: clock: convert stm32 rcc bindings to json-schema - Changes to dt-bindings: clock: convert stm32 rcc bindings to json-schema - Changes to dt-bindings: clock: st,stm32-rcc: support spread spectrum cloc= king drivers/clk/clk-stm32f4.c | 143 +++++++++++++++++++++++++++++++++++++- 1 file changed, 140 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index db1c56c8d54f..6c80c0dbb0a3 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -35,6 +35,7 @@ #define STM32F4_RCC_APB2ENR 0x44 #define STM32F4_RCC_BDCR 0x70 #define STM32F4_RCC_CSR 0x74 +#define STM32F4_RCC_SSCGR 0x80 #define STM32F4_RCC_PLLI2SCFGR 0x84 #define STM32F4_RCC_PLLSAICFGR 0x88 #define STM32F4_RCC_DCKCFGR 0x8c @@ -42,6 +43,12 @@ =20 #define STM32F4_RCC_PLLCFGR_N_MASK GENMASK(14, 6) =20 +#define STM32F4_RCC_SSCGR_SSCGEN BIT(31) +#define STM32F4_RCC_SSCGR_SPREADSEL BIT(30) +#define STM32F4_RCC_SSCGR_RESERVED_MASK GENMASK(29, 28) +#define STM32F4_RCC_SSCGR_INCSTEP_MASK GENMASK(27, 13) +#define STM32F4_RCC_SSCGR_MODPER_MASK GENMASK(12, 0) + #define NONE -1 #define NO_IDX NONE #define NO_MUX NONE @@ -512,6 +519,17 @@ static const struct clk_div_table pll_divr_table[] =3D= { { 2, 2 }, { 3, 3 }, { 4, 4 }, { 5, 5 }, { 6, 6 }, { 7, 7 }, { 0 } }; =20 +enum stm32f4_pll_ssc_mod_type { + STM32F4_PLL_SSC_CENTER_SPREAD, + STM32F4_PLL_SSC_DOWN_SPREAD, +}; + +struct stm32f4_pll_ssc { + unsigned int mod_freq; + unsigned int mod_depth; + enum stm32f4_pll_ssc_mod_type mod_type; +}; + struct stm32f4_pll { spinlock_t *lock; struct clk_gate gate; @@ -519,6 +537,8 @@ struct stm32f4_pll { u8 bit_rdy_idx; u8 status; u8 n_start; + bool ssc_enable; + struct stm32f4_pll_ssc ssc_conf; }; =20 #define to_stm32f4_pll(_gate) container_of(_gate, struct stm32f4_pll, gate) @@ -541,6 +561,7 @@ struct stm32f4_vco_data { u8 offset; u8 bit_idx; u8 bit_rdy_idx; + bool sscg; }; =20 static const struct stm32f4_vco_data vco_data[] =3D { @@ -661,6 +682,34 @@ static long stm32f4_pll_round_rate(struct clk_hw *hw, = unsigned long rate, return *prate * n; } =20 +static void stm32f4_pll_set_ssc(struct clk_hw *hw, unsigned long parent_ra= te, + unsigned int ndiv) +{ + struct clk_gate *gate =3D to_clk_gate(hw); + struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + struct stm32f4_pll_ssc *ssc =3D &pll->ssc_conf; + u32 modeper, incstep; + u32 sscgr; + + sscgr =3D readl(base + STM32F4_RCC_SSCGR); + /* reserved field must be kept at reset value */ + sscgr &=3D STM32F4_RCC_SSCGR_RESERVED_MASK; + + modeper =3D DIV_ROUND_CLOSEST(parent_rate, 4 * ssc->mod_freq); + incstep =3D DIV_ROUND_CLOSEST(((1 << 15) - 1) * ssc->mod_depth * ndiv, + 5 * 10000 * modeper); + sscgr |=3D STM32F4_RCC_SSCGR_SSCGEN | + FIELD_PREP(STM32F4_RCC_SSCGR_INCSTEP_MASK, incstep) | + FIELD_PREP(STM32F4_RCC_SSCGR_MODPER_MASK, modeper); + + if (ssc->mod_type) + sscgr |=3D STM32F4_RCC_SSCGR_SPREADSEL; + + pr_debug("%s: pll: %s: modeper: %d, incstep: %d, sscgr: 0x%08x\n", + __func__, clk_hw_get_name(hw), modeper, incstep, sscgr); + writel(sscgr, base + STM32F4_RCC_SSCGR); +} + static int stm32f4_pll_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { @@ -683,6 +732,9 @@ static int stm32f4_pll_set_rate(struct clk_hw *hw, unsi= gned long rate, =20 writel(val, base + pll->offset); =20 + if (pll->ssc_enable) + stm32f4_pll_set_ssc(hw, parent_rate, n); + if (pll_state) stm32f4_pll_enable(hw); =20 @@ -788,6 +840,87 @@ static struct clk_hw *clk_register_pll_div(const char = *name, return hw; } =20 +static int stm32f4_pll_init_ssc(struct clk_hw *hw, struct stm32f4_pll_ssc = *conf) +{ + struct clk_gate *gate =3D to_clk_gate(hw); + struct stm32f4_pll *pll =3D to_stm32f4_pll(gate); + struct clk_hw *parent; + unsigned long parent_rate; + int pll_state; + unsigned long n, val; + + parent =3D clk_hw_get_parent(hw); + if (!parent) { + pr_err("%s: failed to get clock parent\n", __func__); + return -ENODEV; + } + + parent_rate =3D clk_hw_get_rate(parent); + + pll->ssc_enable =3D true; + memcpy(&pll->ssc_conf, conf, sizeof(pll->ssc_conf)); + + pll_state =3D stm32f4_pll_is_enabled(hw); + + if (pll_state) + stm32f4_pll_disable(hw); + + val =3D readl(base + pll->offset); + n =3D FIELD_GET(STM32F4_RCC_PLLCFGR_N_MASK, val); + + pr_debug("%s: pll: %s, parent: %s, parent-rate: %lu, n: %lu\n", + __func__, clk_hw_get_name(hw), clk_hw_get_name(parent), + parent_rate, n); + + stm32f4_pll_set_ssc(hw, parent_rate, n); + + if (pll_state) + stm32f4_pll_enable(hw); + + return 0; +} + +static int stm32f4_pll_ssc_parse_dt(struct device_node *np, + struct stm32f4_pll_ssc *conf) +{ + int ret; + const char *s; + + if (!conf) + return -EINVAL; + + ret =3D of_property_read_u32(np, "st,ssc-modfreq-hz", &conf->mod_freq); + if (ret) + return ret; + + ret =3D of_property_read_u32(np, "st,ssc-moddepth-permyriad", + &conf->mod_depth); + if (ret) { + pr_err("%pOF: missing st,ssc-moddepth-permyriad\n", np); + return ret; + } + + ret =3D of_property_read_string(np, "st,ssc-modmethod", &s); + if (ret) { + pr_err("%pOF: missing st,ssc-modmethod\n", np); + return ret; + } + + if (!strcmp(s, "down-spread")) { + conf->mod_type =3D STM32F4_PLL_SSC_DOWN_SPREAD; + } else if (!strcmp(s, "center-spread")) { + conf->mod_type =3D STM32F4_PLL_SSC_CENTER_SPREAD; + } else { + pr_err("%pOF: wrong value (%s) for fsl,ssc-modmethod\n", np, s); + return -EINVAL; + } + + pr_debug("%pOF: SSCG settings: mod_freq: %d, mod_depth: %d mod_method: %s= [%d]\n", + np, conf->mod_freq, conf->mod_depth, s, conf->mod_type); + + return 0; +} + static struct clk_hw *stm32f4_rcc_register_pll(const char *pllsrc, const struct stm32f4_pll_data *data, spinlock_t *lock) { @@ -1695,7 +1828,8 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) const struct of_device_id *match; const struct stm32f4_clk_data *data; unsigned long pllm; - struct clk_hw *pll_src_hw; + struct clk_hw *pll_src_hw, *pll_vco_hw; + struct stm32f4_pll_ssc ssc_conf; =20 base =3D of_iomap(np, 0); if (!base) { @@ -1754,8 +1888,8 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) clk_hw_register_fixed_factor(NULL, "vco_in", pll_src, 0, 1, pllm); =20 - stm32f4_rcc_register_pll("vco_in", &data->pll_data[0], - &stm32f4_clk_lock); + pll_vco_hw =3D stm32f4_rcc_register_pll("vco_in", &data->pll_data[0], + &stm32f4_clk_lock); =20 clks[PLL_VCO_I2S] =3D stm32f4_rcc_register_pll("vco_in", &data->pll_data[1], &stm32f4_clk_lock); @@ -1900,6 +2034,9 @@ static void __init stm32f4_rcc_init(struct device_nod= e *np) =20 of_clk_add_hw_provider(np, stm32f4_rcc_lookup_clk, NULL); =20 + if (!stm32f4_pll_ssc_parse_dt(np, &ssc_conf)) + stm32f4_pll_init_ssc(pll_vco_hw, &ssc_conf); + return; fail: kfree(clks); --=20 2.43.0