From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF204214A78 for ; Thu, 9 Jan 2025 07:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409082; cv=none; b=AAw8QUuyJDubeurmtA/JZCM4ETBsbBWeLs0sIUVVXqevB7zqjeNTWdlFU/Mm102X9UwAQlIsVCIfOkhvXK+va5t5WnBWsDUdW71+pSS6B3lUPX5Ej9eEQe/BjJERBQmR8kNZ5Fr1ydyUi3OrMfJffWFGdT3VZLwFTSy2q5Bt8e8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409082; c=relaxed/simple; bh=q5bMp7PJSGnNgxEfef9drZZDGV2cNpjnTsQPTbdE+eE=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=uRdwdDvDkyq1sb9zGKXfelHNEa7OF4pYc8e2k81Yj+HNiNqGsEQrgeEypilc0bbWowYELZQFKdbcZCox4jfi+YZAtdMsmbLGyvBBQKoKkdf1VGK62CM9smtVzaBZVL6duKYyehqLTEYiRWq1e2UBPgs8rNPebf9IK/cKS4O9+Is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=noB7anb4; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="noB7anb4" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e544c8dae18so1580128276.1 for ; Wed, 08 Jan 2025 23:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409079; x=1737013879; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=BfOiQa/L9OiEEGjP9sXMi3rlBfHgK084BGp4CIjcSjs=; b=noB7anb4kVm8UcHMkZ3ho4ACYz6M01TGB9znVdUPA+SvRVipwC9t00M2gsn5ElCzU0 EPvD/i+8Wf+o0XAF1yhbbLdzW1z+oQrQ/C0fy02QGEHAj3S/XLKc8kMyPOkps6WwGlR1 X7+LIVDEmLzr8TVwD9fWY4uyIj4c/fB74JyMfIe5D0xovVk0Bn3b6b0vjJ+LNIfZ2GRd 15hrVx4+9NmyIYGevb+sq1/ZK1GHxvfWiznp6RPZd0fM8xgmpCB48gw9vTNA0RAUYhtb T4UiOuoECJfcIjJT7ivE/F+JratwZgEAJlRJf1fUIV8CKgBxXe64qWgB+htTeUfCTCVk 0EFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409079; x=1737013879; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BfOiQa/L9OiEEGjP9sXMi3rlBfHgK084BGp4CIjcSjs=; b=ZgHJV/EqeFLFEav2sEtQc0bdtWnVY4uMQ1Dg+moCWTSo5qxEUd9G2j5Bx2Keb8LURo FpovkrSpQgwns8h/Fcmq1ljNxVV/KVyPHQ07s3jEweYXWllnLmVTBIBLWaeOkV2HY+Ng 2Y+g88BZ461/x09ljcIASesz4c990bb8s7YjAPs4L+2c/eNsdEwFamadNwitsL+GKXIy ERdZukOpiDW51OaiPl1ivTt9FBYVbv8PLHI1uP0r1IKUIioTN43PXDyhDr0r74Wp/TH0 SQTrTm5z1WEvembdad2Tbodp+89XDU0MKG/3P77HnUytISqAeBaXFR5VQdi6boNL5mcv xpHA== X-Forwarded-Encrypted: i=1; AJvYcCX27FXPxAl83PK+8HDUsL+nRtAvl+vjHcjuQ81Fby9H7CUEpqR5eJyV9rpo0ApF5eQfHYt63WPXZeC0LUY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1zVYq7FM2G0YXXV3RjAfEA6hS0Ydl0PB/4BRoMVx5+PQBTGEx aU02JBYggCg8d6C66jWUt6t5Lc2ujRJ4sSgWeNv8GoF6+cEtSAPWLHqKdUQASICOC3kmuTI01HV XMHuxCQ== X-Google-Smtp-Source: AGHT+IHJ+xoP/OiRHl2NwVopvadefTgrOROW0d1nGwF4MhrqP/RTesuhzD45oXRxdaLTiZ5qawBd8auXYm7X X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:30d5:0:b0:e4a:8f5b:179a with SMTP id 3f1490d57ef6-e54ee276297mr14040276.9.1736409078576; Wed, 08 Jan 2025 23:51:18 -0800 (PST) Date: Wed, 8 Jan 2025 23:50:58 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 01/11] perf debug: Avoid stack overflow in recursive error message From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In debug_file, pr_warning_once is called on error. As that function calls debug_file the function will yield a stack overflow. Switch the location of the call so the recursion is avoided. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 995f6bb05b5f..f9ef7d045c92 100644 --- a/tools/perf/util/debug.c +++ b/tools/perf/util/debug.c @@ -46,8 +46,8 @@ int debug_type_profile; FILE *debug_file(void) { if (!_debug_file) { - pr_warning_once("debug_file not set"); debug_set_file(stderr); + pr_warning_once("debug_file not set"); } return _debug_file; } --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E84DB43169 for ; Thu, 9 Jan 2025 07:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409083; cv=none; b=lGNlGwQpZT27MU5YQ3SKdooGtLrZnZvo90sK/MGMX4M0G3BnJZOHGomgscHcRyrNtB14Wx3C31+EXlguiqnDNz/yco9GODvKsAADE+YfHiw4u/cw4YYD2MvJXufrUu7klBDOYI7Ugq5yUPV5v3fg5JnRy+bfkwuR8jVIeoUknM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409083; c=relaxed/simple; bh=l3rsftF8R/Lbyc2l8yy+s7iBe/R5ucGrbpLeFvVhTAs=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=SulDAGktHterGFOPyvZC61E5AscIRiNGQcIxVPH2h30cgVC5Zs5uTW/XjoRHq8W9loaRFdHJ319xq5AoDm5T5GOjXICBBExcAF8eAPNw+RVzQdefbV5BahHMdNfIRxUNbKAiXL8pEKC0jE850AI0acjW7xsV3SpTP9JU0ZZczWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=iQe7xpUw; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iQe7xpUw" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e02fff66a83so1230160276.0 for ; Wed, 08 Jan 2025 23:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409081; x=1737013881; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=BR5b0II9MP8kbiarazKtxJYt5Ueqv9IehOmdPFNXrQI=; b=iQe7xpUwzABl8UOGPHFY5lIKIovakAdgjGsUimb3UMcJprT8+RywvlbWE5naqviDrs NrzV7wXMAPVE9xDgIu5EVdtkVG5mnizPGJSR2vtXqmB2+XFvozOp8qPLpWhsmEk2s2St i8EktFY8LaTc+GcvKE6dpq0rgsHYw3L4c8WQihUQXXrtfs0Wu69tudPnSPeRFQb3zida /oj+ao5X3KqtSoAfMhQC8VYM4B7uUNlM5kDiLiXQ/EeRCGovFkjoh/BE9B8AksihlViC VVzhHHc6dYDtf4t/rFnZCsk4Eo3zxfeCaM0rNx3uCxWUj4GC3lg9Wf9HA4ylH/4RCPvm uOAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409081; x=1737013881; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BR5b0II9MP8kbiarazKtxJYt5Ueqv9IehOmdPFNXrQI=; b=wBeYkuoe6B26ChYkar+9W2k4xCVY7FEjblBYKLPF48dBhCsOQ8rKrlbf8xJPGCfxo2 krzgJeNYqApshN1eklGD1lkiU5HOfAfqVjgdq8C+Dngm8YhnCx+jwvhx4ksHnmhreUl0 I6/O9Kr3ghrfty7kN8FnDuRU1pYW1iGbIW6WItQo34P1EM2bAxLt9jSBL4pgApZVxm97 P3e71T6YX3OsoMXI4/Q9N18gzDO9VFEhH8QJ3wvwiGhE4TMx0ejojUzJ4s4QjCtuj38S cdTvIJvaSLe3b6I6X7Ttt1uoDWt2FZFfX7zwTbMDgvDEiLtHL4uEVzZOFVxXVjz5xBPR hvmg== X-Forwarded-Encrypted: i=1; AJvYcCUF7fzK0dz/dipQdvKJC0nLAzWDHe1NirnT+5S/tq+mRBT3gYW5XxJS05IHLTZNtXQwOLjxiXGoFpJNDLo=@vger.kernel.org X-Gm-Message-State: AOJu0YyAEKhgi9S6+iHGvwQ2Few6zr53LwLXpXbmT9sa1i+NyDQ14FNO hqK3EHnruUf/ioE45diEXw5oKYI2YEGI2gE+HCHYGj0IwrNxYnoyXKY1S83q3n97fFG0VPl8nV8 ns52oQg== X-Google-Smtp-Source: AGHT+IFaLpuzEz62THI4YJQg5UCkmxrc6rOT4j4MT0fvtNntW9tGS36QfwR2+cn28xMqnY1sGhdl7efGDtAM X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:ab65:0:b0:e53:d953:90a8 with SMTP id 3f1490d57ef6-e54ee1388famr13080276.4.1736409080861; Wed, 08 Jan 2025 23:51:20 -0800 (PST) Date: Wed, 8 Jan 2025 23:50:59 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-3-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 02/11] perf evlist: Add success path to evlist__create_syswide_maps From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Over various refactorings evlist__create_syswide_maps has been made to only ever return with -ENOMEM. Fix this so that when perf_evlist__set_maps is successfully called, 0 is returned. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/evlist.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index f0dd174e2deb..633df7d9204c 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1373,19 +1373,18 @@ static int evlist__create_syswide_maps(struct evlis= t *evlist) */ cpus =3D perf_cpu_map__new_online_cpus(); if (!cpus) - goto out; + return -ENOMEM; =20 threads =3D perf_thread_map__new_dummy(); - if (!threads) - goto out_put; + if (!threads) { + perf_cpu_map__put(cpus); + return -ENOMEM; + } =20 perf_evlist__set_maps(&evlist->core, cpus, threads); - perf_thread_map__put(threads); -out_put: perf_cpu_map__put(cpus); -out: - return -ENOMEM; + return 0; } =20 int evlist__open(struct evlist *evlist) --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6920B21504F for ; Thu, 9 Jan 2025 07:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409086; cv=none; b=A/0eq3KfCnDx77zfN3tcst2lkm5eer0UblNINprnPby0Z/euwwuyRIMYGbN4CRuemOVeCNfSp5HMqW5CbTPBE8SJUYgcHkNag/WpN0hFsd4xiCSj8EiAqauRLGH6iddvtqIYR8NGHtltn8maWOj8zmg1kVjIZdzEqeIP7hirNbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409086; c=relaxed/simple; bh=D2vadbk3cOq/+EWq9g43saoHn+J5Gupg2/gIpPUhIrw=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=KIw9Kos58F8wv8vAkpD9qGch1uuQQQwPpxwlFs90+Bvs+bNQqyc/qVUHawHGrJVuxjjAKMQubjwr3KNsU0nk2l/tdYnDzEfCpoj52fhzLZx9AF41hbHUSPGfva2UcARDHuyhNnI6+YWgTD6RwBy+4GA7ZouyY2SRx/mm8v3i9gs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=J6jZE2k2; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="J6jZE2k2" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e39993d8594so1319563276.3 for ; Wed, 08 Jan 2025 23:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409083; x=1737013883; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=jQcA17ms8HvYcRiFBtp5KUfpun8NEvpfsnHmAmkz/ss=; b=J6jZE2k2/iwQiUAi4wtu/y6UZcvFwd6OCpa7ReKAOlUaa2PCbsklsf4eKJ/HBMVmsE 1NJAQ7zghrSK/iTI9GqYVuaMZxDaf904E0b86sm2QxD8aZQaScShVxFTgXFmFicoMpsZ tb4x+An3YoXYaAbXvl/YlSTsSJ+kY4EMz4SDs0XhIOXPaM4Rllnvh7s8jZWXqcE7cSmO hdYCqOlwZr/m1Zm/Pi6VqQqzZrCW/3U8lu2Bq4u1r1+x0+E4wCsZPwWLZiKtNm5bm7uv Vr0jszLIh9HFkHnISK70wK7fWVSxRs6/yAR9NkY2XQKKgkouO84xLVug9SlYoKMPAzxy 559A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409083; x=1737013883; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jQcA17ms8HvYcRiFBtp5KUfpun8NEvpfsnHmAmkz/ss=; b=UnQYQ0S8Rh44Uym0wesF6BLneAifX/3mVXQFruP+qSYZyKQzuQYggM/BDwd/Ad9pI3 lY9by9aHoPVdzkz4DO178htJbu8kLS63B0SUcA8zxvlbz9o/IoMThh/vN3ry5dkypXsi JRdWTe7sn8DaLMVwCr0ZPl43IFmKc+V83JKZivIzCEglKPnAiGOa/xStwjkp2ToEnfO7 illUlzlClkWqOttV39fgtzuJkIBfkg4fgIhmfFC73/jysOyFpoaMAWEV+WA/R9UFLpgc INWM+gyRlxJ39khyj5d1qsLntQLgcA9HYSAunx39bOf7OFu3UBGkWszEUz2I61knRvk0 g56A== X-Forwarded-Encrypted: i=1; AJvYcCWcnjlgRs5tM8AzNKImznTgZiV2XtvG40ZaIwtuwJ72f0lCct+3/Ms8YsYfpPBA4uYW1DDCcY4oWN4NpiE=@vger.kernel.org X-Gm-Message-State: AOJu0YyKx3/5peYi3+NOX5Ga6yVQjMP/iCuuWoahrNOdjwPm68JWl236 I2ZJYZuTd2TAFrfT0Y6bCCP8c/QAYCly3eDKW97852OhJG4v1bihx3+jfVlqv9gHG8YezQyzy5+ MCcrGEA== X-Google-Smtp-Source: AGHT+IGCahQWdbnl3OdawlTflOkDj2h+wIGV3RscZKPtsVYugDlRvjXk0T62AGYdj+3n+mW4iQktRlBwZVYW X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a0d:d102:0:b0:6f4:beb3:1d8b with SMTP id 00721157ae682-6f5312b5762mr148577b3.3.1736409083360; Wed, 08 Jan 2025 23:51:23 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:00 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-4-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 03/11] perf evsel: tp_format accessing improvements From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure evsel__clone copies the tp_sys and tp_name variables. In evsel__tp_format, if tp_sys isn't set, use the config value to find the tp_format. This succeeds in python code where pyrf__tracepoint has already found the format. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/evsel.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 697428efa644..5324a8916da1 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -511,6 +511,16 @@ struct evsel *evsel__clone(struct evsel *dest, struct = evsel *orig) } evsel->cgrp =3D cgroup__get(orig->cgrp); #ifdef HAVE_LIBTRACEEVENT + if (orig->tp_sys) { + evsel->tp_sys =3D strdup(orig->tp_sys); + if (evsel->tp_sys =3D=3D NULL) + goto out_err; + } + if (orig->tp_name) { + evsel->tp_name =3D strdup(orig->tp_name); + if (evsel->tp_name =3D=3D NULL) + goto out_err; + } evsel->tp_format =3D orig->tp_format; #endif evsel->handler =3D orig->handler; @@ -634,7 +644,11 @@ struct tep_event *evsel__tp_format(struct evsel *evsel) if (evsel->core.attr.type !=3D PERF_TYPE_TRACEPOINT) return NULL; =20 - tp_format =3D trace_event__tp_format(evsel->tp_sys, evsel->tp_name); + if (!evsel->tp_sys) + tp_format =3D trace_event__tp_format_id(evsel->core.attr.config); + else + tp_format =3D trace_event__tp_format(evsel->tp_sys, evsel->tp_name); + if (IS_ERR(tp_format)) { int err =3D -PTR_ERR(evsel->tp_format); =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA91B215074 for ; Thu, 9 Jan 2025 07:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409088; cv=none; b=dPelo9vkHLlBLWXY1hqEJeT+hFQOds8K0IMRlcWaQYpwJEDdoYa3qU7i5JSWdYMUNKhxAmR6/BU0rkzLXTeBUTTLpUul1wqILqSOQe3fQKM9RpCDprojo9jurjSan8+8OF/b84TYeYbbnzMQDuc9B720ZhlGKpgSjrzE/NVfLTs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409088; c=relaxed/simple; bh=JWLHLZaHXZUbCGyEiGTHx6SFRTHPlzSBMWL1I5q0294=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=Hxnbn00RZPDiEDtx2cqSeLsDbU9NZ2/jO0C7A6hH16+bn4kMuVUiwabDI+9Xwu4DDeT9KgxqlUGsdMj+7I9GIFYEvO0wG66Dc6VVxuLltibwp0WN8daYCj2MpF8gwcl7GGi4JaXQq3PF9c3Ecky9rnCF8oLCk/r1zUXrOmTEjEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lDbMTg+C; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lDbMTg+C" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e549eac4ae6so1186558276.1 for ; Wed, 08 Jan 2025 23:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409086; x=1737013886; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=epzBIcpq14vhr2+XgSqG+4thTJ3QNCJ6p4BI0eNk4RM=; b=lDbMTg+Ccv1fYL84iPpiSpNDsZ8+HsK+K6aSIy1sYTETn0A86qIp/mvur/VDRQJoL4 FBTZUOXZJvrAdKh2N7Pdhn4D8WzWAWdjEORNcpZCVGwM7c2Rg85eTAnJ+nb/56G2a/nv 00flQh7MlGoDtrEwS2c59w7+C7vleHwjlxN3/E4cSbTaI55/FFAoAxiFYZf8hHzRD1uW npMRgZjPhFEjfaQmwtqklMQ3U7LSeSw2wdfugx+ZX8iWiyVTXzxBAKaXLcZIM+Pz859X 66rzluV2T/QRcv7JiVG2LE/u3KIfM1q9cQTGhrn0Uk4EG/bxcs+K3EODLnUwkli3maPw 3fzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409086; x=1737013886; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=epzBIcpq14vhr2+XgSqG+4thTJ3QNCJ6p4BI0eNk4RM=; b=LdUkmGSttJcsiUCgIPHcwlogF0knY4KvlaNrCNN76zSL0TAibIhR5L+s6bGxuKcmm4 w7Lo0szWYg9AzUHb0R2HTC1X73VJhYhJZj2h9Tj+He3Duen5SdlZiPwVOwtGxSbrserz 8Td8+y5lwQeSwJXcaOHwRjt7jcR9K1NI2AAFkgpJXwpIY4JhC/A6uHgy8roaigvkwLFa NQont++H+DHDMB6mZvlZtMBd1mE9VqhG5OkZjJe7Uv/X806Sh9I+Sg4vt7INXgaMMd9Y ek3SGakTnyXpSEt3oybVFpctvykAMNEHx/1yj/DxVY533dA1wbZR0mN9wyNePaMjqGdU 8DrA== X-Forwarded-Encrypted: i=1; AJvYcCXhnMtnWvEVKVubOgJPhFIG2XxXgM/zWPMJMPuhHzi/5LqIjwnbk84+pCZWNp61MCKeIzUK7hM4EyZwRgc=@vger.kernel.org X-Gm-Message-State: AOJu0YxylsM8xCDRWuHyyHSvG9o+XcslOnuSYt8D4SZ4ic7q6f0MYimD /LUNeDtfhXb+mjo+JM2Mylm3XKS48Wc1DAuvdOM2RwmR/d6U/mo9idgbVk4KT6kSmhuNkbtvVVT dTve6Cg== X-Google-Smtp-Source: AGHT+IG16oQcBcWxWzba8vjLnphRCfLsB1BOo7MqZBmhZ+9j3cgfHLBvEUa+7wAK787lSMmL1smOrh1E4PHi X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:cecf:0:b0:e4c:35c4:cf05 with SMTP id 3f1490d57ef6-e54ee1e51a6mr11486276.5.1736409085711; Wed, 08 Jan 2025 23:51:25 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:01 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-5-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 04/11] perf python: Add evlist enable and disable methods From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" By default the evsels from parse_events will be disabled. Add access to the evlist functions so they can be enabled/disabled. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index b4bc57859f73..8f68320130c4 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -1019,6 +1019,20 @@ static PyObject *pyrf_evlist__open(struct pyrf_evlis= t *pevlist, return Py_None; } =20 +static PyObject *pyrf_evlist__disable(struct pyrf_evlist *pevlist) +{ + evlist__disable(&pevlist->evlist); + Py_INCREF(Py_None); + return Py_None; +} + +static PyObject *pyrf_evlist__enable(struct pyrf_evlist *pevlist) +{ + evlist__enable(&pevlist->evlist); + Py_INCREF(Py_None); + return Py_None; +} + static PyMethodDef pyrf_evlist__methods[] =3D { { .ml_name =3D "mmap", @@ -1056,6 +1070,18 @@ static PyMethodDef pyrf_evlist__methods[] =3D { .ml_flags =3D METH_VARARGS | METH_KEYWORDS, .ml_doc =3D PyDoc_STR("reads an event.") }, + { + .ml_name =3D "disable", + .ml_meth =3D (PyCFunction)pyrf_evlist__disable, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR("Disable the evsels in the evlist.") + }, + { + .ml_name =3D "enable", + .ml_meth =3D (PyCFunction)pyrf_evlist__enable, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR("Enable the evsels in the evlist.") + }, { .ml_name =3D NULL, } }; =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07973215179 for ; Thu, 9 Jan 2025 07:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409090; cv=none; b=qOIxeVf52urFJGCdm4G/uINrkJmbNqtZBEF/PrvpIIKmBFVQ9qw28iEfzbZ7C3kMosxJF7+QOuMHiy//JV/+/2WokYvlXl+5RkStau1dYjMgjK6EOaWdWyxqdBONC/yUEg2zDiLYrAvO26KTtmi5eLNAGfqw6LRY6Rq1F7Qde9Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409090; c=relaxed/simple; bh=hiXdohrvZfBQQVlWlScp48GUnTP6f+2pkpwNTAqWek4=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=W1ZgwS7zJVBOpFdRA60SMEWZMjaB4zKKCZb2NN4x/OXs9HzfCc3vNfVpgBzyZY+9KrWDZNr86ZiFO0hwaZ53wu4yvLYGSIBiU4+oeCKB2puuzHxsiTTLryNWWlbw5TVDDLeQwFq4nqY1iCbc4N4WgMq6YwzR/1AyC5p53K3VKYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rOiMBxdc; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rOiMBxdc" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e48beea5778so1463941276.1 for ; Wed, 08 Jan 2025 23:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409088; x=1737013888; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=2aDXsm3uEdQo2ZnXfxbpUagdP14qYtfS3MpVBq60tU0=; b=rOiMBxdcauwuA3SY1v4LHIv1nKpnSRVk0sTKuThT2KtrJF/AGwt2P4MWHtE7OKCgKf VaGIwxFxnBPZ5pa5GME+n95xVEY0TZCDSWd3Jz/ri3UpyNLOKqSbKC9UcpGGYT5HHP1C ccxSYJ/EOX6brUVFN2rielmGELRep0MJIoGxRuEEpIzNDRMwd5U9GLJj/6EsBk+jOBKG SBb4aLV2ukfnd80iTVs5HEK7IKvnY7Ipct92sVvmyurf3mLPmM5mJEPkPKPuwk34I2wb vxBwEVl/h2l4Qg08Tv9JK4BqlD+ov7zQkhFjS6wFEXbg6HsPKHuBI+eqMWhswm2undDd oVLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409088; x=1737013888; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2aDXsm3uEdQo2ZnXfxbpUagdP14qYtfS3MpVBq60tU0=; b=WK7AJKl/kbXkqOGZy8ltzNxDjofqaJfMkg4RxbkgTtMSHUfKmYKKld89EKa8+YQW7D YeH0C4rW8/N3hyCMt8ilIahK6nzTIT3gIIVr8NSD5kJuYuzuolBL332GGcrfy5rFBD5B h09bA0G4og7N5BLMXQVgjiclzUNz/ak5Os5ZChG9+HWwQ3XsJTHy1fdRhLqNaY93O8QR 7rUWbxJzJZUYwFYQaFH8cgGuGkCDyxsg5avokz/9HNY51y+Cg8zhYTn0lI9oGLLjzQM3 UVKc+Dgpy3JbghtymsYl64iYqnR31AtjW9UYHxBKyapaR4a59LwyyFILPULAwMfG79sk 4C8w== X-Forwarded-Encrypted: i=1; AJvYcCXwoiRn5m6wjx6xDfmbHkY+okYGOkoCkoc3m4I4tdYbuN7dPGf4pGkP6HR6nKraT6Pm+y8yeU/NSi/GRP4=@vger.kernel.org X-Gm-Message-State: AOJu0YzdAd2GxJkCI1iQNiHDZQNvC7FMT8x4btobkhy+0M5NPVO/UU/Y OCjLd7JnoaaFR52We3o0KKrRaPQlfJaK/Cwq7HAyH1luWYhouVmzh5iKPS+DPzkET0UyQVCpHiD FrEZjTw== X-Google-Smtp-Source: AGHT+IHkS55KUzgcoevzHuMN1Ir9gOuIfNU/o0DtzV6iVcbvEacKNS6E+1S/Q/beXkgJxe1UXVhLr+ri7zYq X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:a144:0:b0:e39:87ba:3582 with SMTP id 3f1490d57ef6-e54f01a8895mr11372276.5.1736409088033; Wed, 08 Jan 2025 23:51:28 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:02 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-6-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 05/11] perf python: Add member access to a number of evsel variables From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Most variables are part of the perf_event_attr, so that they may be queried and modified. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 8f68320130c4..6a7042fd2569 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -802,6 +802,28 @@ static PyMethodDef pyrf_evsel__methods[] =3D { { .ml_name =3D NULL, } }; =20 +#define evsel_member_def(member, ptype, help) \ + { #member, ptype, \ + offsetof(struct pyrf_evsel, evsel.member), \ + 0, help } + +#define evsel_attr_member_def(member, ptype, help) \ + { #member, ptype, \ + offsetof(struct pyrf_evsel, evsel.core.attr.member), \ + 0, help } + +static PyMemberDef pyrf_evsel__members[] =3D { + evsel_member_def(tracking, T_BOOL, "tracking event."), + evsel_attr_member_def(type, T_UINT, "attribute type."), + evsel_attr_member_def(size, T_UINT, "attribute size."), + evsel_attr_member_def(config, T_ULONGLONG, "attribute config."), + evsel_attr_member_def(sample_period, T_ULONGLONG, "attribute sample_perio= d."), + evsel_attr_member_def(sample_type, T_ULONGLONG, "attribute sample_type."), + evsel_attr_member_def(read_format, T_ULONGLONG, "attribute read_format."), + evsel_attr_member_def(wakeup_events, T_UINT, "attribute wakeup_events."), + { .name =3D NULL, }, +}; + static const char pyrf_evsel__doc[] =3D PyDoc_STR("perf event selector lis= t object."); =20 static PyTypeObject pyrf_evsel__type =3D { @@ -811,6 +833,7 @@ static PyTypeObject pyrf_evsel__type =3D { .tp_dealloc =3D (destructor)pyrf_evsel__delete, .tp_flags =3D Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE, .tp_doc =3D pyrf_evsel__doc, + .tp_members =3D pyrf_evsel__members, .tp_methods =3D pyrf_evsel__methods, .tp_init =3D (initproc)pyrf_evsel__init, .tp_str =3D pyrf_evsel__str, --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCF521518E for ; Thu, 9 Jan 2025 07:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409092; cv=none; b=H17/ViNgfCE5cyOohiiOSlTxAZvjW9MQZgfDi0h1cdRY/CQGJBeXQl5hd9qo6xOWH13bYpTwi7lzucFJs49MfidPL3a1S0ARaulcJFM0G+W37aPxV7C39ptLPNdAycvgfIxcE9bIa00ZHHWVtXwsS6AmWuq3oMzMosSyYJi/+I0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409092; c=relaxed/simple; bh=OVkiPVeq19vf+gQt7eOMdpDAMipm8Iy1FMvFsIQOb8A=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=IXthQ9Np04mfDcB6lKclyrCv5Vy2ckpojLlMoxJw/d4K+CS2rRMSuIWhviS8IuSnQNk/6ym689G+J0cwarJsO62YXBogIT2L/OFq+kUyhpCCLHgfL2d9w6hduPDEYvJNHHpdaDUNz9YkhaAwSfuG2Gf1RX1mJtBSfpe4zayrcK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hZuyYA9Y; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hZuyYA9Y" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e5380c13e07so1371560276.0 for ; Wed, 08 Jan 2025 23:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409090; x=1737013890; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=3BohvaPuKDkwXVxzz1n7YHccBtL3WJrAiu6eK/hMI2w=; b=hZuyYA9YCP+s+rdlIYgWiT+TStcyI38PNrsj4cTbplaPmuOivOgqjQq5pXNfI/74um Te3sP+dMY7pX/ybGMLpvY7wNOiq0hfCkSGaZHlsckELJ6cl2fO+T7Qwx9D5EmkeS/qYl UHGfb9eurWWNQfj6XgELrJrq3yUamJirIFpG3MkcvOIknZu+jNNV/G8T++E4JZwyMjOS ISCGYC6nPUdfn3Q8FGLA69ZURgNLeDGic1akXtLXHMN2E3Cpo1Blmj80HlkU8ZaafS6y XMVmIZ2IxD2qzbVZUNnf8rmnQp36+N3+vP3El6nLKfxwC9pVAPjt7/UXepXy1cuBDRkV R9sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409090; x=1737013890; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3BohvaPuKDkwXVxzz1n7YHccBtL3WJrAiu6eK/hMI2w=; b=qfttVIItzzr70OKbvtZmi3cihBmVJS2zlTheDSzWV0Bvsri+8ypanYuoz6lSPeMJ13 Y1B3Mh/hC5U2zBBZLk0Tz1oMVae5yDI6J5YbIvg60O2WuaHg+ArFTx/IiL32DoDkPjpe xRG5kWEYQezcz97mi/CuGt5QVfkmqSa41F2nJ3BCO5KFSSDtYF5tEIzL35btvzQgk621 bsLpHdnzHxs6OrgHXAcUw2sD3NNaK7xQE7wjr+DIvrXLx7t6xk95/8SA/+QPPpHz0XVL cw3OPKgOPn0+nw+V3SlFxWJZBTOI3Vg31j7YNT1zDvk5YP7aoCF0C+sXI9HSmlWu458K EcmQ== X-Forwarded-Encrypted: i=1; AJvYcCUKgvH1U/JZbzvOGTghujHh1292P2Luuq++s64jxwhjt776ZNkWCxCTy1ndxvcvzZQRVZIeL8fzasGRIP8=@vger.kernel.org X-Gm-Message-State: AOJu0YwXExVs03UECI1JQpp9dlyh8vbgjQ1UrxHxgFS7HdqHa1MHNGU7 8tWxBKW7twOfklBmx8i5oBsBzl51NzbuWfc+NLLS6ogI7f40FkPxBim0nauzw6ujlpvamUnV65u mroczYQ== X-Google-Smtp-Source: AGHT+IF7NYtcC8At3h3g7b4Aaith6NaYm8trrPonePKLCnlhWMMWcuNg4VevnL0luzl7avqjuOyrwMXYh0b7 X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a05:6902:124e:b0:e48:6770:76de with SMTP id 3f1490d57ef6-e54efe6685dmr17710276.7.1736409090259; Wed, 08 Jan 2025 23:51:30 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:03 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-7-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 06/11] perf python: Add optional cpus and threads arguments to parse_events From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Used for the evlist initialization. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 6a7042fd2569..45ee6479e4dd 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -1330,12 +1330,18 @@ static PyObject *pyrf__parse_events(PyObject *self,= PyObject *args) struct evlist evlist =3D {}; struct parse_events_error err; PyObject *result; + PyObject *pcpus =3D NULL, *pthreads =3D NULL; + struct perf_cpu_map *cpus; + struct perf_thread_map *threads; =20 - if (!PyArg_ParseTuple(args, "s", &input)) + if (!PyArg_ParseTuple(args, "s|OO", &input, &pcpus, &pthreads)) return NULL; =20 + threads =3D pthreads ? ((struct pyrf_thread_map *)pthreads)->threads : NU= LL; + cpus =3D pcpus ? ((struct pyrf_cpu_map *)pcpus)->cpus : NULL; + parse_events_error__init(&err); - evlist__init(&evlist, NULL, NULL); + evlist__init(&evlist, cpus, threads); if (parse_events(&evlist, input, &err)) { parse_events_error__print(&err, input); PyErr_SetFromErrno(PyExc_OSError); --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7333F2153D4 for ; Thu, 9 Jan 2025 07:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409094; cv=none; b=qIxaS4l8v7/K5nXw0sHa6AupPXEzIw/1TDyLYpmd0D61jop/2Ha4AfMZBaT4UNuKAKP7iZChONmDizylkWxbJFLHljc5/OGXBYSxZD+xZLTwpSnQ/xTBwlCGn3zC5ysIDaSeU3qyS1HENamSg5JlrXrIdt1lkNXyBB9zdOwSPL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409094; c=relaxed/simple; bh=R0a/vHYzWVhgCJQ6DCPAIedrH3ihtnvq6XuWZjEKuYU=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=hI+qXCkOq6Ds554gkjPm4CEzDGJlHkuaVGqJLYEBoaObPdEP0kUb3QpSwxAd9R5Cx1W9B6duBSNU73OAAqKzUpkFT3Tj3L2sri0VFkkV710s6kLq09nSvulIdrxDUOaMQvyq9YllWokS6Bwj6Fgo8uKh3NqRQ2stttXGVx46cGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dmAkkuDv; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dmAkkuDv" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e3c7dc4bd41so1467265276.0 for ; Wed, 08 Jan 2025 23:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409092; x=1737013892; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=YsmdkEmDEGEnP7ScF9FDAmVtpJbV7ac2JPwBDemRuGE=; b=dmAkkuDvLR4o73fQq5W/aK4RIa/3oHhimmKoMR2cuRk6+xW+MKOM1mSdNxtvO5pZY1 meUgwpCjJASaU1dh+tQRh5BAg39xXPGOQZW3z93epF8QOeruyCLs5QA0DaqkZC1Ib5n5 m6hjPiAKcIEjfya3RtiYeiqzQpYXghXWdO2uadOaO5C8b65a+8wPT2dDi2wAY6vNVApu SSfZVewVXDSn728mWgYYK+6kgCALEVORCAxtS7EGxJuPzJKOqPhPxYL/LS0mtON9Ivwl SuHT+fn4OGWbVW56XslH35gBpxxacvBBrHl+kvm+f8Q5EHSkSJhJAeCTeyDnwP4/NILO NNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409092; x=1737013892; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YsmdkEmDEGEnP7ScF9FDAmVtpJbV7ac2JPwBDemRuGE=; b=WlZT5OOGJLVp2PnRMdRSVG1Gsmbhp/WJKV38t8zmX52FvKu7wRMsRHue0JjdY02Mth RJx7Z/gPJqV8s2VeJH03tOUZUowPBcWwqKXz+j6T+FyoM6Sb6mW/GbZ7AtKvgxxkHACG I0DVhaI7bYJs0aWkjLvDYyU5nHyIuKzYToPb5I4U9ZrImbJA0/EYQg19PB6lairiBzA3 QP9XcJHhNdi6r/+zy2P0MB/oEexFt8I7YuM8IQEJ0Z/ijSXwsfjvXAo9LoQg0+ZuWtBW q2fVoPZT3Fsp5hv9NhPLWg2iegH1P7drcXn1Pg/X2UV1gSxDAsJaHP2YyiesTHucgLSS 2hbw== X-Forwarded-Encrypted: i=1; AJvYcCU/ejIDpgc5GvpFs0NSkMI6v7mqwGNOsS/IgDynirXaf/9QsUawaNkjORAebMW5ottDMXEl9C02rXB5Hvo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8RVy00cdIH+9USEBg/GQpkTGpmL9WADOV4YY6CBe2on8rDU92 p7/B10nhtuU8q+62joqd0HK9aLu/4BLgi9W3GR1IUWeVKNsVeEFnVJxU8UWb1tdh1yD3cg/LZBI VXge6Tw== X-Google-Smtp-Source: AGHT+IG8GYH2614e5n/bWNWP2I7UIMRcppng/RXt8U/s+jXzYYv6/E859Eu7ehMh8UQyDSfEYrPtJ9yye5ef X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a81:b547:0:b0:6ef:5754:49ef with SMTP id 00721157ae682-6f53122646cmr124157b3.1.1736409092375; Wed, 08 Jan 2025 23:51:32 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:04 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-8-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 07/11] perf python: Update ungrouped evsel leader in clone From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" evsels are cloned in the python code as they form part of the Python object pyrf_evsel. The cloning doesn't update the evsel's leader, do this for the case of an evsel being ungrouped. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 45ee6479e4dd..9ffe1b633027 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -1303,6 +1303,8 @@ static PyObject *pyrf_evsel__from_evsel(struct evsel = *evsel) evsel__init(&pevsel->evsel, &evsel->core.attr, evsel->core.idx); =20 evsel__clone(&pevsel->evsel, evsel); + if (evsel__is_group_leader(evsel)) + evsel__set_leader(&pevsel->evsel, &pevsel->evsel); return (PyObject *)pevsel; } =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E10412153F1 for ; Thu, 9 Jan 2025 07:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409097; cv=none; b=si4jRqZq66swIwz7rgOkYCrcs5IgL3L/20KP/3zHRqbOHjDAQANrhpG+h1bx4Q5U6HjwPYFFbNURAV8mwJfuzEZNRK5eiv+KTmhTBtyr3ZTg7WLPlaERUQWLQPDkDyPUfF8gCEPId+jgyB+dWZy0j8LyJZe2dm4dh+OwpbOmx6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409097; c=relaxed/simple; bh=N9g3XQ+YXWEEo1w/ZtVTJnGqFkpfljKRoNayMFh1r4s=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=nvLYIsu3V3o0/d04M4ab/9hkdvgkUT/SXLlsbzKfhshF2b1x9bcF63uZl8sm0AwHlR83kONT/EPxVgcISJyRXFCeGYuLNw0Baiz+G9QtB2YnHgQ4xRWtG0mvcDRMXCDz5BoXM0XShTnbFQCqclZ/VgOixRr28GIjNTx5BWKUD1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sAqAEBJ2; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sAqAEBJ2" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e49f7374164so1434551276.3 for ; Wed, 08 Jan 2025 23:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409095; x=1737013895; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=gCIaMmE5oTQbNNVByMsLybBR+kGnWCllU9xpHtCnpII=; b=sAqAEBJ28Cq2QOiWmdF8JjjDXEuP0roU5Iy3RoDP17mqJjhQiNVvl8magbu2p9WdHW qNo870hsxrpd6bt8RwukWXB5Cj+QPga+7GoRC8MXygPANqp0TOPRD81/V6DYD8PbQu8F KiQ1nAIfBC/yNzCvwOKhVHo1gQuFssDkdVkCkc+yMF5zYL32GNV0fuJoXjPT8EHqdUur 6PIk+tN3hq4hvzL3Ii7XqkCNzZmihZP7h7mm/sAwhikioYfijhk+B+f4aUBjzsuvW859 HByfQFAPjQsyvH5AlSKhggJIXOPP8pQSGNEQBpvbuXKE7UcYNhp/+4ZkJxK4I7EWfaBp CbFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409095; x=1737013895; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gCIaMmE5oTQbNNVByMsLybBR+kGnWCllU9xpHtCnpII=; b=v0RzMeA+xPrpoy9qdECWaxsHFSxCMolRE6Fs59DeDmSRCKIIoBN0j6/TyrK5pFPT0i 4d8r1IAjFqbN9TRKJPhvYn9e+iAlXruHVb7lp/oR+h1mtY7X/N/wqqeHriyDnKZyCwtP 1D18+fc5pJTJQvlhR9mtDXLUJtpg5PvUWsxaz3185QWEiE5GhCgrawZVk/Atqyf5eSWD m1fQ3UxeuEzHZbJISIbaSj9pUgOrw/erQ+SKOFkF3SfUAyu6EGDwu4mHu22FFXMNZXpc gJyTWj8NaqQ9KuRafe0+TYSa8swBandTpsBbtMY8+E4W6wlz3tn3XRQebY1p/iZXqegY DSbw== X-Forwarded-Encrypted: i=1; AJvYcCVwpLUD/Ua0luUGFU9tY2tKSaJk9lGOzQlqQhVdtg0r2SAmVMICcn/Th63obnkQScbEYxybkS9lgiNNUg8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0sYYl95yjw24L09BBrDRO8XbZwWm9mrVRm4eL2vzO8kigeCeF wkBA3Asi99RwFCqBP0fvc6TlDM8ajYGRQwDxR6A5W7n0cxbe9ZRJV04fwSPYBiMP9tbQ1lAr8jB N9yttLA== X-Google-Smtp-Source: AGHT+IHnypm3vAAFk44fbCiNzj6pbujk3ELry6s/fGfOOKb1n4y2H0Ml9tahNKZCNxrCOVZnTpDoTmUQsfSJ X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:c4c2:0:b0:e39:84c6:562c with SMTP id 3f1490d57ef6-e54ee2413femr12379276.8.1736409094896; Wed, 08 Jan 2025 23:51:34 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:05 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-9-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 08/11] perf python: Avoid duplicated code in get_tracepoint_field From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The code replicates computations done in evsel__tp_format, reuse evsel__tp_format to simplify the python C code. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 9ffe1b633027..d1ce3b6b5bf1 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -336,23 +336,14 @@ get_tracepoint_field(struct pyrf_event *pevent, PyObj= ect *attr_name) { const char *str =3D _PyUnicode_AsString(PyObject_Str(attr_name)); struct evsel *evsel =3D pevent->evsel; + struct tep_event *tp_format =3D evsel__tp_format(evsel); struct tep_format_field *field; =20 - if (!evsel->tp_format) { - struct tep_event *tp_format; - - tp_format =3D trace_event__tp_format_id(evsel->core.attr.config); - if (IS_ERR_OR_NULL(tp_format)) - return NULL; - - evsel->tp_format =3D tp_format; - } - - field =3D tep_find_any_field(evsel->tp_format, str); - if (!field) + if (IS_ERR_OR_NULL(tp_format)) return NULL; =20 - return tracepoint_field(pevent, field); + field =3D tep_find_any_field(tp_format, str); + return field ? tracepoint_field(pevent, field) : NULL; } #endif /* HAVE_LIBTRACEEVENT */ =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F33A21576C for ; Thu, 9 Jan 2025 07:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409099; cv=none; b=Vdquh64GBuPedLr9WBxzV+HmhbAiWoGu7ERBzSU9AAFmVFpuByHUoCcjUY3omawyB8Woc5wIaCF2iUCKyrpRpFMspTxo5QIEU9OmnRDgsX3cXcfvgNOgQTwZDD9leAtyG7dA1/zRo93D+cD3CpFPM/n7E3fi6l85yt2PScKc+zI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409099; c=relaxed/simple; bh=GuHMIsQjp4bNuyF9P2iuK/6mUQTUkq/9ExOKZGD7pHk=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=Hqu4Q/FQfQxZB6ZCp2npAZOIhfteUHBpql8c/22XomZygDEeFGWNS/OnXF+qgSu7qcqETyev3UOUQOxMPJT9eWQn/89+Yj9NoZ1wxuj4DFeQPrK+sDzTLkFlILkqq7JnvQT5t6frhmVCQkYEcTDU/J9jdDdRp6xrh3JkyFQsPbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hJ5H/G/+; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hJ5H/G/+" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e3c61a11a40so1478354276.2 for ; Wed, 08 Jan 2025 23:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409097; x=1737013897; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=vX0FPpAq44g4U6f0SlAuMrhRB4aCR4aQgT67H1xwScg=; b=hJ5H/G/+ejLfGU6S8TbtB8sGzFmFj0meLYHSCip2jfxbftkyh01dH1KQCE8++0VOy4 sV1lr49RzjM8NV69UhiTii2rRmow+69RjdfLFaD+RmGSCCw4P3guwrHdVX7/lbGd+nxU CE0WBXL5vS9Dh8D/19xuiJV624SnNyozRyXn78RYKBh+Z1W17dYnx3GL+AaNzFnUgCZ6 k2+gKMvYEJYvFHd7mUAe4V2/10RWFiDiGHNxZRbkvmkRYDmK0PT6yb9u+yHN6jMPQC1/ PJq3PdfMQaLjU4JKZhRuu1ar707jFaCO7gNIB20xN+fBC3iv7S6gCS41UgoB6Su/ckuN zonQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409097; x=1737013897; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vX0FPpAq44g4U6f0SlAuMrhRB4aCR4aQgT67H1xwScg=; b=GGupFUfj2xmlZ22sS8kFrsGcfdbTH39Y0PbZDl7AKVRjWzoX5Yk1JfqJdorQ8SIxjP Apq1zZeCfgcOqYa7KtHzX0ifRt3AJvWU7nZicUTXEZ6Sjeh3TFoRwHY5rWu1EgKi4ZWb afa9KmSehNnRn4Vymx7MtHHnSKZpzDHZX2ux6898SUbXj9VYWhZPXL3Lyhc2Kqvu57cX /Ht78xCv5TZs1YLYSyzaBSc8vcO+ROwS/T5gh0Dbj8D7naPUZCaRX8Iw1FoxzZNYSLqW 4wHY21ECbM5hw266q5QvOj7CX4BM0tMSp3k0YacyyATW0kJ0MbOw3GRIJhObR/2bluX2 dLTw== X-Forwarded-Encrypted: i=1; AJvYcCWtOIpgNV9E8rjjS5Am8MBmlKW5/MuO/j+foNnOAcLLNlT5Dh6SQoyzp5yjqD42Cq1/w+D4KKTvgcl5fVo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/uRvWUv5pA0Z1GN8erEf4BUSd8CLKXrYosbU/4rdShbUsW3SD Zgv9BBFPzb9QoRG7ddrhB5C5Uy/6EItYcpnVJ2n4b1IwODCZncwqVtq6dXzn5W+XXZ2E7l/hWBP m5Bdl/g== X-Google-Smtp-Source: AGHT+IHDZuMeExAM13mUvVGjBDZ1b0jptwReHIxWzvrc6z5nX7GHSViezjng9bKkyV8hxAjaKJrReFsn0cJk X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:74c5:0:b0:e46:8e7a:b404 with SMTP id 3f1490d57ef6-e54edf1627cmr13135276.1.1736409097209; Wed, 08 Jan 2025 23:51:37 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:06 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-10-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 09/11] perf python: Add evlist all_cpus accessor From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a means to get the reference counted all_cpus CPU map from an evlist in its python form. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index d1ce3b6b5bf1..1e8ab5291637 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -865,6 +865,16 @@ static void pyrf_evlist__delete(struct pyrf_evlist *pe= vlist) Py_TYPE(pevlist)->tp_free((PyObject*)pevlist); } =20 +static PyObject *pyrf_evlist__all_cpus(struct pyrf_evlist *pevlist) +{ + struct pyrf_cpu_map *pcpu_map =3D PyObject_New(struct pyrf_cpu_map, &pyrf= _cpu_map__type); + + if (pcpu_map) + pcpu_map->cpus =3D perf_cpu_map__get(pevlist->evlist.core.all_cpus); + + return (PyObject *)pcpu_map; +} + static PyObject *pyrf_evlist__mmap(struct pyrf_evlist *pevlist, PyObject *args, PyObject *kwargs) { @@ -1048,6 +1058,12 @@ static PyObject *pyrf_evlist__enable(struct pyrf_evl= ist *pevlist) } =20 static PyMethodDef pyrf_evlist__methods[] =3D { + { + .ml_name =3D "all_cpus", + .ml_meth =3D (PyCFunction)pyrf_evlist__all_cpus, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR("CPU map union of all evsel CPU maps.") + }, { .ml_name =3D "mmap", .ml_meth =3D (PyCFunction)pyrf_evlist__mmap, --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F47C215782 for ; Thu, 9 Jan 2025 07:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409101; cv=none; b=r8H+2f4tBB6NQ4XvQtJS1mobnfOVV5r/3hTzqhLMPH5feuUfNNOfSZuS0IvIs1Wwp175eWISyUswyKWIC5spE6W+OMG5S3/rQ6LFy2CliX3MrFPJ7jsFOI19xD/Ff3Zn0HlkoR3JxuiQJ0QUF4I3HgCf6IFKP+7C+AdghfwD2bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409101; c=relaxed/simple; bh=406aBAYGFzDV1bL8OXedVAztzJzIPqw3jyxHJV9iafY=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=twW2r55UOYtd689VY4p/SNTBXTw0yPdtwPPmtGfwY/72vVBWpbHCpLbrFiB7xVbHfWvFGftGfq/PnaEum/gnCcWaJDaTUoCNeJy4LjIqA22wFxmTBoTcTDDvsDBmaRj9w94o4qr5ttj/iHZQ8mWkHllHO5SaSwv2gbLz26GEIik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gKOxsjY3; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gKOxsjY3" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e549b6c54a0so1576857276.3 for ; Wed, 08 Jan 2025 23:51:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409099; x=1737013899; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=cCiXoa6hR4V0Hw+AXJa/eNgQ4Vri6Ug0YtvV6AM9HlI=; b=gKOxsjY3BQz7mPQozo7ijPkehrao6MuMzdnkxRIO1NnUzMSK5nikTDm3Ov/BMpaJY5 eiLRMMubRQztQ2FVWDdSONnTQAlhDb8VIEc9c0RvAbcA0LjoHp4u9Fvf3iDGRRekhVn6 q0kOQjoKPwb2Sl1Q3AtMjm3ZvKlzNbA9gUl9FAv1vXAog9nL9tJaNonmLERzvFKJ6nFV KhhkO1eCbcTzB9YMWFZ0IGx5wYvc+JrlSqN6ehPQ9CO9r1tMZWgRQd3wefl6D6MGWhCk dqqdWzpjnAwxyvfb1OgSA7aq1UwMGNBnctdcYCIZNUbX7C9CqtVeeXISn8wAEH3PwGLF +mFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409099; x=1737013899; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cCiXoa6hR4V0Hw+AXJa/eNgQ4Vri6Ug0YtvV6AM9HlI=; b=mOC+q1DXvNLs9GPIjBW+9GQTjgobBKeTwMBhKem9h9EFLw+fwPKN2GEFHWRW18is+V iPMJUBSDJy+e9H2TQnQC1eWG7iLYUBckR8TYq+iNfdyv+ZNLkfyiuXQEUCzvpOCTw9P0 L+qdPbDndtWQj1uUFhJgDGOYdKiPceoQv491mB4xz3ypMnc+yyhFepprb8y2tAH3J0r1 c4Rfi/7evU5jyMVrTF2rS4nmLwPmc3HhDkFPG1ose5zgaoIGPdzdpX/wRdeGBVI3grDM SoICLFrXnLtDolelYL0z2KdRnCwToVNVY+lmHAlZeYmWIfoDXSSOT6T1UQUStNHKWs/T RG0w== X-Forwarded-Encrypted: i=1; AJvYcCWwxWy7hI/MRbV6ksi3ntELpvGZXPGUDbSgy97PtBgqjNRc1VNUf8ysUABNiQXQNi3SlRXsI0bsCAFv25A=@vger.kernel.org X-Gm-Message-State: AOJu0YzEMNzpflWmd9Nv64LKmkNkaD629rXz6lFGjCgqnAh20YO8IcUV UUmmXUIk7djSeG3nrPWEzApIGFBm26GDJDzhNK+8TZaNMQMeV+xrI5Q737JRYzJzuP06MfzBRwo iSUeCYw== X-Google-Smtp-Source: AGHT+IEUKlwAipnWk8Ae+MXLNubrpdFPQ+OhZD+yTJnGFg/lMMxHqtycrS4GlaxwkuwxAUkdpNQSkeuw8Qk5 X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:2782:0:b0:e3c:9fb5:3933 with SMTP id 3f1490d57ef6-e54efa4e3b4mr11130276.9.1736409099307; Wed, 08 Jan 2025 23:51:39 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:07 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-11-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 10/11] perf python: Add evlist.config to set up record options From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add access to evlist__config that is used to configure an evlist with record options. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/util/python.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 1e8ab5291637..38a7e16e09c9 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -9,10 +9,12 @@ #include #endif #include +#include "callchain.h" #include "evlist.h" #include "evsel.h" #include "event.h" #include "print_binary.h" +#include "record.h" #include "strbuf.h" #include "thread_map.h" #include "trace-event.h" @@ -1043,6 +1045,31 @@ static PyObject *pyrf_evlist__open(struct pyrf_evlis= t *pevlist, return Py_None; } =20 +static PyObject *pyrf_evlist__config(struct pyrf_evlist *pevlist) +{ + struct record_opts opts =3D { + .sample_time =3D true, + .mmap_pages =3D UINT_MAX, + .user_freq =3D UINT_MAX, + .user_interval =3D ULLONG_MAX, + .freq =3D 4000, + .target =3D { + .uses_mmap =3D true, + .default_per_cpu =3D true, + }, + .nr_threads_synthesize =3D 1, + .ctl_fd =3D -1, + .ctl_fd_ack =3D -1, + .no_buffering =3D true, + .no_inherit =3D true, + }; + struct evlist *evlist =3D &pevlist->evlist; + + evlist__config(evlist, &opts, &callchain_param); + Py_INCREF(Py_None); + return Py_None; +} + static PyObject *pyrf_evlist__disable(struct pyrf_evlist *pevlist) { evlist__disable(&pevlist->evlist); @@ -1100,6 +1127,12 @@ static PyMethodDef pyrf_evlist__methods[] =3D { .ml_flags =3D METH_VARARGS | METH_KEYWORDS, .ml_doc =3D PyDoc_STR("reads an event.") }, + { + .ml_name =3D "config", + .ml_meth =3D (PyCFunction)pyrf_evlist__config, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR("Apply default record options to the evlist.") + }, { .ml_name =3D "disable", .ml_meth =3D (PyCFunction)pyrf_evlist__disable, --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sat Feb 7 12:43:01 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5DC5215F45 for ; Thu, 9 Jan 2025 07:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409104; cv=none; b=dQUMg9hwaMw/qfxeYauKCS3rYfMJwCg1e1N8m4uzPXLTKIcoI1C9hAYe2irKn55uZP4JfzZHAe2P9qIVNWSCL8ZihQ/CNr0LP68I60ZPXHxvRZXVBWZHmQzSJfBgq7ZxoresxKvPNDudHP7rfu5uQzO0hQrdOD3fIFJf1UZznyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409104; c=relaxed/simple; bh=LcuM1TfmrACoRI2O+KPtHudrA17c/H/ANDgc2PirYpI=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=se2j1Z/37V3QF3amevquKOehu1YkpIKrmPRW6D1fc079PqJ9Wq1z2bZxGSJdad1GHRuAOzotbnpzcRrkXU3GkhPS7Z2IJGy8bg2mLl6JC9eK3aeID1LwA4SQjxfXGWBz7Eca0O8Ya2CfMCLb++E7UFSTj3tmOMEIkLixJKUb3Bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=MxYSYn8t; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MxYSYn8t" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e54e14f7cbcso1559381276.1 for ; Wed, 08 Jan 2025 23:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409102; x=1737013902; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=xj93vfuj55xARzsWpay/iUAHdI9qiQp37TLmSVo9jEs=; b=MxYSYn8tmyi+jww6/FQY1HAW1kH0JSThpvmlxc4yNSVhQaNlPZPw059cobsn59G0Tf fjelbxCeLQsIu3+aE4BWVMEtpLHzDYF+ddqdyZdvH2xe/sOjBv6zzV/RqR0iZSjxapXl SpXKntIcQNrVAc44u9iOt4LAfYIgBOE0fDkhoYKwtqDjJMKbChqnDa7Fnqvt8Ty6TOaQ j1T21MQPal2G2zaz8M73GqeqX29Fg6xHjclrmYZ9H79jnjAkiDa9TVFLM4drlfxp8v0K nReAVvbpCaTrqqW4SmCq0hZbXVs7gO1AZIuXwTNyYYuZfWtNatUxGXnQjtjkOJw6qqtC RGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409102; x=1737013902; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xj93vfuj55xARzsWpay/iUAHdI9qiQp37TLmSVo9jEs=; b=tKW7Ixt5HIx0WReJnkuSVw/QVtIHJ/yxkKndeFlbXfwsVESK6Cy6ZKK4ta6npKoQy/ QAvhDjiyuqsDEknTYtl7amSWCYVAOMZfNZzr6yskj2Wb2OhnpYSdddUcsf1+4E/cKB5X Krvg1sPfVpLbyukvhL5cDftSqcPcPlWyuS6u48BnnXuE4plq+iyQCcWf92uLKa9H2MTA hPkXzkHlBmxTmlTdPGECKwgZ1tQczfvnMw3jD9F+ug6tls1xBd2Qhey8Pq1ekRIahWnv rNoh9Zzbi/qQAB4mA/ZnbTvsSLJIyo2+zCbNgy8LHN2rWFlQ4fC+N0FX6yyISzWvrN9w eyiA== X-Forwarded-Encrypted: i=1; AJvYcCXkJSP17aiMSnUH3wyWZmbAdtM/GTfxMT9pRK759Pi0adavxV8Jj5zpEbVKHyMh0uS//XjFO+oMvXdHgZ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwXDB+Z7f6s8bNTIcPSutxbcd/HTkQbXIABGNJXFCF3vmpOck7F 4G2yaQrhVFHE9LxBoZigXcaHrSYnQxBic+cNSadHiPgC5QiTmQrIlFRjLrho2jUHHV689yV0/kT UraJSLA== X-Google-Smtp-Source: AGHT+IFjYOBojDm05vXb6n8MqNDkJC7xm5062sZE/csmmFZ6aKOedVisiYs7brlL51+UYZb/a9LeQuTf5wiS X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:aac6:0:b0:e38:225a:c3be with SMTP id 3f1490d57ef6-e55018e90b1mr7040276.5.1736409101643; Wed, 08 Jan 2025 23:51:41 -0800 (PST) Date: Wed, 8 Jan 2025 23:51:08 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-12-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 11/11] perf python tracepoint: Switch to using parse_events From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rather than manually configuring an evsel, switch to using parse_events for greater commonality with the rest of the perf code. Signed-off-by: Ian Rogers Reviewed-by: Howard Chu --- tools/perf/python/tracepoint.py | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/tools/perf/python/tracepoint.py b/tools/perf/python/tracepoint= .py index bba68a6d4515..38b2b6d11f64 100755 --- a/tools/perf/python/tracepoint.py +++ b/tools/perf/python/tracepoint.py @@ -5,24 +5,23 @@ =20 import perf =20 -class tracepoint(perf.evsel): - def __init__(self, sys, name): - config =3D perf.tracepoint(sys, name) - perf.evsel.__init__(self, - type =3D perf.TYPE_TRACEPOINT, - config =3D config, - freq =3D 0, sample_period =3D 1, wakeup_events= =3D 1, - sample_type =3D perf.SAMPLE_PERIOD | perf.SAMP= LE_TID | perf.SAMPLE_CPU | perf.SAMPLE_RAW | perf.SAMPLE_TIME) - def main(): - tp =3D tracepoint("sched", "sched_switch") cpus =3D perf.cpu_map() threads =3D perf.thread_map(-1) + evlist =3D perf.parse_events("sched:sched_switch", cpus, threads) + # Disable tracking of mmaps and similar that are unnecessary. + for ev in evlist: + ev.tracking =3D False + # Configure evsels with default record options. + evlist.config() + # Simplify the sample_type and read_format of evsels + for ev in evlist: + ev.sample_type =3D ev.sample_type & ~perf.SAMPLE_IP + ev.read_format =3D 0 =20 - evlist =3D perf.evlist(cpus, threads) - evlist.add(tp) evlist.open() evlist.mmap() + evlist.enable(); =20 while True: evlist.poll(timeout =3D -1) --=20 2.47.1.613.gc27f4b7a9f-goog