From nobody Wed Dec 17 12:11:01 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6006C154C05 for ; Thu, 9 Jan 2025 02:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736389841; cv=none; b=oheABsSntskQddrivw5Hkd4ueccT5lcsu2U4JeIlPJxNXm8i5MxGYn80Y5ZTuY3bCAxbL6bfRf93MRwxmBeBAnuSthoGDXj5oIXlDd9FaBIlNOWrVq3gGabS8XsogqyN/d2ojSakeV0O8MMw4UYgOqO0M/1zkC55onLcQCZ8zuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736389841; c=relaxed/simple; bh=t9LvCLfNsf7gW2HQp/USAapAN+m412qBOrN7Y8/AQ98=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Z4WtoQ6muhmdZeHaXUyu+S7REVCfjPpYYXfrzphActCulxbl6X2Iy8GSxCsS+acmEPBuWqfIrMSiUzk3SDsxFeNISAD+6LG3Zlhk+f3AjH5NSs0EKcupjNM8LVqus+4q3Ru/aZtHBWGLFDb15+k8XNYsDLTmTzroa7QkWdl1WH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Oy5ABubG; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Oy5ABubG" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-21638389f63so4646145ad.1 for ; Wed, 08 Jan 2025 18:30:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736389840; x=1736994640; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QrBwNMjEBhpbcxWqFk88nlV6Pfhf+HDin7YMebARszw=; b=Oy5ABubGYniIMUA/4fKpIZAsqITiTMLt3jANHZBGDbVvxSC2Hn2qCm9P90jibz18BN KsrxMSYieoy3AVKbHljvZb0qQgcty2zLLO9wfop+RfTNYiwPFhAkuwzGqFoy+3/9A8K/ DNt9xhClIkVLt0jWJ+Po0RYneALYmpcdFx8TTwkNp6aVH6tUcFQHgqToOISHZapd8/fD RZkqWS6wu8W+THTSnjfBkCjJWCKvZ/JhCn6Ng1h1jH6bIwLWX/ez9xMGt0riWaOwJpP0 YMnB/nK07hl8iXR2PcC4yVy72/2w00NbP/SRTvtfBMW1FmVpIMUqLuXCLMpn4i6qjMwN zqQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736389840; x=1736994640; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QrBwNMjEBhpbcxWqFk88nlV6Pfhf+HDin7YMebARszw=; b=JyOOUD9PFZY6btJpl+CVAoRp+bUR0mMz9LSOC2a1DhNNCmM2ASpMJ0VR7mpsrVJawc KPwabGiDigHhD54C9l7SZ4SCgeDkfd2YkHqec/bNIpSnIJei+gJnPKWbjLMK+5J4YZce kZI2W0UD3FVG+ZM+JkUwfNPQnxmSo7hJCzi1P40Uo1JBPeLJ3b9bOnOyFnJpUHYKYBkw luCIqnsdhmcl/w5h5mFvFcm5q72oHZt1BXmORwcxzlO6vklBRuB6xAmkZsVMWx3Lignj vGzTFrOh5SCmZhRoOpEpBD8Jy17kmOfFOCrNJkzuBCTDWWYkg9lKj/UklcyTQQXXQzZA Ltnw== X-Forwarded-Encrypted: i=1; AJvYcCV5n2Iq0UW4mjyTvcojEImdK3kobQ5dgI8NmRXSzxHyJR9/TBQPhlnaZ0LUuRAMG1zXW5bN4WATiom2PyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyIWH0QXqMEQWbCHT+yxN81clFdpHffwEFPjSsPg/9Ylb6e9xp4 SkxlbTN0H9zg3/txR3Olhrp9hPmDQd/X2cY0r6TskW9KTK03t9pouUeclovxq9kJdyoY3vQGhIR x/Q== X-Google-Smtp-Source: AGHT+IGCSi1cLKzQVkSU7lkundl6oeEMCOCXsG4KvMhn7UcrmY2u1vKpnTKufMOdZ0o1PI8HbdJQwt6UXwo= X-Received: from pfbds11.prod.google.com ([2002:a05:6a00:4acb:b0:725:e39e:1055]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:8403:b0:1db:ffb9:f359 with SMTP id adf61e73a8af0-1e88d128ee1mr9121257637.24.1736389839663; Wed, 08 Jan 2025 18:30:39 -0800 (PST) Date: Wed, 8 Jan 2025 18:30:14 -0800 In-Reply-To: <20250109023025.2242447-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109023025.2242447-1-surenb@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20250109023025.2242447-6-surenb@google.com> Subject: [PATCH v8 05/16] mm: mark vmas detached upon exit From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When exit_mmap() removes vmas belonging to an exiting task, it does not mark them as detached since they can't be reached by other tasks and they will be freed shortly. Once we introduce vma reuse, all vmas will have to be in detached state before they are freed to ensure vma when reused is in a consistent state. Add missing vma_mark_detached() before freeing the vma. Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka --- mm/vma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/vma.c b/mm/vma.c index b9cf552e120c..93ff42ac2002 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -413,10 +413,12 @@ void remove_vma(struct vm_area_struct *vma, bool unre= achable) if (vma->vm_file) fput(vma->vm_file); mpol_put(vma_policy(vma)); - if (unreachable) + if (unreachable) { + vma_mark_detached(vma); __vm_area_free(vma); - else + } else { vm_area_free(vma); + } } =20 /* --=20 2.47.1.613.gc27f4b7a9f-goog