From nobody Tue Dec 16 23:57:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60190218AA7 for ; Thu, 9 Jan 2025 13:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736429463; cv=none; b=gCStDyAne4FnrgnTJRd6gFSIw9/D2yCB/7HrNX/k0xvfe5/26Qfco9zvV/7/mJuiU3EG6owk2Ox7g2lJ9tqK/NalUyNpIn6EM8vdXUcmDgSYMNsnwzexIR+YWyyjhLeuKmtIcF+LyjLQb85x7adB7GsK7jKW3tJ0xBn5tG2/rLM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736429463; c=relaxed/simple; bh=SNgDfj00OqljITRWu1bkZd/iWfQC01LmrSzpDRvZOYw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RrsnBm2h9fRAD3wV57ULKdP2Fm+XV0VdaotZ3X4xWfNEksGxdt4tb9xJbkZEa+QQdmCY+myRSsrAoV2weG1wndHhKliS95Zu+5MYd9PNExEGd5vYhNh9+oVjHxEbmUy3lNBvOQHb1VSBeT0KBEPnB/slIlvIlO1cUzrmgvTUeRg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YpcMkjyy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YpcMkjyy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94B03C4CED6; Thu, 9 Jan 2025 13:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736429462; bh=SNgDfj00OqljITRWu1bkZd/iWfQC01LmrSzpDRvZOYw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YpcMkjyyF8mw6YEsYP0LBZ1UUfvtZ3m9HhW8L71zJG5TOAFsKSjKTozRNwqGf1/GB ZxR0SainwcXXZhXIJCLrjsWmZ7DSEpAqkhDm5uTzqUyr3SIoXmdxRLP+jU6DkA8nC/ EE8k24UrWUAmGnkATGffpmSA2NGdgoMeCf3BneEeZlNtF6U9x2gYhpKqAYKlFzL3SK 1HkFSc1DXsU++pZcKyjvWrvPOtTGmacx8NTaXFgWopFyuoQ3GkgH5h88i1jHcyNDdX PREZPZZitZlrHCScqubLXtLqDCySFun0gXzkeQiT17P/unI2ON3nuTTWUysH7+w3m8 AhNHfmQwJQS4g== From: Daniel Wagner Date: Thu, 09 Jan 2025 14:30:47 +0100 Subject: [PATCH v4 1/3] nvme-fc: go straight to connecting state when initializing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250109-nvme-fc-handle-com-lost-v4-1-fe5cae17b492@kernel.org> References: <20250109-nvme-fc-handle-com-lost-v4-0-fe5cae17b492@kernel.org> In-Reply-To: <20250109-nvme-fc-handle-com-lost-v4-0-fe5cae17b492@kernel.org> To: James Smart , Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , Paul Ely Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Wagner X-Mailer: b4 0.14.2 The initial controller initialization mimiks the reconnect loop behavior by switching from NEW to RESETTING and then to CONNECTING. The transition from NEW to CONNECTING is a valid transition, so there is no point entering the RESETTING state. TCP and RDMA also transition directly to CONNECTING state. Reviewed-by: Sagi Grimberg Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Signed-off-by: Daniel Wagner --- drivers/nvme/host/fc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 094be164ffdc0fb79050cfb92c32dfaee8d15622..7409da42b9ee580cdd6fe78c0f9= 3e78c4ad08675 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -3578,8 +3578,7 @@ nvme_fc_init_ctrl(struct device *dev, struct nvmf_ctr= l_options *opts, list_add_tail(&ctrl->ctrl_list, &rport->ctrl_list); spin_unlock_irqrestore(&rport->lock, flags); =20 - if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_RESETTING) || - !nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_CONNECTING)) { + if (!nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_CONNECTING)) { dev_err(ctrl->ctrl.device, "NVME-FC{%d}: failed to init ctrl state\n", ctrl->cnum); goto fail_ctrl; --=20 2.47.1