From nobody Fri Dec 19 19:21:16 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CEA719CC14 for ; Thu, 9 Jan 2025 06:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736404783; cv=none; b=noPRwcPmI1hBCfwQmtIrC4huQoaHd6BO5hceoKTjGP3FOxW5G3sqaKzoTpUcoEaWPaxgB0KU1/vl08pfSYGE0tkepAYz/qKDOhlirGpiphm2aGnD9mcgdF8R0yFcdQ6a04dP3p7RaVvI/HxD8JGPN4ncSKrpxfWjKVrfHBN9W2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736404783; c=relaxed/simple; bh=IAno5pKTx2K+AER7WFysKsBBPJnJbbX9HJm6cKM74eY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=a9BJXtDIx6S74F4MqXqdkjDhQxak0kt9cOGgJrRjFQnvsmqbrVVQCgsf7+xYcf9fIHwXOe8Q9K8oW8zKBb2TL14Yj8mP5iwqhy/TjPsYUYoXB/Gjxvo+b9oVoW9mpsW4GS7JhKAVCyVHMbu7ldiy9vCMTqj5g6RfZhfoL9gHx2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gw2YQ2rN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gw2YQ2rN" Received: by smtp.kernel.org (Postfix) with ESMTPS id C2319C4CED2; Thu, 9 Jan 2025 06:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736404782; bh=IAno5pKTx2K+AER7WFysKsBBPJnJbbX9HJm6cKM74eY=; h=From:Date:Subject:To:Cc:Reply-To:From; b=gw2YQ2rNL2I3qBaF4OwRxQBIUpHE0ab5tpcxqvkg69B6Gyj5VlSGrrDuv/5ZNf7NG Hp7o+29mYTsVSD+3oUAKQB2bzVMDSd/Xr1t+OUHQVZIVxJHEizVhQs3o0G44nV5kwd faUvx51PEioYMz4SpioSFNkdL7OxfdW9kFU0zmKlwDxeuGoVznd3VzP9JvXkhfywjb jsMnosYmlRjTLAb24JSmFrW3c0JNpOLfwLwdH7wRwxkWd135KdIiVtFeAgohYpfA0K lLn6i/HlbyxDGMLgnHx7WP+2T1913R6sAHmSWHk9XZB3FwcKophCq/+ooYjiESHz7b rgbWgZkE+uu4w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7637E77197; Thu, 9 Jan 2025 06:39:42 +0000 (UTC) From: Hermes Wu via B4 Relay Date: Thu, 09 Jan 2025 14:40:08 +0800 Subject: [PATCH v3] drm/bridge: it6505: fix HDCP V match check is not performed correctly Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250109-fix-hdcp-v-comp-v3-1-1258edb249ab@ite.com.tw> X-B4-Tracking: v=1; b=H4sIAEdvf2cC/2XNTQ6CMBAF4KuQrh3SHxqKK+5hXNR2kC4E0pKqI dzdgcREw/LNvPlmYQljwMTOxcIi5pDCOFBQp4K53g53hOApM8ml5oLX0IUX9N5NkMGNjwnUzRp Uvra+U4yupohU2cXLlXIf0jzG9/4gi236tczBygIENBWvjBBGaufbMGNJq3J+sg3L8hdojoAko PYOudWNlqr7A9Z1/QBPq1XN8AAAAA== X-Change-ID: 20250107-fix-hdcp-v-comp-3ba8e3d7adf3 To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Hermes Wu , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Pet.Weng@ite.com.tw, Kenneth.Hung@ite.com.tw, treapking@chromium.org, Hermes Wu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1736404808; l=1793; i=Hermes.wu@ite.com.tw; s=20241230; h=from:subject:message-id; bh=ZQI2HqzPneYgfzuW3Jkd0no7yYlB8RqeAikI2gt6gAg=; b=Ww30Kk4kRj7A+HK87WjQj3bCC0NVLEq24nfdTnwIF3WeV9pLX7QWmKviUx06mpITJxWrKsI6c hnG372CyOL+B1dM3Cbj97HJt+tPmco+ecNlRHvUvwcdo+DqTxJt8Zj5 X-Developer-Key: i=Hermes.wu@ite.com.tw; a=ed25519; pk=qho5Dawp2WWj9CGyjtJ6/Y10xH8odjRdS6SXDaDAerU= X-Endpoint-Received: by B4 Relay for Hermes.wu@ite.com.tw/20241230 with auth_id=310 X-Original-From: Hermes Wu Reply-To: Hermes.wu@ite.com.tw From: Hermes Wu The loop of V compare is expected to iterate for 5 times which compare V array form av[0][] to av[4][]. It should check loop counter reach the last statement "i =3D=3D 5" before return true Fixes: 0989c02c7a5c ("drm/bridge: it6505: fix HDCP CTS compare V matching") Reviewed-by: Dmitry Baryshkov Signed-off-by: Hermes Wu --- Changes in v3: - The V value compare loop from i =3D 0 to i =3D 4 and shall exit with i = =3D=3D 5=20 if all V element matches - Link to v2: https://lore.kernel.org/r/20250109-fix-hdcp-v-comp-v2-1-7dce0= a59523f@ite.com.tw Changes in v2: - pull the check of statment "i" out of V value check loop=20 - Link to v1: https://lore.kernel.org/r/20250108-fix-hdcp-v-comp-v1-1-94048= 11825cd@ite.com.tw --- drivers/gpu/drm/bridge/ite-it6505.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/i= te-it6505.c index 88ef76a37fe6accacdd343839ff2569b31b18ceb..2f82fbc0b8bf8c322c088dc2577= 20c6825651bb8 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2250,12 +2250,13 @@ static bool it6505_hdcp_part2_ksvlist_check(struct = it6505 *it6505) continue; } =20 - for (i =3D 0; i < 5; i++) { + for (i =3D 0; i < 5; i++) if (bv[i][3] !=3D av[i][0] || bv[i][2] !=3D av[i][1] || av[i][1] !=3D av[i][2] || bv[i][0] !=3D av[i][3]) break; =20 - DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d, %d", retry, i); + if (i =3D=3D 5) { + DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d", retry); return true; } } --- base-commit: 938fbb16aba8f7b88e0fdcf56f315a5bbad41aad change-id: 20250107-fix-hdcp-v-comp-3ba8e3d7adf3 Best regards, --=20 Hermes Wu