From nobody Sat Feb 7 23:06:08 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300A4200B96 for ; Wed, 8 Jan 2025 17:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358167; cv=none; b=cOE0huR8dZ1Yhxb8LNWQuH8OhjyTpoXfhznNERM6S1OvGDqu2BfVHE9m3f2G80q8cFkoe+0RJViGWfPNIt6eyyRMGebDRFfpZ84h0yVmHtTZENJMunw0TRdwOiNVDzoNUpP5Z1dOY7YzA3f5O/DtJOidP+H5k3SsTkNozkIF5FM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358167; c=relaxed/simple; bh=OI68onKi6KoJtopdFkSsGF2khOUuq6xNaRWnaWzYi6g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RLRcAKzjGMNXEsx+JSvx+MUK8JWG5tbRERL4JwgU+x9yYdRDzvTg/174CAHZWNvgt8pbrrNXWZYET8AZaeLhoHfLdhuyKuod0dAnQWWBPI3GSK+FIMKrtrOzQtkMe7tO2LvVQEE6MU1hlOXs6tEb2DPSY4JcirwXVSGl/xm7E/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BYPs8y8+; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BYPs8y8+" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4361815b96cso747925e9.1 for ; Wed, 08 Jan 2025 09:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736358164; x=1736962964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XLNrcx9cjynqqzuzB4NpWA0HHiIsSv6AxtzMCkQZk1s=; b=BYPs8y8+Ebh8Ex+KThJU6piad/DcZkiz4+UEMX2kUovAP3KDrZAHeFdeuAOcK+UsYD 4/ZlaQ1E9QAY7CGxr5lQKI5KqOibbfzmQZhyj6OIrtR1hIMd9E0jvONOwLIq9Bpm8cVw wwGFM8FXsMGZMvjVXrIdCNNjr74B3OKXRChQGjapdjpPGRCxz9eKKoC7aYEvM1NlN/c/ Vc/7y9YR7vlI60Br1AbTK7BdhLMWKqR+OKUPy+50E2VRpW9ubfFl1xxyjHIJ/MekpHPq TakNogoEAeTrinzBIFCkn7msrP8fDMYp05hFub2az91Mi7RNBjJMwbb9CHgmqPUTdF6R ZpPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736358164; x=1736962964; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XLNrcx9cjynqqzuzB4NpWA0HHiIsSv6AxtzMCkQZk1s=; b=ed2NpIbagQZhgFNzpT+qc7qVtamPmzxidwwkzKR5NmomfeNk0f6fK62u6yQCAVjlof Tplpjko/Lcyro4srb3swL5NPQBmb7t2CYKjP5UcPyyOFoDEHSKZfav2TCDHqtwOJqPlu qL1pdfuy2YH4B+6HggX7EKVSMkBz2qg9QpTXowwsQyfYZvkoUOgiUz/Hf+vKFGs4hbre vpqWJ5ZxlMIkBx4S8iv5aillwJV98sqAMR1f26lUbttR0hADtyr9M44w8mBtXOFh/Mik AvN5X9PkwNU37BaIm6amhYW/ztxYf/vd3w8QY0XRWasgh69w8uQjjWKgJqCB+H97Ed+a PIwQ== X-Forwarded-Encrypted: i=1; AJvYcCWLKR3zo0fR2JkkiCWvVEG/JSfk4ErxbXOjb8Mba3RNMq8su2GzewKzXiMJwz+wq8PJU4e2YVkFTUbUgLg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzi+9t0wSOxX95N/oWuaed5k2gHzEhBNkQowKq4Ax0KmIPjzcUF aZDhgElLmMQgMGjoZo0r+Usb+9HsZLySGOXakWkrIRwqekbmDYVtXbFW2Blp X-Gm-Gg: ASbGncsFpBElBT+25ZYwXt5AVs0FwJ32rhMVrO/JTpib/MGc5LYmPaHv2voXKzqGQAs zR6Sz8ZT67R+hntRjTfSkRGAtlNjXiao++cAbXbdU+0409CUwraeZBZOpa4XHXE6VvJFiEWdBJi +jr/NpGDyMw+HqIzHN7UIrnvnToHjzT4h0hJzjtNFWASruF/vaXXZ9kUFK5ZRuTfwjRqrNFSBuA 7KOsOLmxYA+KsfoWi7qUw1SO2plJR2/Zfn8Bx434ns9s/T56mhBgpTOBCkNQXqrPZXEfnNSW0PR lbY/Txz1fXHZszp8 X-Google-Smtp-Source: AGHT+IFIqOkXUuSgc9JKaMiuRTstnOzHRkJFALhHX7goFQuCNxa9l/nz6ltCkfChAn3oKQpG4qp99A== X-Received: by 2002:a05:600c:1c14:b0:436:1ac2:1ad2 with SMTP id 5b1f17b1804b1-436e26c0400mr33509375e9.19.1736358164437; Wed, 08 Jan 2025 09:42:44 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd15766fsm28869345e9.2.2025.01.08.09.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:42:43 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler , kernel test robot , Dan Carpenter Subject: [PATCH v2] staging: gpib: Add missing mutex unlock on early return in Date: Wed, 8 Jan 2025 18:42:24 +0100 Message-ID: <20250108174224.23096-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the buffer allocation for return data in ni_usb_write() fails we were returning without unlocking the addressed_transfer_lock. Add the unlock call. This was detected by smatch: New smatch warnings: drivers/staging/gpib/ni_usb/ni_usb_gpib.c:837 ni_usb_write() warn: inconsis= tent returns '&ni_priv->addressed_transfer_lock'. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202412201550.9NCO57Ye-lkp@intel.com/ Signed-off-by: Dave Penkler --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index 2c0a0d7e36c6..d0656dc520f5 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -783,8 +783,10 @@ static int ni_usb_write(gpib_board_t *board, uint8_t *= buffer, size_t length, } =20 in_data =3D kmalloc(in_data_length, GFP_KERNEL); - if (!in_data) + if (!in_data) { + mutex_unlock(&ni_priv->addressed_transfer_lock); return -ENOMEM; + } retval =3D ni_usb_receive_bulk_msg(ni_priv, in_data, in_data_length, &usb= _bytes_read, ni_usb_timeout_msecs(board->usec_timeout), 1); =20 --=20 2.47.1