From nobody Sat Feb 7 22:55:45 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACBF0201249 for ; Wed, 8 Jan 2025 17:42:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358126; cv=none; b=o/BHeNmrSWzudPDqhyJmbI9U2qkWBE16PyRIpjB5SyE2o6+HcoubuY4JAdXy4Y46oQYY4AcJhqK1HcdAhe93wwyhp33x6WfnUxy2W38sR2i8dzuHpqglou9AReHmHoklGpTJVdgUMwOWgaZte98PW72aykkR0XZv0eE8Wasu5Nc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736358126; c=relaxed/simple; bh=tvW7XjkscpqMn4ljBfxShf2fRy7UlSc1GHf6W2xCKm8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dqhp6zJpaOia/8zso6HXFyXGkTRNViXLC8NZ0is4ecXYcWhKZW69yT9ti6XuAPNcZ+G28bhc/TzKp7zHT879zrpsjfwK2yLxxwVokGDFQH+vX2oxcabGetDAkHwY7R6kl1rmMEhLSbNCHduVOshEBKxJS3OfyElvPbyeDIaw75g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cem+TsK3; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cem+TsK3" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-385de9f789cso30149f8f.2 for ; Wed, 08 Jan 2025 09:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736358123; x=1736962923; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fcSfewpLUtlDikVw3/XrxgvLaw/gAi3tPSMGU/8/Y98=; b=Cem+TsK30CH3Sk6wYv6RLtfApoCBn49ha6TpeBUc1u6TT3a1AK/CChfVNX8EdaYYTR pFyDGLaYzbyU4jt4mpDL0HQp+WZueKqL/ihb9JqDowwjaaW4fbGW/UgPs9c4Xfyax6xb GH/NufnFcBnUXuWYXzQfkPiCD6N359lR/LN+Qu5zVCv3kqs8iGkhnk6iwL7qk6vs0SBk Fw/KifKX4iMDLZqlDcqhHG7hug9FdlF8eBAhJlm9fikPRyGjJDGi2ljPRNTWjF+/kvrh uN/OP71Z+pyJ9+dKzHF94PtDO7J6zwrjCQkpEImUPNOyLdxf9VLv5p5eYSPPt6HNN7d3 rWKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736358123; x=1736962923; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fcSfewpLUtlDikVw3/XrxgvLaw/gAi3tPSMGU/8/Y98=; b=UkYnlLTesq4IeXQAHZ5ybPfkMfR+SALGoM8WSe2uRMZ/qLW7Pk+a0F1fguwYlkj2ys RR+v1i6I32kq5t4xIE4kO0Rb6YUsRsB8OAKMxjbLzeMXANyAd5qkaWfYjADUdBaeDvDn whJf52GW9ynnNuBKjESdAULo1KwijJuTANTWSTTW6m6rnzqmMKu4uh5DY5j3Ya+UeHcb I9V14mLiCLwEuPZNfj2smHRfcH1ht9cf36Kv8s+wJ6kz6EfLci1YVwHaEW9rC7PVTKyY VF6zlz9A/N5WVm6NxQgJrmYvgnLdqgpoB8ahei6Zb63d7B6n4Mf69dBbPn8bryFCFR/9 SWPA== X-Forwarded-Encrypted: i=1; AJvYcCX2a8us5vYcA9BuLPMOZIwO1xs+y9PUPG1RvETSJ6A+FAYAfGEPN0UFg6KRalIjQ3n0M20KiZkTm+o8LZA=@vger.kernel.org X-Gm-Message-State: AOJu0YxN6tuTNfwkgpi+WWawcJsaZ+w4b3/w3V01Scl15W8glzhzBL/5 VVWev1mEmzFbdOMab8tCrv4CybOiyhiAZB+XAHyA8MhT1bqkPiAY X-Gm-Gg: ASbGnctcU1wWgzKoIiB0Hy1Q72cRihCwdRighQzuM3v25E3ns/J15LO299NKkMUXJhd q7s4LLogE+fqpYZKyF9Dm3+UbeEKujKGpX4r5UfwsAu6GZ5aikXlYNK/qzC3nz1Hgj96e6dFpbO hgAGmxaBaZ2Nbduurw3uXDA2Y7sRbo8WsAzDj26cbYFJM9CYWWA5jLtEpjoWjgQXpwg8jNxq1gT xh4H74R5/qFjNZMlLK5YwfUywbzapGgrmwt7FCrgIu4xS1mWPdQl7S0zknOhbOR0w4bEKaWaQYJ OllHjMxqB7iBd9Jp X-Google-Smtp-Source: AGHT+IExRkq1xRf6MB4hR7AdEnwopL4A0jwIAoEyoSh/fMwYYHw25hL3o8kLrphyC0Z+RqerHVYJGQ== X-Received: by 2002:a5d:588b:0:b0:38a:3732:444d with SMTP id ffacd0b85a97d-38a872e567fmr3300909f8f.23.1736358122745; Wed, 08 Jan 2025 09:42:02 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd14dfcasm45998305e9.1.2025.01.08.09.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:42:02 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler , kernel test robot , Dan Carpenter Subject: [PATCH v2] staging: gpib: Add missing mutex unlock on early return in Date: Wed, 8 Jan 2025 18:41:58 +0100 Message-ID: <20250108174158.23077-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When no matching product id was found in the attach function the driver returned without unlocking the agilent_82357a_hotplug_lock mutex. Add the unlock call. This was detected by smatch: smatch warnings: drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_at= tach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202412210143.WJhYzXfD-lkp@intel.com/ Fixes: 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB d= river") Signed-off-by: Dave Penkler --- v1 -> v2 Add subsystem prefix in subject drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index b21eadabc466..c22c6bb30776 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1365,6 +1365,7 @@ static int agilent_82357a_attach(gpib_board_t *board,= const gpib_board_config_t break; default: dev_err(&usb_dev->dev, "bug, unhandled product_id in switch?\n"); + mutex_unlock(&agilent_82357a_hotplug_lock); return -EIO; } #ifdef RESET_USB_CONFIG --=20 2.47.1