From nobody Sat Feb 7 16:10:18 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A523A7081A for ; Wed, 8 Jan 2025 16:52:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355139; cv=none; b=HThlxyJIBgk2iBw0I2TI8rxCPiMpGcDxTuw86JOlyaiON2Kam9LOCYyZaNswoPZXCrQ1bLmfh5M8sIaeDxNM+h5mvNcqN1r/8EXDmg3i8tfO8glw6HOsrDQnEQCh5vT3FB6Tw6bzN9E95g5ngzER/BTovzy+5jmTZQnVG0d7pY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355139; c=relaxed/simple; bh=fnccZPll4N9Oiu0B6NSxpKZw7iCJTTDkBMpqlHQOG8s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SIozsBRNnQmqsztaleMM59K7A5IhoZUuyk1iV245U8DSXqxT/q0A+12y1cCSp8SD5K+UVVQ98thpJqrzsTCOeSKJl0qRk+fLRTdzVMJJAZzFq7BCBh/CsWq+5j/m1OpL7af4GIN7E/1rTO3E35S3DEMByxClR3iskqlTjRnK3Ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZRDbKjVC; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZRDbKjVC" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38632b8ae71so6785f8f.0 for ; Wed, 08 Jan 2025 08:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736355136; x=1736959936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iHaB+dKhEuYryj3wDAeq/qbU6r0Z/A+voW5E087kcdw=; b=ZRDbKjVCptwwa9N8eqAIUGTcC6wA8yXWA7xvT/jTrRq7awssBWHsb3n4F3s3Wi6RA0 nVS3LqhI79UF0czpO2ftv2HBMQhvkfW2a9CkSKrK9wCVzoKfsy+0Q47thA24sTIvLd+K vfVWElbceBNKfPL/Tp+c8emg1RjTr0C9EmF4QPoWrHqYNM9s5gu4RTHHsT+t4iT8BXgf mIU/lHNYrHcyWvWLevqDSooLYHF61iY9/gOFzieE0ATxVulf5Mym9Cmb2GLb+sutJgO2 Nxt+s4XptZsCtyu7lR7dg40awQFpcgA1KiSshvuGEfkncwp1OHxMJ1KblNLZfCSHv3Mx gcrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736355136; x=1736959936; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iHaB+dKhEuYryj3wDAeq/qbU6r0Z/A+voW5E087kcdw=; b=B7RPJ+EYRVSgGAY1ifRb+MUCAT2jd2IX5RGuyXfx0kX064QlnrBtDEbQ6KMl4LVEyk dcHJYbxSVsYNZFzXXmxmhHqupXvG/XTnoB5aqrsVowEGRKeFLB0iMftmNVGAj9+jfIHJ pbPOIQKOcgMmbECs8w1rJr81r3fzHvPIVEhLHpSCy0iESlVUpuIIYFN1r2zTlaj6aW9A e0S+Ijkvk2u5hX7j40xZYCyRcuyh6BbT8YfToyS5W8/OYqTr6Cl3An14IihVgiRRJWnw weY4EHEnAXAMiUZyXw63hvHegDmO0Avp1ixjp19oC38N1hHdbIHfW+rehkhiYhwPjYql 5OLg== X-Forwarded-Encrypted: i=1; AJvYcCVOoXGGwSZcg4JzBETyyByTHO9b9xALQJP8fxrzQKjM75my1VJJVVAZO7d6W3cjS4KZDXfNjYbz5aATpZ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8ig7Af+hmJwd3ucbgLIzZlyVV51tC7ifTqDf4ZO6PgAJCqWQ5 kJQZimoSRv0HjbpARnCLlRukNnzTpr6TeYe3UN0YFVvzG5gBSWGI X-Gm-Gg: ASbGncuXRFj3uy628VWzmkk9ea9Da1TdDLo519WgUzGqfJPz9dr0yBHgjkzl34ejYvC /LCG32yDbSANw4f0+MvTryycCUimhxrC19pPwKFNLJORhmR+wemdtvEnUy0pw5ikG4xVVyfSwyI XBi95pq3x2CSdfiQWZmO1RyfSPgF0aVZlkC1jWozlKE+gzcSiSlBCkTOmygHs7c2WIHyig9Oeuf ammS7y8lmIBzOI9wgFC47fxumfwlB4bYwjGvKS6M6kjyDj2iPEZ2YbeqhwJ64wqe1MSH3vEA78f c5qmH0xkJFT8ktwX X-Google-Smtp-Source: AGHT+IHEbtNoyQ8OPNA6sA97q4i4D/BmEJJnOHv973qV7kZIPDy4Vy3DTpyfiQTRQlihHgyuzzwYNg== X-Received: by 2002:a5d:6d01:0:b0:385:faaa:9d1d with SMTP id ffacd0b85a97d-38a8731508amr2738680f8f.35.1736355135792; Wed, 08 Jan 2025 08:52:15 -0800 (PST) Received: from localhost.localdomain (82-64-73-52.subs.proxad.net. [82.64.73.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2c27b54sm26717715e9.0.2025.01.08.08.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 08:52:15 -0800 (PST) From: Dave Penkler To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dave Penkler , kernel test robot , Dan Carpenter Subject: [PATCH] Add missing mutex unlock on early return in agilent usb driver Date: Wed, 8 Jan 2025 17:52:06 +0100 Message-ID: <20250108165206.20721-1-dpenkler@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When no matching product id was found in the attach function the driver returned without unlocking the agilent_82357a_hotplug_lock mutex. Add the unlock call. This was detected by smatch: smatch warnings: drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_at= tach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202412210143.WJhYzXfD-lkp@intel.com/ Fixes: 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB d= river") Signed-off-by: Dave Penkler --- drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index b21eadabc466..c22c6bb30776 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1365,6 +1365,7 @@ static int agilent_82357a_attach(gpib_board_t *board,= const gpib_board_config_t break; default: dev_err(&usb_dev->dev, "bug, unhandled product_id in switch?\n"); + mutex_unlock(&agilent_82357a_hotplug_lock); return -EIO; } #ifdef RESET_USB_CONFIG --=20 2.47.1