From nobody Sun Feb 8 07:40:40 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3669F19F47E for ; Wed, 8 Jan 2025 03:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736307335; cv=none; b=UySoWFkKZnmbJxyTyJq5hlWKNFiaKl2Zc4bvAo/YD0ZBHdWWhTetOZ1G81Pi15oQ4+HSoB7L4zk7SQOYfyC0S5FnCkX7v8BbBnz6wexkzNRdFeQuNOxQhiKNsducxA03eKVJ82zMKhlqOZ2c7TXal590/M/bwZ2N3hBiqoODAKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736307335; c=relaxed/simple; bh=1vmG54t45n+aurV1artpyA5hhS7qYLkoSaHB+QqkHdk=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=OfDBG6uOJstz2bIz0fSB1nMAERRjGybjnUhY+MJBN08pZduF25LTJ13n35btfZFhtDZhH1Ft9CfYLsXKPNmtiLg1fgqVHQ3/D1gklU2XeYrLGQE0LlNpNAzAJ2HdjWQCRjyD2Z7Gjjk01k0rMlV+IwPlaRD/jsWiKF/lijm6LVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00A7AC4CEE3; Wed, 8 Jan 2025 03:35:34 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.98) (envelope-from ) id 1tVMsS-0000000ApC6-0llj; Tue, 07 Jan 2025 22:37:04 -0500 Message-ID: <20250108033704.033555246@goodmis.org> User-Agent: quilt/0.68 Date: Tue, 07 Jan 2025 22:36:51 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Shuah Khan , Tom Zanussi , Shuah Khan Subject: [for-next][PATCH 4/4] selftests/tracing: Add hist poll() support test References: <20250108033647.656576164@goodmis.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Masami Hiramatsu (Google)" Add a testcase for poll() on hist file. This introduces a helper binary to the ftracetest, because there is no good way to reliably execute poll() on hist file. Cc: Shuah Khan Cc: Tom Zanussi Cc: Mathieu Desnoyers Link: https://lore.kernel.org/173547867935.569911.10127126796879854182.stgi= t@devnote2 Signed-off-by: Masami Hiramatsu (Google) Reviewed-by: Shuah Khan Signed-off-by: Steven Rostedt (Google) --- tools/testing/selftests/ftrace/Makefile | 2 + tools/testing/selftests/ftrace/poll.c | 74 +++++++++++++++++++ .../test.d/trigger/trigger-hist-poll.tc | 74 +++++++++++++++++++ 3 files changed, 150 insertions(+) create mode 100644 tools/testing/selftests/ftrace/poll.c create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/trigger-h= ist-poll.tc diff --git a/tools/testing/selftests/ftrace/Makefile b/tools/testing/selfte= sts/ftrace/Makefile index a1e955d2de4c..49d96bb16355 100644 --- a/tools/testing/selftests/ftrace/Makefile +++ b/tools/testing/selftests/ftrace/Makefile @@ -6,4 +6,6 @@ TEST_PROGS :=3D ftracetest-ktap TEST_FILES :=3D test.d settings EXTRA_CLEAN :=3D $(OUTPUT)/logs/* =20 +TEST_GEN_PROGS =3D poll + include ../lib.mk diff --git a/tools/testing/selftests/ftrace/poll.c b/tools/testing/selftest= s/ftrace/poll.c new file mode 100644 index 000000000000..53258f7515e7 --- /dev/null +++ b/tools/testing/selftests/ftrace/poll.c @@ -0,0 +1,74 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Simple poll on a file. + * + * Copyright (c) 2024 Google LLC. + */ + +#include +#include +#include +#include +#include +#include +#include + +#define BUFSIZE 4096 + +/* + * Usage: + * poll [-I|-P] [-t timeout] FILE + */ +int main(int argc, char *argv[]) +{ + struct pollfd pfd =3D {.events =3D POLLIN}; + char buf[BUFSIZE]; + int timeout =3D -1; + int ret, opt; + + while ((opt =3D getopt(argc, argv, "IPt:")) !=3D -1) { + switch (opt) { + case 'I': + pfd.events =3D POLLIN; + break; + case 'P': + pfd.events =3D POLLPRI; + break; + case 't': + timeout =3D atoi(optarg); + break; + default: + fprintf(stderr, "Usage: %s [-I|-P] [-t timeout] FILE\n", + argv[0]); + return -1; + } + } + if (optind >=3D argc) { + fprintf(stderr, "Error: Polling file is not specified\n"); + return -1; + } + + pfd.fd =3D open(argv[optind], O_RDONLY); + if (pfd.fd < 0) { + fprintf(stderr, "failed to open %s", argv[optind]); + perror("open"); + return -1; + } + + /* Reset poll by read if POLLIN is specified. */ + if (pfd.events & POLLIN) + do {} while (read(pfd.fd, buf, BUFSIZE) =3D=3D BUFSIZE); + + ret =3D poll(&pfd, 1, timeout); + if (ret < 0 && errno !=3D EINTR) { + perror("poll"); + return -1; + } + close(pfd.fd); + + /* If timeout happned (ret =3D=3D 0), exit code is 1 */ + if (ret =3D=3D 0) + return 1; + + return 0; +} diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-pol= l.tc b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc new file mode 100644 index 000000000000..8d275e3238d9 --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-poll.tc @@ -0,0 +1,74 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test poll wait on histogram +# requires: set_event events/sched/sched_process_free/trigger events/sched= /sched_process_free/hist +# flags: instance + +POLL=3D${FTRACETEST_ROOT}/poll + +if [ ! -x ${POLL} ]; then + echo "poll program is not compiled!" + exit_unresolved +fi + +EVENT=3Devents/sched/sched_process_free/ + +# Check poll ops is supported. Before implementing poll on hist file, it +# returns soon with POLLIN | POLLOUT, but not POLLPRI. + +# This must wait >1 sec and return 1 (timeout). +set +e +${POLL} -I -t 1000 ${EVENT}/hist +ret=3D$? +set -e +if [ ${ret} !=3D 1 ]; then + echo "poll on hist file is not supported" + exit_unsupported +fi + +# Test POLLIN +echo > trace +echo 'hist:key=3Dcomm if comm =3D=3D"sleep"' > ${EVENT}/trigger +echo 1 > ${EVENT}/enable + +# This sleep command will exit after 2 seconds. +sleep 2 & +BGPID=3D$! +# if timeout happens, poll returns 1. +${POLL} -I -t 4000 ${EVENT}/hist +echo 0 > tracing_on + +if [ -d /proc/${BGPID} ]; then + echo "poll exits too soon" + kill -KILL ${BGPID} ||: + exit_fail +fi + +if ! grep -qw "sleep" trace; then + echo "poll exits before event happens" + exit_fail +fi + +# Test POLLPRI +echo > trace +echo 1 > tracing_on + +# This sleep command will exit after 2 seconds. +sleep 2 & +BGPID=3D$! +# if timeout happens, poll returns 1. +${POLL} -P -t 4000 ${EVENT}/hist +echo 0 > tracing_on + +if [ -d /proc/${BGPID} ]; then + echo "poll exits too soon" + kill -KILL ${BGPID} ||: + exit_fail +fi + +if ! grep -qw "sleep" trace; then + echo "poll exits before event happens" + exit_fail +fi + +exit_pass --=20 2.45.2