From nobody Fri Dec 19 20:54:18 2025 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.7]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF72F7E765 for ; Wed, 8 Jan 2025 02:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736303686; cv=none; b=Hg7gUJyz6qBMbKcenhZKvtvFx0qbnFZNuKWvL7vkyPHWQvamMgA6KNgjjvI5QBUTEYXDjL+kat8hkBvHxLx+i4+feNkL2RfIIX2dON/al7mucRLdOJixFWH29IG536BUFm6bg+eazjiFlJa75GNa8KcZK/P8TZzDbHu+wOUd0mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736303686; c=relaxed/simple; bh=aU95XIaBtG0Y53hecg9+anOIF9ENwOh0EzI8a/epB44=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ZGAARzk6Kl+nmUDW7T2lgThR2iazdlHod7R3J/94VT9Bl7Itp88RNKd1abvMvro/ZO0lTqua27aTPaC/fLoMJue2+pSUlpTO5o0qOj9nawyC1ybid6VDt8UR2jVv9Ng5Q1xBtfRN0Eg9SFCtM4KoHE66PPbIeScq6j00jYIBq50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=O8oP4n4R; arc=none smtp.client-ip=220.197.31.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="O8oP4n4R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=zL9wr A3EcWScF0dCD2l9jGOX7PvDPxuDwhf1I2zoBtQ=; b=O8oP4n4RHtF9bs/i6+l1r atUZW5Vt5Y3YWr9AlPQu+F7dD/jCPD1Zwrm72M12cssYliUMqfK54TWqsZnyClIm 7cSBwPh+j4RNPCJPEPheksbPITeH1rH0DOvqArxtMsFGbBGCuVTrMJUdUihtpCg/ 6vhJflrSh8Qfo+tC0HOOq8= Received: from localhost.localdomain (unknown [111.204.182.99]) by gzsmtp5 (Coremail) with SMTP id qSkvCgC3XW_5431njDSHDQ--.56539S2; Wed, 08 Jan 2025 10:33:30 +0800 (CST) From: Honglei Wang To: tj@kernel.org, void@manifault.com, arighi@nvidia.com, changwoo@igalia.com Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH v2] sched_ext: switch class when preempted by higher priority scheduler Date: Wed, 8 Jan 2025 10:33:28 +0800 Message-Id: <20250108023328.37675-1-jameshongleiwang@126.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qSkvCgC3XW_5431njDSHDQ--.56539S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF1xXFWfGw13urWktr43KFg_yoWDZFgE9a 1aqrs7KF1jkFWvvFyUGayfZFW0ka10vF95Zw1jkFWDArZ5CryYv34DKF9rXr1xJrZ3Ga9r uwnIgF98Jr1a9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbtC7UUUUUU== X-CM-SenderInfo: 5mdpv2pkrqwzphlzt0bj6rjloofrz/1tbirwDOrWd925aQ2QAAsS Content-Type: text/plain; charset="utf-8" ops.cpu_release() function, if defined, must be invoked when preempted by a higher priority scheduler class task. This scenario was skipped in commit f422316d7466 ("sched_ext: Remove switch_class_scx()"). Let's fix it. Fixes: f422316d7466 ("sched_ext: Remove switch_class_scx()") Signed-off-by: Honglei Wang Acked-by: Andrea Righi --- kernel/sched/ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 19d2699cf638..ef0e3f2c1e6f 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -3034,7 +3034,7 @@ static void put_prev_task_scx(struct rq *rq, struct t= ask_struct *p, */ if (p->scx.slice && !scx_rq_bypassing(rq)) { dispatch_enqueue(&rq->scx.local_dsq, p, SCX_ENQ_HEAD); - return; + goto switch_class; } =20 /* @@ -3051,6 +3051,7 @@ static void put_prev_task_scx(struct rq *rq, struct t= ask_struct *p, } } =20 +switch_class: if (next && next->sched_class !=3D &ext_sched_class) switch_class(rq, next); } --=20 2.45.2