From nobody Fri Dec 19 20:58:23 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 072C420127A for ; Wed, 8 Jan 2025 17:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736357440; cv=none; b=aas/FlHN8hSqkzjH5G6hqas3bTvhQyDpQxMr2Dcpj/poUrsklY15uXAWTsq4f0BHns9aJjEm9TSSh/lHDYFUV91xu4nRT1WIjM05Sn5d1cz9z56Z1Kqm20K3zxyrTMq3s3DNK0frhAvyLye7wyNJ3ZOrppvoplIKGoyk1ywUrFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736357440; c=relaxed/simple; bh=IuHaI/semL+Hv8JNr40Pmjd0RO8u7Ce4lu8w8B537I0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bin93+4PuEH5n0YWIl/+whZD8UO39I9O0987rid1LepsfXogwhgzwW//eBKoaUPNhtkkhzjTwL+dj0PV/bLO+l3D2CIeRY8cVm0OCjhQHguhQRsa/GDUjoG9iBQAWujRACjQbUBJyufXICMqKshZUfpDwM4as3OdHAxz3DSdjcU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=fl+bbM8v; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="fl+bbM8v" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so24801f8f.0 for ; Wed, 08 Jan 2025 09:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736357437; x=1736962237; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=szKwztPhzV6CVF/0X9HGbGEX7Uh9TD9UOgptum5XTx8=; b=fl+bbM8vy1Ovyuhzmdz+qTWRxaNY/cD8dPmdfWFomZMLhk/jwr8EsYHhqsJJmEddGg +pKkrqoNcCMbQ7TPMIYnL/vSFIc26aRIIIeCe/Dgk7T+D5/l0vbtGINObG4T+8kqIak0 fhmVedw6qeay4xb5L6LLn90vLHBMdkAeuL80eGXbhq3U89HWoQ9d23vgZLnvrrhc2JaF xforg/F03QKxJzgTYwr+ztEQ5JV4xTNy/lajN6uWhlupF4nXmXgqRAhM3dWQnaWPQrkl NAxff8wINBgrUouEmlP1nZvCwhYwhPvC07oLWM+fBb3Upd7eOYLCTCR3V2e5XM9EyJrE 53iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736357437; x=1736962237; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=szKwztPhzV6CVF/0X9HGbGEX7Uh9TD9UOgptum5XTx8=; b=g73yeF4J7/47c0OMSnpcLxNCBIscYn/QgL3YbV1rUXeYm2orMhOPXk8SM4ngrXDHGy UZ1mDmLbuHdA99onvGOZtMJQNli7SsfeJuTb6TLeJqylydHLd7bIDi8+uAM6c+ZyiA27 AR++tjnA07woA4YNm+mATD1hmk7KJpBDGzlB0wPKuLFBaMRab4A3B1WGqin/Xz+GJAQf sysB7GYgQcWWmcF82nW1dPyei+audj2M25Bmg6KJgwNToD8CD3gyvnFXP4S0gvJPd5Mt FMu6h0zfktHWlWZ/jV9tDrHDUjsWOd+IJE+tNQiuf42mDCQjYCwtA3OMj9ncpNVbes92 6iiQ== X-Forwarded-Encrypted: i=1; AJvYcCUZIAmoArcQ6W2qDgw/pOB22g7HQIHT1QqngiPRsTZ/WYv+P8Q9LFTqaM6St++UHUlo1G8Fldvmzit6+nE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9LTr4EH3sw5UbXvSIrbCgBR6BXz2ofokyAB+vjTIJ9tA6kFuk Ppd7JvI4bpj8D6JX/WQuZjhOkMAkl/fFqohDp6VJsu205TAtENUlDTAdg1v9bgM= X-Gm-Gg: ASbGnct/NAwP4ADGmXP9JogC36Zc5dQME0PB9SgJr4T7+8+cInYvlG4qeUkF37Jp+P8 PT4jA/SGVm4VsA5YkTocGcTlo+POP0QSUx3Aj/icfFp+6aVonCh4Tdi0wu/vD+R67oA4s4eMwBF oV97+1fqIyJChA28q9t3YZeu7jpZwA1xJZLhKW+QSauM1GgIqxPNbwZaRkANPA2Z2gjZPwhrAdY Bjj3kB1uGY1r0HNZHKaNAFYNG2fKAGyQ9aLEP97FcktFrVMye7imVOWEks= X-Google-Smtp-Source: AGHT+IHZQe7bqAuDCWH482pq2vJ7oArvpn5JDt8LHHWBYu8pE/3pqQpPt6ie/yD+qulq+Fw1RO94Lg== X-Received: by 2002:a5d:64eb:0:b0:38a:50fa:d582 with SMTP id ffacd0b85a97d-38a87363364mr2332501f8f.59.1736357437339; Wed, 08 Jan 2025 09:30:37 -0800 (PST) Received: from [127.0.1.1] ([87.13.70.66]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8330d4sm52782599f8f.29.2025.01.08.09.30.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:30:36 -0800 (PST) From: Angelo Dureghello X-Google-Original-From: Angelo Dureghello Date: Wed, 08 Jan 2025 18:29:19 +0100 Subject: [PATCH v2 5/9] iio: dac: ad3552r-hs: fix message on wrong chip id Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-5-2dac02f04638@baylibre.com> References: <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-0-2dac02f04638@baylibre.com> In-Reply-To: <20250108-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v2-0-2dac02f04638@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Mihail Chindris , Nuno Sa , David Lechner Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Angelo Dureghello X-Mailer: b4 0.14.1 From: Angelo Dureghello Set a better info message on wrong chip id, fixing the expected value as read from the info struct. Signed-off-by: Angelo Dureghello --- drivers/iio/dac/ad3552r-hs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c index 8974df625670..27949f207d42 100644 --- a/drivers/iio/dac/ad3552r-hs.c +++ b/drivers/iio/dac/ad3552r-hs.c @@ -326,8 +326,9 @@ static int ad3552r_hs_setup(struct ad3552r_hs_state *st) =20 id |=3D val << 8; if (id !=3D st->model_data->chip_id) - dev_info(st->dev, "Chip ID error. Expected 0x%x, Read 0x%x\n", - AD3552R_ID, id); + dev_info(st->dev, + "Chip ID mismatch, detected 0x%x but expected 0x%x\n", + id, st->model_data->chip_id); =20 /* Clear reset error flag, see ad3552r manual, rev B table 38. */ ret =3D st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_ERR_STATUS, --=20 2.47.0