From nobody Fri Dec 19 17:16:09 2025 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E8E1FE45D for ; Wed, 8 Jan 2025 14:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736346732; cv=none; b=QoxlshPY/B5hd97IDLZek1KIFx3sI/TjBHnUu5R+1qNBMj2uqjEotheZ6zErEqsznUt90NfVatldTpTb0X3eyijtXNoY25/mUbt7t+oxUfKLst7drYxmjfQFkapgZrycpijM1yStPlTaA47JiwgxrjFSWSBlxgCrroCjq0StgCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736346732; c=relaxed/simple; bh=i0gLL9cKFwnwAUFAvwIYOq+eSp8wWGGPgQgjnTN3PKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qH8RiLUJUOoEFnQgnj1dXAIkR+Op4JtFYmaQ+C4gxgntXnUx2IvEYbmQREPDq2Gnl0LveFiHoRPaP4oqZugZQciSn6dqW9E7KdclEhVHJ9djwWyu9THj8BPCc9VnDJ7venJ2EdfE6jiMl+3nzTmnuWw2L9y3NcQZnwE93AAjguw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ViGAC26J; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ViGAC26J" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-43625c4a50dso116549465e9.0 for ; Wed, 08 Jan 2025 06:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736346729; x=1736951529; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9rGR892CsW48bbjquxFjsrZJbQNkPKwTMgb7XwAF2pQ=; b=ViGAC26JTPgy0QEn/DJb8St0jpn0YF11nXUaGpojbuz7RjWCdMxGdqk5Nym9VeTHIC dSiDCG798Q9X2e99bUNFP+Cdezoir1XEutTi0P7bofZjdxkz9XbPxYiYAjnn8QvD91es HIJmdhHegDw3SP06Gu/9AXTiicRjtvxa/JWRCFPWOEWpRHMTx4iXVecQvGsrUAFmkDQP UR2Mux9YS1FN6NWEte4OCMjZ3tymafDhyJWnNEZuEgOdPMrGhHs29ecKQVdtcu15z/k/ tiBO9MqVrFJYCIAY9sQX+rUOZJUd19zCs7Z8chNM65+5kng1k7mvWV5rufs0SeIaAddT Hpkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736346729; x=1736951529; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9rGR892CsW48bbjquxFjsrZJbQNkPKwTMgb7XwAF2pQ=; b=EO0aLL6nuIgAHyDvkH526FOuhhxPzj/AWGapMew0+tKrce5JdjWz8IEnrGsFdr3aNh neWFS+Qr4OiZVDAswfTpjLpXCkL3VGJjN+VFFf3PwZ2+OaI2ubwEjTv2iN5CUQdPJpvY rJwBNOir+jIOiOlteFgoSkVSdTxWDX3h+HZyERY+4IJp7H2M1xTgSBnltN+m/Jgez85+ 3Eze2i9hbpisSJbuBc1cT+eZpL5BSR8wsi9tykA51dOQPWM6WUIqEvEyfYIkq1C5cZom OPr96pHMq2LELjWH0gAwva5acNgUCgL2Goxc4TXJEiKmKIHuejw1/zPQzw7hdjxaJvwc zW8A== X-Forwarded-Encrypted: i=1; AJvYcCV0xCmifU5sdVsWThEQdfFYGTqC39hWHV57/bKeboyB61Eu/sRYrYENuMfaAK81RqYGuhzPDErf1MeAL6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0GfbNhFdOg49WDaMhJgEfW0rCMt2bCSFaqOH3IQPLNaySxbxj XLGR06p/mAeGfQ+mFnAWxkRIVc9hzPyuWyUE/F6lujkhU99HA1NmDHLs70T0E5c= X-Gm-Gg: ASbGnctsKbc/6uZiNB6mb049nNuc4LQDy1wEdD16wxlW3NjoL961CT//t/cC83iv+1q JPjReIGghbP62hEEe3L/wyxkmoEHGWVqwP7C+QlybT4k7eUE+tm8TUCD3k3ScmyQFI5g05ZVe/i 52HUij5hRXBKV1/qTMNTtyZaLEKN0JySjGDanV9+MBlApke6e7l4AMfNASFr2iu9suVmGk10kUd XPoMWiUXSspbVNWal7MS0pTMt4TxAbY7uvxoKhHPYlTMBY1kkzotUEt X-Google-Smtp-Source: AGHT+IHOFNgi43hh97zw23/scdO9rgdvzo4suhicC6urfK1gf1ViwOyw1YHkL1LYT0r9NFeFOfWQ9Q== X-Received: by 2002:a05:600c:4f15:b0:436:51bb:7a43 with SMTP id 5b1f17b1804b1-436e26776f7mr25763075e9.5.1736346729387; Wed, 08 Jan 2025 06:32:09 -0800 (PST) Received: from [127.0.1.1] ([86.121.162.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e89e14sm22741445e9.33.2025.01.08.06.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 06:32:08 -0800 (PST) From: Abel Vesa Date: Wed, 08 Jan 2025 16:31:45 +0200 Subject: [PATCH v4 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250108-drm-dp-msm-add-lttpr-transparent-mode-set-v4-3-918949bc2e3a@linaro.org> References: <20250108-drm-dp-msm-add-lttpr-transparent-mode-set-v4-0-918949bc2e3a@linaro.org> In-Reply-To: <20250108-drm-dp-msm-add-lttpr-transparent-mode-set-v4-0-918949bc2e3a@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Abel Vesa , Imre Deak X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=3093; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=i0gLL9cKFwnwAUFAvwIYOq+eSp8wWGGPgQgjnTN3PKE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnfoxeHNki79B0QYd4mTUlmaS4L+1SJlhYA9Z/v A4IDLvBSQeJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZ36MXgAKCRAbX0TJAJUV VvsXD/oC6cp0EXwMhmMRSeEBz9Zyx8ZcCFWQr/TnVk4AXiXuzPX9TJGnd77Zq+bPTvcfFEkGd9T 2iCgdfAC12kiMTsTGPfSC4CJw5A6F8fKgAu3Gzm9mhGMIvSEGMUH9ObSxk8aLljgxHjWqJdBfsS PnX+z1pwhNwDf7dJMqmeyDCUtaTCAOX2/0aPtGYDaPV9+5xHAUDipJ8/6f+XAbgUKLmisnmVeO/ x1JN8l4JHYndHJ0UVM5r86iEytn0+7Y/WDSv5faTe9lxmZXBL2vbr+IGwI25/dsCFbueTZxL1ot N4uZBzIFRqUMN2eTq2DHF2IKtKoSHsEdDUcrGkmolIL+4B2BIP1mrjrd1N5MbiFtEaHfmFdNkzj XNSijG0GamQoUl+OC+VC5AyL3QYvG7X80lZhthpK3Ad4wiXzqJG59so0TeEpx9OWAqs7BTGdF0T +wwS6vXDmzqygQrfXuQfY1zatwG0RZHuY4LDJz8U1rs3gb2HUqgxesCwaXK95u4Xcms5qGrr6Qf V7UFT8z0OFgZ6jzG++l1+Ud28R6i2GbJgISqMjRqEstLMKA/HPo8db1bIiY6lgiMTj3Qth8kcSA lY+oYAQaSCGcqdUVuE4D9b8V/3CL+h7FF4sSgISfB2xfD7eq2XAV43yQ4tc5uPB2BiqR0hqyuPc +ZR64oI0/smoEBA== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them, which is handling the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. So use the new drm generic helper instead as it makes the code a bit cleaner. Since the driver specific implementation holds the lttrp_common_caps, if the call to the drm generic helper fails, the lttrp_common_caps need to be updated as the helper has already rolled back to transparent mode. Acked-by: Imre Deak Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +++++-------------= ---- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/driver= s/gpu/drm/i915/display/intel_dp_link_training.c index 8b1977cfec503c70f07af716ee2c00e7605c6adf..c5bad311edf7b9a5cebb633b9e9= 692bae397f9ed 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -119,9 +119,6 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp *in= tel_dp, bool enable) u8 val =3D enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : DP_PHY_REPEATER_MODE_NON_TRANSPARENT; =20 - if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE, &val, 1) !=3D= 1) - return false; - intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE - DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV] =3D val; =20 @@ -146,6 +143,7 @@ static bool intel_dp_lttpr_transparent_mode_enabled(str= uct intel_dp *intel_dp) static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dp= cd[DP_RECEIVER_CAP_SIZE]) { int lttpr_count; + int ret; =20 if (!intel_dp_read_lttpr_common_caps(intel_dp, dpcd)) return 0; @@ -172,22 +170,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *i= ntel_dp, const u8 dpcd[DP_ return lttpr_count; } =20 - /* - * See DP Standard v2.0 3.6.6.1. about the explicit disabling of - * non-transparent mode and the disable->enable non-transparent mode - * sequence. - */ - intel_dp_set_lttpr_transparent_mode(intel_dp, true); - - /* - * In case of unsupported number of LTTPRs or failing to switch to - * non-transparent mode fall-back to transparent link training mode, - * still taking into account any LTTPR common lane- rate/count limits. - */ - if (lttpr_count < 0) - goto out_reset_lttpr_count; - - if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { + ret =3D drm_dp_lttpr_init(&intel_dp->aux, lttpr_count); + if (ret) { lt_dbg(intel_dp, DP_PHY_DPRX, "Switching to LTTPR non-transparent LT mode failed, fall-back to = transparent mode\n"); =20 @@ -196,6 +180,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *in= tel_dp, const u8 dpcd[DP_ goto out_reset_lttpr_count; } =20 + intel_dp_set_lttpr_transparent_mode(intel_dp, false); + return lttpr_count; =20 out_reset_lttpr_count: --=20 2.34.1