From nobody Sun Feb 8 12:40:31 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 253AB1F8666; Tue, 7 Jan 2025 20:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736281094; cv=none; b=Ll+uo3yD8DluFFBGnz5QPi3ftOsW59cgBH9WMmOKYCYRdSP7baHScn6CN6Izh0AnNYG6/WjAU1+uPC6wZFii6WOqvmDzR8CKvjOdev9/mXeSfr/IYHM+94SZjOjvuP38H8OaZNNrFOnHIcfsGMh17xj4MBy+Uu/zPVyjYaQunbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736281094; c=relaxed/simple; bh=SeGgDvPfXuXgeFvtGluC78K25dToIj5MV+FyPl+BzUU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qDcXCfKmtCep1o35ratt+2BmQyQ0NBeDff8plc13sy36+PShTUOe5Dm1/QsVYP+w1lhJEe+c4zTzot5mBiJqDfnVj03tcwS5zSJBk63/hArfiOXX6/B1Rn9sUQ1POUVJvgUGD9wb5PvwKB7n3mPGNpb6T+Zj79O4oknFkBPCa08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OxeN3wM1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OxeN3wM1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E427C4CEDE; Tue, 7 Jan 2025 20:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736281093; bh=SeGgDvPfXuXgeFvtGluC78K25dToIj5MV+FyPl+BzUU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OxeN3wM1Vi1ShZ4pD2Rd4hdVw6Q7pn9tsFM/OnmFfbLKq4vdhzB8yi0XG9CUdls77 nDdeUxE1UjCDw9/z8lYYUtlYUSnh/cIhMGztGIxuZf+QPxJS9prq0NBjr+ym28T3kU gV9SOvM/KWk/rtRb0zI77NdRZJ7ldMThEWIbUhpEkMVPBtJGJ/N++5WuWzFsiR3rx+ 8/vbaa97U8+Vu9KJHF2kzFc9y/T5co7hS9ezK5u9UnTK/Wk9Kt0zr5/hByOAOb94+z GcnUN7id7QXHugoMQ+PmBGYtA/JF/vt+PzYaHwDc9qNXihcnUwjLQsj25XkllfjBGh p46hnywfBlBMw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 05/10] mm/damon: add pass argument to damos_new_filter() Date: Tue, 7 Jan 2025 12:17:34 -0800 Message-Id: <20250107201739.79484-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250107201739.79484-1-sj@kernel.org> References: <20250107201739.79484-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DAMON API users should set damos_filter->pass manually to use a DAMOS pass filter, since damos_new_filter() unsets the field always. It is cumbersome and easy to mistake. Add an arugment for setting the field to damos_new_filter(). Signed-off-by: SeongJae Park --- include/linux/damon.h | 2 +- mm/damon/core.c | 7 ++++--- mm/damon/paddr.c | 3 ++- mm/damon/reclaim.c | 2 +- mm/damon/sysfs-schemes.c | 2 +- mm/damon/tests/core-kunit.h | 4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index baeb884ed156..27593dadbd76 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -801,7 +801,7 @@ void damon_update_region_access_rate(struct damon_regio= n *r, bool accessed, struct damon_attrs *attrs); =20 struct damos_filter *damos_new_filter(enum damos_filter_type type, - bool matching); + bool matching, bool pass); void damos_add_filter(struct damos *s, struct damos_filter *f); void damos_destroy_filter(struct damos_filter *f); =20 diff --git a/mm/damon/core.c b/mm/damon/core.c index 71db2c754e6d..13f12d82de5f 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -266,7 +266,7 @@ int damon_set_regions(struct damon_target *t, struct da= mon_addr_range *ranges, } =20 struct damos_filter *damos_new_filter(enum damos_filter_type type, - bool matching) + bool matching, bool pass) { struct damos_filter *filter; =20 @@ -275,7 +275,7 @@ struct damos_filter *damos_new_filter(enum damos_filter= _type type, return NULL; filter->type =3D type; filter->matching =3D matching; - filter->pass =3D false; + filter->pass =3D pass; INIT_LIST_HEAD(&filter->list); return filter; } @@ -806,7 +806,8 @@ static int damos_commit_filters(struct damos *dst, stru= ct damos *src) continue; =20 new_filter =3D damos_new_filter( - src_filter->type, src_filter->matching); + src_filter->type, src_filter->matching, + src_filter->pass); if (!new_filter) return -ENOMEM; damos_commit_filter_arg(new_filter, src_filter); diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 71cb02128b46..cd89500efc22 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -259,7 +259,8 @@ static unsigned long damon_pa_pageout(struct damon_regi= on *r, struct damos *s, } } if (install_young_filter) { - filter =3D damos_new_filter(DAMOS_FILTER_TYPE_YOUNG, true); + filter =3D damos_new_filter( + DAMOS_FILTER_TYPE_YOUNG, true, false); if (!filter) return 0; damos_add_filter(s, filter); diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 9e0077a9404e..a675150965e0 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -221,7 +221,7 @@ static int damon_reclaim_apply_parameters(void) } =20 if (skip_anon) { - filter =3D damos_new_filter(DAMOS_FILTER_TYPE_ANON, true); + filter =3D damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, false); if (!filter) goto out; damos_add_filter(scheme, filter); diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index deeaf23c1fcf..9a883e8aea1c 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1901,7 +1901,7 @@ static int damon_sysfs_add_scheme_filters(struct damo= s *scheme, sysfs_filters->filters_arr[i]; struct damos_filter *filter =3D damos_new_filter(sysfs_filter->type, - sysfs_filter->matching); + sysfs_filter->matching, false); int err; =20 if (!filter) diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h index 8f58d3424c21..532c6a6f21f9 100644 --- a/mm/damon/tests/core-kunit.h +++ b/mm/damon/tests/core-kunit.h @@ -411,7 +411,7 @@ static void damos_test_new_filter(struct kunit *test) { struct damos_filter *filter; =20 - filter =3D damos_new_filter(DAMOS_FILTER_TYPE_ANON, true); + filter =3D damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, false); KUNIT_EXPECT_EQ(test, filter->type, DAMOS_FILTER_TYPE_ANON); KUNIT_EXPECT_EQ(test, filter->matching, true); KUNIT_EXPECT_PTR_EQ(test, filter->list.prev, &filter->list); @@ -425,7 +425,7 @@ static void damos_test_filter_out(struct kunit *test) struct damon_region *r, *r2; struct damos_filter *f; =20 - f =3D damos_new_filter(DAMOS_FILTER_TYPE_ADDR, true); + f =3D damos_new_filter(DAMOS_FILTER_TYPE_ADDR, true, false); f->addr_range =3D (struct damon_addr_range){ .start =3D DAMON_MIN_REGION * 2, .end =3D DAMON_MIN_REGION * 6}; =20 --=20 2.39.5