From nobody Fri Dec 19 20:59:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17F881F2365 for ; Tue, 7 Jan 2025 14:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261442; cv=none; b=e7QzFcYaz45YoWaQG5qEeFXmOuZ2ERLXSMQq+mHXh1IaoClX26R/jGpWJIrdmDORU3z2cUuMHLTDu0qR6mdw4r90nHHpilC/EMUn0HgTEB1qIK2HSmxMoP7Su6TPEd7nprnGlMTqB3137CmlNaYt3o7RHd/TnC7Lpe8lWUe3rJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261442; c=relaxed/simple; bh=yWJNeLUlUwSkJjpwIh1lxy4NhW8QzCWxVfdVz1RS7ZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AvLAuQLVsR2ieU8qZcoB/SdvckWCrY2XsnNCptDdkNhTFPZnGD4S7SmMLFM3JeU8uBMsJ2JgdXNHj3yx5pvDxfLfo0rOzLTWd20Bny0bdaS7F7KFSEeWI28DwScg6MbWD5XTPKSiocGOewfB5BPPn8y8OkqQNB1jzQ4NGpgQNoo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P0wx2mAU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P0wx2mAU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736261440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NM0ibh4ovGXHvVLVyF/bSYQFn1AYBfBKeO4PWD9Syis=; b=P0wx2mAUtEjf9l8Cg9317QRY8yBfeaTIh0p4k/W5nU3/m9vICsq78Kv+DP+PHiNoKAJt9q RHseYe6E7c7/T3lmPwBL+KDZ1olMtbWbBtOpm2YK0ojymx6jKxGPU7PGa4HCV19EPKXYYR E4CBfUcd+6IL8EyliaTC+PgwMCly2t8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-wqNov7CjNkqUSEe-QgB86A-1; Tue, 07 Jan 2025 09:50:36 -0500 X-MC-Unique: wqNov7CjNkqUSEe-QgB86A-1 X-Mimecast-MFC-AGG-ID: wqNov7CjNkqUSEe-QgB86A Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 279DC1956057; Tue, 7 Jan 2025 14:50:35 +0000 (UTC) Received: from fedora.brq.redhat.com (unknown [10.43.17.159]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3B339195609D; Tue, 7 Jan 2025 14:50:32 +0000 (UTC) From: Tomas Glozar To: Steven Rostedt Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, John Kacur , Luis Goncalves , Tomas Glozar Subject: [PATCH 1/3] rtla/osnoise: Distinguish missing workload option Date: Tue, 7 Jan 2025 15:48:21 +0100 Message-ID: <20250107144823.239782-2-tglozar@redhat.com> In-Reply-To: <20250107144823.239782-1-tglozar@redhat.com> References: <20250107144823.239782-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" osnoise_set_workload returns -1 for both missing OSNOISE_WORKLOAD option and failure in setting the option. Return -1 for missing and -2 for failure to distinguish them. Cc: stable@vger.kernel.org Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/osnoise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/osnoise.c b/tools/tracing/rtla/src/osno= ise.c index 245e9344932b..699a83f538a8 100644 --- a/tools/tracing/rtla/src/osnoise.c +++ b/tools/tracing/rtla/src/osnoise.c @@ -867,7 +867,7 @@ int osnoise_set_workload(struct osnoise_context *contex= t, bool onoff) =20 retval =3D osnoise_options_set_option("OSNOISE_WORKLOAD", onoff); if (retval < 0) - return -1; + return -2; =20 context->opt_workload =3D onoff; =20 --=20 2.47.1 From nobody Fri Dec 19 20:59:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F70E1F0E25 for ; Tue, 7 Jan 2025 14:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261445; cv=none; b=VhT8PbSBJhzMJTzK+75r8/2mEzyEJoqMxYVNixhW0p+aG2qCnRjlhyPuO5S741txIIfuGKGTNr6iTK9zKxnHtrbQEPbMFO1Coo0gA+WVtWvSXzNgyUr7D1yZf+CIlwW++J6WR8dhGsoCzPATWaz4flFX8V95TawVZsUFD5LaxOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261445; c=relaxed/simple; bh=w0c3rNLDyxO6JHtLQmyOE++mY8R4pmsFiFv3QAnGGpw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UIx7TeN3iIT+DEPMM986FTW+yWqgUQkQAHN2/3JjtZjll8tN8OOGAZq7t9LQIqtvsmf7lqTnxX6xe+buNzDfpJFjjYCKe2BWcJTnbcN7cGqG6i4PQHOklGW/YsU78pOQcq0bubTiZGy76vEnChCxmtQW060n/wbun95RTusF2pE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VpzLUgfd; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VpzLUgfd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736261442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nqf+2O72YPOi9tYokBhg/rAaOaHnIjswD4gdhGy2+dg=; b=VpzLUgfdO0y1BMj+aTNq1/nrmIMvkaqsMFSh53rnz1e5AvaSaQ7g2v6xMGZNQ1ey0d2SPj XdRxpQLgi+Dal2pj7U/zCbIWE0FmFTvVhjQGM365o4NvYuA54J9hUXZH0DCu3pUp4PU88B qwqTGukusRMMRP/nB797QnjwQzSfmqs= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-pXFpWcSgMw6eMUXXtjQnPg-1; Tue, 07 Jan 2025 09:50:38 -0500 X-MC-Unique: pXFpWcSgMw6eMUXXtjQnPg-1 X-Mimecast-MFC-AGG-ID: pXFpWcSgMw6eMUXXtjQnPg Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 742431955F65; Tue, 7 Jan 2025 14:50:37 +0000 (UTC) Received: from fedora.brq.redhat.com (unknown [10.43.17.159]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 917CE1956088; Tue, 7 Jan 2025 14:50:35 +0000 (UTC) From: Tomas Glozar To: Steven Rostedt Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, John Kacur , Luis Goncalves , Tomas Glozar Subject: [PATCH 2/3] rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads Date: Tue, 7 Jan 2025 15:48:22 +0100 Message-ID: <20250107144823.239782-3-tglozar@redhat.com> In-Reply-To: <20250107144823.239782-1-tglozar@redhat.com> References: <20250107144823.239782-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" When using rtla timerlat with userspace threads (-u or -U), rtla disables the OSNOISE_WORKLOAD option in /sys/kernel/tracing/osnoise/options. This option is not re-enabled in a subsequent run with kernel-space threads, leading to rtla collecting no results if the previous run exited abnormally: $ rtla timerlat hist -u ^\Quit (core dumped) $ rtla timerlat hist -k -d 1s Index over: count: min: avg: max: ALL: IRQ Thr Usr count: 0 0 0 min: - - - avg: - - - max: - - - The issue persists until OSNOISE_WORKLOAD is set manually by running: $ echo OSNOISE_WORKLOAD > /sys/kernel/tracing/osnoise/options Set OSNOISE_WORKLOAD when running rtla with kernel-space threads if available to fix the issue. Cc: stable@vger.kernel.org Fixes: ed774f7481fa ("rtla/timerlat_hist: Add timerlat user-space support") Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/timerlat_hist.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index 4403cc4eba30..66dbc034bdc7 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -1100,12 +1100,15 @@ timerlat_hist_apply_config(struct osnoise_tool *too= l, struct timerlat_hist_param } } =20 - if (params->user_hist) { - retval =3D osnoise_set_workload(tool->context, 0); - if (retval) { - err_msg("Failed to set OSNOISE_WORKLOAD option\n"); - goto out_err; - } + /* + * Set workload according to type of thread if the kernel supports it. + * On kernels without support, user threads will have already failed + * on missing timerlat_fd, and kernel threads do not need it. + */ + retval =3D osnoise_set_workload(tool->context, params->kernel_workload); + if (retval < -1) { + err_msg("Failed to set OSNOISE_WORKLOAD option\n"); + goto out_err; } =20 return 0; --=20 2.47.1 From nobody Fri Dec 19 20:59:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26EC1F191E for ; Tue, 7 Jan 2025 14:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261446; cv=none; b=IukJBjItoThSDqLHmjZjgSqSZKgDTbO+mgPBjgWxwL6M4WQkapF39wwCkfSIzhYEl1NnWg+zhOVe+/eTcso1NrFpzqQtfUwyueR0o0RcfVOqtyjzO3iqPrwsTBrxemgRMGjv3zVmJtqa2kh52EgXfc78v11uhamjkCl4tsk/348= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261446; c=relaxed/simple; bh=JFHwV3rqAhje+xFwmQcHy9oSgigK/8RdGCoLPRcD5Ro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oauqzWMz2YO+Xo80nOFJr8QoEKqAWmQBQBVmxwxdwmGAHrhzDU8REiwlo6Q6AEfjzzgdOvwHo/A3b6RKV5KqHQGYVpefEb5hEWfwcqKhS79x6lWZnLOwlvPAJ+d8FZZ4H0QlMW0IjxJqW5hUJMircxXlZbETlPIiHl4Lll8LY9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KuKi0OKt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KuKi0OKt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736261443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p2N17mINbCXI2IZHsY3as/nDrVkZy95kpKV0uMugEi0=; b=KuKi0OKtxeydz7sOg8YyMgkuKQ+hRUhsg14z6WC6EoUC3PyitpxXBnm1F62i2WcIvrlhBb x5dWA3zPL2BeyLooSXFNaIUjWwpCz4/yMnAFmf+jDn57h8u9pbUIT4rVtwOHDrZVFxt2dA VH888FFD7JI6HX6zWuO6Oxg+FbNYzpo= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-BN1CTcmRP9KOrEZHFfrhDA-1; Tue, 07 Jan 2025 09:50:42 -0500 X-MC-Unique: BN1CTcmRP9KOrEZHFfrhDA-1 X-Mimecast-MFC-AGG-ID: BN1CTcmRP9KOrEZHFfrhDA Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2E4AD19560B3; Tue, 7 Jan 2025 14:50:40 +0000 (UTC) Received: from fedora.brq.redhat.com (unknown [10.43.17.159]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E07111956088; Tue, 7 Jan 2025 14:50:37 +0000 (UTC) From: Tomas Glozar To: Steven Rostedt Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, John Kacur , Luis Goncalves , Tomas Glozar Subject: [PATCH 3/3] rtla/timerlat_top: Set OSNOISE_WORKLOAD for kernel threads Date: Tue, 7 Jan 2025 15:48:23 +0100 Message-ID: <20250107144823.239782-4-tglozar@redhat.com> In-Reply-To: <20250107144823.239782-1-tglozar@redhat.com> References: <20250107144823.239782-1-tglozar@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Apply fix from previous commit also to timerlat-top. Cc: stable@vger.kernel.org Fixes: cdca4f4e5e8e ("rtla/timerlat_top: Add timerlat user-space support") Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/timerlat_top.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index 059b468981e4..521f9822e747 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -851,12 +851,15 @@ timerlat_top_apply_config(struct osnoise_tool *top, s= truct timerlat_top_params * } } =20 - if (params->user_top) { - retval =3D osnoise_set_workload(top->context, 0); - if (retval) { - err_msg("Failed to set OSNOISE_WORKLOAD option\n"); - goto out_err; - } + /* + * Set workload according to type of thread if the kernel supports it. + * On kernels without support, user threads will have already failed + * on missing timerlat_fd, and kernel threads do not need it. + */ + retval =3D osnoise_set_workload(top->context, params->kernel_workload); + if (retval < -1) { + err_msg("Failed to set OSNOISE_WORKLOAD option\n"); + goto out_err; } =20 if (isatty(STDOUT_FILENO) && !params->quiet) --=20 2.47.1