From nobody Sun Feb 8 05:06:46 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE501EF08D for ; Tue, 7 Jan 2025 13:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257846; cv=none; b=iTM3JOlukP0HNtHNngrHWu6p8Rmwpyj9exDr91iOGf9TbAp3UbUBpgX1/sLaEePHKyxb96LPwc4z0N0YK5+hXPn0qSt2Y2QbdGAsnOdjFDeGCyzs55Koah2hq6PGTpzLuTSmrakth3VrlhR5ELqX1ikRUQG4zQZUrTcR8Wf9ZIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736257846; c=relaxed/simple; bh=25YVvJwi2Xjlkzv9WtWyYjLUmIh+R6dUhQ8sSYCiVuE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZncPFuTs+OmDnDHT3HEcDZwgktf9Y4sLbf/NJeU7dzKx5CuIQLeRzCoDz8g0ao9LgucPFtUE+rqhP3LZyZb+xNkYZGMVTm7bz/ROi4WcPwVUURDqisbpYymLGOBQTe8vaUvbHstHp2epXy405c8jp8Y2WqZI9qz8ywXR3/z1lEs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hp3i2wXB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hp3i2wXB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736257843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JEU5DIrN0YF2UNspXPf/7Xs7dl1aHNEC4BRgGEqAXYI=; b=Hp3i2wXBj6xfn03hxobR0fqkfI8ZUmyzCrL3QMVbMrx1aizAd1sfsYjNOIhOhXY08JqQR5 nhzGO1CLfQ+vePMevQxKQL5EDoqxzaV95UriO0aAHaz+kn/g9K0abrjB+csm57xQtO3x93 DSB4zdqbtbTPSPSXDe8WVRwcWTxE1O0= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-lJ4Ow2JCPu-fDzl0nQ35gQ-1; Tue, 07 Jan 2025 08:50:42 -0500 X-MC-Unique: lJ4Ow2JCPu-fDzl0nQ35gQ-1 X-Mimecast-MFC-AGG-ID: lJ4Ow2JCPu-fDzl0nQ35gQ Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7b6e241d34eso2219724085a.0 for ; Tue, 07 Jan 2025 05:50:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736257841; x=1736862641; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JEU5DIrN0YF2UNspXPf/7Xs7dl1aHNEC4BRgGEqAXYI=; b=bhW9MB4JLmPYelOAIFx8YeGPAvqxujKoG2tmKyB1NFgvOBovPEk+0CG4Kcybooim7w vZz4W2fHFsD7TEJxDWXYQuW/4e2OLsawjPvllxmLBF4/cO/gHx0aQ4iOJDwNf0kCfv1q AnA4r6SS29DZB+OrjVw+Eu3j+CdPr9BDt6KWxDjefoCBunVoDzzeynO8BW/oeyUlUiJN SK5VEPRQ9cXV9vpbxfoy0THqmPwuz9LGlGjbTYWCjlznkc/RqfSpybeQvy4c3/sPKFoz o/TAsWgngcMPHo4y7OM5CGer90l28Ekeu320G9LLVh4W1B5j/vvWxNTnvB3l8q65CIwP N9jg== X-Forwarded-Encrypted: i=1; AJvYcCUJMu+DBAr/lNG9VZeD2EBZ77vXMdXpck0X08ZVB3wmVcAzpAu64czpy9oTzZZHNG7O0uGN2qVOidcLXMg=@vger.kernel.org X-Gm-Message-State: AOJu0YwtHBnikC/Mz0pJlrgaooELJcn8sIuris/Y904uu5Cqjqd0Biab UInZgRCpVZALMFB75cEDoW3Qxy1EZa58AteeEEe/EUWj2cYWG47Ds5IwJtOEFSWEuO9ECy1mUY9 YFOFYAqnRO9oYMqc4/HKtoC6f6j0iXaV427HGsgHrfTYmlfMBCjFwnqoqjIcz3Q== X-Gm-Gg: ASbGncuCOiiNVnRptRbgfwM5BQPHMoABeeWWE00qVgW2+PsMdfh3Hj5wzk845chjxMq p3YnvSxG8fLFJVMwjEA3AxHFCT0fPBxxLN2a7L6GDSMN7EnxVf3dizVVoo7pQnXzVmbdow/3XmP Qcttk7FTtOBGqzfiGUjl/Kqu47MN64Bsnrenck559Kt3plJkYqWKY5D4BiBlPO8aDAD5JowakNJ NanwKSLMPwmJ23q/2zuHsHAb7EgDxYQtxT4N7U/cIZLX1Kcmt3wqtM268RCV1Fs4vX/IXq++z1P Tr9ATM/7MfInlnXlmKCa7dRarJHA X-Received: by 2002:a05:620a:1998:b0:7b6:f024:3ca with SMTP id af79cd13be357-7b9ba8358a6mr8715776985a.58.1736257841704; Tue, 07 Jan 2025 05:50:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFANf+z1z3KdYW+6x6UlHOT4pYepUgwCvqnrxCM2s9PlJ10sXv+tzuVFh//bx7jVUURvptS+w== X-Received: by 2002:a05:620a:1998:b0:7b6:f024:3ca with SMTP id af79cd13be357-7b9ba8358a6mr8715774085a.58.1736257841400; Tue, 07 Jan 2025 05:50:41 -0800 (PST) Received: from lbulwahn-thinkpadx1carbongen9.rmtde.csb ([2a02:810d:7e40:14b0:4ce1:e394:7ac0:6905]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac480936sm1591427385a.72.2025.01.07.05.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 05:50:40 -0800 (PST) From: Lukas Bulwahn X-Google-Original-From: Lukas Bulwahn To: Arnd Bergmann , Dave Penkler , Greg Kroah-Hartman , linux-staging@lists.linux.dev Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH] staging: gpib: refer to correct config symbol in tnt4882 Makefile Date: Tue, 7 Jan 2025 14:50:32 +0100 Message-ID: <20250107135032.34424-1-lukas.bulwahn@redhat.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lukas Bulwahn Commit 79d2e1919a27 ("staging: gpib: fix Makefiles") uses the corresponding config symbols to let Makefiles include the driver sources appropriately in the kernel build. Unfortunately, the Makefile in the tnt4882 directory refers to the non-existing config GPIB_TNT4882. The actual config name for this driver is GPIB_NI_PCI_ISA, as can be observed in the gpib Makefile. Probably, this is caused by the subtle differences between the config names, directory names and file names in ./drivers/staging/gpib/, where often config names and directory names are identical or at least close in naming, but in this case, it is not. Change the reference in the tnt4882 Makefile from the non-existing config GPIB_TNT4882 to the existing config GPIB_NI_PCI_ISA. Fixes: 79d2e1919a27 ("staging: gpib: fix Makefiles") Signed-off-by: Lukas Bulwahn Acked-by: Arnd Bergmann --- drivers/staging/gpib/tnt4882/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gpib/tnt4882/Makefile b/drivers/staging/gpib/t= nt4882/Makefile index 04a4520ed3b7..a3c3fb96d5ed 100644 --- a/drivers/staging/gpib/tnt4882/Makefile +++ b/drivers/staging/gpib/tnt4882/Makefile @@ -1,5 +1,5 @@ ccflags-$(CONFIG_GPIB_PCMCIA) :=3D -DGPIB_PCMCIA -obj-$(CONFIG_GPIB_TNT4882) +=3D tnt4882.o +obj-$(CONFIG_GPIB_NI_PCI_ISA) +=3D tnt4882.o =20 tnt4882-objs :=3D tnt4882_gpib.o mite.o =20 --=20 2.47.1