From nobody Tue Feb 10 21:40:30 2026 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A4D692B9CD for ; Mon, 6 Jan 2025 09:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736154222; cv=none; b=i0G9YaseqCgL+cQJBE8hJA2Dz2RZu4CBOzrM0dVqmknxvj+TQ0W+dWop16FBjR3yeDNi43tOBlA58N3gU6pJxeatEXY2Z3Wom2K8Lq9FrobOb9UBVXgjXPzo5CoPSiVxnNb171QhtjUN8N1qgr9co7fbOTeFxNW64Qkf9utoKWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736154222; c=relaxed/simple; bh=czDXDckOhjYSeUz7BxZNyQe6fIlehB3/zBBQFkZywZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nX93UYWZQ7X+LwZBr0gihPMU3mU5wuAgD/6NhyBE6yOytNwpvpoGcT0beNM9Yc0nxWTal4RnisS4tuba/e1rNM7FqY+HamuUIi3rRL0VUXAw5DAIkFRtRWcO2we04OW41aPnVWvsyXNFAldVF6GWTIlL3IPl41FqGOFKH3OYPH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn; spf=pass smtp.mailfrom=loongson.cn; arc=none smtp.client-ip=114.242.206.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8Axjq9qnHtnMY9eAA--.31258S3; Mon, 06 Jan 2025 17:03:38 +0800 (CST) Received: from linux.localdomain (unknown [113.200.148.30]) by front1 (Coremail) with SMTP id qMiowMCxYMZonHtnskkWAA--.31771S2; Mon, 06 Jan 2025 17:03:36 +0800 (CST) From: Tiezhu Yang To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xinhui Pan , Harry Wentland , Leo Li , Rodrigo Siqueira Cc: Nathan Chancellor , Josh Poimboeuf , Peter Zijlstra , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] drm/amd/display: Add SPL_ASSERT_BUG() macro definition Date: Mon, 6 Jan 2025 17:03:35 +0800 Message-ID: <20250106090335.5751-1-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20250106085755.3268-1-yangtiezhu@loongson.cn> References: <20250106085755.3268-1-yangtiezhu@loongson.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowMCxYMZonHtnskkWAA--.31771S2 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7CryfurW8CF1xWFy5GFy3trc_yoW8Gw1rpw 1kWF98uwn8Ja12g3sxJ3W8CFW3A397JF47X3sI9390va48ua1xZr9rJr4rJrWxWFWSya4r Jrn8WrW2gFs2yrbCm3ZEXasCq-sJn29KB7ZKAUJUUUUx529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUBSb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAF wI0_Gr1j6F4UJwAaw2AFwI0_JF0_Jw1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2 xF0cIa020Ex4CE44I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_ Jw0_WrylYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x 0EwIxGrwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkE bVWUJVW8JwCFI7km07C267AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVW5JVW7JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42 xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF 7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU4YLvDUUUU Content-Type: text/plain; charset="utf-8" In order to keep the current ability for the aim of debugging and avoid printing the warning message twice, add SPL_ASSERT_BUG() macro definition to harden the callers of division functions. Signed-off-by: Tiezhu Yang --- drivers/gpu/drm/amd/display/dc/spl/spl_debug.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h b/drivers/gpu/d= rm/amd/display/dc/spl/spl_debug.h index f01c932d550d..8220c5800692 100644 --- a/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h +++ b/drivers/gpu/drm/amd/display/dc/spl/spl_debug.h @@ -11,18 +11,27 @@ kgdb_breakpoint(); \ } \ } while (0) +#define SPL_ASSERT_EMERGENCY(expr) do { \ + kgdb_breakpoint(); \ + BUG_ON(!(expr)); \ +} while (0) #else #define SPL_ASSERT_CRITICAL(expr) do { \ if (WARN_ON(!(expr))) { \ ; \ } \ } while (0) +#define SPL_ASSERT_EMERGENCY(expr) do { \ + BUG_ON(!(expr)); \ +} while (0) #endif /* CONFIG_HAVE_KGDB || CONFIG_KGDB */ =20 #if defined(CONFIG_DEBUG_KERNEL_DC) #define SPL_ASSERT_WARN(expr) SPL_ASSERT_CRITICAL(expr) +#define SPL_ASSERT_BUG(expr) SPL_ASSERT_EMERGENCY(expr) #else #define SPL_ASSERT_WARN(expr) WARN_ON(!(expr)) +#define SPL_ASSERT_BUG(expr) BUG_ON(!(expr)) #endif /* CONFIG_DEBUG_KERNEL_DC */ =20 #define SPL_BREAK_TO_DEBUGGER() SPL_ASSERT_WARN(0) --=20 2.42.0