From nobody Tue Feb 10 17:08:44 2026 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75A63FD1 for ; Mon, 6 Jan 2025 04:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736138083; cv=none; b=G8DuRxWlfAwv+/cqw0J0acw941cuSEClCh0zVVp4GqkUgIAAuXP8eLmf3LVmfi9SBRDQV7wNDLykY5QIG1eCiQWs6KD6gY7lizRqySVPZI4IT9MssWqmwi3WZhtIRZjTY1CQITvn/dPcUlFidhAWb8jvdCfyuUjb7ueawFxuEIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736138083; c=relaxed/simple; bh=CZfqiePgiDIZwl9HmM49abMXtArFA7lzv36AWhpAvlU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VcyJiHNFelmY6hBY9IAvvTTCY7I1+HEwvcUZN2UItPkBS6LdsHXqnEw8YsNJdiq8SCoUGgPCgOfvV2F4UuiMycH+222B1QvmG3JQi6T365JVSmzVMUvkaUfWeTRDjL2CegfJZ2C4Hbf3EvpJg+goLe9KFmZ5P17XdMsQY0rZqw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=VL7mPGwj; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="VL7mPGwj" Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1DE783F1CC for ; Mon, 6 Jan 2025 04:34:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1736138073; bh=ChVHc6ZPzJs71/6njj1CtrhVYKVQFtYsO0ttD5TcL0s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VL7mPGwjoVYibyS6tMz5okqTzp1GBWkzCcoHYVb1mOsS+TFddNJ6ylA/a1EwO/n4P YdUmqfznnp5yJPDfWCd9SOKu1f4xeS4ldP07cmckdVnX+ECTkBlPNcfudy6LV8xK50 7VpOFIa102RgOMZEXaqIeAjzmOyAv2kilRq0K2gUDHrOTAq3vTCGAU2i6y2DzmNGkn Q7sSHShXOwbjuq7DKkqg9TzMT00Q/lMZACwTWTtAZ7UEaanBn79+Q/pX5AH8NS4oWa V1CG906V5B3U6EG6mmlyGqAGNKf+RPd56VEUUtggZ6JQr2BxUKedVWCKtcGGkzL7bD +bWrjwIQI2dhA== Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2167141e00eso189576485ad.2 for ; Sun, 05 Jan 2025 20:34:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736138070; x=1736742870; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ChVHc6ZPzJs71/6njj1CtrhVYKVQFtYsO0ttD5TcL0s=; b=qMHQ0wwA0+lULn/5ZycCcgA9AoCPeqyB5l0f0Djd6rJC8AlD1oSWF9eMebo6T5cwWK xJYpgKa5DWstOfknKJkOVRPdSiWM2IM3iNWQcAZag4Z2sYSEiAf/4wmpV5x9iHnK0+ir FlCwO/o2Zg8+EXzT30KdmW/TTxGUiWUatXpCaCbcPy/pKvGNkYO6SmDmWU9F6xUcABkz Kh0eCuZCHCJyeE5MQ19k2WnbIJPEvw/KFvXB7RPhJAC0jImFI2ylyd9subvNGTPM3PCY 5b98hSFIn4Kgy4FnxY1cjcUIkA7jaKQC8yw2P8WZxABzmNDVHCJtMTk9XU/XzVsN3Un1 835Q== X-Forwarded-Encrypted: i=1; AJvYcCUjcGy98zw1GWH99bKHrdMXjvZnxkgzs/SWsoajk0AVIT5IDQlz6ps4WsUHtJYiU40z6r9+IBJzRLNmCbU=@vger.kernel.org X-Gm-Message-State: AOJu0YyBCgy+sVBVBTx6/U1qV02eaLSFF87IxaUvv+gwD0i+/8rpTh7s c+pQOHdv33wz40GsctD3VXVGsCQElQQNGqsxtCGfUvTah8ySt0hp4uJyQOtTD0a7MMRvhBU18Ny QNvwaN9MxPnCcpL5W51UxxV6GYfr6IN35v468k2/gnm0bUCjc9BxS54iURyksfnP/03xB7+X/m9 EnYg== X-Gm-Gg: ASbGncsuhFvdvZ+VzvnqlGeOY8pCz3jE6a2FsxbtUrVwKI9mGwnNdXiB0+hhXlx7YHd Pm4gFg5+PAoGoxfKdOwhOTVmjFshuol3qpwreuPGG0X4McUSKoD35F0RDEedIYHAf+fdCnU2osE PvuHC9wqomlkM7kAwdS4BqFnsmxecGgKFPsG1/p65ZLq8fT+y3VMFV9IppoHlBx5OtbTJmvgPwd OcdQYNiEjc3ZCS9a310hy8bGmtoQlHLdIpxFM9ye2kZ/OEEkUidnDs0YF9T/M1Y52Dj0/8lW9yr /H54fucAquFR3Xg60hIXKf0= X-Received: by 2002:a17:902:f68a:b0:212:40e0:9562 with SMTP id d9443c01a7336-219e6ebca42mr722689525ad.25.1736138070535; Sun, 05 Jan 2025 20:34:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnSPAHwYB8rvDbD11GERw5Ix73oWQRKk78+dS/rhA+cpA8LkIl25zaAy78WmYEQhKWp7LLHw== X-Received: by 2002:a17:902:f68a:b0:212:40e0:9562 with SMTP id d9443c01a7336-219e6ebca42mr722689205ad.25.1736138070190; Sun, 05 Jan 2025 20:34:30 -0800 (PST) Received: from chengendu.. (118-163-61-247.hinet-ip.hinet.net. [118.163.61.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f6922sm285119695ad.223.2025.01.05.20.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 20:34:29 -0800 (PST) From: Chengen Du To: pjones@redhat.com Cc: konrad@kernel.org, linux-kernel@vger.kernel.org, Chengen Du Subject: [PATCH RESEND] iscsi_ibft: Fix UBSAN shift-out-of-bounds warning in ibft_attr_show_nic() Date: Mon, 6 Jan 2025 12:34:15 +0800 Message-ID: <20250106043415.1966355-1-chengen.du@canonical.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When performing an iSCSI boot using IPv6, iscsistart still reads the /sys/firmware/ibft/ethernetX/subnet-mask entry. Since the IPv6 prefix length is 64, this causes the shift exponent to become negative, triggering a UBSAN warning. As the concept of a subnet mask does not apply to IPv6, the value is set to ~0 to suppress the warning message. Signed-off-by: Chengen Du --- drivers/firmware/iscsi_ibft.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 6e9788324fea..e2c0749f6afa 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -310,7 +310,10 @@ static ssize_t ibft_attr_show_nic(void *data, int type= , char *buf) str +=3D sprintf_ipaddr(str, nic->ip_addr); break; case ISCSI_BOOT_ETH_SUBNET_MASK: - val =3D cpu_to_be32(~((1 << (32-nic->subnet_mask_prefix))-1)); + if (nic->subnet_mask_prefix > 32) + val =3D ~0; + else + val =3D cpu_to_be32(~((1 << (32-nic->subnet_mask_prefix))-1)); str +=3D sprintf(str, "%pI4", &val); break; case ISCSI_BOOT_ETH_PREFIX_LEN: --=20 2.43.0