From nobody Tue Feb 10 23:01:55 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F5DAD24 for ; Mon, 6 Jan 2025 04:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736136716; cv=none; b=g23H96q7dIf0j6/C1QwdtRBw1FjevIZ5XrQR727kZ275SceKNeUjgvLDyoG7B7z71Ph6WIiw1A/KZFe0f853DeA9irODa2FVYMNQX2Lved0uji9dgKjGUQrXmJvj7X5Xm6DfbK2L1lDiKcV6xVr4viWstC+BAikZ7lTmwBgYd44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736136716; c=relaxed/simple; bh=PbLQXkrPtLCpSjHmPhPM+GSirL5Up/b3xhHOXyLYHf0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nJUYceCbv3r9B3lP1hgLpdx6sZoWgNuC2S649sbpATOtXgOyI/KFhsEhTDX8O5lqaQigOtKjkA2XzaaL5p31cBAaIAwXF+IF1ZGwRfziRVOPPOV284RDtGELqHTNzKIjY69Aept3YVpufLyy2tZG1TJ9eLeS64Z8qRQDbDL4Ok4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddvEqhdf; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddvEqhdf" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2f42992f608so15959322a91.0 for ; Sun, 05 Jan 2025 20:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736136714; x=1736741514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XGHWLOWy3xgYZ6nB0NBVlXpvKd+NSKHd4SgyS3eIpJg=; b=ddvEqhdfys3IhIRDOmUAi7A+x10ci3mv9PQEElpwAFpgmbfgyHpQh6trrYgxl1tlK+ /Wb9L5znPZzjacgsOGmuO3MuLmv7PWzt/A4UAKz57Jjl1MTPcHvplmXt0EoCcwvYiTg4 J1H+yLjLUuRnEQsIb+o1xO6GE8JGRhKhHfjG/Gyh1tQPp34K+TMEaTpjXVC5cBO0YtwS F62nmw1Ql90psYCsFWhzpVXPyoJioaaNSSha9ht7TGkagVOmKv3NC8IcP+sPdpYwLpUy 0hCDB7IC2pc+WXnNvvVQEKlwvpNioWDxAKnBus9i2BdCIla4KpY2C/NxMHVoxJPwWp1i bC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736136714; x=1736741514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XGHWLOWy3xgYZ6nB0NBVlXpvKd+NSKHd4SgyS3eIpJg=; b=gmx4ZKKFrgvt67HJ9kqyKQnw4hR0+L/Kw8Jtf0+d0geGHpn+wi7YQUAhtqCpcZKonQ U60f+iDDeke5xlixOs43u1j0ccX8cKCFP2l1K7vscR30vjUOpXOkTtzbb4CTb8cn1tgG fBZsPi7oAypLquiZWdFnT44nyF2KMpw2lt1dETjWJKGqpQHaHf3cbujY3t0SsgLJHtPb CJcTK2g9hOuRrgfO47vxJiAGTo1nr2/V316wQR8GnTi95uIFfqFqHHswzXUsrNV/SLYq sEvNi/HnV7df9GncXgSIdes1AuwmMh3oC9nCgwJBDA9/dhzhoh9kYmxtFZ2igZdnUQ4+ xOpA== X-Forwarded-Encrypted: i=1; AJvYcCXQSx/u+h/yotkFqVfl8NyAlDn8xgZLdXCs7ksNbzmusDmuTBQsuapbNL+Zx+74neqxFOhMwokkjMCFIMg=@vger.kernel.org X-Gm-Message-State: AOJu0YzDHuV+uNKlxp4opjxlfvfsuMaI7gBDC2uQsw/o+2dq9yYqSOGl 45UeWHUgm8fJ5vcfzif4ogWEAX9WaXqRyWcTwbWuUJBwSO49v/xs X-Gm-Gg: ASbGncsgCFop33prCeOdXvoIYCALCHVZBpzafRuiSmxmj8pCZtOgrd1COXxAbfBH3oN XfSyi0SG8uoLW73i7fF4oPX+O4aaIvT0fbTT42qBKHK70/gcobN04nVx230QMM/Q+Cu/uNEk82j FTSoqlr/cP79BrfUrhho5psofLQUqAC/Y53Ezu4E8YGF9lI9eU8Bzlcd1sIJpWk3DXaemYWw8QM JvvFVRqHBYWSkpJUP+C194TU7FLbl/N/uNe9Ct3qcPTdMD7m1vRHjAaz/oieZ9ZMGhDqnd6siYD Czut X-Google-Smtp-Source: AGHT+IEMWxX0/uzzMrHt9tJYZsDsCSuLbXfj8lzaO0dFZsZ1a+TK2FXF0czZXfX8tlc/ooDwcS8SLQ== X-Received: by 2002:a17:90b:544b:b0:2ee:5bc9:75c7 with SMTP id 98e67ed59e1d1-2f452dfcce9mr89650129a91.5.1736136714578; Sun, 05 Jan 2025 20:11:54 -0800 (PST) Received: from distilledx.SRMIST.EDU.IN ([2401:4900:629b:9350:532b:226:f3fe:b873]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f4478aaa74sm32724463a91.45.2025.01.05.20.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 20:11:54 -0800 (PST) From: Tejas Vipin To: jo@jsfamily.in, neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: quic_jesszhan@quicinc.com, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tejas Vipin Subject: [PATCH] drm/panel: ebbg-ft8719: transition to mipi_dsi wrapped functions Date: Mon, 6 Jan 2025 09:41:29 +0530 Message-ID: <20250106041129.114867-1-tejasvipin76@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Changes the ebbg-ft8719 panel to use multi style functions for improved error handling. Signed-off-by: Tejas Vipin Reviewed-by: Douglas Anderson Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 67 ++++++----------------- 1 file changed, 16 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c b/drivers/gpu/drm/pa= nel/panel-ebbg-ft8719.c index e85d63a176d0..0bfed0ec0bbc 100644 --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c @@ -57,65 +57,39 @@ static void ebbg_ft8719_reset(struct ebbg_ft8719 *ctx) static int ebbg_ft8719_on(struct ebbg_ft8719 *ctx) { struct mipi_dsi_device *dsi =3D ctx->dsi; - struct device *dev =3D &dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_brightness(dsi, 0x00ff); - if (ret < 0) { - dev_err(dev, "Failed to set display brightness: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, 0x00ff); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x= 24); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_POWER_SAVE, 0x00); =20 - mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, 0x24); - mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_POWER_SAVE, 0x00); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 90); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi); - if (ret < 0) { - dev_err(dev, "Failed to exit sleep mode: %d\n", ret); - return ret; - } - msleep(90); - - ret =3D mipi_dsi_dcs_set_display_on(dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display on: %d\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } =20 static int ebbg_ft8719_off(struct ebbg_ft8719 *ctx) { struct mipi_dsi_device *dsi =3D ctx->dsi; - struct device *dev =3D &dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_off(dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display off: %d\n", ret); - return ret; - } - usleep_range(10000, 11000); - - ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode: %d\n", ret); - return ret; - } - msleep(90); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 10000, 11000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 90); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int ebbg_ft8719_prepare(struct drm_panel *panel) { struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); - struct device *dev =3D &ctx->dsi->dev; int ret; =20 ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); @@ -126,7 +100,6 @@ static int ebbg_ft8719_prepare(struct drm_panel *panel) =20 ret =3D ebbg_ft8719_on(ctx); if (ret < 0) { - dev_err(dev, "Failed to initialize panel: %d\n", ret); gpiod_set_value_cansleep(ctx->reset_gpio, 1); return ret; } @@ -137,18 +110,10 @@ static int ebbg_ft8719_prepare(struct drm_panel *pane= l) static int ebbg_ft8719_unprepare(struct drm_panel *panel) { struct ebbg_ft8719 *ctx =3D to_ebbg_ft8719(panel); - struct device *dev =3D &ctx->dsi->dev; - int ret; - - ret =3D ebbg_ft8719_off(ctx); - if (ret < 0) - dev_err(dev, "Failed to un-initialize panel: %d\n", ret); =20 + ebbg_ft8719_off(ctx); gpiod_set_value_cansleep(ctx->reset_gpio, 1); - - ret =3D regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); - if (ret) - dev_err(panel->dev, "Failed to disable regulators: %d\n", ret); + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); =20 return 0; } --=20 2.47.1