From nobody Wed Feb 11 06:32:28 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3748F1D5CFF for ; Mon, 6 Jan 2025 03:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736134317; cv=none; b=bDXIOWcYdEKJyZdxSkXDI1vj2oUzi6BbG75Iima0TsYuLhB3EiL+ropV5BtBW6OWCqxp6/YAzMahXcmm+Xm/fZYBobmB/C7ZIcZlfgZdeAY3JBKw6uX/ULcPHhnKc+DQFbzu7Wo4cJ9NDi2e24SJCcaTJx/noTHiHuthL7f3c9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736134317; c=relaxed/simple; bh=TjsGZu1BkZh8/ajVsU6A9ih+QvR83X2ElBnNxJt0u5g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GyR1YwdNtGzfiVt+c642qYcERmIa7dQC7+oSe0rBzVwItQY5s59PAj4CC95JGkUdHfWDJ5w/QU0eFLRCWeLOu41CmeplB+yzpBb/5R8/G8jqtEOncAjSykBgollvQ3uxcQ08HZaHt8sA4w9yWBr9Zrf8mfgHikToItW0xuCb7VI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=cw3mFBp+; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="cw3mFBp+" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2156e078563so171552475ad.2 for ; Sun, 05 Jan 2025 19:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736134304; x=1736739104; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L52rvo+Xinet56DqCazfsooXe+eXMDS7wR/C1rggopk=; b=cw3mFBp+KqTgwsb+zVCwE2I7UlecRFuhcDMdtyWFamERj2wfBHxu0MBEkhkOLbQLOm QGFu7U9vxqvrT5BoztAqLeWmOWieCxvwQh7GRjjPZUqtUZMV+lQSOid1JBGIJhWdNTjX 7VLnxM4zjnk32XCriuchaECoPZdwyG4uhRVI4eHLP4zv5yecmuNbJgXgPL7UD8cr1GLC LOR4bcpsiEIabW6nt0NsdiqKHqorPalMdKFVBBWABgLGEhb48Uu3xaCMf9wcauf9FzqH rEeHCFihIIZNcgr3RYEZiQGfXOKsrGQOewZuQLZDw09rLq/Dtz7djYoNJdDvgwhy1Hr9 WROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736134304; x=1736739104; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L52rvo+Xinet56DqCazfsooXe+eXMDS7wR/C1rggopk=; b=Ao2XURZ3mhtJfftRw2W875pSW05JwmZ8dN8nXcGdbK7dnWun0HbewDU82ljw94XEiq CGYZr0u2V3Oppka6F81OuyHhi8+3PG7PpDOfpQeAkMSH4e08zjBoFMCpKHCzijmQgIML iyYVZ/VYDxY9DMUVqF0lJ9j1m9S4gOMxnPxnjS8knA16RFIOVtbuVJ98gupf3AuLnAcW E0uYE7OnrBZfpG88tS8aGHRzEIV2iqWGOX0wLbu7XCDh2pZ7KRSpt6Vn8bpPdydgwiXL lWCaYvZc2fDHDRV9B1P0gXhyKc4CPbdPEcsZVxXbh6EO1aqk90o8qpL0PZZfpTKAChUv fQxQ== X-Forwarded-Encrypted: i=1; AJvYcCWs7plDaoPrGIajq3xo/66hlt2K1qougSR8/2H1aPaIqzJ6J5SiYVHY3zu/UuHXbUtMKvzDICE6EwrBTMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4aqd3aSy4+mAlfjHIpEqNFmCDDgrtd1ng8HTIoCOb/nwy3P01 twclJFRUjN3lYT0nbJLBnpp2tWnvq8Jffi6HsTfoQ2DupwHYosT5x37Vh+egeWE= X-Gm-Gg: ASbGncvbRMNvIOYbhILZA3SKGovpYRHB3x4dnlyzTRDp3B9ZOFP3MtN1rAI+4wrmUvz Zfgaj9iCm/Zbl8nKIPTFlWZj4x54JTzrCpufqVfcAZECp6pmA8JHpXL5MvrATtQDGaULyukNQYm PV+UWfjGiSUc3js2WHJulGcaw3HRyErYzf659uVcBDu0/6VdJ6C+3sWTrPzTr+VjRIHzPFUT659 7Mco1yKHoLzfJOX2b2/TDqCQRAqMUv+pF7rV2sGTDXEdyXcixV9XKU5qkjxzXiV72uWDzbhVmc0 vArk1sK3lKncxA== X-Google-Smtp-Source: AGHT+IHTDND3pNhNoEGlfFUQ2ez1LpWF/jUmJRoSp+psOxVg/ZgzMtJNsV0Qtt4Wu/gpBrf77MNeZA== X-Received: by 2002:a05:6a20:6f06:b0:1e1:b014:aec9 with SMTP id adf61e73a8af0-1e5e080c77fmr89285785637.29.1736134304340; Sun, 05 Jan 2025 19:31:44 -0800 (PST) Received: from PXLDJ45XCM.bytedance.net ([61.213.176.11]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8dbb87sm30391698b3a.113.2025.01.05.19.31.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jan 2025 19:31:43 -0800 (PST) From: Muchun Song To: muchun.song@linux.dev, brauner@kernel.org, lihongbo22@huawei.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , stable@vger.kernel.org, Cheung Wall Subject: [PATCH] hugetlb: fix NULL pointer dereference in trace_hugetlbfs_alloc_inode Date: Mon, 6 Jan 2025 11:31:17 +0800 Message-Id: <20250106033118.4640-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hugetlb_file_setup() will pass a NULL @dir to hugetlbfs_get_inode(), so we will access a NULL pointer for @dir. Fix it and set __entry->dr to 0 if @dir is NULL. Because ->i_ino cannot be 0 (see get_next_ino()), there is no confusing if user sees a 0 inode number. Fixes: 318580ad7f28 ("hugetlbfs: support tracepoint") Cc: stable@vger.kernel.org Reported-by: Cheung Wall Closes: https://lore.kernel.org/linux-mm/02858D60-43C1-4863-A84F-3C76A8AF1F= 15@linux.dev/T/# Signed-off-by: Muchun Song Reviewed-by: Hongbo Li --- include/trace/events/hugetlbfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/hugetlbfs.h b/include/trace/events/hugetl= bfs.h index 8331c904a9ba8..59605dfaeeb43 100644 --- a/include/trace/events/hugetlbfs.h +++ b/include/trace/events/hugetlbfs.h @@ -23,7 +23,7 @@ TRACE_EVENT(hugetlbfs_alloc_inode, TP_fast_assign( __entry->dev =3D inode->i_sb->s_dev; __entry->ino =3D inode->i_ino; - __entry->dir =3D dir->i_ino; + __entry->dir =3D dir ? dir->i_ino : 0; __entry->mode =3D mode; ), =20 --=20 2.20.1