From nobody Wed Feb 11 05:35:54 2026 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 356D71DE8AF for ; Mon, 6 Jan 2025 13:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170817; cv=none; b=TDo1f2lht1D0wR/bCfC+Fend0+Up+t4R5VX4YiEVGoURfeofdOQmYNz9hmA2RXhFn3NXer+RbYZ+FlzcURMTrcXmsNMhIxMh811a+fpx0m03UbDnl/+ZegYh0/tP1KmFw0f8INCR5i1pTxbY/uuujhN2AvngLEtOLjPOtHh/wpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170817; c=relaxed/simple; bh=/hPtkiqbMiSuYUABeLf0k0X64qWSBh2CcTj5F3/fdPI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f4ElprfIg6/WVvqwnToPhhq+TMgUR+jlNJFnRtQwdrv4bKnErWDdRZLjlR25Blf46uMj5XRSmRLTxJEfTjZU2w1Me/GXMEXwdMs51/gxyB87P+LdiH/Sz3fIiA9mSkfaiQN8gMWM6RJWPdv+8twPdsxoTDY2oHAd1TzrOUAzdJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PAQxFpv9; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PAQxFpv9" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b6e5c74cb7so1030717585a.2 for ; Mon, 06 Jan 2025 05:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736170814; x=1736775614; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OaluQD75i5WN0/M2E9V2xLSR9NLQRzro4V8nhNRsJEo=; b=PAQxFpv9MIGmrwTaRjVIdwABBj58hHScDnH38p+lDl4EVwNoyIoOrdWTWfvpi9x04D KhQCidNj7qaHL0gfXVUUQVleuywVolb9Jmbh4hgjbCrpwoXxgL28jr5b9EZpNulVa8Gy k2pNZmcNOjW1GJMxV+SE/kKt69WQ/iI8ChNFM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736170814; x=1736775614; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OaluQD75i5WN0/M2E9V2xLSR9NLQRzro4V8nhNRsJEo=; b=t5qSQC3BC6XoXXjhuDf5iELRzw6540KezT0qiXjNVRHUnIkPvJVyKpuAKuoP5+GL4M +UN5Vn96bg1/oqI0kgfGzxhA/onIP3N0ZctSgllEZjPZQa7c+mMPn/03i3oOUa8RMZil c+njw7J/e3PbTtIMii8nfFeHWsUA85fC47upsfsg/df0MnARTFrX+Pz7f1OAa/9kh28A SPQF1+g51Svg/zXRKmMBqvKNY/LyZNCwdeS+RlkWgMhuIFKs+iXoLXg5dEtWWpsk64Kj f4Ks3rTr1JAfNKmN+wz+IZ59sioZVc9auAmEEMsOzZ9Unfykn/Fbf2os4fdNpGW4GR4n me9g== X-Forwarded-Encrypted: i=1; AJvYcCWvZGnhXvZBy4W2/5dZVFDTmfBBiJdssktpiWdGsXzUKO2V/9QZJXwM8/unOhUoas6b9VaNupUH6mLQTFo=@vger.kernel.org X-Gm-Message-State: AOJu0YxpSdZ9SajfGs9noJwkTUdaqg1VRHew/5Da48VW2c66QIl7MJSo 42D3v+c5GT4B4sBZhrG6SZLCZvKboij2siFEXvIoUy5PQL9YU2r9NBqjs2xgsw== X-Gm-Gg: ASbGncteAORcoRGjYO9l8a8QCmn0KiplTaDZsUgg8e6WkaUKWL+1+a8x68XEzNOg9h7 NL2f3yH0Ptv2dOZ8YCBUP6yPEwp4n5Dqdu5FZT64h5j+kFBBt8geuFV0JBIlujzYS/nANPISF2+ IagUPBlxkonBrSP/I3xYQfGwJ3tDzoBaHLnaUF5w6auIkIIo3Fxe29JxrwajUJ4Lh0QUtPVq1jt aXA3DTkDW59xLb4tmmyDZvLQJ9yndjj6sN1N1AcV56DIjl0nWIBqYRVFSg5B6eN7Ypio8+1M72W skvA2TU+iCIMUtBLseHNpcy9c/ihEQD48OKB X-Google-Smtp-Source: AGHT+IHv1oIpl6WcfgN36jKDKAWdHfzzIkAbnj9H7EHr8HHbAWlAP6Mwo+/BVH3tIZ5MTc2nhgENBw== X-Received: by 2002:a05:620a:468f:b0:7b6:d050:720f with SMTP id af79cd13be357-7b9ba79ae8bmr10079146685a.22.1736170814275; Mon, 06 Jan 2025 05:40:14 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac478d35sm1501861085a.90.2025.01.06.05.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 05:40:13 -0800 (PST) From: Ricardo Ribalda Date: Mon, 06 Jan 2025 13:40:12 +0000 Subject: [PATCH v4 6/6] media: venus: vdec: Make the range of us_per_frame explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250106-fix-cocci-v4-6-3c8eb97995ba@chromium.org> References: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> In-Reply-To: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. There is no need to do a 64 bit division here. Also, the driver only works with whole fps. Found by cocci: drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a = 64-by-32 division, please consider using div64_u64 instead. Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/vdec.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platf= orm/qcom/venus/vdec.c index 6b8906ced6bc..88f6b5a3a4fe 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -464,7 +464,7 @@ static int vdec_s_parm(struct file *file, void *fh, str= uct v4l2_streamparm *a) struct venus_inst *inst =3D to_inst(file); struct v4l2_captureparm *cap =3D &a->parm.capture; struct v4l2_fract *timeperframe =3D &cap->timeperframe; - u64 us_per_frame, fps; + u64 us_per_frame; =20 if (a->type !=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE && a->type !=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) @@ -486,10 +486,7 @@ static int vdec_s_parm(struct file *file, void *fh, st= ruct v4l2_streamparm *a) if (!us_per_frame || us_per_frame > USEC_PER_SEC) return -EINVAL; =20 - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); - - inst->fps =3D fps; + inst->fps =3D USEC_PER_SEC / (u32)us_per_frame; timeperframe->numerator =3D 1; timeperframe->denominator =3D inst->fps; =20 --=20 2.47.1.613.gc27f4b7a9f-goog