From nobody Tue Feb 10 21:41:07 2026 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 357801DE8B0 for ; Mon, 6 Jan 2025 13:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170818; cv=none; b=LXYUiYki87ZRPRRyUXG8aDP+dtIUeoKHa9UsEEbgBv8gUeksyQuAtkWVqPw/gOA6PTqwGSmdjrrR1XQoaUTQ3MChU2aSPbyI19Or+P5BZjT+qnmINPu2rqmvFcVi4l2evGkJoLMWc0xUD2vbK4NstzTREbLd8dz3GB30ceGRIUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170818; c=relaxed/simple; bh=MKfqw2WVGARyLQAOD8Mt7Dqo3jHse4EHvr4z1KQ2TkE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cHgmQA2G04Shhiv3Mi9nXLt+ZKenAFGbIIcwWXxDuw8k3tmUqAZODmdoxPW/hg5FJsf+m7RHWrf7LINEnPjqncfQFIJgCatHH5XZljJz3TMB+9AhjdUYkES4B17q92FzQfGARw696CQ54XChJcViDf4OPP4c61KqJonZsL7dg1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UJXIyOZD; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UJXIyOZD" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b6f95d2eafso1403643685a.3 for ; Mon, 06 Jan 2025 05:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736170813; x=1736775613; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Fr8YCqaCWwp/Be9W9ht5j9c8BF4MD3nNLHYL3KKI1+A=; b=UJXIyOZDLCqwwJcc9P3iK34i7mE2hQ8APvMppE4KuCMjHuxhaRwK6GuRp4+bDGKjJZ ZOhop9yxWZC5GTrcgVozLT41m3saXmDGHZhk7ndGgvVd6dVWLHZyl5Jlw/liCnUD7raZ i4B9g/Gp7Hwlu7ybTTcNiFmJaSNEL2D+BtBiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736170813; x=1736775613; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fr8YCqaCWwp/Be9W9ht5j9c8BF4MD3nNLHYL3KKI1+A=; b=tZ6ko04GCOBrInNLpBdFp8weuvHSdfy8eJUgfZDo337oPSNwhNUQHRK8ftY7sETJGl jFym37S5w9/bMkPGyeGCfB8yVFJnHkfVwo/r+7Uv3OIsoyv9Px8dEoA4MBKIRjsh7xdk i0qpxm3FvjLRNcMszqTKK8K6Lsr0A85xsTjMUa5iheX243VvU6tg7ZrLakyhCH1q+w96 YO0RX/LWM0DEiy+2MfFWcP4wj2F2cbTBzjIs/ePJiEmsDaQm7b7qqo7/eqPChiJ5nXo1 8Xqo0i/76GKiU9IzUvxKMli84SAIf47I8yl/bgL3zfiW7O9jJvP0kJWt9EF9tJVQmNP7 hr2g== X-Forwarded-Encrypted: i=1; AJvYcCVlZR2/U/qDTB7o5LXkDoxOL4s0hdhaOQTMFyygSkpLCZ6VdSAFRAzIh7hMvWkFG4bAJ+NWleoFynLa16I=@vger.kernel.org X-Gm-Message-State: AOJu0YyfBHUctt0EiYb4FoexQzEApvnhDE5eApf5avARu4P5DV/UzHIq o3wk5yFVfUpLvlnibnY5qbPc4ZKtkEAGFOTJpMRa6WCwSnCo51rlZUg+TefxVQ== X-Gm-Gg: ASbGncu0xw0AE7SSsW2lNlHGgX+vYjyYGPBaxUd700gsfm6Rwcomt59LkHX1/K7+rRj vJmIr5GyPhdIScb+u4A4OJRhalGfGum/55TGGIZaAf6Id8uZLzuSJlNp5Am5qYUiTdFejgMpdBh dW4a/nQggbirSK+O840axeiqC4tcOtt6X3Tn6NCEvz2/vtszAy3swcdi5501X4Jcqo0yGYREADy USduAZriGcmewg9SiwrO3Kf3zckBcyjFYXyOQPLhOH8TUwHAPdZRCGSfXAp3ec6SpISrKujVhtk FHNlvcG3DgnzFOlnGvTlvkoS5TvNwV0Csdjm X-Google-Smtp-Source: AGHT+IHcjB/Pb8QD204DXadECgJD3hF6JOTt0Wc101hAlBe7SX6FDrf39ifHgQZXoKerdzwzAWLNnA== X-Received: by 2002:a05:620a:2805:b0:7b6:ed18:fe2 with SMTP id af79cd13be357-7b9ba79c187mr11546099885a.30.1736170813425; Mon, 06 Jan 2025 05:40:13 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac478d35sm1501861085a.90.2025.01.06.05.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 05:40:13 -0800 (PST) From: Ricardo Ribalda Date: Mon, 06 Jan 2025 13:40:11 +0000 Subject: [PATCH v4 5/6] media: venus: venc: Make the range of us_per_frame explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250106-fix-cocci-v4-5-3c8eb97995ba@chromium.org> References: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> In-Reply-To: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. There is no need to do a 64 bit division here. Also, the driver only works with whole fps. Found with cocci: drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a = 64-by-32 division, please consider using div64_u64 instead. Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/venc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platf= orm/qcom/venus/venc.c index 8355bd59a5c2..5683a04bdc14 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -393,7 +393,7 @@ static int venc_s_parm(struct file *file, void *fh, str= uct v4l2_streamparm *a) struct venus_inst *inst =3D to_inst(file); struct v4l2_outputparm *out =3D &a->parm.output; struct v4l2_fract *timeperframe =3D &out->timeperframe; - u64 us_per_frame, fps; + u64 us_per_frame; =20 if (a->type !=3D V4L2_BUF_TYPE_VIDEO_OUTPUT && a->type !=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) @@ -414,14 +414,10 @@ static int venc_s_parm(struct file *file, void *fh, s= truct v4l2_streamparm *a) if (!us_per_frame || us_per_frame > USEC_PER_SEC) return -EINVAL; =20 - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); - - inst->fps =3D fps; + inst->fps =3D USEC_PER_SEC / (u32)us_per_frame; timeperframe->numerator =3D 1; timeperframe->denominator =3D inst->fps; =20 - return 0; } =20 --=20 2.47.1.613.gc27f4b7a9f-goog