From nobody Tue Feb 10 17:08:41 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ECD11DD0DC for ; Mon, 6 Jan 2025 13:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170814; cv=none; b=gUQr9C1UTRrzLrgezYsXmPP7jm8iV7XdJUg6lQwBOk9k6AsPKpLWK7qiTFt/CZfSoJehXFT6Uneiub5gqZN4pcr5Sr4rnq2s3IEpexP6xht8k3quskQ3EUlwO+xk1OXZjvtpSMxwxZPWH49MKn/Z0MQJn6tijzWqTmLWTFWpoEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170814; c=relaxed/simple; bh=6S98sC9zb379SpXjPj44qvbnzAChVkkYXuoHqOebMyY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fie+LFK+KRqD4hsttGqd7KOw1TVHefDdZuP8y3JULLGfazV/599z3MiglYVsy1PrsEcUyg0UcZu3CYPBhyXtXyoOTK07qAxkVopXupaAQUai3YiehUPw6mJPUI+76aw5EwMJD4hnIFuVZT2gNYZGz5g8AvTBeukwPZtwkmAF37Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=kncgcZxE; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kncgcZxE" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7b6f53c12adso1151845485a.1 for ; Mon, 06 Jan 2025 05:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736170811; x=1736775611; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1sua/H7q/HxBmtn5ehYvB6xIDSURBEgE+eseMuH9rt0=; b=kncgcZxE+nBN/bBF+yiZX3cdt+EhOgfulXyNO8OT6URRm2wHJFX5LnH/1LaVH81cxH wKO54jBDLv3VQ1vjsWJIb4f5SUHhVrmGISlKnT3S7TzbLB5FN8ocZkkLe5lHXmL1AGaC kCTFK4/URJCBqLYNKduqa16gpwyYMMUVyWyKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736170811; x=1736775611; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1sua/H7q/HxBmtn5ehYvB6xIDSURBEgE+eseMuH9rt0=; b=lSKcj7zIUL3xo97spYevsQV16hnQDAarjmn5ngIaPXTSZ6mWpcVsLLtfkLgl1oPKwL 5DYYTOmaXYyJC0pAMtAGfyb5VjBZ4z1z9iWpdgpYKUSbSqyC2DF5mL1aXPI+auxLMMYh +IDhpTkbohVvpJTCPt1Doy3Sj8RcJu+sDjvpI6K0sFlUBnRq5totW6y+DfuQoFhMrd8a uAj/JkTpdqHz1FkQ95pOCqYJ6onGl8D3PRHJpM28lv1KGKvIT0NQuAUaiB+vTbE20R6U vKf16H0qpyDbHCSWIL770LagARC4+R3lzdsLN1DustToV/1tqVBP4T3/HimiLWGiyNYt T+5w== X-Forwarded-Encrypted: i=1; AJvYcCXt4p4TQhuFSp6L87Uek+3vgkovnvd/sgWrOBqCD1qpYG/T8fY7i2zq7ttFcwa0+mCTE7f7z8B9McN+0CE=@vger.kernel.org X-Gm-Message-State: AOJu0YzAY68f4UPWnQjPSpzLaxQfzuB9ucGOF1wdnXnUXzSg1s3sylVA Bq+ZAvZttTbPLwGxeqZUjdN40ibtdUPwTiMCDUQ/LJUFivA1eOf7YManCCzFOQ== X-Gm-Gg: ASbGncuKxxIz/9rHJ7yRdOGXNjzZvrhWOLPP4m8WW6P+5rpMJaT4EwZK0HAcytOviyF CMrACiRs6s2kZe8rvzWGOhF/OBG3JRF1abVQtOHfVBJpnwB/KSacENnSiRw0xGjVqQCGiZiZ2wr a5t8jcMI+X6opB9BdW9iufcz5wIbPnJjDHy7/FnP7x/KdcNP1GqKs/c8zNO4djrMkgnUWVfph/O 7bjPSpZsUJ0eexDNjKgNowrXdwnyndyb/p9k/adVfVV7G5MexBIlR/oUy1X2ZC6bqxNTnYEfxDb eGeNwyI5cyeZl0otZUaCKSSrcGkx1nJzHL9B X-Google-Smtp-Source: AGHT+IHL/i9PYol7/BeTRyIFkBBCg5WCtmISC7fUpGW6mAhMPY0gQu9kkKdiaUQVy0qOM3paHIXmwA== X-Received: by 2002:a05:620a:4410:b0:7b6:ea22:3069 with SMTP id af79cd13be357-7b9ba79c26fmr8894375485a.26.1736170811310; Mon, 06 Jan 2025 05:40:11 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac478d35sm1501861085a.90.2025.01.06.05.40.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 05:40:10 -0800 (PST) From: Ricardo Ribalda Date: Mon, 06 Jan 2025 13:40:09 +0000 Subject: [PATCH v4 3/6] media: venus: venc: Ignore parm smaller than 1fps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250106-fix-cocci-v4-3-3c8eb97995ba@chromium.org> References: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> In-Reply-To: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stanimir Varbanov , linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The driver uses "whole" fps in all its calculations (e.g. in load_per_instance()). Return -EINVAL if the user provides a parm that will result in 0 whole fps. Reported-by: Hans Verkuil Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147= 453e4@xs4all.nl/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0 Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files") Signed-off-by: Ricardo Ribalda Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/venus/venc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platf= orm/qcom/venus/venc.c index c1c543535aaf..bd967d60c883 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -411,7 +411,7 @@ static int venc_s_parm(struct file *file, void *fh, str= uct v4l2_streamparm *a) us_per_frame =3D timeperframe->numerator * (u64)USEC_PER_SEC; do_div(us_per_frame, timeperframe->denominator); =20 - if (!us_per_frame) + if (!us_per_frame || us_per_frame > USEC_PER_SEC) return -EINVAL; =20 fps =3D (u64)USEC_PER_SEC; --=20 2.47.1.613.gc27f4b7a9f-goog