From nobody Wed Feb 11 07:50:12 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB90A156257 for ; Sun, 5 Jan 2025 17:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097469; cv=none; b=gohiWWf3nTSo+rMt9IH+V2YwFH3DxDJ4Kwynp8qdRlPlZAaM7WVK3IYRJ8q3oNc3nxFHV/+aYdVms4B/Rr1phNLv4HJ1gFBhmSPpVyFeeNhezc/R09RNzGhmjl889MRp1ZcjedG8VYfu9gVyXfcgKfa0iNGn/XtphpgMszZOLcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097469; c=relaxed/simple; bh=ugPkk0xuE0DOxXifT7SkqrrxnsW/tCcCapkBSno8/CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HCSIvcPPvdSieEPS4/LYA5jnhmJhFI6y2Wz7dHCbet4PPA2TN8Oi6g/21bz+aWKQCvX4YgqiewNnxLIOurKNetsR2ejFKpTsG6qr7OzE7MrcfprsZyeb9DC+ohru54KM253UG6DWkXDuVmdrBIHb9OEJnVjxzlsgnMdTgMmX6nM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ga6m5Bvr; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ga6m5Bvr" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38a34e8410bso4421495f8f.2 for ; Sun, 05 Jan 2025 09:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736097466; x=1736702266; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J0GjmDNgFtYMS4CNHIpakXuXjn5IlFWM6hL+vU1HdSU=; b=Ga6m5BvrEKb28exxJk19qSdosVcDzbLh14fLb7PyFGglhMGrKbeJcVLzkgqLeJakWm 1GV9BxvuZ7Nl1lRJj+1Wh3wXsZwlQpF12uQhxR9nRs9zvT180GNalr2VAw7ErLwOb846 M9l1UYuxHAsQEmmzaJkv/dkgwGtDe5Icx09jk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736097466; x=1736702266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0GjmDNgFtYMS4CNHIpakXuXjn5IlFWM6hL+vU1HdSU=; b=KqFT+uddJv3lByLI1ErzpUR2du14+nCrlITeuPGs6lykoI9+MM/d/Z8ah8R+H+vSnn QHssQa7t/TbJjdvfiCkOndb1IzhD4QSir3cfAHFyGhC7U/ibOcWA/Z7Lkpimn14pgbl7 0BJqWgkld0Aa6gMicM07TYeLT1YVllmQOYkfv+Uz0N/cmRkm0sqrp4ybbb/P7EkYbvFO NeNRvfU4ydTxQxWCyqwHA3i6tAQQy6l65SBiPDnF5T24aPToWpf8UpKmFdf/at1bgDVt Lw/ElNY5fPzb6InhBIfcAe5P/LtcwRZ6WhfuRz0gkC0VBBW/hj83vQyW+240O1qjArl2 2v3w== X-Forwarded-Encrypted: i=1; AJvYcCX9LQwuF1tGBVRMUziTCOFS2lHv7h165NPLpmbuo0bcP6pP0G7rBs61mO1qieXIZ2Bpdl3pMKyjEkO5oNA=@vger.kernel.org X-Gm-Message-State: AOJu0YzV3La8f09MBv/i2IcrfVJ85iLI6uxUDYIHidMoO5SP8/A7A7wP 9m7xRtAGOBVwechdEx0lIcoAd5r2N6I26L9s2UFayc50/796p0CoSFkP4Prgiw== X-Gm-Gg: ASbGncuboWuxr6kPd9i/6GoQa7I61SBD1aPnpJt6qv5Daxyl9tNfJQgpUpqGL5LVEUm 78qebkmdmy06reuJ7l3lcC7/bnu1Rc1cNp1KOoNEnAcQoyNYQhQ9pbYVHRm1Oc1znd9Q75aWvI/ 857qprB5/d/A2wt4cbvOSdCMApP/oD6BfbzVLgPv4W6g6MFE/hDBUza841PzHWC2CNTsDuY6ZPs EvX1llZj3GCtgxm+ksjfeNILrcevrFH761p5+NspobLXegiyWT4wMz0IKOXWbez+B43EAxDN3Yu qVkWgIdY460OLc6JKWCeu7PjbvYbC0lZNI+Q X-Google-Smtp-Source: AGHT+IEcXFCNnO/fDAJP7+xy9vBl4+PVAh17+298KO0qXQqMn4ReiFb8r6IoYitgvJxcYVbT9bnTOw== X-Received: by 2002:a5d:5e09:0:b0:385:e38f:8cc with SMTP id ffacd0b85a97d-38a223ffa1emr45639718f8f.38.1736097466136; Sun, 05 Jan 2025 09:17:46 -0800 (PST) Received: from dmaluka.c.googlers.com.com (19.50.76.34.bc.googleusercontent.com. [34.76.50.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436604e9c2csm543987345e9.43.2025.01.05.09.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 09:17:45 -0800 (PST) From: Dmytro Maluka To: Thomas Gleixner , Rob Herring Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Saravana Kannan , Saurabh Sengar , Usama Arif , Stephen Boyd , Frank Rowand , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE), =?UTF-8?q?Pierre-Cl=C3=A9ment=20Tosi?= , Shikha Panwar , Will Deacon , Keir Fraser , Michal Mazurek , =?UTF-8?q?Bart=C5=82omiej=20Grzesik?= , Tomasz Nowicki , Grzegorz Jaszczyk , Dmytro Maluka Subject: [PATCH 1/2] x86/of: Don't use DTB for SMP setup if ACPI is enabled Date: Sun, 5 Jan 2025 17:16:42 +0000 Message-ID: <20250105171643.3473702-2-dmaluka@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20250105171643.3473702-1-dmaluka@chromium.org> References: <20250105171643.3473702-1-dmaluka@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are cases when it is useful to use both ACPI and DTB provided by the bootloader, however in such cases we should make sure to prevent conflicts between the two. Namely, don't try to use DTB for SMP setup if ACPI is enabled. Precisely, this prevents at least: - incorrectly calling register_lapic_address(APIC_DEFAULT_PHYS_BASE) after the LAPIC was already successfully enumerated via ACPI, causing noisy kernel warnings and probably potential real issues as well - failed IOAPIC setup in the case when IOAPIC is enumerated via mptable instead of ACPI (e.g. with acpi=3Dnoirq), due to mpparse_parse_smp_config() overridden by x86_dtb_parse_smp_config() Signed-off-by: Dmytro Maluka --- arch/x86/kernel/devicetree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c index 59d23cdf4ed0..dd8748c45529 100644 --- a/arch/x86/kernel/devicetree.c +++ b/arch/x86/kernel/devicetree.c @@ -2,6 +2,7 @@ /* * Architecture specific OF callbacks. */ +#include #include #include #include @@ -313,6 +314,6 @@ void __init x86_flattree_get_config(void) if (initial_dtb) early_memunmap(dt, map_len); #endif - if (of_have_populated_dt()) + if (acpi_disabled && of_have_populated_dt()) x86_init.mpparse.parse_smp_cfg =3D x86_dtb_parse_smp_config; } --=20 2.47.1.613.gc27f4b7a9f-goog