From nobody Wed Feb 11 07:50:10 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB90A156257 for ; Sun, 5 Jan 2025 17:17:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097469; cv=none; b=gohiWWf3nTSo+rMt9IH+V2YwFH3DxDJ4Kwynp8qdRlPlZAaM7WVK3IYRJ8q3oNc3nxFHV/+aYdVms4B/Rr1phNLv4HJ1gFBhmSPpVyFeeNhezc/R09RNzGhmjl889MRp1ZcjedG8VYfu9gVyXfcgKfa0iNGn/XtphpgMszZOLcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097469; c=relaxed/simple; bh=ugPkk0xuE0DOxXifT7SkqrrxnsW/tCcCapkBSno8/CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HCSIvcPPvdSieEPS4/LYA5jnhmJhFI6y2Wz7dHCbet4PPA2TN8Oi6g/21bz+aWKQCvX4YgqiewNnxLIOurKNetsR2ejFKpTsG6qr7OzE7MrcfprsZyeb9DC+ohru54KM253UG6DWkXDuVmdrBIHb9OEJnVjxzlsgnMdTgMmX6nM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ga6m5Bvr; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ga6m5Bvr" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-38a34e8410bso4421495f8f.2 for ; Sun, 05 Jan 2025 09:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736097466; x=1736702266; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J0GjmDNgFtYMS4CNHIpakXuXjn5IlFWM6hL+vU1HdSU=; b=Ga6m5BvrEKb28exxJk19qSdosVcDzbLh14fLb7PyFGglhMGrKbeJcVLzkgqLeJakWm 1GV9BxvuZ7Nl1lRJj+1Wh3wXsZwlQpF12uQhxR9nRs9zvT180GNalr2VAw7ErLwOb846 M9l1UYuxHAsQEmmzaJkv/dkgwGtDe5Icx09jk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736097466; x=1736702266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J0GjmDNgFtYMS4CNHIpakXuXjn5IlFWM6hL+vU1HdSU=; b=KqFT+uddJv3lByLI1ErzpUR2du14+nCrlITeuPGs6lykoI9+MM/d/Z8ah8R+H+vSnn QHssQa7t/TbJjdvfiCkOndb1IzhD4QSir3cfAHFyGhC7U/ibOcWA/Z7Lkpimn14pgbl7 0BJqWgkld0Aa6gMicM07TYeLT1YVllmQOYkfv+Uz0N/cmRkm0sqrp4ybbb/P7EkYbvFO NeNRvfU4ydTxQxWCyqwHA3i6tAQQy6l65SBiPDnF5T24aPToWpf8UpKmFdf/at1bgDVt Lw/ElNY5fPzb6InhBIfcAe5P/LtcwRZ6WhfuRz0gkC0VBBW/hj83vQyW+240O1qjArl2 2v3w== X-Forwarded-Encrypted: i=1; AJvYcCX9LQwuF1tGBVRMUziTCOFS2lHv7h165NPLpmbuo0bcP6pP0G7rBs61mO1qieXIZ2Bpdl3pMKyjEkO5oNA=@vger.kernel.org X-Gm-Message-State: AOJu0YzV3La8f09MBv/i2IcrfVJ85iLI6uxUDYIHidMoO5SP8/A7A7wP 9m7xRtAGOBVwechdEx0lIcoAd5r2N6I26L9s2UFayc50/796p0CoSFkP4Prgiw== X-Gm-Gg: ASbGncuboWuxr6kPd9i/6GoQa7I61SBD1aPnpJt6qv5Daxyl9tNfJQgpUpqGL5LVEUm 78qebkmdmy06reuJ7l3lcC7/bnu1Rc1cNp1KOoNEnAcQoyNYQhQ9pbYVHRm1Oc1znd9Q75aWvI/ 857qprB5/d/A2wt4cbvOSdCMApP/oD6BfbzVLgPv4W6g6MFE/hDBUza841PzHWC2CNTsDuY6ZPs EvX1llZj3GCtgxm+ksjfeNILrcevrFH761p5+NspobLXegiyWT4wMz0IKOXWbez+B43EAxDN3Yu qVkWgIdY460OLc6JKWCeu7PjbvYbC0lZNI+Q X-Google-Smtp-Source: AGHT+IEcXFCNnO/fDAJP7+xy9vBl4+PVAh17+298KO0qXQqMn4ReiFb8r6IoYitgvJxcYVbT9bnTOw== X-Received: by 2002:a5d:5e09:0:b0:385:e38f:8cc with SMTP id ffacd0b85a97d-38a223ffa1emr45639718f8f.38.1736097466136; Sun, 05 Jan 2025 09:17:46 -0800 (PST) Received: from dmaluka.c.googlers.com.com (19.50.76.34.bc.googleusercontent.com. [34.76.50.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436604e9c2csm543987345e9.43.2025.01.05.09.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 09:17:45 -0800 (PST) From: Dmytro Maluka To: Thomas Gleixner , Rob Herring Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Saravana Kannan , Saurabh Sengar , Usama Arif , Stephen Boyd , Frank Rowand , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE), =?UTF-8?q?Pierre-Cl=C3=A9ment=20Tosi?= , Shikha Panwar , Will Deacon , Keir Fraser , Michal Mazurek , =?UTF-8?q?Bart=C5=82omiej=20Grzesik?= , Tomasz Nowicki , Grzegorz Jaszczyk , Dmytro Maluka Subject: [PATCH 1/2] x86/of: Don't use DTB for SMP setup if ACPI is enabled Date: Sun, 5 Jan 2025 17:16:42 +0000 Message-ID: <20250105171643.3473702-2-dmaluka@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20250105171643.3473702-1-dmaluka@chromium.org> References: <20250105171643.3473702-1-dmaluka@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are cases when it is useful to use both ACPI and DTB provided by the bootloader, however in such cases we should make sure to prevent conflicts between the two. Namely, don't try to use DTB for SMP setup if ACPI is enabled. Precisely, this prevents at least: - incorrectly calling register_lapic_address(APIC_DEFAULT_PHYS_BASE) after the LAPIC was already successfully enumerated via ACPI, causing noisy kernel warnings and probably potential real issues as well - failed IOAPIC setup in the case when IOAPIC is enumerated via mptable instead of ACPI (e.g. with acpi=3Dnoirq), due to mpparse_parse_smp_config() overridden by x86_dtb_parse_smp_config() Signed-off-by: Dmytro Maluka --- arch/x86/kernel/devicetree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c index 59d23cdf4ed0..dd8748c45529 100644 --- a/arch/x86/kernel/devicetree.c +++ b/arch/x86/kernel/devicetree.c @@ -2,6 +2,7 @@ /* * Architecture specific OF callbacks. */ +#include #include #include #include @@ -313,6 +314,6 @@ void __init x86_flattree_get_config(void) if (initial_dtb) early_memunmap(dt, map_len); #endif - if (of_have_populated_dt()) + if (acpi_disabled && of_have_populated_dt()) x86_init.mpparse.parse_smp_cfg =3D x86_dtb_parse_smp_config; } --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Wed Feb 11 07:50:10 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD2AC1586C8 for ; Sun, 5 Jan 2025 17:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097471; cv=none; b=UC2aIBaOPJdj5Z/udySq0cNJWK47dnQ1cG44ONItBRxCgawjpvE3TxG5i5+DCaRJfCJsGDYA3uLi7hYt1R14/Ea4HRMXA8d2Znf0WQx5cknzWtQ/hcpqNVCBZjoOHo0o+Kz2AV8cSIBYey3plXcmaSYmUlpT2Ox3pRVyYEjvy7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736097471; c=relaxed/simple; bh=cQimmwB3iNQGTyLREuAKfsmql7piInL4jdzSszYRtYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MrJZA6CSIjC2g/nPKACSI9orXnktYiQ397MtD5WQ+0qQlh78nSbaI+z7rLfiBIM1bJ962TH49Y0zALZCqUZ6nbXLNKpIdeHt5oFaSUA/LiVL+7niTgKVTuUU/RNQA7/Ct1uP9QUialEDwNM2j8bzjTsxak24svXNpNkUT2hRvqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=lq2YNxLE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lq2YNxLE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43634b570c1so97781195e9.0 for ; Sun, 05 Jan 2025 09:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736097468; x=1736702268; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=waaXYIjfvBCsra9ANlbbeFiP++cQQ67tbxpqxfXM0M8=; b=lq2YNxLEkAdCaNEX8yh8eUA6/Yj1p0J/4mZUxrhwALwEL1UL+rSnspjEvK52zoW8pX BCVRDPCmmL6abhDGYbSF23ePm63ZdZcWhhsaIvtvFcKJqvbSEWIG7W81ecNqX6nPRtgh cN6uTF6AbbdW+SRsR1f7xZCWx0Cvw/NoBmtXg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736097468; x=1736702268; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=waaXYIjfvBCsra9ANlbbeFiP++cQQ67tbxpqxfXM0M8=; b=QLJBZwVblb42I3gBdSIczvjpQ/YKrMPbaT98ERDOgYt8J/07SatqxD8aVwI9A+JLu7 IQ5TIgI0tim4ypUFwxaPg9J241u87rLIvt4HptNDv8Sf6nYWplyA/wq63IT+Qy1twyf/ WqUyVFDi8ytrUR4ZeWlP4zu3uGcrvDF2BG2QIxlF/9nOzmDLJ+Sa385oXolocXi5IYrz mByHcJp2q04QnAOIwgGVceDuv40qU5QoOTXHknHg1OMRC6arzoqhgeq24Kw3KAnjYWJM dv78BIw4eQiKyTNmydSwtGm6dS4u/2dzcVgtinLWeopJ0AXyg89V2XAfd+T1boCB075E DR/A== X-Forwarded-Encrypted: i=1; AJvYcCX8ddEgyH02UgHKCziBGG8sXyXhJj/3F3W5c/rkI05aMShpmj7kpOW0p3HIvrcq7imD9GvsYazTXqy6AnY=@vger.kernel.org X-Gm-Message-State: AOJu0YzkxoKfGUWUF8aRNeKa/PQX3hFtTJ71UYsAEv3kyqI92zSyFiVe VOVh1W1lSY9JinWC/wvszT3nkXrz/F1k7s29txb5VNKnyYJ88rrHbZnqZEsCTA== X-Gm-Gg: ASbGncv8SWiBrBXGYS6YUyc3VDaL9JbpARuQlil9pkku/a/e0GP8ZSxd/GLquUjzN7W lxltY3p3ZDmA7GFEyqffVSWVDLmEXxvnfWh/bg2rGFIrurYt7WHpo+iqFJZQO+mZKZCjG1zO83p j7rbXN5b1UpB+mA1LC3MWz8QJqLwzP+MfdeNMtoPG7JCuyXc4nrCX1Pbn75nB/BpiCfjkb1BGHm Jv+/LQs0NKdsiYKsBGKuZstFzD4oPljhnbb6LR9JYPQuXhE1BIeOpPjhOFLQ8UyoRWb8ixOQ+p5 THvJHHawUdx09e0t6frVPoF14++B809B27GO X-Google-Smtp-Source: AGHT+IFjcKrCEMvuHlallteEPNM9uk2psdNLjspH7AZMYWR56bzbdDPjejh5DZKCGH0JiZAnpORCrA== X-Received: by 2002:a05:600c:1c87:b0:434:ffe3:bc7d with SMTP id 5b1f17b1804b1-4366864646fmr484161975e9.16.1736097468068; Sun, 05 Jan 2025 09:17:48 -0800 (PST) Received: from dmaluka.c.googlers.com.com (19.50.76.34.bc.googleusercontent.com. [34.76.50.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436604e9c2csm543987345e9.43.2025.01.05.09.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 09:17:47 -0800 (PST) From: Dmytro Maluka To: Thomas Gleixner , Rob Herring Cc: Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , Saravana Kannan , Saurabh Sengar , Usama Arif , Stephen Boyd , Frank Rowand , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE), =?UTF-8?q?Pierre-Cl=C3=A9ment=20Tosi?= , Shikha Panwar , Will Deacon , Keir Fraser , Michal Mazurek , =?UTF-8?q?Bart=C5=82omiej=20Grzesik?= , Tomasz Nowicki , Grzegorz Jaszczyk , Dmytro Maluka Subject: [PATCH 2/2] of/fdt: Restore possibility to use both ACPI and FDT from bootloader Date: Sun, 5 Jan 2025 17:16:43 +0000 Message-ID: <20250105171643.3473702-3-dmaluka@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20250105171643.3473702-1-dmaluka@chromium.org> References: <20250105171643.3473702-1-dmaluka@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are cases when the bootloader provides information to the kernel in both ACPI and DTB, not interchangeably. One such use case is virtual machines in Android. When running on x86, the Android Virtualization Framework (AVF) boots VMs with ACPI like it is usually done on x86 (i.e. the virtual LAPIC, IOAPIC, HPET, PCI MMCONFIG etc are described in ACPI) but also passes various AVF-specific boot parameters in DTB. This allows reusing the same implementations of various AVF components on both arm64 and x86. Commit 7b937cc243e5 ("of: Create of_root if no dtb provided by firmware") removed the possibility to do that, since among other things it introduced forcing emptying the bootloader-provided DTB if ACPI is enabled (probably assuming that if ACPI is available, a DTB can only be useful for applying overlays to it afterwards, for testing purposes). So restore this possibility. Instead of completely preventing using ACPI and DT together, rely on arch-specific setup code to prevent using both to set up the same things (see various acpi_disabled checks under arch/). Fixes: 7b937cc243e5 ("of: Create of_root if no dtb provided by firmware") Signed-off-by: Dmytro Maluka --- drivers/of/fdt.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 0121100372b4..3b29a5c50e2e 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -8,7 +8,6 @@ =20 #define pr_fmt(fmt) "OF: fdt: " fmt =20 -#include #include #include #include @@ -1215,14 +1214,7 @@ void __init unflatten_device_tree(void) /* Save the statically-placed regions in the reserved_mem array */ fdt_scan_reserved_mem_reg_nodes(); =20 - /* Don't use the bootloader provided DTB if ACPI is enabled */ - if (!acpi_disabled) - fdt =3D NULL; - - /* - * Populate an empty root node when ACPI is enabled or bootloader - * doesn't provide one. - */ + /* Populate an empty root node when bootloader doesn't provide one */ if (!fdt) { fdt =3D (void *) __dtb_empty_root_begin; /* fdt_totalsize() will be used for copy size */ --=20 2.47.1.613.gc27f4b7a9f-goog