From nobody Thu Feb 12 20:18:12 2026 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 524CD1D618A for ; Sat, 4 Jan 2025 20:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736024115; cv=none; b=k3nZU+Ca7LuQPfhEVLf8Ov7gIym8FK0mixfUQ5LmWSXFgAXVwKtUq2G4YbLMbQtMEMN2mHIbqPoXJmBv/PYIEh8vy9kWxGrf3TvgCPpoeFIbtoaLFUMWZaPGZ9KtiZlAF60JcyuNM9m9GFfV/1sX0uXEYmMeOJTJ2uWL+xbuGMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736024115; c=relaxed/simple; bh=Xn/kRMOeY30BbZdhigNGOrSGfeTCnFdlp6m/DcAWf0s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PFqrYCqjehW64uKSeGVJ6fR/yR0gA6nCjBbjhS7lOk1SbdAjG4cqIKJ7fcLPIUvFZ1pDdmuWsdTisFqDr1SuiYT2fDCTYs/3Oe9ntuK7lcWO6On0BKEpNusrCVee0/uUL24pTgVZ9WnVRDCgzDR5ivrdzeC8A+A+Hw8CtloH1xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mc/65IQt; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mc/65IQt" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5d3cfa1da14so2758605a12.1 for ; Sat, 04 Jan 2025 12:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736024111; x=1736628911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WDsJNqlpSJNNawMf3Py4v8MhzkVez917T1reSgeDSXg=; b=mc/65IQt+2MM5+Npo75wBtMSx6g+8NOZFzOlD+Dw7oTdp0pA7GpEGSXm2g4NkLTknf F+PtkoINvl3oa1jPYy+Ukdso7u5+Xk9iurumY3BsUOlMxifPaBeJf9VGRtgMhW6PQbis axV0Lf/OWMZQ4gIBpFfiKoZWevTaDUuihI2sh6fvgxqQjykh8ikUOu6vrbxKsz2ZkTnc UYsPh9aaVUlpLF8uzky8frWKcmZNNj47DvcMYHmQlz/3i3usl+MinEfRZE0vD4UBMU7h GccCKA0sCMna8eZ62S4Vb29y/cf1Bwo6/1re6nZ0OZLkn0eTaUUTtLVhJLpgCiFyIdab LCDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736024111; x=1736628911; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WDsJNqlpSJNNawMf3Py4v8MhzkVez917T1reSgeDSXg=; b=L/xsWyL4zHcZxabJ76csScvhBc58ASsLCdqzQAUZ9clKavVfhHo4G7a/IEGYNdk5lK sKsepjrAqiCDkJYCcxomWXWNd6hW5V4725KIdcNZB5wjA6n74UNk6VidpE0K8T6PBMeq F2vP3f9QhBKgvR4LCq6lzTRSK+NMucySZr5fgySHrds7r3TOWX5Rd2KMGGM9Buc/3yQu 3sGa17ZdP3HSqNVwLsObjIsRGQFLxKBP8S+DM6jHMWrx9HA6GsodlFNaulVAvfGXLJkv yIAd1Y8um6D4gymRCy0OBg7klk3jiclR+JWCffn2yPTaAnI5fxyflEoFXbm4oYux4DRb dquA== X-Forwarded-Encrypted: i=1; AJvYcCVUb3I/Qoqrprha+Fxj6to5NdIPvS7pO7TYmWBCkY3NOwpkCvc+Xz8Prd5VVEZZ82V45L0eQzqSPa7W0I4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3vHQC4DegmiqXsxf4YmMSsvmagUbnXm0EJRJq48CdqmiA6tNI gyERfGcqGljNF+LgijO6ZVofsfOpnWSkAOLZkeTWjNoODK/pbrjgJrOLNO9rbikhK3AkW7uWU5U 2 X-Gm-Gg: ASbGncsPJZJl/7rLt9eS8ZFYpKb4ik1IAszW22YwS5kfEBJWRkZ3nV/UItuzhUqyAIT UxFvLEfHblCoQ2R2L/2m4AZq2BxtMXuVP0o0vJlTuE31oI9IQxtAwq69fT6yw4nu5/Kw8cNDgLq utzYKxi95NEcrABmlPLqlUp7kkYz8CtLC7zwPoSXCsIC/wnVlkwPZJirzmthT47AUBbraVaHoos grALzhu+njFgFckdkGNf8MLJYsBlp+UW7h6Me0NIewkwlnqv5Tp2KIY3FCjuQ21Xi3gVQo= X-Google-Smtp-Source: AGHT+IHWTvEbFyBXzG9e8FsP0ij+GiuUSqKpGVu0O1LuszPhiJHSeY0kaqUmQ0J/IbFid0QVoi6aLA== X-Received: by 2002:a17:906:7951:b0:aa5:a36c:88f0 with SMTP id a640c23a62f3a-aac3378e312mr1546765566b.12.1736024109719; Sat, 04 Jan 2025 12:55:09 -0800 (PST) Received: from krzk-bin.. ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0eae3a7bsm2050315466b.83.2025.01.04.12.55.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 12:55:08 -0800 (PST) From: Krzysztof Kozlowski To: Herbert Xu , "David S. Miller" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Cc: Krzysztof Kozlowski Subject: [PATCH] crypto: bcm - Drop unused setting of local 'ptr' variable Date: Sat, 4 Jan 2025 21:55:02 +0100 Message-ID: <20250104205502.184869-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" spum_cipher_req_init() assigns 'spu_hdr' to local 'ptr' variable and later increments 'ptr' over specific fields like it was meant to point to pieces of message for some purpose. However the code does not read 'ptr' at all thus this entire iteration over 'spu_hdr' seams pointless. Reported by clang W=3D1 build: drivers/crypto/bcm/spu.c:839:6: error: variable 'ptr' set but not used [-= Werror,-Wunused-but-set-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/crypto/bcm/spu.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c index 6283e8c6d51d..86c227caa722 100644 --- a/drivers/crypto/bcm/spu.c +++ b/drivers/crypto/bcm/spu.c @@ -836,7 +836,6 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher= _parms *cipher_parms) u32 cipher_bits =3D 0; u32 ecf_bits =3D 0; u8 sctx_words =3D 0; - u8 *ptr =3D spu_hdr; =20 flow_log("%s()\n", __func__); flow_log(" cipher alg:%u mode:%u type %u\n", cipher_parms->alg, @@ -847,7 +846,6 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher= _parms *cipher_parms) =20 /* starting out: zero the header (plus some) */ memset(spu_hdr, 0, sizeof(struct SPUHEADER)); - ptr +=3D sizeof(struct SPUHEADER); =20 /* format master header word */ /* Do not set the next bit even though the datasheet says to */ @@ -861,10 +859,8 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_ciphe= r_parms *cipher_parms) =20 /* copy the encryption keys in the SAD entry */ if (cipher_parms->alg) { - if (cipher_parms->key_len) { - ptr +=3D cipher_parms->key_len; + if (cipher_parms->key_len) sctx_words +=3D cipher_parms->key_len / 4; - } =20 /* * if encrypting then set IV size, use SCTX IV unless no IV @@ -873,7 +869,6 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher= _parms *cipher_parms) if (cipher_parms->iv_len) { /* Use SCTX IV */ ecf_bits |=3D SCTX_IV; - ptr +=3D cipher_parms->iv_len; sctx_words +=3D cipher_parms->iv_len / 4; } } --=20 2.43.0