From nobody Thu Feb 12 21:47:11 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0DA842C0B for ; Sat, 4 Jan 2025 13:56:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735998973; cv=none; b=bxu/MXrPB0eyH/LNO6tGFV+lU7dZiYeD8M4T3AKEGBbvBTd3nibfXFPMsUeNzvzP2pwSN/+MUKU7ORZYh/9AiFtfTtwDTlfbOOm30kV/1b/zLyJ15uSAA5Az9AwWPTFNZCS2ywdq+VyQN3wEOFQBQEBP//nnE3ZIoJLcQotBayc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735998973; c=relaxed/simple; bh=NI4tRP1Is76uLgwzVQpxCWLwbHMSF+L2Mz3je6ObnqI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X2AkK018IbhXh8DohNongYrqVaxS0EaYsEkSVgfNraN4uSqVfzbrt+g6H6pN5ll5EnIA8LcEcqFv/tqT9NKLxs0CDdoyH96StkBty3nCvWTJgUVuIkDX9gt9xN1pN+eRhbr8NRK3yN7KjDHikw1F+1cuqRhNxRY8LA1Li0wM09k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GQ4kMs/g; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GQ4kMs/g" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43616bf3358so20366325e9.3 for ; Sat, 04 Jan 2025 05:56:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735998970; x=1736603770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zJEWejicaBz6dmUxoJQXl7EdOTueBwQvHraBKvH38is=; b=GQ4kMs/gOkDzbQQuUHac1YRQwFnA1pFC+RPMZo0b29ONUIHhhd+8s494KTMV9BxUse sOsqmp0PzHLkVRwwUUvmKYYLnFKpcY5IvOMkDDK1tmGLpAFcCKWpe7MqYDrZuig0eHD2 xe499KgtsnPm7S3ZpZHzm4mHl+Ub/LuorRbDouYqVJgGcMnyZjH+OqZaY+6ZWsURr5H3 sP16CKFsMjEOrgJ5VRiy9cgMF0KR9OIOLQVi4PAO+sLeabpCGjHDOI+Ek5xFgaNS75KD /mzza+3fcN5YyOmcHuYF+8118dcItntBWr5m6hBnC942RMMW7gkyOUZYezHhk6OoqDut FbCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735998970; x=1736603770; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zJEWejicaBz6dmUxoJQXl7EdOTueBwQvHraBKvH38is=; b=DfiE14ZgXnu5opU66XoEAy23LpeHoGmBoStNvU1JS3FM+AiYW2gjslW69NmSp5DCBb dooPENH95Ewptr2fPGs7UjKI1iD0bpaU1ND+uZV+6omceqSSK0m+IbwmF0V55MBrm3MU pJZgzFnyTI1g4qunwsV9tnVx7VE0xCVh01Tm1EKeQ8q1F6YiT58kE01PvG1y+R7ssrlQ BTDdPoLON4kB5TAkKTSEy58K0/meWkhjIUcCQHR8Inf3z+kZs51FYax7pq0Uo+WBFyva 0IK2FpjQDVVmi0a4VLhZQh3TpKXdjRj6I47ytaa359JW2Ig45LIdGeJCM3lBIIq9wumb 1jJg== X-Forwarded-Encrypted: i=1; AJvYcCUvQtHgm30MSSXylTS6aOeoAEaj+dX6z1noldRVfkc32PpdWpXpB/Gnwzo4g2pBjYq7O2wBjz3A0p12qAw=@vger.kernel.org X-Gm-Message-State: AOJu0YwvIP4Ycgk84qBtliyAivWI4EpaxweA54beMJ3NKT/U4RTQ0iqI N25G+6GTzpLPheCwrfUHb7zA9Scab9Q+gkpTd0g1P5EdDkNOYDbfCFHQLvRksGo= X-Gm-Gg: ASbGncvHgev67EEZb9gnFnPUmA6YwuAFoftxcg4bjQneD13NkKOjcMHMaGFcJ/JtsPw dyVGeTK2naWw77VDSCIr27zvfkjp3YlIM/rXCuxE1XnQdYgX5pfuVVJM1ZMT96GpIc5jIR8MaO5 wqU7gOK60Gwx7wfiKrOmDta9RsmMJLBlyb1lvJelg59LfxZsxrJ5B1RX8HBeQ53S7ujfD/Yu5iU oworvXz2/KRt6ajo8XIJBTn7PIOnez+V++TdhQw2Oiesn6mWh4mnVPFjYXj9dmulfQnycA= X-Google-Smtp-Source: AGHT+IEO/3u4qvFe5Vb1vURPH9ZBPG+ma9tc2SOelaqiPnyPkQaHdPOjLVZUFkyq61FMNDtN3/bC2w== X-Received: by 2002:adf:b601:0:b0:385:f7a3:fec1 with SMTP id ffacd0b85a97d-38a221e24demr13083083f8f.3.1735998970188; Sat, 04 Jan 2025 05:56:10 -0800 (PST) Received: from krzk-bin.. ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e375sm43946322f8f.73.2025.01.04.05.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 05:56:08 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , Alim Akhtar , Peter Griffin , Sam Protsenko , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] soc: samsung: exynos-pmu: Fix uninitialized ret in tensor_set_bits_atomic() Date: Sat, 4 Jan 2025 14:56:05 +0100 Message-ID: <20250104135605.109209-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If tensor_set_bits_atomic() is called with a mask of 0 the function will just iterate over its bit, not perform any updates and return stack value of 'ret'. Also reported by smatch: drivers/soc/samsung/exynos-pmu.c:129 tensor_set_bits_atomic() error: unin= itialized symbol 'ret'. Fixes: 0b7c6075022c ("soc: samsung: exynos-pmu: Add regmap support for SoCs= that protect PMU regs") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/soc/samsung/exynos-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-= pmu.c index d8c53cec7f37..dd5256e5aae1 100644 --- a/drivers/soc/samsung/exynos-pmu.c +++ b/drivers/soc/samsung/exynos-pmu.c @@ -126,7 +126,7 @@ static int tensor_set_bits_atomic(void *ctx, unsigned i= nt offset, u32 val, if (ret) return ret; } - return ret; + return 0; } =20 static bool tensor_is_atomic(unsigned int reg) --=20 2.43.0