From nobody Thu Feb 12 21:41:30 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D5CF481B1 for ; Sat, 4 Jan 2025 06:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735972811; cv=none; b=kbV7JkpguJljyyYbda/eBgmGMv139KD6MkjlbecCUP732GeykY3Y7B7Gs2AAdIoXnncgg/a1ivsgETjqllQAy/sjDaHYeY/olEahjPop0p/Vw6G4yKZ93LIKZi1zBzZqsUZQeIm3lsBM4Rbhx6uwkDF5sO3Vi9lNTFT121eIn5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735972811; c=relaxed/simple; bh=7GNoJD7/JJV2lhVTZOwS8wTTsP4ZQoeDsIzWbFeHpIQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Y5UYxwlgD2V9zlnphJDhlOc4yqH8WVNE8G6VJ+XV/EQx1eVnCnvA+GbxEAS95JQo9qh9H1hCPMGc49JVale5eU9stNnedLEiyoM2M0CCzsc1lsVeZVdVOYz69wBQQQUnM5KjIiG15bMA68m1JBNQk6rFOrXTtmhFWywHZfKeBX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ooseel.net; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ooseel.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2163b0c09afso178589845ad.0 for ; Fri, 03 Jan 2025 22:40:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735972808; x=1736577608; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d/r6eAJCWKnJpEM6xoY5X6KkYyUPd9NQ1z6Kz8gkzw8=; b=Ze/hojon9L4r5KzdbK1KhCl5aFHsCvA4Jz00HET2xixl0A/0Kmq34vhqvf0vL8wi13 SDdHZTZj8s0l8eL1W6yNmDF4+J7LFollwwbziyy/on8n9FXhoxjEvCdC9SRlSxSDLy2N NEhP8+cvvAs//BF+d1R7VOEMwZaKvb2BdGESflYaB1fdWB9bp+x0SmwQVY3AitEc63k5 MGugQcwiRcyYbw+lhzk+7E4eooXR+/q944Uvmr+S8MI1T8D1e/ojThthfjEL+YXtr2As aAHUZhjdvBW5OcogNDPiI5NJ/oB6PA5kZpXxCik2YbvAq4DNQaZFeuFeqCkccUvw9Z8w HnVg== X-Forwarded-Encrypted: i=1; AJvYcCW7HikjrUFRZbja5sUEtJEA9oAk+pTddSkkY+09vUBKWnKLiRm2g5HYVW0NhEuo5hn/Nbji2I17aFlfjyI=@vger.kernel.org X-Gm-Message-State: AOJu0YylkoyEzCnVnQsenI1dnIJ82ISOXqid7WV6+PDVag8vKo61JZ8J thkffaNtXIsFsVZ8CttmX+ImaRrRu2eLqqOSUuslsqs2PR04SeN7 X-Gm-Gg: ASbGncs7wqK+HZaq/ew6G78PTUK7yVX1Xh2wtcuipShl+nffs0P8nuzdi3VcaTkO1vD 5INV4n8QXh3pfQqCe14BdhL9YigUfoYAo3Beq4xgLT/493DJoxkcUEzBNDM4V/fepc5hT3qem1D gpKzQA/Bg/ASud0+PQAR8a9YkeobFPL9yuUIu8k1WXrsBjEUT0zHuY79yowz2rTBglzpASnSQEN +9meswzPg7uw2q1jUEkfS4t95eyv89bD0daLCX/Ad6xgMnZL6DE/HxSPWZ3xU9b X-Google-Smtp-Source: AGHT+IHCLtI8SUAFxLHxoKUtgA9nRM7ZNzuS2BmhmbipdvEHHgYPZQN8/LmncPqaI2Py7FqFz6TeNg== X-Received: by 2002:a17:903:2286:b0:215:cbbf:8926 with SMTP id d9443c01a7336-219e6f10978mr716666215ad.35.1735972808312; Fri, 03 Jan 2025 22:40:08 -0800 (PST) Received: from localhost.localdomain ([1.213.237.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96eae7sm254771415ad.85.2025.01.03.22.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 22:40:08 -0800 (PST) From: Leesoo Ahn To: lsahn@ooseel.net Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: ensure the uniformity of arguments passed to do_mmap(..) Date: Sat, 4 Jan 2025 15:39:25 +0900 Message-ID: <20250104063925.1544944-1-lsahn@ooseel.net> X-Mailer: git-send-email 2.46.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Standardize the way of passing a value to @populate parameter of do_mmap(..) as follow: 1. Caller must initialize the variable to 0, except it's clarified as the name of the variable, 'unused'. 2. do_mmap(..) doesn't take care of its initialization. This patch has a couple of changes that: - callers initialize the variable to 0. - remove the line of initialization inside do_mmap(..) Signed-off-by: Leesoo Ahn --- mm/mmap.c | 2 -- mm/nommu.c | 2 -- mm/util.c | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index d32b7e701058..4aebb1440c35 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -289,8 +289,6 @@ unsigned long do_mmap(struct file *file, unsigned long = addr, struct mm_struct *mm =3D current->mm; int pkey =3D 0; =20 - *populate =3D 0; - if (!len) return -EINVAL; =20 diff --git a/mm/nommu.c b/mm/nommu.c index 9cb6e99215e2..fa69cd8271af 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -1016,8 +1016,6 @@ unsigned long do_mmap(struct file *file, int ret; VMA_ITERATOR(vmi, current->mm, 0); =20 - *populate =3D 0; - /* decide whether we should attempt the mapping, and if so what sort of * mapping */ ret =3D validate_mmap_request(file, addr, len, prot, flags, pgoff, diff --git a/mm/util.c b/mm/util.c index c1c3b06ab4f9..728effcab217 100644 --- a/mm/util.c +++ b/mm/util.c @@ -570,7 +570,7 @@ unsigned long vm_mmap_pgoff(struct file *file, unsigned= long addr, { unsigned long ret; struct mm_struct *mm =3D current->mm; - unsigned long populate; + unsigned long populate =3D 0; LIST_HEAD(uf); =20 ret =3D security_mmap_file(file, prot, flag); --=20 2.46.1