From nobody Thu Feb 12 23:18:54 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C5015383C for ; Sat, 4 Jan 2025 06:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735971565; cv=none; b=AAFAJ1PDXPoDKQ/2RFW6SVsJ0/l4elROZD0nZwX5a+LNncCqjeg1JzkykKmD1CAlwBoWOI8FVWqbMTfqpk/stwMP6wAS5jXdBfQ7t1Xbo0UN88B0XSwwD+YQ80PLEPNuWTkyoyPI0BjJBIqfg+XPmqUW/pWGy8h90bEcNZ/Q1vc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735971565; c=relaxed/simple; bh=bMUpv3/FTqnMwV5u9s/COuv1xw/6j5RQN2haBUShGuQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TaDuOL186UYQRahOfUVgVRBId/EeO2CO1WmtLSvu/bp8nQKE+HJOMa82qugpr72SYisokJcFwXasFXMnf+VCJJgdSYoAoZyc0DUoaJBVsfj/HWA1v9CUkGpi0Mt47y/quIeMTBg1ZXM/Rl4s6iVMXrxa6MbsJUxHNdOkI2lXozo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MCYyReMa; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MCYyReMa" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-53e3a227b82so12004927e87.0 for ; Fri, 03 Jan 2025 22:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735971562; x=1736576362; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5DSZTlkDI1EMkPtJkyKjg++KAUAWvEWZnABji8rlSLg=; b=MCYyReMaW8Zq46kNfNqgNrO6AguTGLVpTw3luLItj6Wog2B5EXG/hKvLkWsSzayWC+ MniQJbhjq1m6Egi1RTe47XYMYO8GjCYkaqKuG8bHUH7PncaP+STKrwtu/V4w7+BTy4OM 08OZioIdJXNHZCD3iBen2IviQfzlZK0qNxtVDu+pQqChcAv1n+hd6y/7E6Wzo/HqD9J2 jElGr50qgqkxYZJaWNIT+2nsonJ3RbAirlMoXuuuq/UDtaM0XEqkn4U1HZg1x+90Mst/ VMy4qoWb+68mw+KuEtFQfxFNe21fqNApH1uS5Dt8MKgCIyYmL/hi2rF+iIZBpEayNUGy llfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735971562; x=1736576362; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5DSZTlkDI1EMkPtJkyKjg++KAUAWvEWZnABji8rlSLg=; b=SZVmTphDo8HEBdNXEIwcFhVbQZvquxEUit7/icgx/+pu3F4AP/KTWshKomAP+PNouy V4HNbuiW/IA86Q1QzDkkZVAXV4iMwRTBPgfEe2tS9sB33u/CyZUNQe58XpfqH7vNguHe U6S90o8ibyziRsoy2pQgpRc0WcGPlMQxs4AGWV0U21ZgMN60KzfjMubg19ay5mUmblUQ nZRACbQnAHmauaMkmnQa+trPsnPaqW1wz4cLprJShy/mmJ3SmeX0yIV9Kv6FJ2IGcxmc 7g66X6PrI8CjrFY3SRBK7AAwoxsxGE1KVlrMpp3oF43UZ+loHZe0gqAcecypugDlP1fr n/PQ== X-Forwarded-Encrypted: i=1; AJvYcCVm29beFQJjfW2h1R6O/N1jYrqAaJ/4ZsCDpfQNraNXr+mJnHt4uM4+m90AQZVewsXDczpChR3EXz1X1xI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo1D5cYYIeJPPseQzg15XZToLBFpwOgIB6ERvHrZs48W7rouzk c8nz3Xa+wekIEEYHsJm6TM+glbBZeuUInvta9kQRbOD9v21fRstjplDSrJ1ZGzs= X-Gm-Gg: ASbGncudtzxV8mU4dqC0GVzeG1VUoWmSBBcuw7lvoh4c2IKYuDLe7VefKPMLaJzXbxA y0znPjGt6ginbvdmFO1m0mBYvxQfnkKP545HMhEg8T6z6/OqPbPkpmhFBTdvgeMDH1ga3WPBA1F 42SDwT81XgonrGeBKMEYJzVq2Le0zy5vkCo4BuKDGKEj0mF7WOca03yvc2ZiFeepki28miHyq7/ SgjZL/L85vhx96M8FT2koFSEi1UC44woDtryddluRMXkgZS6Q4xcqTLE7Ad3dQkXTTsOszWx83D Ubjz7XZd0B4SLU+Lu0DjRwK7 X-Google-Smtp-Source: AGHT+IE9ihzAYsTq5IA1xojBKzGXCaMZRqvRsRFIJmPXVfooN37uBW8FsaXaGYBqlVT/Lh13Sv96Pg== X-Received: by 2002:a05:6512:114d:b0:53e:391c:e983 with SMTP id 2adb3069b0e04-542295229d3mr17961104e87.3.1735971561863; Fri, 03 Jan 2025 22:19:21 -0800 (PST) Received: from [127.0.1.1] (2001-14ba-a0c3-3a00--782.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::782]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54223832c1bsm4261655e87.280.2025.01.03.22.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 22:19:20 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 04 Jan 2025 08:19:13 +0200 Subject: [PATCH v3 2/5] nvmem: core: verify cell's raw_len Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250104-sar2130p-nvmem-v3-2-a94e0b7de2fa@linaro.org> References: <20250104-sar2130p-nvmem-v3-0-a94e0b7de2fa@linaro.org> In-Reply-To: <20250104-sar2130p-nvmem-v3-0-a94e0b7de2fa@linaro.org> To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Akhil P Oommen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=930; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=bMUpv3/FTqnMwV5u9s/COuv1xw/6j5RQN2haBUShGuQ=; b=owEBbQKS/ZANAwAKARTbcu2+gGW4AcsmYgBneNLhNpEaoF5/Nu4xiwe+9PdqReWSOtYGSpP6l XXWZDC+fmiJAjMEAAEKAB0WIQRdB85SOKWMgfgVe+4U23LtvoBluAUCZ3jS4QAKCRAU23LtvoBl uBaaEACz+dBHD0fxgsvnk2YlNABSiPbK8CM0Y4w+Jnl0u2d3HZDzeeWqFpbE3CIkh3ddqXrVCNm RZRk+ew2A0cMQu7YqoL4LOJOekVeTPaBjwFetRYDkAxwpUeza4PNC1exBhtbUOwm8vd8Qt3I2oh SHUxSRGCQzBkVpaEdriCCZNFCNEbmmGKfteuyHXkqc1ahCg/Shspib9Syrxt2xOxdu9f4rFDOBl 1DUuiaA4BBgDub/ajxrvqmw3UvWxBLyiLIEnAMX5XMmEY99tynDU39JXQvPGW/hJN868xPV/uY6 bYN5tdXKmXt/lWzbc0B+mnuvnzLYA+IqUkt85EGYOAaJLcXJb+12/Bht4Zp5PuXYjaU9fBP8wPt 6ygwrY4v5IJ5cul21nEOuu9Nsxo7pFO1uL2sIRYw8YgZoFU9+U9Qu3OH8G71jOKpU2NT4Vyp0an vymYLKImJoBUouukIUIYtZkmFwRJkM0E8cfkPKrpd9XwZehTAdyV7PRuhzUIJSDQgIHPF+LC9Qz 3HpzbWjGi2iNv5PsI15JelppbYVaf7VJVKe9+MWz21quq1Q4bF7sUTfJn2f7fNaU09CVRSAhXik j23xQ5FCI2wjg56n9riI8EMdqjhHpp1MGN36pWPUiA+K723Hr4kQ+HtSYBPYVBlFp8+keDp6CvX CESGjJFTn0H9g2w== X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Check that the NVMEM cell's raw_len is a aligned to word_size. Otherwise Otherwise drivers might face incomplete read while accessing the last part of the NVMEM cell. Signed-off-by: Dmitry Baryshkov --- drivers/nvmem/core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index c0af43a37195c3869507a203b370615309aeee67..a03a3006bd611ea6e91703cd19c= 2842bd4f56659 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -602,6 +602,14 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(s= truct nvmem_device *nvmem, return -EINVAL; } =20 + if (!IS_ALIGNED(cell->raw_len, nvmem->word_size)) { + dev_err(&nvmem->dev, + "cell %s raw len %zd unaligned to nvmem word size %d\n", + cell->name ?: "", cell->raw_len, + nvmem->word_size); + return -EINVAL; + } + return 0; } =20 --=20 2.39.5