From nobody Wed Dec 17 08:54:36 2025 Received: from mxout1.routing.net (mxout1.routing.net [134.0.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F182E1F941B; Fri, 3 Jan 2025 10:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=134.0.28.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735901232; cv=none; b=E1Yi8/z0lhyDh83f94aLzOTZ5LoLsv7TvCLs2UTBr0t+u9VAdbRL5KGJlr9IhTixKGyI6bMsZZP+WJpFPLsJsuMczTq63IX4clsdVqmwI+5Ek2mRN32AjR81QXLQJYiWXKp1m/yR7xpQV62wwbk2adTEW2hgQO+E5ur5iiWn9aY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735901232; c=relaxed/simple; bh=svVt4AC9J24r/20hCNRyyZxiB45IKxHFh55uC0gKCR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uNtgfzF2Qhy64bMv4LW4hynodHeA/1iNCIKQDnI6sa9D1L1MrfPFT4xQ3QOyYFCvfk19yZmE06+DpKvDE5jl4+mn/CLNxnj/+22cYc06LZZkbX/u/IxT9cYwLAxTOM76zMQNq815PmXvh6wOVv6gZ8fMSbX6UDryuIyYGim4cRw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fw-web.de; spf=pass smtp.mailfrom=fw-web.de; dkim=pass (1024-bit key) header.d=mailerdienst.de header.i=@mailerdienst.de header.b=xKCxX5w/; arc=none smtp.client-ip=134.0.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fw-web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fw-web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mailerdienst.de header.i=@mailerdienst.de header.b="xKCxX5w/" Received: from mxbox4.masterlogin.de (unknown [192.168.10.79]) by mxout1.routing.net (Postfix) with ESMTP id 6EB8840033; Fri, 3 Jan 2025 10:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1735900652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4rXD5zuchcHr1CCQj+5YBTJ6sikusQ9PNDvv9nmdqkE=; b=xKCxX5w/2iMCgECHwUjWQTAttZ5ha2ioW/uKO28gMBUFmUd6N5wkxF55BwmtV7Ku52rO8e voPdcYIL76nvt+4PO9TgcYmlXO6O9QMMdcTHPzwxbY2uxw1TU+eeEhu9co5oWCd6QpYi28 lXq5a9cYXZVItM0rLL6gKp8uNXIXWfA= Received: from frank-u24.. (fttx-pool-80.245.72.216.bambit.de [80.245.72.216]) by mxbox4.masterlogin.de (Postfix) with ESMTPSA id 62B8F80236; Fri, 3 Jan 2025 10:37:31 +0000 (UTC) From: Frank Wunderlich To: Damien Le Moal , Niklas Cassel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King Cc: Frank Wunderlich , Hans de Goede , Jens Axboe , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/2] arm64: dts: marvell: only enable complete sata nodes Date: Fri, 3 Jan 2025 11:37:21 +0100 Message-ID: <20250103103724.6223-2-linux@fw-web.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250103103724.6223-1-linux@fw-web.de> References: <20250103103724.6223-1-linux@fw-web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mail-ID: 256d86f6-c468-4b81-9f06-abbaa767be08 Content-Type: text/plain; charset="utf-8" From: Frank Wunderlich The ahci-platform binding requires phys/target-supply property. After converting the binding to yaml the following files reporting "'anyOf' conditional failed" on sata@540000: sata-port@0 armada-7040-db.dts armada-8040-clearfog-gt-8k.dts armada-8040-mcbin.dts armada-8040-mcbin-singleshot.dts cn9130-db.dts cn9130-db-B.dts cn9131-db.dts cn9131-db-B.dts cn9132-db.dts cn9132-db-B.dts the following files reporting 'anyOf' conditional failed on sata@540000: sata-port@1 cn9132-db.dts cn9132-db-B.dts cn9130-crb-B.dts 'phys' is a required property 'target-supply' is a required property From schema: Documentation/devicetree/bindings/ata/ahci-platform.yaml This is caused by defining sata-ports incomplete in armada-cp11x.dtsi and overriding only a subset of ports with the needed phys/target-supply property. Fix this by disabling the node-templates and enabling the needed nodes. Signed-off-by: Frank Wunderlich --- v2: - change commit title v7 =3D> new v1: - rebase on mvebu/dt64 - drop fixes tag i only try to fix binding-check errors. as i cannot test it on hardware, please verify my changes are correct there are still some there, but they should be fixed by someone having the = hardware. v5: add fixes-tag the dtsi uses a macro for the node-label defined in armada-common.dtsi CP11X_LABEL(sata0): sata@540000 { so i hope i catched all right nodes to be enabled... have enabled all cpX_sata0 sata-portY childs --- arch/arm64/boot/dts/marvell/armada-7040-db.dts | 1 + arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts | 2 ++ arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 + arch/arm64/boot/dts/marvell/armada-8040-db.dts | 3 +++ arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 1 + arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts | 2 ++ arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 2 ++ arch/arm64/boot/dts/marvell/cn9130-crb-B.dts | 1 + arch/arm64/boot/dts/marvell/cn9131-db.dtsi | 1 + arch/arm64/boot/dts/marvell/cn9132-db.dtsi | 1 + 10 files changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/marvell/armada-7040-db.dts b/arch/arm64/bo= ot/dts/marvell/armada-7040-db.dts index 1e0ab35cc686..2b5e45d2c5a6 100644 --- a/arch/arm64/boot/dts/marvell/armada-7040-db.dts +++ b/arch/arm64/boot/dts/marvell/armada-7040-db.dts @@ -214,6 +214,7 @@ &cp0_sata0 { =20 sata-port@1 { phys =3D <&cp0_comphy3 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts b/arch/ar= m64/boot/dts/marvell/armada-7040-mochabin.dts index 7af949092b91..6bdc4f1e6939 100644 --- a/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts +++ b/arch/arm64/boot/dts/marvell/armada-7040-mochabin.dts @@ -433,11 +433,13 @@ &cp0_sata0 { /* 7 + 12 SATA connector (J24) */ sata-port@0 { phys =3D <&cp0_comphy2 0>; + status =3D "okay"; }; =20 /* M.2-2250 B-key (J39) */ sata-port@1 { phys =3D <&cp0_comphy3 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/a= rch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts index 7005a32a6e1e..225a54ab688d 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts @@ -475,6 +475,7 @@ &cp1_sata0 { =20 sata-port@1 { phys =3D <&cp1_comphy0 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/bo= ot/dts/marvell/armada-8040-db.dts index 2ec19d364e62..fe5d6cb9d692 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts @@ -145,9 +145,12 @@ &cp0_sata0 { =20 sata-port@0 { phys =3D <&cp0_comphy1 0>; + status =3D "okay"; }; + sata-port@1 { phys =3D <&cp0_comphy3 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm6= 4/boot/dts/marvell/armada-8040-mcbin.dtsi index e88ff5b179c8..5043cf2eb33e 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -245,6 +245,7 @@ &cp0_sata0 { /* CPM Lane 5 - U29 */ sata-port@1 { phys =3D <&cp0_comphy5 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts b/arch= /arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts index 3e5e0651ce68..9c25a88581e4 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-puzzle-m801.dts @@ -408,10 +408,12 @@ &cp0_sata0 { =20 sata-port@0 { phys =3D <&cp0_comphy2 0>; + status =3D "okay"; }; =20 sata-port@1 { phys =3D <&cp0_comphy5 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boo= t/dts/marvell/armada-cp11x.dtsi index 7e595ac80043..161beec0b6b0 100644 --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi @@ -347,10 +347,12 @@ CP11X_LABEL(sata0): sata@540000 { =20 sata-port@0 { reg =3D <0>; + status =3D "disabled"; }; =20 sata-port@1 { reg =3D <1>; + status =3D "disabled"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts b/arch/arm64/boot= /dts/marvell/cn9130-crb-B.dts index 0904cb0309ae..34194745f79e 100644 --- a/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts +++ b/arch/arm64/boot/dts/marvell/cn9130-crb-B.dts @@ -28,6 +28,7 @@ sata-port@0 { status =3D "okay"; /* Generic PHY, providing serdes lanes */ phys =3D <&cp0_comphy2 0>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi b/arch/arm64/boot/d= ts/marvell/cn9131-db.dtsi index ad7360c83048..626042fce7e2 100644 --- a/arch/arm64/boot/dts/marvell/cn9131-db.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9131-db.dtsi @@ -127,6 +127,7 @@ &cp1_sata0 { sata-port@1 { /* Generic PHY, providing serdes lanes */ phys =3D <&cp1_comphy5 1>; + status =3D "okay"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi b/arch/arm64/boot/d= ts/marvell/cn9132-db.dtsi index e753cfdac697..f91fc69905b8 100644 --- a/arch/arm64/boot/dts/marvell/cn9132-db.dtsi +++ b/arch/arm64/boot/dts/marvell/cn9132-db.dtsi @@ -175,6 +175,7 @@ &cp2_sata0 { sata-port@0 { /* Generic PHY, providing serdes lanes */ phys =3D <&cp2_comphy2 0>; + status =3D "okay"; }; }; =20 --=20 2.43.0 From nobody Wed Dec 17 08:54:36 2025 Received: from mxout3.routing.net (mxout3.routing.net [134.0.28.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5203187FE0; Fri, 3 Jan 2025 10:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=134.0.28.8 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735901068; cv=none; b=tGIV7DqIuDIoDTAxrVwaj6BhB/13T7ovFiRyDUJDdZC2FTAoK2B/0fm5XSwLEjYLya3gjtpXzO2cNRP5/olezTiTznihQWXLAuaE0jEsbn5pRMRO60kd/1l3TYgiebdbcmjNuA87uMYc7hYVQU4ESlih+yYl/5quPpuL+uv5DVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735901068; c=relaxed/simple; bh=YHMNti+didoHgK68FhrbDg3mJKgl9PHm8/CyISacV2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p7McMu7LBpQRiL3pUWbpUNxojlQA/HXezCL3/G84S5BmMP/RQNYNEj0MVxPKbZPv1BWrJjglcmEK6SJKwe7NuOpAWotvLhDwAYnhYVRZfVSkfuJTbjnoEvpDM96WRpFOzmQhNeW7iZZBWGkfVCPH7kZRwyydT3yNYhJxBNWuaDc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fw-web.de; spf=pass smtp.mailfrom=fw-web.de; dkim=pass (1024-bit key) header.d=mailerdienst.de header.i=@mailerdienst.de header.b=eHzB+yui; arc=none smtp.client-ip=134.0.28.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fw-web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fw-web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mailerdienst.de header.i=@mailerdienst.de header.b="eHzB+yui" Received: from mxbox4.masterlogin.de (unknown [192.168.10.79]) by mxout3.routing.net (Postfix) with ESMTP id 51691605A2; Fri, 3 Jan 2025 10:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1735900653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D2iahX1buMzs5p03vC9Zh7kp9EyqKjlKiO/Ae93S060=; b=eHzB+yuiY9jr3y6dXPaAaDCDMM+2kVQQKJY44VZzx154UmOM6eQKF1ebC/7PntzMAvSL+8 pG68WgWOMQWMPlPzEPz59OxrOxp6vfQJS5Yn294w7EnWxnFj6Wt6hh3ZZnDAEE98P4mNTj oSOnBuxOjVz84X3q7Ev6eu2gmmrnaRE= Received: from frank-u24.. (fttx-pool-80.245.72.216.bambit.de [80.245.72.216]) by mxbox4.masterlogin.de (Postfix) with ESMTPSA id 6474A8020A; Fri, 3 Jan 2025 10:37:32 +0000 (UTC) From: Frank Wunderlich To: Damien Le Moal , Niklas Cassel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King Cc: Frank Wunderlich , Hans de Goede , Jens Axboe , linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/2] arm64: dts: marvell: drop additional phy-names for sata Date: Fri, 3 Jan 2025 11:37:22 +0100 Message-ID: <20250103103724.6223-3-linux@fw-web.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250103103724.6223-1-linux@fw-web.de> References: <20250103103724.6223-1-linux@fw-web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mail-ID: 36ba5333-1016-4fad-b8ef-f646e7a56354 Content-Type: text/plain; charset="utf-8" From: Frank Wunderlich Commit facbe7092f8a ("arm64: dts: marvell: Drop undocumented SATA phy names= ") drops some phy-names from devicetrees but misses some. Drop them too. Signed-off-by: Frank Wunderlich Reviewed-by: Andrew Lunn --- arch/arm64/boot/dts/marvell/armada-8040-db.dts | 2 -- arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-8040-db.dts b/arch/arm64/bo= ot/dts/marvell/armada-8040-db.dts index fe5d6cb9d692..9d45e881a97d 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-db.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-db.dts @@ -307,11 +307,9 @@ &cp1_sata0 { =20 sata-port@0 { phys =3D <&cp1_comphy1 0>; - phy-names =3D "cp1-sata0-0-phy"; }; sata-port@1 { phys =3D <&cp1_comphy3 1>; - phy-names =3D "cp1-sata0-1-phy"; }; }; =20 diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm6= 4/boot/dts/marvell/armada-8040-mcbin.dtsi index 5043cf2eb33e..0d4a5fd9503f 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi @@ -345,13 +345,11 @@ &cp1_sata0 { /* CPS Lane 1 - U32 */ sata-port@0 { phys =3D <&cp1_comphy1 0>; - phy-names =3D "cp1-sata0-0-phy"; }; =20 /* CPS Lane 3 - U31 */ sata-port@1 { phys =3D <&cp1_comphy3 1>; - phy-names =3D "cp1-sata0-1-phy"; }; }; =20 --=20 2.43.0