From nobody Thu Feb 12 23:04:09 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013039.outbound.protection.outlook.com [52.101.67.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F3EC1CDA2E; Fri, 3 Jan 2025 08:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893729; cv=fail; b=PJ/1zqBn0vMiW4jabA4z2FEeAcNBFEhiMjh2akMZW3m7xKcFrDwcOj4xuwqwXZ6j/b9MfH1+SXtYtpgudpF0/Atp0dUsIyiNDKPhy0FY49Gj4pmRQjjiY9yw4Xs4sJjzEM8lPY6ZBiQnPO3E8tHJp5f3ddROvVe91CBdvlRXdqw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893729; c=relaxed/simple; bh=MtlGyF7f4IaQ5gXyjDyNBKstfyPBC/6xufVjFPOKlIQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=tq0SK/wdk++ZzMWBCHExITQKMq2AqBPPtiSsHYfnPXuWLyzbLzFbNqRIoRXeSCjdDlmshtYI1NiY/Tm5DM0bf73TWl28D6b7wrd/UEIzBlNhEgjgrGGdzia1MOL/jcqarHrfUzwaq+miek8kjhC+xlPy0S0rkoyWifeRUOdv87c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=SQQbuU/P; arc=fail smtp.client-ip=52.101.67.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="SQQbuU/P" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HIZYJBv1zHodPoR8UlsPvIFTyC734gJepvyWTq2DPyHmKVGqauYz5yNbfVLOJdiYkl/XoD8uZnXZWiriXMiDpiJDIDoZ29kOVXO9sfxr/WDKzlPuP69NUY37ADt0PPBv/wk3ygrQUB1lVZelYNgUHL1pMNGMDXFqgtIu9Sdm94XLty9jFbBFc71UkjEs/t4ww1OyViQ6hqROFRAqMp86ISlzhCAJ6qu0hAO5IvT0M5vTTpVLMA5WjZpt91wA+gw/WreGwrKaIF3biz01gf/JiRiMPCzdID/ftFCpT+KNSdxsfZJOLEeKNSaFT9GTWgpBU5lERF3P7DxYjwymHaQWvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GvJSucZCIwQtWFHFefZHH8o5izy9wD1tkxKMnEC2y5Q=; b=aACBxHw7G6D7OHprQyA72NYuDRI0Ip2BZWXxyxzYqLWWA/kYRgFfK+PjilFKXKS3tfM5hUeqMgz9PxO3Op9tzUm3/WDqnFpy0GdyfPg8KwxL/XhFJtzzGUAvh3y9u4fHxIrStxEej9kGKeMtfMG0uCMmC5Ct6TqJL4B1eW7tnIf0jxgie0qjURrsVKVe0ZPMYLaT9czWfxwdg6dWMpsoKOB7meGsM7lk9l0Gagp44nt7o/wo08o+osv5cPEpD0Ueg6DqzpdvZPcaRAVJ6EctjAjmaUulUzjKorqGOChvQDSG8pKo62vBt7wwAypAXvGI7Wa4QuJw1lwGzdUqjSlZYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GvJSucZCIwQtWFHFefZHH8o5izy9wD1tkxKMnEC2y5Q=; b=SQQbuU/Pc2kDdi0mMKNu2kHZ6WL/6I4ax1KRGRPL5uT10HLJL247RaP4UDTf964jmS+cCB1wbyOqrMYAngo1mOXCydsFNMKN8PsBjONCDk3eHQSEKd6RE6vjegnpAn03Ocn/ga1oICZ8TArFtG+BzMh7BEUxRFNV3uhORI0bdjCMJvZ8jQIyYqhqoOirXeFV0RZmt0Fwdn76PVdawpQ5DFpQvIbdLgasRs6xGJaRqnNFnijBGcElwBY8qPgRcbQtOh+R86P8yBoGy/BYLN1ewRVfIRUyaJCiAx6l/N7nb7RQgi4KLmg9qZwXW4lC6Iwd9tunu8y/dmAvZCoY/da5yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:02 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:02 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:13 +0800 Subject: [PATCH v2 01/12] PM: sleep: wakeirq: Introduce device-managed variant of dev_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-1-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=2411; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=cZsxdEVfnwbWB6VyEJvR/aoyZKsWpsHQZXR8Pc5i6rY=; b=j1W2wjxkUyGXeKstwZDwXLHFSM2SgXzdNMFeRi14fZeVx9+ZZtiyM8Xe0hbxRmrqsALDiNlsh Z+I5HCmQOy9C3IoAIY6cIOYoh8iGZZWq0onr5AsZ4tjvecBnbvrw/8h X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 605fc750-e430-4da8-2e5b-08dd2bd27e65 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VTdVY0JMNVFMS05vNTVjVC9nQXdzeXcwT3k0LzVqNEpuS0dodWdXVG93dWpk?= =?utf-8?B?OWk5K2ZzdHlEM0Q2ODFnd3ovcHBUa1F1Vlp4cW5CUCtLS3JrZTdlR0hFMWpo?= =?utf-8?B?Lzc4L0ZSdTVnK3FGTFNYZjZsMms5QjVOR08wZUhDLzhUMVptbm5NSEFLc2xI?= =?utf-8?B?YlE5T3J0bFpMWm96S3YxU1BvNld4R0szM2pCMTBzc2dRTUVtTDE2cDMzeHJH?= =?utf-8?B?dnY3WHJaVU9qM1pNVHZrQXkrZ1BvVGhyb05TdVAwTHFZME05bzl1V0czR3B1?= =?utf-8?B?d1pkb2VtYitKU1gyWUhwemFLMmRuem1xS1pIMkRscTJ5MzNkL0ZOSFhKbFl5?= =?utf-8?B?RElkVVIvT2cxcFRwZjVucStRVk82aGRLL21MMmRCNHljQXJaczI0ZjBhLzVO?= =?utf-8?B?ci8xYTBXTnFvbk1WeWVUVEkvKzNXNk0zYnVsZkFXQ0xsNnliUXZSNE5VQUph?= =?utf-8?B?aGkzNWJvQy9PV3ZLVTcyNysvSGVKc0xjaUJqVGc0ZzE5VHgwcWZac2FRMW8v?= =?utf-8?B?MnI3bVU0V0krTzhlVENyNjdIeENrcTIxSHZDZk9TNElIVlV5QVpOWlhCRGNC?= =?utf-8?B?alpDYnI0eW9RdW9NRVpTczBENXJab0krbVdIc01vODdmS29JbWNqb0lLTFJw?= =?utf-8?B?d3ZnTDVaVEtYc014RHIvcm9NanRVWllNSXVPK0F3eFVqd3Yyd3dyY2w2OGVn?= =?utf-8?B?TUwwb05qRVViQ3FVbXFTY3pITVhUczZkSFovTXd3Z2VUYldnSlJRdWt6cEh6?= =?utf-8?B?L3MzZDZoSUZpOWxmeHFEQ1hkaXhLUFNqV2hDZHhJYXRraFJsOS9RR0E0S3NM?= =?utf-8?B?cG9acXVGV2FpbVFqdFZHNU1KUEt6Q01nb2ZIR014WlVjUkhzSWRxcTJaYnN5?= =?utf-8?B?dU9NenR2ZW5jSXcwSjdhVWtCV09PR3dBS1FockRFZUEwRDduY21pS3BOd0Ru?= =?utf-8?B?K2d5N01IYmxjT3E4ZFdHWDdmc21XMTAyODFoTVBHSU56TWdtTW03eGVDRTMz?= =?utf-8?B?b2EzRnBlamtGeVNsdmpzNGVmZG01L2ozVVhtWWphSWJJdU5Hb3NKcERoTFFR?= =?utf-8?B?cTcwVXNVQzE5bkdPUW1pNCtIWldMTHBQdldyeVBIZC9oREJTQ3QwMDBVbGEw?= =?utf-8?B?UjUwZ0tqQ05oekpIelNMdUFUSUNsdnpmcVZ6RXJBa2s3d1locjVKd0FOYitZ?= =?utf-8?B?bTZ0dXVYUHdxRjhCcjJzY1QvSGlwMWhET2ZsWlhoMDl6L1JFMklBUXhKb0xB?= =?utf-8?B?a3hLQmFIWXZVUkN6bGdWZnloMnJjeG1mb2NSejVxQVVMOWJ2Z0xjODYyRm5Z?= =?utf-8?B?cWgrbTg0b2ZaS054aUM5elRGbDQ2SWZxUnlrQnI5V2MwdkRtOWpFdDU2Z2U0?= =?utf-8?B?MVB4RUVHV3hGQkwzRXpCQ0hXQXZEY3YyNVdPODNDWnFyM1BQVGZMdlI1S1Vx?= =?utf-8?B?dnloTm9JRk9uSVdjajk2UWZaYTlHNURJenlVeWRWTVlrOTdsTDlZeEhHNURt?= =?utf-8?B?M0xQUlFhR3BGR205VVZLOU9ob3ArTlp3bWdkN25sNUo3TlRoUE5ZeHRyazNn?= =?utf-8?B?Yjg5VjZ4QkpOeXBpazVWdUY2M1FYMnJpVHR2UGpqY1BOVm1nZ1pDWHljcXBU?= =?utf-8?B?SUxvZ3MxaktGME9nL2ZOa0treUJ1MTdHVDJjVWNEU3ZrM3ZiZ1NNVllMRUJX?= =?utf-8?B?SXFER2lRUVJIb00xWlJSZVhVaHQ5RlJKemtrK3VwZDZOdXNINFJIbklON0RU?= =?utf-8?B?VXZJZHZqbk5YcFJCSzR2TnphZGdXRlNyR3RrWHMyNU0vK21sQ2M5SUZwemRp?= =?utf-8?B?WjdJeWRFTVl2SE1nWlRCYmtWVTZ3aHNRZGdXcmlPWk83RFBQcUlDaGR1elAw?= =?utf-8?B?azBHNDhFKzJvQk50TlFXcWpVQUlqTStCMEN6ZVBnQ09sTEVESHBTUXcxNXNM?= =?utf-8?B?cXcvQjV1REc4aE15SVBsODBSU1htcGJiNWpEZC81Mjk3ZWp5b2NRVTI3ekln?= =?utf-8?B?ZlloQ3dpU3h3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tmtiazcwd3JRRFAxbzBwbkVvNUpQeHpTZ3BUWTMyZ29BMnlUTzJCYk1ac25i?= =?utf-8?B?djhROGpjVjc2bkU4dSs0RW1wQVhlMTZpZkcxMUJCbGxROGN0ZUhFdWJwemxP?= =?utf-8?B?R1doS3RGeTk4TXI1VGhCL08xSGxJVzJ0RzZBeXR0Z1Q2TkVobVhZbWdncVlC?= =?utf-8?B?RUptemx1NDJiN0VqNEFWa2hTWG1tMUJKaUNWaW9yTEZQb05wbDBPWnhHNkxH?= =?utf-8?B?S2daUGdhdURucjVqMnZLM0IyZEFtSkxuN3l2bHJ0bWUrL0tuM3BPNXdXem9T?= =?utf-8?B?bzFjN0xHL0w3em9Bb2FramxteEN1LzFLaU1wUDllTnh1NVlMVENweWU3L1Nv?= =?utf-8?B?cXJWR1l1QzJhTW1QTE52SGlkL1VvR2N6ZE01TUxBaUdzQmc1TnBINDNIMU82?= =?utf-8?B?NXk2MTluMk1mMUtVTjBXcTdFV1QzZ056SHc2NkErVm5SWlF2YU9pVXIyQVI0?= =?utf-8?B?SVRhMXZRcWZQOXByRk9WaTV3TWZhM0VEb0pXbm1wL2FOUmxWNTR3UGZYclpG?= =?utf-8?B?TS84UFZ6VTBqeGZwMGpSR3ZQZjR1ZFBxdEM4eGp3akwydlFmVXlmSmdmcndp?= =?utf-8?B?WjV1Y1YwM1pPMFAvT0J6NWM0RW1TWFNVMENVa3RpTXhWaWxpY3NXaVc1b0Vl?= =?utf-8?B?QTkzZm9DcEpXcVJtSC91QXQ5UFdXQVBkUXhMcUlxYlplcHprYmhxenhTR0tN?= =?utf-8?B?OTFZQmlkeHlCbWszcWRKdlpnYWZ2MFRnUlBjaFh6UzNQdVRVelZpdXozNG1T?= =?utf-8?B?YVQ5a25ra04xQ3ZTbGg1U0ZWZUxMSEZqZXpFUDAvSGZ5andLVWd3ZlBSUDdu?= =?utf-8?B?a1llSy90R1ZIWnN3MExRd3ZKaGpqaXlraExkd2xSWXczY1F2WFJYMGoxUjZt?= =?utf-8?B?em5YWmpkTnY5MVUxeFlCdElKUDdXblBmYUNub2VPMXppd3ZLTW9lWVFydzJr?= =?utf-8?B?b3VvbTdFQmgzY3Q3UmhlM1NTOHpDYW16MFd6eHliUXRvb0g4blA1ME9vOTAz?= =?utf-8?B?MUFsaWllckpQNmNFYXczOTcvdU9rMks1Vk5aQTBsNjY5S3JiUHlsTi9xZC8r?= =?utf-8?B?SCt0RTgyMSsrM1UvRDJOR3BnNVNOb2xCQWwvNVVwTlJ0SXRhVnBISkpWTUp5?= =?utf-8?B?RERFcWxOZkdUS2lQcnY4VFpIL3dOcGNEVCtPbDJ2aGZ2ZVBjc1Z1cGU5VWJS?= =?utf-8?B?YldKR0trdEppM2ZGQ3RCYmNXRWlBU2FsR0VTZldnaCtaZkV3OTNUMWVGUkdB?= =?utf-8?B?WGZPWjVlcTZtVWtLOXdVb1VzK1phUEI4RmptZ1JSRnVrZjRheEgxRG9wRUdp?= =?utf-8?B?enExaEw4MDYyWXJpeCs1QndsNmcyd3A2TXZoNm1KZ3dhelNPdDVYd0pKVFh4?= =?utf-8?B?Wm52cW9ad0tEWXpBYmRqZ2FJeVVTSDZvR2xhOWNrdWFpKzVDY2NvcFFPU2l4?= =?utf-8?B?NHJ0c0piQy8wZmhndStWV1NDVCtxa2ptRGk1TGdyaWR1Y0hNQ0ZGbGZhM2ZZ?= =?utf-8?B?SDh4YkxGWnh1V29IVWJFWTRiMHZQQWlhbVVhY3pkNWFKSFRoVzMvQ1JjUVQ1?= =?utf-8?B?U0pRRCtGMmV4bS83RDgxOWdkeiszRkRGemFFQW5KMU9hWnpkSDNGY0liaklB?= =?utf-8?B?NEtGaUwyNXdCc1A0QlBteGdEM20rRkpzZWhmdHoxeEg1Njc3T1E3Y2hCRTk0?= =?utf-8?B?V0FCYjdQa2RwQXI5dWoxamlJRWR2TXVxZkErV2xFVmVsYmFlWE9jUzBtZEE5?= =?utf-8?B?OSswRUp5bFVEaFVzS1FoVnN6eUlXeS9WZFJIMm1IWndHTkdYMWhFQnBXTllS?= =?utf-8?B?SXRrZVZ4TDZzUE1hQmlKZ2N1eGJQeER3TUNIemthc0dmTUU5Y2dGOEtFMWpO?= =?utf-8?B?d0NlMnJ0WVA2UWVaWENnRFlGMU4zbnY1RHJtZkRUNXY3TEYzVE9oQnpKL2Ja?= =?utf-8?B?cGdRWW5rV251YWJGcFk4Z0gxMzF6cXFUaHA0SVpRSG12SU5nZ1dVakZac296?= =?utf-8?B?WFNJeWRyQVRnM3drY3d5NmJ5VlFiNlVCUXlvbi9NMXMrcGlOSjVVck5uVEdZ?= =?utf-8?B?TzhlYWdjajZIN0VTaG5aLytSdnA2YUEwTk5KNnBZQnhURVdaNGN6K2srUGVZ?= =?utf-8?Q?zasmBY8JtHQPVE/hLQgyuRLDD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 605fc750-e430-4da8-2e5b-08dd2bd27e65 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:02.1115 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 92QI+cW0ykw8vms9yGkeLmFh4UlLy1EB87SyEeB8Gpy3Jd+fCGIdGBl9ExHcq4l5Ulkp12486k73j81I7QY44Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 From: Peng Fan Add device-managed variant of dev_pm_set_wake_irq which automatically clear the wake irq on device destruction to simplify error handling and resource management in drivers. Signed-off-by: Peng Fan --- drivers/base/power/wakeirq.c | 26 ++++++++++++++++++++++++++ include/linux/pm_wakeirq.h | 6 ++++++ 2 files changed, 32 insertions(+) diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c index 5a5a9e978e85f3fc9d89cb7d43527dc1dd42a9b1..8aa28c08b2891f3af490175362c= c1a759069bd50 100644 --- a/drivers/base/power/wakeirq.c +++ b/drivers/base/power/wakeirq.c @@ -103,6 +103,32 @@ void dev_pm_clear_wake_irq(struct device *dev) } EXPORT_SYMBOL_GPL(dev_pm_clear_wake_irq); =20 +static void devm_pm_clear_wake_irq(void *dev) +{ + dev_pm_clear_wake_irq(dev); +} + +/** + * devm_pm_set_wake_irq - device-managed variant of dev_pm_set_wake_irq + * @dev: Device entry + * @irq: Device IO interrupt + * + * + * Attach a device IO interrupt as a wake IRQ, same with dev_pm_set_wake_i= rq, + * but the device will be auto clear wake capability on driver detach. + */ +int devm_pm_set_wake_irq(struct device *dev, int irq) +{ + int ret; + + ret =3D dev_pm_set_wake_irq(dev, irq); + if (ret) + return ret; + + return devm_add_action_or_reset(dev, devm_pm_clear_wake_irq, dev); +} +EXPORT_SYMBOL_GPL(devm_pm_set_wake_irq); + /** * handle_threaded_wake_irq - Handler for dedicated wake-up interrupts * @irq: Device specific dedicated wake-up interrupt diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h index d9642c6cf85211af603ce39e280a5b4de6617ee5..25b63ed51b765c2c6919f259668= a12675330835e 100644 --- a/include/linux/pm_wakeirq.h +++ b/include/linux/pm_wakeirq.h @@ -10,6 +10,7 @@ extern int dev_pm_set_wake_irq(struct device *dev, int ir= q); extern int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq); extern int dev_pm_set_dedicated_wake_irq_reverse(struct device *dev, int i= rq); extern void dev_pm_clear_wake_irq(struct device *dev); +extern int devm_pm_set_wake_irq(struct device *dev, int irq); =20 #else /* !CONFIG_PM */ =20 @@ -32,5 +33,10 @@ static inline void dev_pm_clear_wake_irq(struct device *= dev) { } =20 +static inline int devm_pm_set_wake_irq(struct device *dev, int irq) +{ + return 0; +} + #endif /* CONFIG_PM */ #endif /* _LINUX_PM_WAKEIRQ_H */ --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011020.outbound.protection.outlook.com [52.101.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B9C71D31AE; Fri, 3 Jan 2025 08:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893736; cv=fail; b=UOgG5NHrSc6dx7jyw+QE6QXhgA+MJs0W0yj5eD8y8NK1MYcYTBOViaEp4zsTtDjX5Kg1UhZYjfJUc9oc58cR2umVzHsArATjMER8JnLPfBFcTHTyah8wzqWnX48/CBKTeGL5kLg5FFJOphVUzZfadrkj06FTOUkDArrsmLGZ0sA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893736; c=relaxed/simple; bh=f0XWM6xBggK2QfOcHzd3+B2023F378UQ/qXOqelOuSw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sQ5mLN6bOmSeiiuc48vMqINUhU5Raofa+QUnsVhZarZ1quQfxOvqttQglb+XyukxEtM7U8nD0/m63b2Fpv4Z48S4W2NldNmkN9B99IWOsrBnPqMibinlCGWPr/a+vENKs6SeDzePiAk+jlyGNmc5Lhku+8nVykpp2cGthWuOWvs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=CgbFYNBD; arc=fail smtp.client-ip=52.101.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="CgbFYNBD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S1aH+MEkJL5DstVipxgKG6JRHaV/1Ve7AjvT5moKZG+24DF1F19ec5JL0AxlbkFVbweUK4ZVhiXSwqaf+lsxDxAR/4iTWFSnSvSxC0ch7STbUbgT/TrPNpGtwKF2hbSQFF9x7l3DXNwDfPshaE3AiOvR1arbtksbEWOlnRkdaGStWcCAB/Ak0Eb5IYJH7j9z1GUXO1eOL4iG8p2ybts9b8o7A9Bz4/gZoCte+K9Vjg2rxU5AGYqtTKs/XK3qtM2V6Io7tMJ0cQqWPrSWfDq1QirzQoFeOE48beVj92el+zZfLg81xn3W7NOEHbP+uCPfjGUUVf7CsZ/dYOHPHqFLjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=g+Gt9ZCwEdf+zk3TaGDp9Jh+IOMtI8QOTe/QVSUc+O9Y3I1/+UitbW2BCSvH1QSEiNhnJDKSdshSjUG4/nHf/zY/WqD9//hxz1j0UiaYOWBPB8zuPA0tpCbZgQ6j38zxeJIf+VH+w5vuS95gpzxDVl+x72yOYCrNjrewNV62B8zBfIFyoN4a/dYqTZOxe9eXD6riGHfD8dJXUS2EEv5r+WDgSgk5j/CNjZ5Tqj4l7EIT7K+VeK8W9LjxXCT08wNaRm2OE5A7EO+sFpbCL+JTnmbK7ZeMPW89gRsC2u9ggjPXnwIe82fQ7XOOoyDyXxq8Os5FSZ8TU1Q33OwKJ34RsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBJXBX/BlDu3iR52lDbc09nZRQMR+H0jkQvpTPg3SOY=; b=CgbFYNBDuGz8UJ8IfWvKeqMsk9s3KcXjoeEx4/S6BOp25/Zo3oL10mapeicpDGrr49bu5aJCll+91k8laxyjbXk0SyTc5OReAJILBRqhf3aEMmPlI/6zhiUhZqgEus3slEop9raYPBZOBP/cnJpJNwkYKztrLBiTC3dZS3GG3ybwfkhOoMqfcfOMi2eeGlQbZsubqWeJdTRiPmPN6MNA06CMUECE26dQsikGMjtByRmTbcOurOVrGaGbCVavBPuWyfedfw3xAW3YL7VxtrzlTvjdvdWgVtwjvIRrimYIILyYonmNWhrjh8aDQazYkLcJsjJdHyNKjoUYU0DDUpUrnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:07 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:07 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:14 +0800 Subject: [PATCH v2 02/12] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-2-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1402; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=lLk6bV9Q4qc+HUdwJdc/NyACnoatpwVUWdW9RwekWXs=; b=R9/qzuNawG0lBp3arrRjMdx/n5J25HPKu2UkbM3HWbYO1/MmCJQ6naNNy0xhmrFQWFa1HqZD+ xfQu4IBNzZKBQUW368Fey1iMo3Zzkr4YqCV8xVtsxLgW9IUk/Wzh57Z X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 82b7a357-005e-45ff-41f6-08dd2bd28193 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YXN2QmR0eTlBVlptckNlUmt4YWg5djFsRVU3ckJ2RnJjUWF3ZmZDYkJKNmdx?= =?utf-8?B?TkZvLzR5SnFkWWVFS0swQ3FUNmJUZ2luaWRORkg1N3QvbVJQVC9tb2NpYnJv?= =?utf-8?B?YW80RVhqQkdzaUVNeTJlVFFTVWk1b2IydFVycUhSelFPTC9aVi9lT0VNNFVp?= =?utf-8?B?bkZUcWJlL1ZlRDZpSWlMRVJxd0NuQ3VQYUxUd0FDQzNxcnZwd0lEeDBBRFMz?= =?utf-8?B?cElkSk5SejJTZDVFZ2ZnWWEzbWlwaS9SMzZIWllyYmo5ZnlRK0M1KzNBSjdl?= =?utf-8?B?MHkyN2xERkJNMXhFVnozaGZyOHVEMmNzdXZzSGU5ek92V2h0b0RPSk5LYkFh?= =?utf-8?B?Z3hteUF3aXdMR3ZjamdORzl2cTBNaXJXdjQ1Wnd4ZmdmS3oyaU9RWWl4NVF1?= =?utf-8?B?NjJtTzB4NkJkK3FGbHE3S1I3b0IyYm1OL0RTODA1T1RhV01CbDJvTXAwZlJV?= =?utf-8?B?UURQMkREOW5qUUkzd3JHbklvelRrakhHQXFDdUROQ0tlYlowTjJHY1ZBbDBy?= =?utf-8?B?Z1hlT3NmcTJKMWJOOExBSVI0Z1FDSkNxRlNuZitMUFZPK1JueTRwZHJOVEdT?= =?utf-8?B?WkFGUUtMUlhPaGVZK2U4SlRXWGlDdUNNVjZ2QmFST3N3NWZ6N0JJcGVrNkpt?= =?utf-8?B?QTAzZHBuUCs5MWNJWW5veUhNZWs4bllXS085ajlNYXBCM2tKZy9kWEtvVHlS?= =?utf-8?B?L2htTUVZdStnaHVHZkYrTnFSeVZEYjFYVGJLMVV6TUNGaUxxYUFxd0UyYU5a?= =?utf-8?B?UXIrdFVpNTkvUXdYaDJUZTJKYmg4VVFGaTlrZmFqM3B4a3lyOUNPdCs5bXFI?= =?utf-8?B?OG4rSUVxdmxWaTFER3RnaHNaUXNlRGFmQ0tqUEJjMkFLR25rY052RERGeU9D?= =?utf-8?B?eU1WSkRVVG1lb0s4SXFCRzlnamxYWmxyMUs4bEhxTGt3UHQ0RFd4U1ViU0w0?= =?utf-8?B?OUViNHd2TFcwWXhoUXJudDhkVFN5WFg0czBUS2hlMXBrSGpqVStlUDZ4SUJu?= =?utf-8?B?aVNKbGFNL1lDNGlka0ozMEMwaHBvYWFZYWJSMlJTclpZQngxdHM1SjdkZUxP?= =?utf-8?B?am0zd1U5TktVU1BBZzhsUDJFdGNiKzIyeFFuT2tseUZIUzNiWEJiQTcwcC9W?= =?utf-8?B?bWZPdk9sV0tPOGN0VzRaam83SE5xVXJvUlh0V1lyMHljVXVSV2xydlhVSDd3?= =?utf-8?B?UWUybnlFNUhJOEtZU01OWC9hdDMrUlN3MzBnS3k4Ym5uMmVkNlhVT1NDKyth?= =?utf-8?B?MTBhSWRTbjZBM3dLc2RZNTZaTHJYRkpWUWM4M2owWEdxcThWdERXRXhCVzZn?= =?utf-8?B?TGpVWXk0Q2xQTjl0NDVmUHpqOG1vdUl4eXNqdWtPTW5XbVA2bG9ZNU12Zmpn?= =?utf-8?B?cjJvdUtoQ2FDcUVldUlKckVsYm1yUTdXR3NwK0RHNHhjVGNIaWwyTCtmWFI1?= =?utf-8?B?S0Y1b1dCdUQxS2dHTWI3VWN4MjMvL1dyNUVJalJTNEpFMDl0UWtBOUxCeHdl?= =?utf-8?B?QzNjWWRUYmNrZXRsbjA5NUZEazNRYVlSb1FJTVVFUXJYKzVhbHdVWkxiS0FY?= =?utf-8?B?YnlHVTFtQVNObmNYUHB5VkJuN3oyRHo3ZHM1QWRFWDF0UW4xaDJ5SHF6Qkw1?= =?utf-8?B?ZTc1dGFmcW5lRnRmTE1zR2hlSkdrZlhiSVh4MjBQc0lVZ1BveGpuSkNueE05?= =?utf-8?B?UmJ4eVdLVGU0VTdEUHRDS1YwTzM1T21Id0xWd1BBM1laNmVOT3BHOU0xeWxi?= =?utf-8?B?cXBKbUhDVEsvT29sZU5KanFCeG5OQ1E3U25WK0VaM0tTZ1BFZmFPOXFkeHRX?= =?utf-8?B?SnZCazhRK0lpRUlVbTY0NnBCZjdhVkM5YWdjUXRlNUQ2cXVJY3E2MWlBeE1h?= =?utf-8?B?KzlLN2psdlBoUmRoL25kbllXRXJHald5TFFxTWp4ZVV0V1hqdERWS3UrbEhQ?= =?utf-8?Q?OVzwfqGJxd2WaX0yUiDcuIKlV26VM/lo?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGNMRUs1NzhDSFJzTlVjQ29DM3pQTGRNc0dJcVF1QjF0c1FLd0VvVmNKVjRQ?= =?utf-8?B?ZHJTWk1QU29UOVFmUEFCYnphalFndFIrK25XRUoySVZxNU9vU0JJcytwNlY4?= =?utf-8?B?ZVViRG9FVmN4TzhQZ0ViY2R6VEcrNUs3QURiRUQ0MHZyanNvQlVhRlNHVUp1?= =?utf-8?B?aC8xaW9qdTM0WmFsVWFoWGJTaTJvTTJWYzhYK3FwV2lmRVBlME5NSGprRDJi?= =?utf-8?B?QlVwWXVZSXY2TEtqSGdmK2RLc1BUZVlJT3E2WkdTNEIySUxBUkE3c1ZYMWt3?= =?utf-8?B?MzlWYis1SlRLejlQUDczZXR0YUhSVE9ucklwb2ZzbUZGUUtiQ2x2VWd3ZHN0?= =?utf-8?B?RHRrNlZrdDh6clFQaGdIZmdTRzBsNVhNL2NzOUV4Q01DNHJMZVd0SStRbDQ1?= =?utf-8?B?T3lEVlR1cnQrUk56YW9neXpUb0M4LzI2K0JWOWVCNlVtc1kxdmwrUGdkRWVU?= =?utf-8?B?TVA5ZDZ6WklhbGpLQU5lNmpzcWVyaGhvbWdBUGJJOGZjOHpFdkNOSlJsdEJC?= =?utf-8?B?bnBiQldFOElpRFd4bjg2N244OE43eDZmR2ptdTRHYUJTdDRpcmIySTkxVkU1?= =?utf-8?B?M2lFOUdCTDZ2TFBtOEg1QTF3ZjJQSU9PNHBZU21oOG1LQ3VPTFp6VnQ3SHhE?= =?utf-8?B?ZVZaU1FOeFRlaTErYmNJdGFSVzhsVFREbmMvTnJYTGUzLzAwb1ZZQ0xHcTVJ?= =?utf-8?B?WjNhVlV4M1hRcXhNaDl3MTlWWTA5VTlqWmNNaU9rcW1sNm9nYmEvVkdCL2dL?= =?utf-8?B?ckdJV2xOOUhYR1I0bmxVeFN0SExFSWRDeXlQNXZPc2dlUnJuRFBONjJ3MVlm?= =?utf-8?B?ZHA2YXBZTUxwQjRRTGZGY2NLZUc2V1dNOFBlOFk4a2NwUGpsb0lYWVpQRmxQ?= =?utf-8?B?UFFOM2lRektURjJCenhNNlRrako0S25yZXdEa0J4cEwyM1VaeDAvaVhzcHEz?= =?utf-8?B?MUI5UlcyUi93SElKb29pR25kMjBIckM3R285SXBTUWtlRDdZd2dxbUJMZXJO?= =?utf-8?B?NFZFRlg1ZEViU0RCT3FvaW5FWjh3WGxZcEh6eGovVEw1MWJQd3hYTnpac0sy?= =?utf-8?B?L08wN0VPVkJRQVdGMzIybVEyL1ltQkpid3A1RGExM3N3ZHRJTUdwUlFxRkRr?= =?utf-8?B?VXc5anc5YmNIUVRXNS9MRk4zdHgyOFdKU2NsNzZ2aFdSd0tpdUZFM2JaK1dz?= =?utf-8?B?Q01OVTJHWXNhOEgzcXJrREo3WjA3U0lna2c2ZEhpbG1WNS9pQXBjVnZvWHMv?= =?utf-8?B?c2UzWGplY1RJdzNkSStudnRVbW55VkNqMFpXM1VKNUJLV1VlNzRoNDZIdzE0?= =?utf-8?B?T0c3bnBhaUttZkh3RHl0V05ZOElqK3dUMTVmd2xOUDdnUU5RL080bXlHSTdG?= =?utf-8?B?TlE3Nk5CWGc3anQzY3Q5TUp0b1VwRkNQd0thcnNMeG5CVnhCVlN6VkpxK0RZ?= =?utf-8?B?aE5QZVA0c0VXWnQvdWk5OEE5YUd5VEFaRllqMnRpTzliZk1zUEpTT3Y4cXQr?= =?utf-8?B?eWZ5ckt3ZW1RK2FwQldJUXVkeVVmaUgwUEJuR1JiN2MxNkRReUcxb0RmWHRS?= =?utf-8?B?QXBzSXVVc2sreG5NQUNwdVJvUVJscVl0QnM5QmxGRnZsdmtPUU5KeUE1Vml1?= =?utf-8?B?WUVYem9lcHFFNllxcDhGWlFWRjNrTDFJRmlYRmJIYTBPeDdmWHNJcGRlUkNP?= =?utf-8?B?U0dMU1VzOE5yVDJWSGx1SFlaZ2V2TUJ2NmdSQjNnWnN5S1NjazluR0h2aitV?= =?utf-8?B?U1BkYUtpNHpMdzM5dFFEbDdzNUd0NS80aXQrcEFXd3g5a3Zlbm1hWk4vV0d1?= =?utf-8?B?Snh4eVlSUzJSUG8wZE9ucHZUKy9MQVlaeFI2WEhLYVZxbjcxQ1NOb2cxVk1V?= =?utf-8?B?b01DWDZsTkMvUExiRmpJZ3htaVZsQ1NGWGtzV1BCcHV0alY1dk1QK0FrbW5L?= =?utf-8?B?SjFsb3lxMGRBV3hEYS96V3Z2aytDV25jSll0Ujhmemd6YlpRK3MwYlF2TS9U?= =?utf-8?B?Q0tMTFJXM3gyVjl4S2pQT0hBNzJCVytEVkk5bVU4Q2pRbHBYZ2VsWUxYd05L?= =?utf-8?B?S0UwQkN6cmd4SnhCbzl5Z283eDQ3YUdnYVV5OGxwQ0FUNWFHWXUzOFVMWGo4?= =?utf-8?Q?lrkCZ/7uhymU7XoHVCoteo5er?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82b7a357-005e-45ff-41f6-08dd2bd28193 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:07.4608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bVjgLhuqcubx01q2NGl5hR+bX9gxV96kxlnjqpwmNZlGCKPMwxzv/hI3L5PEmXuTX4/2xuH7XrhBznoEcUFLYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/ep93xx_keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboar= d/ep93xx_keypad.c index 817c23438f6e5176431e1f736bb511f9919b67de..6e3cbe3ca72dbd43485c23f6042= b4fba007ff5e6 100644 --- a/drivers/input/keyboard/ep93xx_keypad.c +++ b/drivers/input/keyboard/ep93xx_keypad.c @@ -260,18 +260,13 @@ static int ep93xx_keypad_probe(struct platform_device= *pdev) platform_set_drvdata(pdev, keypad); =20 device_init_wakeup(&pdev->dev, 1); - err =3D dev_pm_set_wake_irq(&pdev->dev, keypad->irq); + err =3D devm_pm_set_wake_irq(&pdev->dev, keypad->irq); if (err) dev_warn(&pdev->dev, "failed to set up wakeup irq: %d\n", err); =20 return 0; } =20 -static void ep93xx_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id ep93xx_keypad_of_ids[] =3D { { .compatible =3D "cirrus,ep9307-keypad" }, { /* sentinel */ } @@ -285,7 +280,6 @@ static struct platform_driver ep93xx_keypad_driver =3D { .of_match_table =3D ep93xx_keypad_of_ids, }, .probe =3D ep93xx_keypad_probe, - .remove =3D ep93xx_keypad_remove, }; module_platform_driver(ep93xx_keypad_driver); =20 --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011052.outbound.protection.outlook.com [52.101.65.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29CE1D416E; Fri, 3 Jan 2025 08:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893741; cv=fail; b=Ezo9ABnufR7nR0fXrZHXeyySKaVc59fk62IgJ4841RTbm8MDJnnSe7XKZCbr3tKApT2YrZxKXGDS+KkFvi3+NwpQeJR/9jmk4G7nDPgjERh6/YxBFi7BOyG53tm7c+FepouaJ3LXEdSvdF5IKn5PFE9T18tdAHiISvCWxniF4io= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893741; c=relaxed/simple; bh=DNmSM/zlaiHe7y+SpoUtP9k7yyKM9LouOCBuhZSkcWM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=T/H3ZzrgiUQDDClKAtB43PU88XOeE2fD38Oo1RqDqFL7m2mGmAt8S0G9jCRFPmHP43jNaJ/jz4Qm1A8fzCZZmfM38yVAEolsrhMGwZuWcYIODCsvtXB0+UEipKD2NtiTTIxSTcEYPhQymVmY1hI17BddXuxB3l2tpMv8mb6I53k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jWSlDaxU; arc=fail smtp.client-ip=52.101.65.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jWSlDaxU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g1INAJ/bOnX7waGcQOg7lo1eI9rFoeSWtwOQGlYnLmwjeWgPOp7gf6HtI1fq/FBjkr4n2kV59rkDqf+MBpoG3cttcv17+m9nzwXmGHTw+rZztV1iRNKT3Xi7WqsIFFY26tck06O5gp4SfnMOy0a5EwqmH2s61vWw37rHOP/PYB1/3PSuob3ECeqz9fUrVpUjtDb7cy8hhaq/oAYpLuMI9dNE+Lg7uoeEawLOZwYkK1yW9lwqkIKhMSz1NB7E1x8D8D6CVdnQNQ3BntcOIdXhWpC8tVawaq1BlAlytFOhmcm+xo9d7nR2bdEZV6NEK79RBhsecqLsrt5zQIBZaJD5EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=G8pNF5BbMuGi/CHzERuc1+FxxvpeB0hnl60r2JKj0G4ZS9rj9L7yxg2uig/d8Q0XT8uH7GqOk7B252aGTRqDi0b+gF8aP5Aa+mHMsQ/IHLynrLVN0e8RgffBpCwmwJar+ct5mTKj7mXEmrFwNpCL2WNx0tiobGtN3Aq1PbByD5b2mR6nhzUFafOJpeTJDzi/L7Nn0j92LyE+WrlwJb1b8DKuY4F1gi+zJNrUy6wxbkF9RYEXnBkpW/JUbsyD49Rx1HqWaEgAggWxhdcvhNlfmy4EnRXG5j7W0g+JE3UaRUvuorjiJhbOGl2knwUQcCjVrvb4yhYiRvoUO0Mflood/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cS+DM8g/1DZ++lGRTiLrP/ykpiHku6xeI0up7+EwB9k=; b=jWSlDaxUOQPubjn6YnL2IP/M+C+3hKl4+vaCFOPmLstSF89B5X4SBcyj0CPu9YCKlLrGY7socGCUmjUwMDi/79U4buZMFp3lHDIw4XHEJb80jokM0AqqnFqkmQBcSvqzd8CaXvMZ06ifKhkilWmPqZKgR0nNLyjFnvBdQE9zgpsmynnD+Ro03oI1u+84ClpdX1fSGCopZ116KYRdtr6BSv4PReC+FI1Gw08Z1juCKrFQW1eozfnVlXleyZs3Z1BLo1CvZPjBSpzXYMWzNkjwAPpmMY7X688/dz3tYWGNii7X3/Wkq2EwczsCBjtjABg2b+StvK/FIOzCNTRf/Lm3EA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:12 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:12 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:15 +0800 Subject: [PATCH v2 03/12] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-3-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1365; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=IYFb5BcVnaCb3uUN830r92UAprUHpPfeHJSpQKDJq+A=; b=6nu0OAi33ocm78dkg6STG8L8Ee09UFhiaBJdS99JJA6i/e2entTy3W6z8anPmAJRyKnEZnYOi xtZqte/I1oQBSVE2uCc1ceFZ+1I7C7kgC1MkG7VRwOXgQJV3b/Wu1qH X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a5b7492-0c39-4819-01b4-08dd2bd284c5 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z29PZ3EvbXBnd2xsd1FXczhDKzJlYWltU3JUSUJhUjlld2MyUjQyMWszMm5J?= =?utf-8?B?RmV4MUlvV0g3UzgrMUFEVHlOcXBzRjkvMDZ2TWZFN3hkaWY5RmltSXJDb3JQ?= =?utf-8?B?YUFlYkw4NzFKSWZpR2pvQWRZenpWRmxqeXVLRGtiYm1Wb1E4QzBoQk85UHc5?= =?utf-8?B?Yzc4bUlxUU43ZUlJRDBQNFRKWmxnUXBrMjc4REF3b0hpMmtsRmRhVUxEaVVW?= =?utf-8?B?SlAyWFZSU2hOdVBwSzIzN1dYQ0padlVKVm1jRlRCYnRndmRTbmxsbW45WjVD?= =?utf-8?B?RFpJelg2UEVZbmVkRk0yc2d5RXFZLzl6UXYzdWxGbjduT2I3RGdtME0ydjN6?= =?utf-8?B?T0tpNGRwZSt0N0thNmF6VHBPNjNmR2dPWkpOWTRpcWJwQjkzcGxMeHN0emEz?= =?utf-8?B?MmNSYjBsVDg0OTdZdk8xcm9QVVR3K0srR3JLOXU4czRGNUk2eHlXRTFyQS8y?= =?utf-8?B?cWlPOW1adEM2NWx5RFJoL0I4enNkSjFndWpSRTRtMmlmYVg1ZUVZQ1Z6eEhi?= =?utf-8?B?ZGNuVER2NEFUQ0VMc1JoRkVUVjh0UHpCbHVYZHI1VGJEcnR4SUNtdjJpam95?= =?utf-8?B?RVQ4Z2xtc1JjR1NYWlNEak9raDRqNUhxUHdjWkIzVVlEODBtRVd5cVdZc2Jy?= =?utf-8?B?ckgycWhoeGIrYiswNnpMMjZBV3cvMUtCcUZWTTIwYnQyVTdFbmVUcFZaM0h0?= =?utf-8?B?UmN0NHQwa0VaVGNDRE9XVXk4ZjcvSWl4RjVPL1RHUjdZTmx1YVMvdjhYVHZB?= =?utf-8?B?K2ZDMVZnRWZQWmprMjZaRk8veEtlLzY1U0ZsYTFUaFcvUmpqZ0pVTW9XTE5B?= =?utf-8?B?WGRPNkhBTmVMcTBkem1pQzE1dTNPZVZLamNiRGRTME15eXRPTmFyaFA2TzU2?= =?utf-8?B?ZHZuYkRFLzRXU0wvYW16ZldrTUtTNWVoNVZaenB2YkpnWDQySEN4cXBQdzI1?= =?utf-8?B?cmczQ1RoYVhGSE51UHhsWTVmZWZwVCtZVTdKNGlzekJOa1pRTVY0ZWtucFBE?= =?utf-8?B?NDM4UzFtWEJ3UGpPWGxleXZzNjhBRFc4SFovQzIxYlBTZUYzM2V5U1RYWEVx?= =?utf-8?B?aDFRemdTbDdOL3ZtRFlzR0lrMDhDR1NoWU5MenNYK0UycnhtazBJelAxRk9R?= =?utf-8?B?ZHlEWXgvdVh0ZGdYRTE0ZWx5bWxvRThGRnNQWjNKUmYzZ3BEWENZSTUvaVJJ?= =?utf-8?B?Y3ZpdmowSThKNktWcGNXSHJyL011TVovb0dEa1c1RXhxVDBNSEZoQnRBZHF3?= =?utf-8?B?TnpaaFR1ZEJmUDNUcXFNWGdtbjY2YlNOa1hzZm54UmR4RUJnb3FhdEtXMHcr?= =?utf-8?B?bmFWK3pIL0Q2MG9NbGx2WjIrdEptRE8rMzhWNCsweWY1R04vaUNUSmw2NHdn?= =?utf-8?B?elFzOHg5SDhnN001Z3RVSndHaWNqZEJCMEpCSmUzU0Flbjd5d2hmQ3lvVEFB?= =?utf-8?B?QmRwWUp0ajMrQktHeTNlOFFkeExGY1FWaVBsWkFqcUx6OUZCMHExNmhwKytx?= =?utf-8?B?d2hGbGg4YVo0VDkxV3BSc1FpNkJsV3hHdTdCVGR0UVRqbjJFZW43aEJvTW1F?= =?utf-8?B?K295WnFvbEpJWmNsSkVGS1hWSEZybW5WcmZyUU1ncUVEdjIxY0o4bzJ6b3Jm?= =?utf-8?B?Sk5RZjlpWk90U2hNdjFYVFdsQVE0L0R0cnJLenJ2a2dOK2t5aExtSG9PK3hj?= =?utf-8?B?MTlYNlRCS1hiR1ZJQ25QdjlTMWNNVGptR0REelhvVlYzWTNJdWlaazcxQ1hl?= =?utf-8?B?Y1puTWh1ek9Lbk1vejFqenZvRlo5dnNUUXlONWQ2Y1JIN3FwejA2M042bzc4?= =?utf-8?B?ZmxGRTcwbm1xMForM01RdUVzZ1U5VURFamE1ZGdmRlhtSng4blVqckMxQ09n?= =?utf-8?B?RVR4TEtScGpHZ0hpY0o0UStwakMxcjRxWjEzNnBZTEUwV01vOTFFaG1QZjd6?= =?utf-8?Q?W+1Vs4D53mCaagZSyYoeK35jnU/ROc2U?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjhNOTlCY3ptbldjb29xU1kxaGxjdXJsQkRBSWZLUzV5MDF6NlNsRWpLTUlZ?= =?utf-8?B?NzE0SytNYlpSTVpDUWRwYnpKSWJobTRjekJZOW9wR05QUkVDRFp5TlFCT3Vm?= =?utf-8?B?aVpheTJPVUswNEsvc0FKQXZWMGJZQ0psL0tlQ1pnV2pDZEtOUm1ZMVV2RDdN?= =?utf-8?B?WG04NGdKTU5pM2gvaEcwcGZKME53TU1jcndVbkV4OXRhSlVkYys1akJ1Rk9R?= =?utf-8?B?NVM2dkZEclQ0dFN3Rno1WHhqOU9GVWxVWUVST0FaUmJOTHJINSt2N01wa2VT?= =?utf-8?B?YnJ3Ukd6eWUrT2xPY3MrWW9TS0ZJSlliWnNYY1AvNXU1Tk9DSldONThSd3pl?= =?utf-8?B?OThLZmRNOThYaFJuOXRFYWdFcGZ5K21qaXBzT2tad3NzWEtPUGlCbGQ3MWRy?= =?utf-8?B?M0o5T3dkZlBtazBHZTJ1cDNkTCt5VWtTeXlRdUxFMUVQc0dzMUxnM0J1N096?= =?utf-8?B?L3JRN2NDeDhtUTBTZGZ3bE9UYWdBNjk0Y3piaU9OamJJRHVlK0VrRVdGQjB3?= =?utf-8?B?Y3FJR28yZTRINSt2OTJ1eWYwMVRMUkdONmorOFM0bEZMY0UxMUpOOFRmdWJ6?= =?utf-8?B?ajgrUEN2ZkY1QzBGSlNQRHNCZ1ZVWW5ZTTA2U1VSMHR1d2lQNldERGRhNlhm?= =?utf-8?B?Q2hRZURSVng0R25RYmpodW5vSUxRaC9qWC9aM3RRbk41U2dYam5ISEFWY3Z6?= =?utf-8?B?V3phWEVVUUhRMjVISzdxZEZOd1Z6Wk03ODQ3Z3JXWGVpZmV5WXU4Ykx4M0tC?= =?utf-8?B?ckZGK3lwRGt1UElZMUljNkcrMTdyTVZ6Z0lKUXJ0R3FCYTViTzRGSVpCNTly?= =?utf-8?B?d0xpNjJWSDM3V0w0cXYvNEV0YzAwcndVTFpuTzRseG5RN1hESDU2L01lQzFF?= =?utf-8?B?T1FSSmJaa3hHWjhuTGViY083VWp6T0NyTnk2aDAwZ1hNaUpzWk9VYnVMQkNn?= =?utf-8?B?ekhrN2dQa3JKLzBSeTZMWG85ZHV0MHVhTE92TWR4WVpzMS9lcjU2eXlWTFhW?= =?utf-8?B?M1FQOEZRamg0dk5DOEZwbkpHWmtiaElPK3RIQUpTNUNjRUhPbFNMVXZsN0xL?= =?utf-8?B?dTBkSUFoMllmbmRvTnlUTkRsUE5BYVVQTGNnZzBvTFFHWk5wMmZrRm9nZGt3?= =?utf-8?B?aDZxNGhueks3SWdaOFFzdEJ4VW9qU0dtRDU2UTZ1VHVzOGhIems1aDYwanFR?= =?utf-8?B?SjhPcDFqd1BOZXArNUh2M2hwRU5hYjFEU293cWwxRUF0YW4rcXFmcEI5eVpp?= =?utf-8?B?WHgwb1RiQ25pcWpVS3JCcUtGSFRzenNhcDdDSzRKV3hVVGN5ZW9ZbmRxbFFX?= =?utf-8?B?cnBPSHhKU1Ayc2JrYWFrVE83cVF4STczS0FOS09QSG9JMXhNSnVIR3F6VnZR?= =?utf-8?B?V3BoZmgxaDZ4dEM2TWxEdlRrTStTTVlaU3lEd1RmbXFTd0ppUHlQOGprZVFn?= =?utf-8?B?UFgzaS9yVW1ndnBBT1N5ZVB2U2MwRnA4RFJNaUNOZERPK1VkOEpmRFhGaXpp?= =?utf-8?B?T0NFbFFLSXNDUkF1WGdJNXRXR1haQmVLZS9iS0VHRUo2cjlrTDhEQ2p4Undt?= =?utf-8?B?RVFpTDEwMXpEVjVkT2VkNEg2c1B6RTRadSt4bmRyeXlCVHpMWHBzYVpSYVhs?= =?utf-8?B?K29BR2RTWWthalkvK1Y5ZVVhZ2hXbWM0QXNObVNDRVh4TUZDTERjNytPMVJk?= =?utf-8?B?dEVZK1RCeTlmZTFyWkhQM0hmRFBrSjArU0ZiY3ViR2Y3N1o5c0htQWpnRC9P?= =?utf-8?B?VHRxVkJGWGlnNmE2RW9iS2RONmowR3FybDlSdHg4enpKNDFocm5DbjBybXo4?= =?utf-8?B?WDlmTFlMVXRzL09Vb2JzdVFEMSt0Q3ZMTzYxYWcraWtXWjdYS29VYUF0SUts?= =?utf-8?B?aWxJdnY2cTBxcGFMdklScllKU0FIT1JtY2dvdlVBYVVoQms0d2hVNWM1VGFq?= =?utf-8?B?K0tWMkFKVGhLeCs0dnF5OE5tUGh0a0NFdnBDcUdCaGc5L0dJZ0x5bzAyMXVD?= =?utf-8?B?aVpVa3BSZjl5VGcyUVl3ZUJ0SzRVRjBtZEtNM04rc1JESGpuUFl5OFpUZENq?= =?utf-8?B?K0RsQzEvZFZOaC9oZ1dKZDJmYUhvUkdXNjZweE1aZm9mTmtJM1lveEhRWkFt?= =?utf-8?Q?huFiG84gEMVSi/l0W8N5gxS4R?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5b7492-0c39-4819-01b4-08dd2bd284c5 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:12.8458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Al1AcWcXpcHbku+hg+Ivet65cdghWEwt0RvJoVscmF2Q0J6rZ/3D66Ut26X+mtb8wegDuWZFl9vECayGhy7ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/input/keyboard/omap4-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard= /omap4-keypad.c index bffe89c0717adf9ebe5b33892efa4dc30b158f83..b7bd649d1628a6bf10db4135f73= 778f62db92647 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -465,18 +465,13 @@ static int omap4_keypad_probe(struct platform_device = *pdev) } =20 device_init_wakeup(dev, true); - error =3D dev_pm_set_wake_irq(dev, keypad_data->irq); + error =3D devm_pm_set_wake_irq(dev, keypad_data->irq); if (error) dev_warn(dev, "failed to set up wakeup irq: %d\n", error); =20 return 0; } =20 -static void omap4_keypad_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id omap_keypad_dt_match[] =3D { { .compatible =3D "ti,omap4-keypad" }, {}, @@ -485,7 +480,6 @@ MODULE_DEVICE_TABLE(of, omap_keypad_dt_match); =20 static struct platform_driver omap4_keypad_driver =3D { .probe =3D omap4_keypad_probe, - .remove =3D omap4_keypad_remove, .driver =3D { .name =3D "omap4-keypad", .of_match_table =3D omap_keypad_dt_match, --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011040.outbound.protection.outlook.com [52.101.70.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67FF214D2B7; Fri, 3 Jan 2025 08:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893747; cv=fail; b=u7ucxL+cO+m1aE+e/EwkWkAys2pVITvNn0x+D59Fy8bzffC+Lt61wvRmcHvfxaZq/Y0RzPftoJ8wtHGFnMdriPUvC0wynDhvOK6bWG0ZO+9n6Z405Kh2LDqETpmzmHb7A6AW8II6hnZ6vnENByDlWfxCT5mWczwUF6XvLB2O1sM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893747; c=relaxed/simple; bh=zQeVfeCxLWPp1ta82McHGDfqjkgW42mBMCjsal6VJxQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=i8Ufd/7PA8Q2Jvn3WFExND+VisT0C4Ku5NCNFrhEeoLWxzqbBlhdZhMCowIC/MikQUx19CHoQY9zXQTSDTm321gUujGq/2sPIwXe16MVjFqK1BloEGM56Mv0AG1wAdDtTm31VqJv3u28cm4h8wLW1Q71w3CKufv6DUzXCnh+d3A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=cts5C0Oi; arc=fail smtp.client-ip=52.101.70.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="cts5C0Oi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x8tm0uvqhIf6eroM2HkdsD8BVwwRNYKIWwxjflnKELkq4poS1y+SHTdOD/JbLRK7kdBOQyQbfsNcLPfo1hOZSTtPt5e1mi0rtop5qPSlm06knOFNBiamsQLESAqhzu2CF3UHPzl2YYaC3Q5CLZwL0aYMQTShWL9c+LQM1VqR3y914G0F0/IOvYPhREeGpSEX/evzRg9+B+ArlNJlbMVq0eT7+pvuQEc9jxtNuos2gcb4ih4KlQE2voew2TrAmBpcMYjnVnhJfYdQjAZ8O4J9Q41q5bGl44GQrViGRdduWe56nlu3fXILxclWzgLHRUy6vZMTcOn60+23ojiwCI01Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=Ja/dB4ugHm6Vcl2ZZFuh1oA4BY9dX6PnHP4jpoR9vZyCMvsIO7JxrqPRgVzI4UlOFhPFF1XPNGla9fiSCRM7FQx4F8xL4Lzh+1qCaXFjRAsKVsuQ3yXFRkHnuSrps6lpJy8JcU8HTe+5wwUDYngFhaNw6iGk3CuMK1pM480D9lGv0EWXNwqT3m1SkKIuve7P39kyDYdntx0EhGZ523+GI3mcUa3PE3SGxjhFkzBLhNla8BC66neUXhvLmfBH6iHx9781FFrQneffCTMmAd3ugdeslrMjd8tt4ASgEtHQwSxE5NQUg/8skI+qBQFozCx9fnMc0icKdQxe7LyBUdWvCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eLJ6/6T287sMFeFzpA8pzl4U0kUK+AHmoE0BEwYo/f4=; b=cts5C0Oi00MJZmoRNM4haR+LCAm5msTkmn2uRXN/MAT6bD6ZTGs/SBu52cdodHHB7vKd7FaMjQ2K9jHz+keG2LH14/Nqe4eA82YhsqEkt+SxAqjt/S4HJRA+V61N9dzyGMgN7Wg7QbX6E1t6khUDIbatBQjOjUejj98LsYWe2WPfED5u46ztmLhk6zL8sWN/R9EhVpO1D9x05ndsgpOqGSra5cosXwk64TbT5jAPP4qpDU4O1Byr2+rZ9DjhkL2oLL70okzc1a53/V43vnCM7bxKBgtxoazTqDslAPi8SCh9bNkv44kIctxuMaDcMqTiqSMb7K9oxW1JF2hy4zA1tA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:18 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:18 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:16 +0800 Subject: [PATCH v2 04/12] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-4-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=g2vZhAdAlG59tJHA7zmPtBw4oLxwHW1tSbJmlo9rLyg=; b=+I6HRtno9tO1xMt9Xr1J/+5hT5bkBUElXdcTiUS7rB914jnH7yIGafGxTvgx5xbyGDYPREEEM qgLQ9gN7uKRA7a2DGATSZHotKncPnzAyRgYkI8jhhuEYvA3TZtkEnlB X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d65fc1e-2bc8-41dd-7b0c-08dd2bd287f7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R2lBVFJhemUwbmVSa0R0OFBNeE56aXVmcFhRdERpRzBqdkF5bjFrQ0NGeFA4?= =?utf-8?B?cVExZ0tYN2hSRTVQeExYK2NOVmlnZzUrbGZKbk42TFYzVHR6UXp0YVIyT2VI?= =?utf-8?B?akZEOWN2SU1qR1JZakZiZXNtMFMzL1pjS2pqeDREUGtkbkhFOUY5dVJYd2tK?= =?utf-8?B?ZWhEdExzRW9hRXFPOEt1L1N1ZmVRejgyVXBhK2NwTzBqdmROTmVNbXVZNmo1?= =?utf-8?B?ZEhCdGJDbUovTitzWEt0Z25zSTZqcy9yY3FyWi96K1VMYU1TdEtxUk1pc0RD?= =?utf-8?B?NEpIcDZpSThvVDNtQXBiWXJCVXduWlhjdVFHdE5ncWs3TzlhUHk2Ykp4NFVL?= =?utf-8?B?TXVwcTNuTW9QTEtReEd3cTJ5UjJkalFVNkZobG5xaFNYZ255TDlOR1VTa083?= =?utf-8?B?ZWwrWXI5b2xMNXlrMWdTcXFiMWVTdnBnVUR1OE1LKzNkS2dYU09XSEJ3enpD?= =?utf-8?B?enJRVU9TdzRzczE2TEZlTDNVRVdjdlVLUEVRUFNpM2xMZHhnWmxsWGRZc0R2?= =?utf-8?B?dEZNbDEwK0ZKaTdLZ0c0ZnNINjlZUS9ZRzRHcnNldGYxbWZNenhCZ0tDZ3l3?= =?utf-8?B?QjJQZHg4QVdRa04wR3dZSFordGtyVlNiVjZqRkx6ejhWbVMyQXdKMkFTTEc3?= =?utf-8?B?WFhaK1RVeXpKUDNhdERpM0czK1MwNnlFWFZpU3dxdXZXT3UwR1UycWllS0Nm?= =?utf-8?B?RmFKY2ZNbHBpdU42UHYweXo3NnhIdmMzVG9jaGlIdEppRmdTcGRWKzd4TnZk?= =?utf-8?B?RHZ4ZWNXWDA5aGY2UElJRWpSRHgwSEhsZVJ6RWxuWFZMMWs5aGxOOHh0ejJU?= =?utf-8?B?SGUwdDZZU21md1RUbTIyS3IvcEdpUW41dENudnNMaGo1VURid3JvTSt3a1lk?= =?utf-8?B?U3h6M1V6ektrbm43S1l5Z21KUWRGcEhrWktZUWxQM0xnRVNka2drR0h2RHkw?= =?utf-8?B?WWljSmJrZWNOK2N4aFZhSlgyWkR6R29HdWNRNkg5eDA0cTFtNkd3Q2EyUjBa?= =?utf-8?B?L2NrV0djcEhhcmNReVRCaVFEMWZDMlA3RStLdjl3ZGtMa3padXhEcmgvSDMy?= =?utf-8?B?aEpjQ0FLS2VXVU8rVUZ5eGM4YnlKWnJYcjM3N3NPa2MyaU1tMkY2eHVYQzd5?= =?utf-8?B?QWZmK3lENEh4R3R6NXA0Y3FRSWJtb0I0eGVIU1pyMUVzejh5eDAvblY2d3dp?= =?utf-8?B?QXR0Nm1qenExczQrUWhGS2lsakNMbEFDSGQzTEkzUzUva3Y3SHBKbEFvV1p1?= =?utf-8?B?T0FHY0FFcys1SGZ2dG1VcU9kNzhEeWp4UDNTOGFRaDFSbGdiaWliSnhIeFo5?= =?utf-8?B?eHJPYkR1YWo2ZWNXeHJTUjdRRE5wdzV5V1NPNE5MK1ByVS9RVGFmUTNkQkp6?= =?utf-8?B?N1gyZW85a2tHN2xhc1VLSmxFZWlLYXRJbklPZU1rSFlRalRQc3JmN01QQUIw?= =?utf-8?B?dVdiV2tjb0pENWo0KzNmNE0xZE4xdVdZNlVpYVh6UHFZdVozYzdadk16TzRC?= =?utf-8?B?djlob1NxWVljUlc3MDdSaGtxb0dSdW0zYjI1Nlh1Q1I3dFMzU3RuWk9HVENB?= =?utf-8?B?emM5RjV2TjNCM1d0NGowYUFXSC96b2VndURiYktISmxyR3ZmZHpYd0FxeCtL?= =?utf-8?B?Vm9mY3k4azRyWUJzcERGMTVQSUJaa2hJdjhxTFl0OU1MaWhMQWRPNmVBM1BE?= =?utf-8?B?cGdESWpiQjhsdzZjbWZJSEdNRTc0elBoQmcyTUtFMFFEblpLeThIWFlRdzdX?= =?utf-8?B?ZTRDNnFab0pwUHdyRENVTWpXNWc4Sm5XWVJlWmRDQTVLa0RVbXBOSVZFN1I2?= =?utf-8?B?SGNEd3ZnQXoveFdkQVdIZXc2cGtPaE5qVm5Id3V0Vmd3dnk3b1A4eVdWRXcw?= =?utf-8?B?d1hOeGxmRE52ZnFpN2tTYnlRWjNtSm92MkFhbEUvTEkvMXJ4czBRNnQyemxo?= =?utf-8?Q?Y0+5unj+C/N8EMblYcOJbTiEFiofZdi3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2FmZ3NKcWN5Q2ZLUUEyMlNKUFZabGZnR21sUzZoOXpsdWJLWHNFUXpHbFdI?= =?utf-8?B?VXcwd1BNSUhEeldPN0NESlpXM1pIZXUvSUlBMVRUcm1BY3oyLzNpdkE4clNH?= =?utf-8?B?dEhjd2lKWnJhdzlPYkhTTWl3TTlZWGRhWjFVTzVjb3JKRVpmemREOW9DZDZl?= =?utf-8?B?SVdMYTltVlFlT2Y3bUg1UGtNWStnbHFDdXNKNnpIRlg5VXA1UGZkZHRvcUxt?= =?utf-8?B?TEhnY205WU4zVlpDSVdoQUFVV3I0RGovVWFVT21SK0I4eVhpM3NBcC93UXEr?= =?utf-8?B?WVg1L3BtbXpGcWFwdWJ6cHhBUDZuOERlWVFGWHkxbmQ5MTdudEFNSWNscXll?= =?utf-8?B?QU1mVmhrOGFsRitycUlJS3N5c3B1OWNzRFMxaG5NeVB3Nmsxb0xSeEQ5Ky8x?= =?utf-8?B?K1pIRDJENDBRMVZEem1tUkFXc0VKWFd6WE5Ed2xSMkZPeHp1VUZIOEMwdzB4?= =?utf-8?B?ZTNJNHhXOTNPbEZSdU12b2FIaUJZZWVta0hJdlFQNjlOTk0wUENjZGVVMGxS?= =?utf-8?B?MjdBQUJsZ2x4WnN1T0doRkZ2VVcwcmJpd0xMOURpMmd5bTE5QjRIV1dkQUZo?= =?utf-8?B?Y1ZoVXNvQlY5Zk9OUWl5eUNNZ2hSUExENlBqUlhDRTcvUWVqR1BEZE4vNWZo?= =?utf-8?B?RnphVFY0NndySEpUb1cvV2F6U0JWM05DeGs0Q1hGZ250dExFUCtRVXhmZ05I?= =?utf-8?B?RnVvblVwdXNER3BWY20relkrQ2E5dzlFM0lDRi9JSnFvczEyU0RQd0dtZkRP?= =?utf-8?B?Z3RXcm11alRpdDdaZzJYNFltbkxFQTVxb0FhajFYVXgxNHNJVjE2NkhLRlVW?= =?utf-8?B?bmxtQUpNVnM5Vm5aMjErZkNHeEltcHVuS3RyM0szY3J6N2VmT3BPM2U5UXB5?= =?utf-8?B?TjZLTXZwS0gyeHV2Njd6UzBXeE05L256R1plc3NkbU5ZOGdXOUI1VDU0cTA2?= =?utf-8?B?ZmlDUTN1aHRoSVJYLzFsUnEwZHF5bzJuc0ttNGVwb01KT2dkK09PS2lNcitx?= =?utf-8?B?YVpPY3d1ODZCWUZXOVhPQ1ZCNWdPNW5WcVp6eDZlK3FxVmZkSnZrT0QvdW44?= =?utf-8?B?ZFNQNllzYUlNYnIxMk13Sjd6ZUxLOGh2dmZLL1BLdGk2ckVqamJ0eENKTndB?= =?utf-8?B?c3NEeko5amJ1clVIeFZBNGVFcnJzQXh0S29JT21jTGhDdlFZbHZhY3lLYjRn?= =?utf-8?B?dUtWV2czSTREQjRyR2kwSmlLeHdqa1FIWGN0aTBDZFoxTzBLY0MyOVdCY3FQ?= =?utf-8?B?MmUxTWhyT0x5QWRyYzAzNWJ0NHR0SHZlSTFuNng4U2RRVTNjVDdxL3dMYi9S?= =?utf-8?B?OGNWTnovQWNJY09raUlNVHpsN0F5aVE3bGRRdlpyaXlSU3BtTlV1TnBwc0FX?= =?utf-8?B?L1FqMnVvVUpUSXdwN3JralBZaEd3dmx6NUp5a1lGdVVoSlRTYlFzOTg4UmxU?= =?utf-8?B?MjRnYTlwZFE3NjJCemd3UEpOUW50cDdHRjhLaExGSFIxK1JtU01WMjRHVUF3?= =?utf-8?B?eEd5MFZRVmR3NjNBQ1V5MDBCMURoTXo5NmsyWEIzc2p6SDYzNWtSRGJBd1pT?= =?utf-8?B?ajU4QmRWMzk1ZWtLaVZPSjEyNnpneEp2YTNTOVNVdkJEUDhyVHFYaVAzYTJI?= =?utf-8?B?bTBzUy9FbUtla3FzZk9PbDF0Tkh6Q3M3dVdLOWFwMUhjakZkb0Y5RFN5WTU3?= =?utf-8?B?a2dJZ3IwVGp0ZmZnRWNRV0lPNmczeng2U1RDbGhkWWgwL2s4QS9leUF5YnRX?= =?utf-8?B?TmFCR2lYazIvVTRIZnczTGo3eFpHSnY2OXRFa21mQ2o0QjJHbE5Gd3JLc0VX?= =?utf-8?B?OUpQUVpEdzVpdGxGWnpYZDZmeTVGVEhNMUpIMjI1bi92M0VmbEtMQ1hjcXl1?= =?utf-8?B?QnNGVmpZYUlYTlhwZGFXZG9WM1E3VitjRkZnY0xBL3NwT2hJT0NySVdkNlV0?= =?utf-8?B?LzlxbnhTSEprZ1hFamxpSFd4WGIrVzQzekpWMmN6S0tOdzRMVDdHbmRNanhr?= =?utf-8?B?Z2NHRlRPMmtmekZhVVVGVHFFVDBKMGhzTEdVdStEemQ3L1pSWFU3SnYyMlZ1?= =?utf-8?B?bnh5azhhUVlkWkwvaGxmVzBNbUlaZ2hqdUJ3UXJBYkthY0k3ck95VEk4Y0F3?= =?utf-8?Q?Md6gp39qwxyRSOB8Xpp0ER0Is?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d65fc1e-2bc8-41dd-7b0c-08dd2bd287f7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:18.1998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: guPTvljsyGYzXe5O5VBVaJ2FUhM0XZRUy80MXfIHCNgH5u1s4/qtkgJW/BSEtHw/7k87VIluKfuvxEiml5HPqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp= -bbnsm-pwrkey.c index 7ba8d166d68c18b396e616f6f9074ae98c4629b7..5faad2c98af35c52dcacbf25728= dbaf2cbb3c625 100644 --- a/drivers/input/misc/nxp-bbnsm-pwrkey.c +++ b/drivers/input/misc/nxp-bbnsm-pwrkey.c @@ -179,20 +179,17 @@ static int bbnsm_pwrkey_probe(struct platform_device = *pdev) return error; } =20 - device_init_wakeup(&pdev->dev, true); - error =3D dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + error =3D devm_device_init_wakeup(&pdev->dev); + if (error) + return error; + + error =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); if (error) dev_warn(&pdev->dev, "irq wake enable failed.\n"); =20 return 0; } =20 -static void bbnsm_pwrkey_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static int __maybe_unused bbnsm_pwrkey_suspend(struct device *dev) { struct platform_device *pdev =3D to_platform_device(dev); @@ -229,8 +226,6 @@ static struct platform_driver bbnsm_pwrkey_driver =3D { .of_match_table =3D bbnsm_pwrkey_ids, }, .probe =3D bbnsm_pwrkey_probe, - .remove =3D bbnsm_pwrkey_remove, - }; module_platform_driver(bbnsm_pwrkey_driver); =20 --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012064.outbound.protection.outlook.com [52.101.66.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68D891D517B; Fri, 3 Jan 2025 08:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893753; cv=fail; b=PHN0XOAClWZ3bYX6kw/Oupc6DcCqfIiZfppwBEYyhLan7zq0GRwUac3De5f7l1Pbkk3lqIs4Wi3wySnd4inZaSKqHVBfvKn232sCbey9qqlZfeY5u3suZ2RzeMJ57+7Tobhn/beXnSyLg2dyvVfeVuEYZOZy43xsN6/D4GnHm1s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893753; c=relaxed/simple; bh=yGvaO4CE8KR0YjpwnelDEdIH1YkR2FTo1uOdpptvhd8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=N/YLCrXoLCC72PxrBP8p1BZ7//UH3hpMcZ5mUdAFbXX/K4LuIV8RbUAh0DqDk1PECv4GdnkiOVGgJVB4/zgRTEHOWxTuYTSresJRCwpPdmnHUXhlSd5Lvhd9/ziCyWCz2VoEWZBI4XWCkzXVBwy5pifPghgllEPYb3TdGohJFpI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=UzqqZG2w; arc=fail smtp.client-ip=52.101.66.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="UzqqZG2w" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UTjwbQU3kUsgvzGcCD3VBqY2J7+BYx7ckbBrgQCKX+8MCj4X1a9RY8hOfmcN6omDNc9dx7rkF6rW2WmFfHM17xCxijcq3wFIgaOP134Jw0iSq6AczjgMveuzdPVKhf/71t19EDZyZ0DkElxwZVKlNy0/6mnk6lqZoX1ZemSBS+awWHDm91jFYlzRTFR2Krru2dWN59MvKP9FCjN9ySWBwoBPhgdE3Ti0sPm/WmQLmDw8aUfbF4IOvUkuXX9/4Ubu9bXQkPfvKZaasHMOkCPlFWsUo7sbj0s3o6dfy3bSAyANcjKbbV65rAIcklpHxH33NeQDb1317If6DAVfMMv85w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=PI5ZGczYPQLrL1jP2Od5JiZSEG4FLCVBKFOubqTgMlA1agtGr2CVKGLY9KyvNKi52XuxpJgG4QgLzErtuxvUZaAzWJE9twsYiOB5f8e33OPVbCRbvl71DRiZaPJ5uGQ+P53+upzoqL2oKDhZ/j+7PInt11xgVAh15NUprJH1aUzl7L3wWrE+RscKj9NMtWwZyoYUO2kGUNRUS5lyLE2m5ddM+hUBmwy+n5D9ITlnzgcxcw4TBspE0pvck2e/kfd0FXj4bGjK0PwBPXjQPKSwQoP0j4kl8Zf6WCQeFrrNSFuxnT5b2XgA/m2sTdBEeU2f7hrwfiPrpUWefQ1elDz0JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhC1ngrU87eDqzUYVlj3esO6y93gVDOOhc8DDXGyy0w=; b=UzqqZG2wt7u3GOyLoPgZRvDb0RQGwAtCgwI1vmNZKRVjTpo07sVTFJns9v27st1R4idAwSHngrXtsOL9vq82o2EP5W0/YJHFEhVRib4EJrPLYim81mGqel+8asUavjxbSg48gJC+z/KqbKudGA/JvroHDHLYfXT9njob8Gj/rU5L9Mwnlg+nIfwfUe2EJh/2hwm/tRM3Onpq50VydBl7g6oKGgGgXO+q3Z8E5W34sIh4hTnQ5VODrj4xaRD4DgtMLO4yXmQUJzH1L1gznzVHXd/cxEz76fRbEfDEwGPHMB7QH3txBc3GftkX2byH6R/2ovO+igebHQO4pFZUytQCCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by GV1PR04MB9101.eurprd04.prod.outlook.com (2603:10a6:150:20::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:23 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:23 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:17 +0800 Subject: [PATCH v2 05/12] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-5-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=3411; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1lZmp/EoQtZDgK9cRNpEHi0IbcGjqZ+/tYP3nl5MGB4=; b=d+ynM2f+87jzy29uH2AmtGEhWDRO9UQf3P+P0Uubu3afIPgRsDzhnXyS3RMl2g4FSX1MqPgcH dHCQMbcmHz7ChbsmlULhgPAwEhZEjpD+rfpLGpCbGI27Ef2eX0u0yKJ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|GV1PR04MB9101:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e97a831-88b6-49cf-1515-08dd2bd28b28 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dXRBVVlIN2FIRVJvODUvTkp2TWFmeDlZQm91UVV1SFBMK3hHcWFEVXg0Zk9z?= =?utf-8?B?V0Q0eXNlallvZ1owc1duNEtjMzRyVWQ2MFY5dnRYYXVXWStTam40UXRPdnpj?= =?utf-8?B?MHd6QjY1THlEbHBVWHoyUHJzL2kzWEprcmdKVTRqdmY3TEhCSTFBandtUFpm?= =?utf-8?B?RzBJRkp0RDM5TU9jV1AxcE4ycEhzb2UyR3AwZzB2c3JkRGZGOWZxYzNzaHYw?= =?utf-8?B?NEZIK2poQ3I1cDJsQW00YmFZQlVIdTl6QlZjQmNGOHNtYVRhSjRvZjJGOGEv?= =?utf-8?B?SUw1WWNoaEpZcTM0TFBPSlREVjVoakRUS3ZnMzRuQjdsMmRzc2JlenUxZW5K?= =?utf-8?B?VndIR1RNejdRMjJvNktFTmRRQk4yWEU5NmxTcmhnb25JY3ZTMk92SmZFcXV3?= =?utf-8?B?dHpjSjluZGxBTWoyNW9SL05XU2hkdXZGcWNvV21aSUpEaEUzc3hYSlpDcnBw?= =?utf-8?B?RktzWGFZZUkwUXg1dStHV2E0L2lQeWo0RVdib2pUWWhHNEQzd053YTg0QjNY?= =?utf-8?B?cUNld2hBYkxoZXpleEQ3OFJKVTA0V2xUdlBrWjdwTVRGYXBFZjJjU21BRkV0?= =?utf-8?B?UFpRQjY3YnlpNENrek1BYVNlSldxbVBOSkMwS25WeGpEcGRuc01lRG43Uy93?= =?utf-8?B?a1cxMnVCb2FBK1pnbXF1dWdGL29iQnQ4RitYdnV2bmYyNkhRZXlBSHdWaENC?= =?utf-8?B?Y054VHJHYm1sbWp0N3hLQ1lZanJFTEhUSlZoZW15U1BDVVdSUGVHbnJETXZO?= =?utf-8?B?ekVOamRDZCs5SXRqakQyMTdUN3JMMml5aWhGZEY2dFYvNHZBWTRXY0piU3ZZ?= =?utf-8?B?WHNBRVNMWUU4ekxDV2tOdG1zUVhuOHdId2pmNmRtbGZzUjF6NzdQUmpoTG0v?= =?utf-8?B?VmptOVFQa1IyZ2lOZzJ1NTlBUVp6WkU3ZHg1MTEwWkUwQUxGaWZFSm1CRkNp?= =?utf-8?B?c1V1TkJQdE0xTk5WZWRXak5NcDhHUnJFdDNQZjNmZzFSd0xXTjN4RVI2ejha?= =?utf-8?B?cTBQa21uZlprOEgzVnROSElyNDJuVzA1bFJCUGVLdlJidEZCaUJaYWg5QXVw?= =?utf-8?B?TG1TMk9yeVNod2tRMXh3T1krb2FCdHprdnRCbzdLaDU1bWdKV1Bla1hRUDhV?= =?utf-8?B?dEdqcFFTQUY0Z1N6UnowU1FUY1hZYlhKcXAxelRaRFlNa2pPU1NNbzk1T1Fp?= =?utf-8?B?V2xWRmNJOG43VTJqdHNCcjN6SEdYSmtOb25RWE5MQ3FKWXlrNHZ3ZDJCQjdY?= =?utf-8?B?eUpVR2dTRS93dm9GZTdSRzRxMTVtdnl3dEhRcStUQW83ZHdySGVNYmc1N2dm?= =?utf-8?B?SnRQUHBOQTg0aDMxYk1zVlJJMGJTSDErVmNMZDU1WkpEc1dWTUIxcWdCTW5i?= =?utf-8?B?UVB0eFNTckR2RXFRVHE4Z0p2bjVJUmNtTzN6Smg2MUhOWmVtYU5ScnNRbXAw?= =?utf-8?B?bDhnQWl4dFcxQUF0YysxbDFXNDIyWUpaT0xhYTBpTFlsMVJjN0k2ZXBxTVlk?= =?utf-8?B?elJVL1BNNkU3STFJNWlXcDFwdEVJbmI1b1BjN1p2T3RneSswR2traVpHNWs2?= =?utf-8?B?MDZCS1p4SnJZZXEwV21QRE1VUEIvczZ0Q3cwVHNKWnJoeStiTU95NTdXMHhM?= =?utf-8?B?emlneXcyeHlKSmhBdnJtZnJLVlhQRTFoUzRnRENRYTNLcXdSeE9QRElyakp5?= =?utf-8?B?WXFhMWVPMkZZWUV6MlJteGU1KzM2YlMweDdQU3hFRHpQNkpRZ2I0T254K1Zx?= =?utf-8?B?VUhqVXBxYTFxUTdSZWd5Z2pGd0lISDNJOS9aSVNMZ1hDMk94dTJSbXpBdzkx?= =?utf-8?B?ZFFmZWgrZ2FqY1dGZFRjWVRGRXorY244ZEM4OTEzNlZGTUhzZXh6VHhhNSt3?= =?utf-8?B?d2VPQkU5MWVENHVJZzRGaCtnVXNXYTd3Unc0S0RoZzRKbEV6ekNmV3lVNWNr?= =?utf-8?B?MHh5MGZMdVpMMXVsR3RhRkVsQ3lZZU44OWhGU1lUZmIwVFRTU0Q2MHplcnFk?= =?utf-8?B?anZPTFM1ZFh3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1FnYlJVd2UrUjlpc3prd0pGZ3BzZmZwL3Z2Y3ZNaytCVi9ITWJRMTBXOVVD?= =?utf-8?B?WnY2Z084bkYyNzFvSDBjNiswbkNDYWFSZ1RLN3RxSHIweXk1cXBaZkczUzNC?= =?utf-8?B?ZmN3RUNpYm53ZmJHT0JFbnYxVDZvVndkbzlaL3pXTWtHYTh4MTVQQ3YycTZn?= =?utf-8?B?enlQVjNMQzJuMnkxV3JBMGhGY3cxWkhCUWxqSkhsNWpXWUJyM3BRTVpmSWk5?= =?utf-8?B?VkRBM0V4bzNkbDN3d3kwa0ZXUHk2WVgrM2xBZHVvcktCWUFGcmFwc2NtRGY3?= =?utf-8?B?WnhQVGV4dXI0MHpYRmhxQzZ4TmdtVUpibGloS0xDbDIyNkNHR1N1OGIydytv?= =?utf-8?B?VXVSMUhxMUZQTjdPVUZlOFY5c1R6Qi8rdjVaRDVVaDNFUU05NUI0NFlDOXBP?= =?utf-8?B?V2RreUM2UU5wQi9yU1VWWnlOK3M3VTRLNzcwM2REbjRvMHpXOE9SMTVwcWpS?= =?utf-8?B?ZVkwZEpYNlZIK3E4MEJFUWdjb0tsa3NyeWQ2NENPQVZ3elZrOEk2QkI5YzRW?= =?utf-8?B?bXY4czdQZTRLZk5tdHhVOEcvSW9kWEtWb2FPMnBUMXBVZDBtVTgzYytjWDZh?= =?utf-8?B?SldQNEVlYzdLeGhycGxZMkJ3MzQrakR4L2cyK0QxbVNRVDF4TlRZZUd0K0Z2?= =?utf-8?B?ZEoycGNWMWFPWW00dVZTdzQ5ZUQ0QnpsRXJLY2FYSm1MZHZvQUY5R2VTcXRT?= =?utf-8?B?ZzdZamlud3ZUNEdSTHBvTHZXNDBOeWd4cGFKTXdHdWYwOStiaFM5Mm9vNnQy?= =?utf-8?B?UlBYTzBqSWw3c1ovTFE4R0Zqd3FXMjJ3UXJvbFd1d2ZNMktsSkxwL3hSUW5R?= =?utf-8?B?SkJ3cHNSYXBjbVYyOGRtODZPdU14WEUraHpZcnZjenhGVnczSU1sY2k2dkZm?= =?utf-8?B?QkZUYjJzWVlQc1JFT1Z4bWtUWHkxdi96VWZNWDBDSEkrUmlQakU4eWpIRmdv?= =?utf-8?B?UEpyb2J2elVsZlhQTExINkJVVzJ2cFcxYkFFcWlZQk8vNitIaEY5VjNSdVlM?= =?utf-8?B?eXQ3VkM3dzZYSWVlMUdSUzZVVW9nWmo1SUxMY1oxUnpHY3J1YTJSVHpMYmVh?= =?utf-8?B?RDduRFVCdkwrNmdVeVRpMURBZFRDNnYvdUNoV2JLNEw1bjNhdUNndThLNUVM?= =?utf-8?B?Q2lOcWR2TE1ibUJtZllJUHRkd1dIeFZ2Z3VGTzh2VFBta3JWWmRKMTBKR3ZD?= =?utf-8?B?Y1FRTVpzb2lxU0hXb2t0dVV4cG05VVYrN3V1V2tuUGdib1N0TXQrdldCZ1Z1?= =?utf-8?B?QnFLdkZwdll0UTRhMi83Wk1zc2dvekFVMEw3cS9zRE12bFVwWW0zNU51VDdr?= =?utf-8?B?NWs2UHhOMGtZR2hnVWc3VnQwNk5aU1BJTkRTRFpROVA3alZMWmIxMnAzRVA3?= =?utf-8?B?eE1RUUVCVnFKVUlib2JhMHl4OUhJRUVhWG9QSFNweGJRNFREUy9IbzJXQ2sy?= =?utf-8?B?QURnbVluTFFFckZzRFpXSDhJR2xqdTZ1NC9MVFZCZXhZdk03bGFOWWR2UlVF?= =?utf-8?B?S0NSbC83Qi9RUFhEcHZ4cmxkbTZyOXlweHlmcEJvb3ptbTF5TWxLOXh2NUZm?= =?utf-8?B?SHBIZ1VIbEtRUmc5eWlza253cmJrN0lsNFJac1RZUmlOU2xocTFxc1E0MW1O?= =?utf-8?B?elFxcWp0ZGNTOUVKQmh4WkxHM3ZCS21heTZWejdKak1zbHp5WWlkajZyVkJy?= =?utf-8?B?T2k4dENGRGJYRk5BZDFNY1p6TysvanN1ak1tOHowUjZqbW85MUcrUzdidmRu?= =?utf-8?B?alpSd1BCakZlY01sOUM3c2ZHZzVUaUg3RmNXY2dEYXNXcisraDJHa2ZGcWtS?= =?utf-8?B?VkhweGZjdEoyck9kUVpWaHdhYUtkY1U0VVF6cDNGRm1lTGtEV1BCam9WYjIz?= =?utf-8?B?SjE4aWhvZHF0VUFMQklFdkkzaUhuZlV5b0hEdUNXU3hPMTdhcHRndFJhYWd1?= =?utf-8?B?MWJ6Q2ZlbVRtRkIvVVBMMUQ2blgzK3oyNjJ2Znl6aWVGY3kvdE5SNTUzNFdB?= =?utf-8?B?NzFaZTJGdFRVN3pMdlJEdDM3VU9ZQWIraVEyVVhheDlqZFIwc0tuYnYxanVC?= =?utf-8?B?L2pyWC9QRllZR2JtWjJ1bi9oczlCNHVGMUdyN2hjSTNPbjhJZDFTcDVXVkVn?= =?utf-8?Q?Fesh6f/bd0vOvy640lF2SRgqu?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e97a831-88b6-49cf-1515-08dd2bd28b28 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:23.6458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y76hL7eWCAXZ4d7JTo9bVzePVFX0j2fzFAQMsLIZQ5JQTBOPaaIewcvUe031gS25x5U7dcSyP+9f+TbdD/EjpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9101 From: Peng Fan Use devm_input_allocate_device/devm_kzalloc/devm_request_irq to simplify code Signed-off-by: Peng Fan --- drivers/input/touchscreen/ti_am335x_tsc.c | 43 ++++++++++-----------------= ---- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touc= hscreen/ti_am335x_tsc.c index 93d659ff90aa94ecbd7000fe05e0eef8ab3546ba..aef38b2e4e464e3b76395de5991= a0f41b4f852f4 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -418,12 +418,11 @@ static int titsc_probe(struct platform_device *pdev) int err; =20 /* Allocate memory for device */ - ts_dev =3D kzalloc(sizeof(*ts_dev), GFP_KERNEL); - input_dev =3D input_allocate_device(); + ts_dev =3D devm_kzalloc(&pdev->dev, sizeof(*ts_dev), GFP_KERNEL); + input_dev =3D devm_input_allocate_device(&pdev->dev); if (!ts_dev || !input_dev) { dev_err(&pdev->dev, "failed to allocate memory.\n"); - err =3D -ENOMEM; - goto err_free_mem; + return -ENOMEM; } =20 tscadc_dev->tsc =3D ts_dev; @@ -435,18 +434,21 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_parse_dt(pdev, ts_dev); if (err) { dev_err(&pdev->dev, "Could not find valid DT data.\n"); - goto err_free_mem; + return err; } =20 - err =3D request_irq(ts_dev->irq, titsc_irq, - IRQF_SHARED, pdev->dev.driver->name, ts_dev); + err =3D devm_request_irq(&pdev->dev, ts_dev->irq, titsc_irq, IRQF_SHARED, + pdev->dev.driver->name, ts_dev); if (err) { dev_err(&pdev->dev, "failed to allocate irq.\n"); - goto err_free_mem; + return err; } =20 - device_init_wakeup(&pdev->dev, true); - err =3D dev_pm_set_wake_irq(&pdev->dev, ts_dev->irq); + err =3D devm_device_init_wakeup(&pdev->dev); + if (err) + dev_err(&pdev->dev, "device init wakeup failed.\n"); + + err =3D devm_pm_set_wake_irq(&pdev->dev, ts_dev->irq); if (err) dev_err(&pdev->dev, "irq wake enable failed.\n"); =20 @@ -456,7 +458,7 @@ static int titsc_probe(struct platform_device *pdev) err =3D titsc_config_wires(ts_dev); if (err) { dev_err(&pdev->dev, "wrong i/p wire configuration\n"); - goto err_free_irq; + return err; } titsc_step_config(ts_dev); titsc_writel(ts_dev, REG_FIFO0THR, @@ -475,19 +477,10 @@ static int titsc_probe(struct platform_device *pdev) /* register to the input system */ err =3D input_register_device(input_dev); if (err) - goto err_free_irq; + return err; =20 platform_set_drvdata(pdev, ts_dev); return 0; - -err_free_irq: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); -err_free_mem: - input_free_device(input_dev); - kfree(ts_dev); - return err; } =20 static void titsc_remove(struct platform_device *pdev) @@ -495,18 +488,10 @@ static void titsc_remove(struct platform_device *pdev) struct titsc *ts_dev =3D platform_get_drvdata(pdev); u32 steps; =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - free_irq(ts_dev->irq, ts_dev); - /* total steps followed by the enable mask */ steps =3D 2 * ts_dev->coordinate_readouts + 2; steps =3D (1 << steps) - 1; am335x_tsc_se_clr(ts_dev->mfd_tscadc, steps); - - input_unregister_device(ts_dev->input); - - kfree(ts_dev); } =20 static int titsc_suspend(struct device *dev) --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 633D51D049D; Fri, 3 Jan 2025 08:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893758; cv=fail; b=Hv2qcYsIftT5lWeDLBFtq0wTrFhYq6UjedV/M+Y+9hWnx0Vhdt/BA5TRyBKspMH6CExm3b7tMatNyO7Dm7A1DAJoIArC/EqrOKcriUfRCCfrHuIqDh4akBVA0ya6KmfL5LDadfepMnBBKQucH2tT2h0Rm+pHgu6AZUCWZsQXJwU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893758; c=relaxed/simple; bh=JiSAV7Q4NNZurUbBcswCV+h/Lz5/1lhowxKOZ/KNAmw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ajiWfjinZ6rIs0j/re350mLvnVH7wPduPH+3Db2xZSwOWqSVZnvAgVVzeXlEQDwmxmrN4a94tb5Xdd2I2KRoF4q0vmiUMRAdCz320FVqaqz6p00Emarhrwm6Ernpg+igeplU3GSP7qg6FBfUXOZxBsckMtPm6XzxNXEKzberYAA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=fGUYm12T; arc=fail smtp.client-ip=40.107.20.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="fGUYm12T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n9tZLXK96LTb5DMTa0oxE0gtTQ57pmJ5KDGiVAo5R6p6LlRoTZ+iu8KkEo5UgUYQNbWquCHM9RA78fk8JU9VSZnW2J9wt8e3A4+gcsH1KMKiuYYP+apZGkod/oGP9XtcCcG+QVxPf0CNdMBA+rWXMunoJ08FYPzMAkVXQPp/opE5k1aj9aQ+ch/SG4CDjFwKUjge0yK2fUSYunZTFkKuCWCbNo3krtmW1XAlVw/J9/4G+c8Ch0WtPd1eN4s5RpEE1Ae56SNktr4fQXdXJMqvSM7l68k4tDWzB1DXwH0d8eixdN7D+KUaajl3luMjk9tPvfJXrklTvdK1ycxAN/5GKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvRxcJQkTcUxL+UY0CT1LkbMh/5QCJDI8WvxLfFze6k=; b=mDSjqbwFRfR3QBmdHtnQiHl9iqy4p3Y9k23qTai+X/b7qDExV6pNeNjFXsanGd8NbZadnDLImjIACu0ZA11GEdGCCUkrfjFBvsJv3/1Xg1OurbxhBwrbKbx6iulnuIo1P5Jm3k3m3DS8xri+sQohAdEvupRsPiHAhRbaUF0UKdexKuh/ch+ZEYbhaTf19Al7DRA+D3ILtzrSE8sL5nj8YzIVpRP26u6IW1g7pQWnwpHE50IN/h2wVtkb4tA77taPACWDiotasaqx4Rpq8D9XnSlZuOYMtQ3yWnOJirFwo7GNmnnv0YCDx9zxVHvzeWC4bH9jxExdTtnKR67TmCUvrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvRxcJQkTcUxL+UY0CT1LkbMh/5QCJDI8WvxLfFze6k=; b=fGUYm12T/DQCz0A8aQISU6V492G83wjCCdwnPhKHUQpkImKdXiMH1j4RarlI9ZBQpa9PRrMVEBGyzZknk6LUjWlsYwU1yKR0QtaylOADgELkVd2+DrrXg0Wtge90dn/FplsmSt/y0fQm4lovOt4Bj/QBzC4FwXAoakaZfYm13GzI93n4lxP7ZSA/HEbmCclmOHnUJc9zXXBvoMBk/EOYXJr24rcRFeQh05lVqDooTlXUnPfswqjRv72xTOcS6ls3zvL6lHKjwC5NiJJ8RZSw4WyXR5BeOLajPQbJ/2uxX9qLbwPEZvr7uxjJ6LFWca1+BlfouHIAzPxI+f5SgEo3Yw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:29 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:29 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:18 +0800 Subject: [PATCH v2 06/12] rtc: stm32: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-6-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1529; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=3L5kSry1bFWI+vzXqFXX2mukiWSnq2LH9PLt8NvYjoY=; b=Xu3sHTShAOCn276HCcSAjpYXzwQZYnEZUQUG/28E7wU8gCnra/3hnBowu+NsGfe4WKS3ziS7W vPvGrDFbiDDBnytnoXuv151BKhqwdVR4aBahH4Rtb6gqUmgcr5INuXs X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: ca160c3a-d728-47c1-9059-08dd2bd28e96 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cjk0Q1dGY3VtYkI0b3VOa3BoMnZORDZrcXFHWnMwZGxLcnJDYXNLMHNmeXRH?= =?utf-8?B?bk1kR0t1UGk4NTc2T1I1UjBacEl1WEZOTHoyNE0vTG9PZWcwb3BvUUluckE0?= =?utf-8?B?bkhiTGNwaDBFdC9rL3pKUWU2cFhMTzlFa2t5bEg3U2NIU3pzTXJMNjQ2blp1?= =?utf-8?B?NndnMnRtSE1walBrV2hGYVVMZ0Z3d3JmdGpoTXYyMTcwODgvdXFIcDlLYUxn?= =?utf-8?B?em1SRVJ4dVliNXJUQnA2MmdLbFYwZ1JXcitFUHBKT2g2Y0xYYk1XTVlNSmdN?= =?utf-8?B?SldWODBac1VYK280VWVSWFozb0lPeU9ES1Y4WVBaR3UrNmc3N3oyTU9ydjcw?= =?utf-8?B?QkF0bWZ4blFTMTVHSW1EMm9uaGN4c0R6NHVOelIvc0xsNm1Icm9OV0xFTWZJ?= =?utf-8?B?bjhJMWRtZTIrTGYxY3Q0d0N5TkRKSFI0Lzd0MVEzeE5kV3hnR04xOEZyQXIx?= =?utf-8?B?WnRIODU5Vk85QnR5VGVtaGRNbERZbTRMc3Q0WGFqTzk0NnVPNS8wWmlOeXZZ?= =?utf-8?B?cXkzQWdWK3hNM0ZlVWJOY2FkMkFwNkFUOTlpejdGaWVzdUpoME0xbGpCTjcr?= =?utf-8?B?cDBGNzU3a2RZZFU4U3U2YUtuUXg4dG9CMEcrSUIxN2QrbGZES3U4cFQ3bnhh?= =?utf-8?B?RkxzSkVGcnlhb0ZMc0VUNG1YZGMxeTJ2MUJreUQvVk1mOFkwd2pNYlNCQm1D?= =?utf-8?B?MTVzZWozZnY2NmtRdk1QSzBTUUFyOUVjV1J2WW9ZTXAzUVpiVWhSSlJJdk53?= =?utf-8?B?VHFhdnJjbWZzbC9VMzBtVm41MVVISnVlYVhDaGhyVG5WaDJTcUd0WjlTVGlO?= =?utf-8?B?c1hYaDhBc1h0a1VIbTBDU1VQYUVxaEs3WkQzMDdtVVkzS3pBeTQ5OE40cTRQ?= =?utf-8?B?ZXZwaEp2WWc0UXE4U1JZSzhCNHBldnZjcmdpUDFGV1lHL3JldGVzL2c4R21O?= =?utf-8?B?ZEFBcGFsU2t0eDFnb2ZJVklJaCtQRkZKNTFFVnRMR1JoeXFjUkNOdVRsYTJm?= =?utf-8?B?b2FWMFlvY0h2dXVML3lWOE80RVhiZWhvZGpuczM0Y0FCMHI2dUE3dEw2UFQ1?= =?utf-8?B?aXpGSUFhWk5RMFpYdHkxNFA2QWhhZlQrSVFSbStkak5iN1c3djJTVjU0VDYr?= =?utf-8?B?aWNGbFpBcmY1Ni9kUGlGTHZ5OU5lQUpmNUdxOHlMRzNPYzZFSmt5S1MrZ21G?= =?utf-8?B?dVd3cXByZlNGZW5YaEdnOW9udkwxYUtyL2QrQkQ0T2NkUko2WnphQVNhV1NW?= =?utf-8?B?VDNrMkdNVVNuN1ZXWkkwRnlLdVRXeHZ1U2c2K1hvbUVFdktiM0MweUpEeWwy?= =?utf-8?B?WndrR0tZTEMxdEdkUXd3TzhidURrcElrSGxmd0JPS2xGbEpFVm10aXBzdEN2?= =?utf-8?B?UytZUlVVMTVibGp5RG5scmI4Vm1UbFBRUDc1c3I2NHdmaytPRjRaZFlZY1Nt?= =?utf-8?B?b2ZsWVlVZEpTWWZPTnFuajVscGdYQzlWUGRncThFbW0wTkNoUkE0RUtvZERl?= =?utf-8?B?ZFc0MUlKVGN4RXJwRG8wdFNvT0dCZm1xRGZMOVdUajZFbGVrRFhkWXRWeVpS?= =?utf-8?B?eFdrQitZT003NTVJbHJ4cFBJV3duckNyWTFveUZtb0pXU3dJajMyUUNqaGRS?= =?utf-8?B?aW5TcWtDZkFDNitUcWs2a2Z5bjB6V3lYOVBwVUFISmNNdHdtY3NuZ3JmcTNl?= =?utf-8?B?OS9CM3FwOFhaUGdCWC8zVjNuK0ozTTQxUHFSdXVUaVhUdXIxQ0Y2M245b2pW?= =?utf-8?B?QUdYVWNJTDRrS2xkR0M2TDJZZTMwQWFsbUV3a3gzK0dVSGVKb3JmY1c3b1JF?= =?utf-8?B?QTR3dC9nZWgyRzFOL3BJYTg5WFFOR3RUdXZZU0hUM2ZEU1pTTlhkZW1oOTBr?= =?utf-8?B?UTFLM3pmZUpWTU1VWm10dWdWWUpIaHYveUFkS2psNWwxVFhoaUgwRUtGTWRv?= =?utf-8?B?aDZRVnVKNjhyN0hua0gxeWkxdHp3K0UxemxMc082Vmt5TjRwRTA2anAzRTJT?= =?utf-8?B?S1JHTlcxbEZBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THFER1FUYUdMejU3cHQ5bzMrRktiZ3dRbk5zZVpvVTUrVHlVWkZ0dWYyNysw?= =?utf-8?B?WU1YRk5Cb0ZvNjVnQ2N1cCtOZXA3ZkNHYXNMeFFrQjEwY2s1ZDVxanhobnp3?= =?utf-8?B?Ry9lUmJxcjFWNUNCTlVtMVo3aVFra2E0YW1TTTZ5eUFVUm1lbFo4K0wyTHVU?= =?utf-8?B?M2hTYmlRZVpkTi9sMkhJbXVrTi9UcXdrckR4MzQ4Y3c0M1VyWnZWazd5bXFY?= =?utf-8?B?ZGMrNnBXeUJaZmpHclBsZk9tQzc0ZVJUaVllRmpHbkx3cG5GTXk3UEI1YXUz?= =?utf-8?B?Y09nam9Td2VzWnhFdy9oUzJEMGg1MldCTzV5TlFZSFA3S09YV3VjRWhKdTZT?= =?utf-8?B?UTZXV1ZKREZEcmtKL1Ird1lNcHpEdHhIZURTeGFWSHM0Tys2aVNKZG1MQW9Q?= =?utf-8?B?Z2pUaml3REFZUnNlaGNqa2d1dExmOHFieWpJVDZoUUFnYmtJc05TNWFlR1JZ?= =?utf-8?B?Q3ppVWZWcmdSdmxBdko0THc4cU05dVdCWFdxcU1jb3IwRk9UQXZ5V3ZPa25X?= =?utf-8?B?TVRiV2ZRM2dTMHIydHRvS2ZuMHpHdWtkbCtQV1pTUWtlY0I1RjBVdUxRbTha?= =?utf-8?B?L0x0WU5JQWE4OWNzUFluMERSVDNlc0VjOE1nYmZiMHNNKzFqT0hiSVdVYmFO?= =?utf-8?B?bFFqbEdoN0IxWXowMy91OFlrRzlDWWZtYXJqUmYwQng0NERJY3pPY3Rib2Vx?= =?utf-8?B?WWpjcnVJbUkxWUhYNkpOTHRUVWxyUDdDOW8ybG80cFRMdkVLbHJBQjcyeXRP?= =?utf-8?B?YWE3TFFTKy9HSlMzY2YzWlF1WGVvNWZSSXVPZGZnNElHaUQ3dVgxZG80SjdE?= =?utf-8?B?a3dyYndIODJlRmF5dXYxZHFDdm9rdG1FYks2U3lWSTd5cE9hTUFBZlpaSHJK?= =?utf-8?B?NUo0TkJxdHBYV045dWEreFFhNHMrM0pwRS9Id0NDOTJvaXFQUXZtdWgyT0pN?= =?utf-8?B?SXc4MFRUT1FlWXJPOTBxZDVjaWp0Nmh0SHNicnM0Myt6alhFcElJTzFvU2RG?= =?utf-8?B?V0pKQmFDbGdONVpxSjAxZDBYQU10WWQvWjZpaG1Xc2lkbGxEUUNZYm5YWGw2?= =?utf-8?B?KzNSbWZ2R1Vsd0JoemRxVllsZGRtU25GVkhqK29vQWx0ZTUvbU0zM3lJdVVR?= =?utf-8?B?NEs1Q3BwcnZhVzNuME5IK0JxM2k3YWMvbW42NFphZUpBNDR5UThCamhZTC9a?= =?utf-8?B?TWo3ajcrMFh6NlJNT1lORWJ6OXZCMHh1bmR3ditxa053bnVmeHpld1hTYTdu?= =?utf-8?B?cVpjSG5RRmZjM2NWbjl6dlMwYnRZZVUrVUFQUjRBUXRmN0pCWE1Xb080RWp4?= =?utf-8?B?bk9xS3JYSVB2YTNUZWdDdGorNCtpMFpPZFFXNGhnZm1HdWlTN01laE5HSnFE?= =?utf-8?B?ZTRUZ1E3RU1xQ3dMajQzSGhMSFZxSW85cklzd2V3Tm1oRGxRNFlSQmlreTgw?= =?utf-8?B?R1dqTzkzd3NlNGVkbG4xZk9Oa1Jtc21BL2JrV3VxZ0hiRnRkVUlORzlKTkxq?= =?utf-8?B?bEpiWEFDN25yeTBpMGFTVzZLdmUzdmdNenFsUG45ZXhhNzhUc243U2dibU5u?= =?utf-8?B?MFRpZnNMdW43cStZcS9ubUlFcG5Jc1ZJblZ4SkV5aGRTYWFNZkdSYWdTUTBF?= =?utf-8?B?dWMvT2JVT3Y4TlE0MkhEdjg2cTA2S1Uvb3laTXZvNjM4NnJBNFhOdkIrSTcr?= =?utf-8?B?eTR5MXZHMDMvUlZXb1Y3ZjlocW1ic2RaRXUySXFvdlAySFNnRHJuVm13Y3Zo?= =?utf-8?B?ZEdEWEVHRWlXWnlXajVMTTlGcmpRUEl1WTNkenZ3eW9keDFURDVRMTFYVmNk?= =?utf-8?B?WU5PTmNXY0IyaDVnYU1FMVhVRzN1Rkl1bDhWS1E0UUF5MnhGWGJldTluMERV?= =?utf-8?B?eUxmVTJ1blFGcnduNE14V0JaWE5tTEdLTVhmYXJLVURpbTdJK1hxQ1NqQlZq?= =?utf-8?B?K3Jvakg0K0V3Z3U3MkI5bGtucThxWE5URTl4elRlblovZnN3dzM4emZBNVlt?= =?utf-8?B?TXU2TUlnaDJLR0JTbG9HWXhnYzBiLzg0VEJaRmxKM1ZSaEtUSFZrbXlhL1Rq?= =?utf-8?B?c054d3FQdmM2YUVIMk5xWGZISGpYRkxhQVgvT2wvRVE4VnFOVHVpdHVvQXVP?= =?utf-8?Q?tEzSMm6ga1ZdTd4NXcq2Trq1a?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca160c3a-d728-47c1-9059-08dd2bd28e96 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:29.2992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dkR6W/pclZiIsEJzYoDiIo3vnWW/iJPYiyS5Q0PmwImUWFPl9uIhTvvxsyInNit2cAyD4JzwhaUbi+W4YceHAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan Reviewed-by: Antonio Borneo --- drivers/rtc/rtc-stm32.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 9f1a019ec8afa57245c6d40d378ec50fdcd64deb..183017b0d33d10481f94891de24= cf2eee95893f5 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -1151,11 +1151,11 @@ static int stm32_rtc_probe(struct platform_device *= pdev) goto err; } =20 - ret =3D device_init_wakeup(&pdev->dev, true); + ret =3D devm_device_init_wakeup(&pdev->dev); if (ret) goto err; =20 - ret =3D dev_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); + ret =3D devm_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); if (ret) goto err; =20 @@ -1216,9 +1216,6 @@ static int stm32_rtc_probe(struct platform_device *pd= ev) if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); =20 - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; } =20 @@ -1245,9 +1242,6 @@ static void stm32_rtc_remove(struct platform_device *= pdev) /* Enable backup domain write protection if needed */ if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); } =20 static int stm32_rtc_suspend(struct device *dev) --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2058.outbound.protection.outlook.com [40.107.20.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 702241D14FF; Fri, 3 Jan 2025 08:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893764; cv=fail; b=gH45UwVyjst0il29pALyvatnvzdmxTSPe+tsEmlgdr3I/4X6vjVEXZbLutatWA4MUuOGQFHOh1krTJB9aSHUTaB4TNk2IKO6zC4bV0hUGCM+3Qy+9WOZ7PLKodTwnL2TopmhZQVT6Nwd9jEAjyBxn25TFtJNKJxCLsGb0ocT9ig= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893764; c=relaxed/simple; bh=bGv4dF3gwaQ8/rybE3qOHzdzrW8kBSYtqBarBhutlJE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=pWxj6XfEhp3AGkRPrZI5nGGqXrUdUhKK3GUHHuseUzRjJQCQ41jiikU4vhPipXuPDARrYDqVeh2uM0ogDFrVcPfcXSNK0XWht8mq1C4ZeO2xvbpcKEIV2JeSmj/C2C9fq66c1p8q7SNeXNeSj/HVW7/DpHBgSXlTt295UN4PKkE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=wCGHfmJk; arc=fail smtp.client-ip=40.107.20.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="wCGHfmJk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aOPYu/jF9/SCCeRnvhLOfOGctYxsmO7WXa9ShemzMzqeuwTaUhhzk/w1stNS5xQ2DZ/dtFzmOwzmnxflT0ELXjgPKpsqASyo8vyvmcl2lZgNsviObWQ/Qalp4i1SAGm0pUfTKVW/yqYR7Q87rU8eUy4Nb1JVVz9UIPqmfP4lOuSsM67F1DVZWuTvqZ55P+/xJNC02495uqKaKJhDkZUmMfaw33GgitvBfwZ/Wb2a6j3ULvwAFoCThkD5rHD/T15YdpZmloDsOGNGKKXSiufOXpcSON0ZRULkLJyT0lKRI6xnvyCc+TCjFGfTD/fZMoBIQX5PhGJaMhxHGjL0+1VGZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=n7+9FX+e85Ek1w2uOgOWwpxZkery+EJHyUqFuiOSGJPCqTI5U0vqE3HdryBsAgn4uLp4AlxlPxEUuj7bJ2fHxS1/vdy0s36OQKnEsjbfxGqGtcePTVGtFPgu2oKJ98BrqE8srZzdh3dzrqeVEfxAaeoh7dEPAXnZeuJH/UHP1XpT4V/ydaOEYWRwo6kDFfBPsBSQHg/pQxTVwzQdMyWD3g3wHyEGJyPJl5HhLv2fUoZnNIhLIsbcaL7+Ch9EABXutYOgi0AwaieO3xe+7Iw8sPlcR4WSi5lzU++kqpx4cLYmriypwSpdg96nrnkcwaC3v43/Qa3OyYmAnwi2J1fwHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=wCGHfmJkhq7G5hMBmyhLCziZKfqotmzL7S2spd2FQB0hf9saaSEZUUiwITRzMv1YXA30FIdzx/L2zJg0V2pbieM7SwL7c+iomeuQjVh5EZzD3/bSE5oLMvAcmc3GK22QRhHIZ0fh5+T6Qb5UcA2B9chWU49xAwbWZCYDlFEGYt68gtKEZE1pFBp1COOSzpNx/uS5f6pr7M1W8xqYm4VcA+tAp7ycJqp3JonC9tIvIkbyvSdTJPHEb/8L84SeFZ+bzzYyNOTfAUr5s+gcD4DqLJX4U17hiolDAHZlcgL61Qkl9wE4oTsAsSQ/Xf3eP3RxBHr1lBhn14vCHPoKq67LCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:35 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:34 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:19 +0800 Subject: [PATCH v2 07/12] rtc: nxp-bbnsm: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-7-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=2071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=VAulaoWVPhHtzgpO1nG1u9VR+bogAGzfLBxhdt2/l0I=; b=SJnE6nTcSAS4I1d291x5RNISbMdR92Y3bdxMVEhj1npS25/awsjbGzI0msy/0HB1ZZ6MKzP/4 7OsAdosToQ/CU+1nt5kyf4smIDYXBQh0LTFZYtNiILaJ7E8DONqwLFc X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e8242c8-3877-4214-7a14-08dd2bd291ee X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U1E0ZnppS0tvRHZ2eGdKL2dGOVhGNk4wSTJEMkpJSFZGMUw1OVN5YytqVzRj?= =?utf-8?B?dzJwWjhmQUpraG91SUNCSE9laFVFMFR3T3JTNlZ1TzlEMWEwaTIyc2l2TWZM?= =?utf-8?B?a3F3dUlCcnk1aDVNclVJeVdqc0xsUlR4U3NYL29tcUNOWDFzTlAyWXlFOVkw?= =?utf-8?B?cWxyRnNtdFFLL2FYeER5QlBSMXBIZUNFZWg3R3BiVmRXSGRiZmlML3VadnF1?= =?utf-8?B?K0Z6WVpsd29UcGhoR3l5MGUyZldNWTZ3aSswaWhaYXlNSERJMkJWYnV5ZVNS?= =?utf-8?B?NzdjcjlRSjhVZ280ZlJsSEN3THBUZXlXY1VpenNwWTZKbk1BdWF2blZpblFS?= =?utf-8?B?bTFGVlN4RFFxL3FvalJSSjNUbThhZXhIYm1WWGtMSHRrTWFjVnhrb04xRCtT?= =?utf-8?B?OEJQMWlPRW84bEt1aWFPUDVVNFJ2Vk01cjREWVUyOXRSUm9pVGdKeGdlQUJG?= =?utf-8?B?SUpwcXo4Slg4bWlOLzZGL0RMakRxTGNlL3lBaEZqakFNVWFzTmJ1bEF5N3c2?= =?utf-8?B?WXFVUU9mbVN0QmhxcHkrbFhMdWJtTEhVZEVXVVVQNVJKbVpXVkdHK0loRlFi?= =?utf-8?B?eWsrVmpsRFNCR295SU9sbmo0ZjdsOWkrd0YrRnlvd0FIby9BM3o5Y3NVZ09P?= =?utf-8?B?djRPOEpPVkoyQ0FwVU1HMHVUYjR2NGVLR0o1N3dLeE44bXhVN25yOUphekhT?= =?utf-8?B?bk1NK1NvTzVyUmU2bHN2YlVjRnpFcmxZd0wzQmJ6ek96Z3JNU3FMTHcybFhW?= =?utf-8?B?akRnczY4UWthbVVuVGVVaThER0JBdEhOWVBqdnlKZ1RRVWZUa3hNeERRdTNY?= =?utf-8?B?R1V2VzFhNjhYMmd3VnBXazhKeHZBR1BNalVQNitJY0JtS0tvOTBIU1ltNVJ6?= =?utf-8?B?a3hvOHhPUEhvV3Y0NFpGQUJZWXAvQXNldWkwTWs3REJpaWR0RzNlNUo5V2Ny?= =?utf-8?B?YTBlZFE5TXhNeXU0eUtiWTVZWUl6YkJMVjlmMTg4czRiZ1RNQ1hlelZaTnll?= =?utf-8?B?VkpUTWQxWnA1a1JtUU1xY0g0YjhzdHhGMDA4WE9xbEcwNHVJZGdKcVg2ckR3?= =?utf-8?B?ZVJyNThBT09OS05CdnhjZTd6NlRmSnNESnRhQlZXZ1pkOUJGV2JoRXVmcWox?= =?utf-8?B?bkF3Qy91L0pURVRRanNNN3ZIU2FEVjJpeG9FUXhrRThpTDgxRnVvdC9oOER3?= =?utf-8?B?a0UrQkZDYzBSakIzQ3BJM0drMEd2UDV2bVp4L3lQQzBQNjJWU2ZKbEY4QmZZ?= =?utf-8?B?RHdNcDdDRUNybEFwQnRYeUp0elBqbW13UUdLV2FoeEtSMHBlNjhZS2FpS0hO?= =?utf-8?B?RHNVeE9Wd2JMa1d1eEJ6ajdrQUhuU0dMUkh3U3MvTEVjOTlGS1NnQVNBRi8r?= =?utf-8?B?ZVFwMXdUQnJuZHg3TTdFaWJpMC81L05nbGxxYWpRM3YvK2d1WlB3SjdBenRI?= =?utf-8?B?VHUxSHZZUG5FcUN5N2NtenBXRjg2RHNrb3FPL1VQNEUwV2hOdDY3azU5cGFt?= =?utf-8?B?YWJFUUtTZ0RGczFRNm01WFNRUmdLT2JOUFp1L2w2N1M2M1BnWXR3cTl4TXVV?= =?utf-8?B?TlljTEZYWWxiM2hhZ2drVHVwbnlOMGhYV09kNGVOVDBna1g3RElSOTVtdVMy?= =?utf-8?B?ZFhOb1pFbWFKUjlUQTBWTk1ZQWdQTThPU1Z6dTlUSVJaZ0xLL016dDFtSlBi?= =?utf-8?B?a3BJTFBlMWo0N25YcHFaN2wrdW1SV3FYRlNrSVp2ZkEwN1VVU3M3WmV4YzNT?= =?utf-8?B?ZnpSa1FIWjhEbGt6YmRJMlNBamZpbmpBUkdLS3pqREV2QndnY3hiRGlYNUxJ?= =?utf-8?B?dlFZWkNhNGxheURURElnMzJ3K1ZSRHNhNW5EQmM4bCtMV21LSDJZdGNHTE5E?= =?utf-8?B?QXRsN1grc05UTWlwZk9JVUduZjFkODRQZFN5M2w2WGpZYis5SUpoSEJ1bXpS?= =?utf-8?Q?7lpMhp/95P3yQMfpjJVmuDAPcb56wc4t?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eU01UW16MmNzTkNnWWQxTjZza0JUWERic3B4cTBxK3lTUHYvZ2lFTUdZMWh1?= =?utf-8?B?NHhwTlpQdndDRTNjY0E0eTBxMWdoQ09ZaEJ2SEZRYUdXa0FpcFVkc2dHeVJ4?= =?utf-8?B?TFFRRGZmR0hoVDc5YTVGZXhkZjVzRkU5K0VhZDI5Wko2REdBcU5LZFdESWxK?= =?utf-8?B?WnljRzZaM1A4TjVsNVBUdTRuR2NZdUoxbGxzdWZsa3ZFMlpmWEd3UjZESXZt?= =?utf-8?B?b2pyUGFqWFAzUUora00ybFVOU0dkRjFSYVhEWk5pL2lIY2M3YnRLYzJWR0ky?= =?utf-8?B?QTZUZS9qcW0rc2Flb2RqSTF2MXY0NWQvTGgzSFJXaHVjZWZwUCtMVGtIdUdF?= =?utf-8?B?U3J2U0J1cDRDZWdWUjhwMDRsNTR2bnZHOVArdGdBcUQzajdpZTBGTk1nUzQv?= =?utf-8?B?WmVSNFprbUIvT21XL05jMkNYeFVqcVZhdkxJbFFwMndUZndLbXV4SSs3Yis4?= =?utf-8?B?Qlc3ZHlwZ0t1Umw4bzVMM1NmUUhFRDFsbkF6S0taZFFvUlc4NFJyMkx6NFJr?= =?utf-8?B?UFB1VUU4WVVKVW1GVityQTJaUnNNM1k1eFBtKzBHQzdrdy9WUDNoSW5NZDJt?= =?utf-8?B?RWxoeExBRUNkUldpbTVtS3htWndHZkVFVGFaM3MwWTYwalRYNzE0V0o1ZEFv?= =?utf-8?B?dDRIcXozSU9aTmZHVDFidVRwZTFrYktIVURTZlNtcmFHcFlxQ0cvZzJ6Z0FX?= =?utf-8?B?NEZNVDJpYXdRcVlacnhSYXdXVStGTFh6bXhCeHFNTlptVnZ6aDkvUGJXUXZH?= =?utf-8?B?NitjV243L2tSYk4yR1hXMjFEazFBYmtyRWxpWWdLVGlUWUpIYnZiWkJDYmpn?= =?utf-8?B?eDlmbDFod0paRVN0VFdsMS9vcVZxN0VBc0hMa2RFdVFFRlFzL1lWbFN6cXZB?= =?utf-8?B?VlcyQldkWGZjZS9ZZEFRUEs5QWlpWXJaNmh1eDRZWit5bFUvUTQ5OXFnaFV1?= =?utf-8?B?N3ZDcXVkQ3lFdDQ3L2RRUnhia2l4VnE0TkZhOU9HSmR4dGYyY05JcEpiVzlz?= =?utf-8?B?U284MitTTWg3b29ka3g0anFvdnhqQUM0WWxxWWFSK0Jicmk1eGtNbGk2OFJZ?= =?utf-8?B?OW5rdmRKWHhwTENGZk83bzdiV0EzWWxpSml6T2ZiV1AwbURVZU5ndmRaNUhr?= =?utf-8?B?VWM5a3NhV1hMVDVkL1N4TUJNWWdUVTd2YWUvM2ZMVTA3Q1RLUW1TRHQzKy9y?= =?utf-8?B?dW1UaytEYTN0L01JQkExRGhIVnhjT1pXVzdoNGdGSE8rU3R5OUYzeCtMZGNS?= =?utf-8?B?SzZPaDVrMEVwQTZMZzlKZlFCbVpwdEdiYk54Z3hmcjZ0UjdRR0hVMFFKcld0?= =?utf-8?B?bmJQMU1mKy9weDdtRTduYnN1eHVmeXM5azNaTUNlS0VyWHdwczREQnZjcDF6?= =?utf-8?B?ZWw3YVhZblMzQytXUnJwUEwvUnY4YjZJMzQxbDhlTGhNR2NzWFJ0UzRwNVRX?= =?utf-8?B?Z3BUOGVlV2ZnVE5LM3JIOFhZaUl5bW5mNDFsVVdCV0RDVGZkZG95NXhJNG9N?= =?utf-8?B?OERDZm12QzNCampMWGsrRTN3d2VSL1FYS29hazZmdkVSeW5sdzZEZ3kvK29J?= =?utf-8?B?R2JlMXRTR3JRajVhNVplKzlDWENOV3RvVlhtNFR5SUhjRllsUUg0UkVXSUVI?= =?utf-8?B?UncwNWwvY0lhRndqd1RZRnA4M2M1dkQrMDlyajBPeUxFVlozSkl0V1lRWmtW?= =?utf-8?B?aFFUTnZmTWlvUnEzUFNUVWtBdFZIdVk1NGtiR1Npd1k4NkpIc28yWGF6b1Rq?= =?utf-8?B?TUEzbExMYzFZdXZ1YjFvRzVnUmpHMXZ1NFdWOXU1U1dWUmU1bTM1ZlFMUjhm?= =?utf-8?B?dGNSSFBHN09SR0hncEV1cDhnSThFaTZxUExxQVhSbHNSR3FDR2JiVjBvVzNM?= =?utf-8?B?OWtRTWlyaVl5c1BLWHdNZGo2WU9Gem9qS1BlU0s5Rm9QcHNsSitDTHVEdW9i?= =?utf-8?B?MWxtYnk2S1lzVklKaUh1VWh0RHVTQjNDeXRKK1FvYWppK2tnRm40UWdSR3NP?= =?utf-8?B?elRwL0x5OUJrbzVWaCtRUDZBV0VJZzNGd25ZZ3EvRTNydG1PY2prYmlpdmZq?= =?utf-8?B?alpVRjZaWlFleGdFY1NuOEJkQUd5Nld4bEZvanBBOG9UY2hDVTZ3V1dwTytY?= =?utf-8?Q?IfMuTVNxdWfV6lWtfVxGZgLjB?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e8242c8-3877-4214-7a14-08dd2bd291ee X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:34.9490 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r/KVS2/gkm2jJ4aI02MLeFct2jN6RdHkYRfkgON8K/K0gvWLm3qOhZzt32hIVf9Wv2ZJowH24RKxaGE84so19w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index fa3b0328c7a255ff8a902a58d61a4b0e59eac493..d4fc9dc583d317d4852b7d897a6= c45cfff6961a2 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pd= ev) /* clear all the pending events */ regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); =20 - device_init_wakeup(&pdev->dev, true); - dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + ret =3D devm_device_init_wakeup(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret); + + ret =3D devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + if (ret) + dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret); =20 ret =3D devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, IRQF_SHARED, "rtc alarm", &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request irq %d: %d\n", bbnsm->irq, ret); - goto err; + return ret; } =20 bbnsm->rtc->ops =3D &bbnsm_rtc_ops; bbnsm->rtc->range_max =3D U32_MAX; =20 - ret =3D devm_rtc_register_device(bbnsm->rtc); - if (ret) - goto err; - - return 0; - -err: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; -} - -static void bbnsm_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); + return devm_rtc_register_device(bbnsm->rtc); } =20 static const struct of_device_id bbnsm_dt_ids[] =3D { @@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver =3D { .of_match_table =3D bbnsm_dt_ids, }, .probe =3D bbnsm_rtc_probe, - .remove =3D bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver); =20 --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69FBE1D5CDB; Fri, 3 Jan 2025 08:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893769; cv=fail; b=Mhec7ZcTC+ehO+7Mji5GtkOdkSQg5DpLQG3huscJfXqDyX+4x4yZLVhIuxrzwQlpno/Sr7oATgPMVrfD8ibzWNrFteZ++zBIB7AkvzNgu1ExkVvFYd6Ekz2fDlpESaA4KtXPVlMQgI6MqR0xeE9Qx2eqmo58qDapgWn6YOgGp90= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893769; c=relaxed/simple; bh=BO8Hwal6yUEtmatjGxTeE8CGMKa+r4910TYtu1OW9Cw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mOnhVeu7mlJ4arAq52lDPpxxuVf23wPOTHFf6NpZnXLcSKRcwv/P3IXc94kEX28Jhs2cXRsDKqho2Z/96Lb6tlmRY9Yqlky35KAumUdLJhGUri8r+x2S+ch50GpE1RKMRMVkCVU3oNkHKlXf1ZrBX/vUZvnBOf01n4kgujTNXro= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=JM9SRDLL; arc=fail smtp.client-ip=40.107.21.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="JM9SRDLL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=buf2XaHbOo0mnUHhZBium0o4JAe2v5OHZ1ilDaYKSUwdIQ+rOI5vu2bs2oHD/wxkTsV+NzCG72Rm92V2IUQoxd5PNNfi66bThVNcmEyQqZamJapaJNXros8Omqem7u7jAZt7oCDhArkOMtk0AF2v1Oq2eSGShFL/rrrpbbq2K7ufyJvIfjiI6JDnDcFaHNPetFDmV0HdAp+pMj+K1C6DeRbTPgSLLqKzeJh4FDY4eawrW8kny7uYRhQ5UIAfPurgdAuV37E9K1ati5ZwpzaI8xfONrkgweR2tPmQOLiRc4T0M9g5wjVTtdXjFK4PVPIjbh6RI/awaupwKBsWDCt40Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=IpM0rpaeD6cHgPulshGi62S9Lvk2VaqvRIS+cQm22Kg/nQkjZjvIrvjLwxBj6bivtvDB+3kPqYsq41HELwQFwb0qYX7TgkGB+H1DgJb55LswQ/S4gSeHw0JxiMt/3frxeKvC3AUtZsfl66A0lYMEe+MO+VUqFc1/3TPvPyT7cuunFInJQgsKThBWP8qPgt1uRRFaKuKwJt5jL/IBbSJX8VSuXZ255ux6JMwzD6hnFD+arVF/aS1Ga0ikDXeW2Zdxwn++Qz7WF9jClcMrn5ed2mHN7/jKxGIqwgyxMZqe1Qha64mAUQsX5sw7RzMmV31cB9EuNg65KFz2/tVJgTUloQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQmjc+FMqh0dI0wNgt8HMjgVvX1TWtUXJ1FCgaXAoBk=; b=JM9SRDLL7Iai7G4X/dCL/0+6Vy7tLFMfeOqFCpg+N29s1AB5cGuB0YHlfmq+wczIphIuevu0xZBjXmxxJTloR9EyVGHTDCDqfm5FshggeaAJ8RL+Sur37NuwAg9dxQrr+ezWlIqI9kPBUw5aGEOl2U3iGAJBfKwrimcIgL2aUCIsFW+L1FIMNSQQgi46QeAnniF3MpwKq98FC3tYQFip60ul7GngCC2U5lABIZHMw9x/9Bwg5SzrAZZe4O46Ue3fBAWIKdjoPWJUwL9pKKoX7BPIbdjKnhBJluP0KXwnL+yRBmEETvLK90mqQoGs4QCkX/5h+qqknge80DMOIRZ9sw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:40 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:40 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:20 +0800 Subject: [PATCH v2 08/12] rtc: ds1343: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-8-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1119; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=yYeVC601Fmqm3h8IRsE1e0gqqkwuyZ6uKwkA4brZ+6s=; b=frrewPLMHBqjUxMa+a+fJPMsZKvOP0ydpssUsy2Dl4jy3KEwpr2k2XS9bf92qot4Pcgk5A5Sq btsu1E28jMfDRRyXatmaIw5jJojAERsH5wy1AoFyaExNc7XvPuWJVZg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e33ee89-b252-46fe-0276-08dd2bd29527 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OGgrWjBTSW5BdTQzOFFoMzRGZ29uVWFDeWozbVZhVFNEVnN4Z0EwS3grMEZ2?= =?utf-8?B?WVVYbmZ5ek5IaFZoZTd6ODUzZjhTU2VxeUJXOFhsL0VuOGgxWmxnc05mbTEz?= =?utf-8?B?UFFnd0NuREtDMTlVa2FYcDU1VnE1TE1GWDhXQVBKVllMMld0ZkZMWWVjWTIv?= =?utf-8?B?K3ZEd3R1bmdqakI1M1A5MGNKRlcxRER0dHFsa1gwWlk1WlV1S0RQdUJmVjV3?= =?utf-8?B?eGFUNmNnODB6bDRHeS9PaUY1QktRUzVOMFRUc1JBdzBUR2lJbm9EVjg0bjJX?= =?utf-8?B?cE9Yano1R3EvNFUvSC9uajJ5dUtRTVhzNWN3eWltL25ibU41akU0enNCWW8x?= =?utf-8?B?UFNkQUMzZUdsbERYRWZvNmpZYTlPS09zL1dyTXM0M2pmc0QvczRWWVJISUhV?= =?utf-8?B?Ky9XQ1lDeDVwYmdaZHBFRW9INEY2anFzbWR3UzZMVG04ZkFrUk5Nc3c2elVC?= =?utf-8?B?UC9zUkZ6a1VIU1VGcmZCRTRWNE1rMnYyWEFRS2pMWGF6S3ZSZTdVZGpxUUFP?= =?utf-8?B?Q3JucnJRY3V1MzJ5cDFKYnJ0UFJmVmNtVUNYOG5Nc3Y3S0hLYmpVejZkQ0JZ?= =?utf-8?B?UmJMOG8yaktWRlZwU3RWZUlrcDNBTm4yR1kwendHeW56dmZnR2NveERFaitS?= =?utf-8?B?RjV1UXp6dnFGUnRoSTZobjN1WGxSTExSQkgwMzBzVHZqMFdKbEJMRGJCOVh6?= =?utf-8?B?dUdyTnZPV0JiMmNxSlRDWlFEUFB5anN5a0tvaGU4UUx3TW54clFVTXJvc2k1?= =?utf-8?B?dHhmS2s0UUdCSzhFVVFvQkJqQjVsbGZBNi9pdjhQU1lMUHAxQ04venpOT0lO?= =?utf-8?B?ZVZ3aDFDMyt3UDVTUEMxRnRRZG5MYUdISS9sYzd0TzF0ODBPNTJDN2pMd0Ft?= =?utf-8?B?SHYrWkkwakZ3K1Rra1FNMUJZcjF3c3pVbFFncENPckxkc1lCWktraW02M0hZ?= =?utf-8?B?SEtsL1VVbVJjdnMxbUNXQTlkc1BVQkR1cGYwWC91RlBmdEw1MEt6cDBSRG5s?= =?utf-8?B?WVZvZjJ3ZVFGQ3BPTi9jdERnY3NoeHZBV2ErSXZ4RWVnWnFNc3dkYkRlM3hq?= =?utf-8?B?VG5kVldQMG5LZTYxMFVEWmhjamFyVEFUT2U4N1lBbTFhc3QyYlhsYXQwdGZn?= =?utf-8?B?MlFVbUZEUXRKQnZOaUdmaHdLci8xLytqNGFLVE1MNW81b2x1N1dxUU43SEdH?= =?utf-8?B?YlUreExZQmlXL1NkUlQ1eHlwaVNINWNjS3RYZHJqSGZwV21jSm8rTHI2Wm5N?= =?utf-8?B?dVZxeThrTFZKZFhqRlpRbW1PMDI1VTY1Z2oyMk5PNWlpWGRmMjBoM3kzd1lN?= =?utf-8?B?S2NUa1dGbjVRTzFyVnU5UVhGZEljNGZNQjRLLzBTS2dRVUhHNS9YaDdCZU1x?= =?utf-8?B?VXFnVlZhUXlYMW9SNG1iSXQzSWJPMXFFUEVQVVdGN29ITnFQcmtnUERqQUdJ?= =?utf-8?B?QkZzNkFQTFdrT3ZHM1pFWkZXdHp5TU1sS1VNNEYrTHdtd1k3cnB6aUd1eTBG?= =?utf-8?B?bTNIcmtMb1dKa1ZDWERMYjVKZWtCd3p2WURWbzVJVytKTXozWE5ob0FlZWNq?= =?utf-8?B?NUVPQ2YrWTlXeXpXTnRaWThDVXlQV0lWdWdaYVFXTmEyZ0poYkthV1p3R1Vu?= =?utf-8?B?MlFnMXV3VXoxSFdjd3Y5NjVMOEs4c1Vmb0lrcElyVjMwVlNRcXAzRXY1L0Yv?= =?utf-8?B?UkdjMkRIQktOZENzTElFYi93elF3T0RXaGlHRVFuWTg3TllaR3dFRjgzUTI5?= =?utf-8?B?L2Q2cGsycVRmU1V1aFh1ODFoVi93b3U4cFB5Z2dQdzBpYmp3dDJnSTB3a0U5?= =?utf-8?B?RjVaNEJmWEFYRlhmdExQYjBXb1VSQnM0bjAzNHVRZUlpay9rb2lhRHRYVnQ2?= =?utf-8?B?Z3BIQ1JMOG9WYnBrOGNjb28zSzlrSXFPRENJd3d3YVVCWFhpKzAxcVZSOEd4?= =?utf-8?B?bHZVSWlWMWFtTndZSngzREEyTFR1Qk8rU3Z2UHdlWi9DdnVFTUdyL2xqZGlE?= =?utf-8?B?bThQd2RGL0RnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVlpek0yUDVwV1l0em94eVpWWVBDdXNVSjltWFgxNEFFRkdudENvMThhbm54?= =?utf-8?B?blRleGo0SWJNTnF3eSt5VVhVcXFEbDh3alRkdFVZemRNSFMwRmQrVkVvZHhF?= =?utf-8?B?TXFHUWJWSlZ5aUo4WVM0eUpvWnlVN2NHRUdJenpjUVNlazI2c1Z3cEJNWS93?= =?utf-8?B?eVBVWTVWR2t0Ukt1OVFLMUNpaVlISk05d05OVmxObDA4TnFDVTBVTXNDbHVT?= =?utf-8?B?dlg1V2w1UnkySWlYQ3A5QkpOT2FCUFVuR0czSGk1M0lZQ1pyR2p2VVVEZW5u?= =?utf-8?B?U3hwYVRVbVVWWXBLRjY4ZThOcGcxQ0xaR3ZtMWtiSGNRM1FQeENkbVNxaXNl?= =?utf-8?B?NHVmOG0ySE5YTEVIV2V0a1BBRXFZVEoreGxoYmV0ODBDbDgwL3RFb1lsZWp3?= =?utf-8?B?T3lxS1g5WDRBQk1OQ0ppV09RN0tJRVJLWnZ1ZDhtSDk2Ujd2RktBUW8vZ09U?= =?utf-8?B?U1huWXR0WEFzSnN1UThrMmZCNDF1VFVRRnQ1OW1GeWwwYjVrN056KzJWa29m?= =?utf-8?B?ZXBHZjY5c1lFM1dNNkNxUE55UEhrcFdxVHNHMUVINHphcEMvN21ZbnpNZHh4?= =?utf-8?B?OWMyNFVqNDZQek1OZjR4akxIckdDUHlIa2Yxem1pNXhCVlJzT2ZZNHpqdjFL?= =?utf-8?B?QWlsNEorU1lEYzB3ZURYcFlsUk9WL04rODFiVjk2WEQxenJvQVM2YmNraTJH?= =?utf-8?B?OWpoRy9xeDJQYmgwMDBSQThpSWJ5VXdGamRaZ0R4TVlRWFphcmRxbkFEcXpY?= =?utf-8?B?dWUyR3dydkxKK01yeHl6MkpCU2dJSW9jZk80NEFVTkwvYnA5QmZoMW1tSnVR?= =?utf-8?B?cHhRcXk2czBUVTJYN0RUcnIzTlBhcHZUaVRaL1ZLcXpOL05BanpuaytSUkJS?= =?utf-8?B?R2NmZ3ZBMlhOZXBFZTZqbzFNclUrWDYvVTlQd3FKUUNuZVNyVVZVNW9zZmJp?= =?utf-8?B?MG8xaUsrVmlQblpOTm9sSjZsdzlnOVZqeFVCdHpheFMwcXk4VzVyRll0d1FV?= =?utf-8?B?WTRnZGgwSEVWY2gwNEdyaTZ4cmppM2RxRWxza0swbFNvZDIxWGJBZ1A5c3ZF?= =?utf-8?B?VTdPZnlaTEo5YkVUMDg3MGtaUjR5dUptT1A1NFgvOE9YY09oWUF1THVZK3Mv?= =?utf-8?B?N0JrMHBIai9Yd1N5azh1TVFoQzFYOXVvQTRmV2p4TlhCanFvUGF1c3JVbEF6?= =?utf-8?B?a1pZdHZyME9ET0xsaWZ2SndPVEh3M2lKSVNmTGdQdldBUlRHMEVCSUR0VWsv?= =?utf-8?B?SVdTc3Ric0hXRlBZRVQ3N0FLQ3dJRFkxdEN0c05tWUlVbENSMmRXRHFvaWRl?= =?utf-8?B?RUpHVnVldytlSzNrUzBLMCtZSFp3QUxzVTdoYm1ZMElGYmNUZmhQMytYNnAx?= =?utf-8?B?UFg1S3F5Y25QaDc4TnB3S3pyMHcyaGttSmI4OWRTQjBhQXlGWHozK004cGNR?= =?utf-8?B?Z2VLeXpMNHNQQlpYaDVFc1M5eGo3Uld3Q3VKbU9FQTFYeWlrWE1rYUdJdlQr?= =?utf-8?B?Yk9EZzJ2WndxNERVQ2dTcDhoRmI4N3Rmb0Rpb1g0d0hLMjRmMVBIcXBUN25C?= =?utf-8?B?T0s1Zk5kOExvZnN4aU9FMm4xMEhkN0N2bXg0OFhxeDZrY3RzVk5KTEJvQ1pm?= =?utf-8?B?aDJKY1A2UzVVaXBJTEF3bm1uZFJTUXljMjZoMktkVDlIWWdZQng2NFJYUmkv?= =?utf-8?B?TVN0Rk1CWVFwQkNraGZ5Q2UzWFJNZDZYZHJ0RlpuS0xCa2F6ZHIrNzhDWndF?= =?utf-8?B?Z3oreG94VEl6RUFETHpGYng0TlUzOU5VVVc5bU5OMTlUalpheFZiSTV0ZGdK?= =?utf-8?B?bGs1ZUE0L0R0ZWl5bXhnNGZiUGd2bnhQcEFXeTZVa3lBc2RQeUlpSDd5dzlX?= =?utf-8?B?UzY1SWJndDNTOG9VU3dBdUJMU3BXVjlxS2NDemp0TVJhMDBUZjhCTVdxNDBn?= =?utf-8?B?dFRCUlBOdnc0bU5LcWFQZnZFSVE0U0RMaXlWMitiY2UwcmgxWnVTK282VXU5?= =?utf-8?B?RHJPR2lrREdxckVsNzZ3WExZQWNJUm91WkdSSkhsckFxRlp0cUYyaVdxR1da?= =?utf-8?B?dkZlV2FUdkVLVkcweVk3a2F6Y21KdUxJdFBxM2FmamlORkFSS1NmSlNhTXJr?= =?utf-8?Q?roMoJPHBb7vRSmtQ1MSFRQUuA?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e33ee89-b252-46fe-0276-08dd2bd29527 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:40.3434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wDzBr6FXHOMthwGDfQ/C/dZA7CYz0zRfECADuFYnbw/BSLbdC2r6oP56L2fp2IYOSwQs63Z2G5k2boNxvFjDGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-ds1343.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index ed5a6ba89a3eeb2a0b9d6dea3c8b3d40aa2cf317..aa9500791b7e0300b150bd654b6= 9c74f3e5e6e6b 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -427,18 +427,13 @@ static int ds1343_probe(struct spi_device *spi) "unable to request irq for rtc ds1343\n"); } else { device_init_wakeup(&spi->dev, true); - dev_pm_set_wake_irq(&spi->dev, spi->irq); + devm_pm_set_wake_irq(&spi->dev, spi->irq); } } =20 return 0; } =20 -static void ds1343_remove(struct spi_device *spi) -{ - dev_pm_clear_wake_irq(&spi->dev); -} - #ifdef CONFIG_PM_SLEEP =20 static int ds1343_suspend(struct device *dev) @@ -471,7 +466,6 @@ static struct spi_driver ds1343_driver =3D { .pm =3D &ds1343_pm, }, .probe =3D ds1343_probe, - .remove =3D ds1343_remove, .id_table =3D ds1343_id, }; =20 --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57BEE1D63C9; Fri, 3 Jan 2025 08:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893776; cv=fail; b=fm0TINDTb1KMKKAiGsjorxegtaAQgZ5tqdf4xGW0ZBxoHBOfhREEVy/cOYa7RrSVfRKT2/OBrvUTV2TZ3nZrskbEGKx0qP2ufNCS7HuL0Hb05O5K4sx/X175sWKdGrurr6epLsGyNxejhk8L/FccjCdyE3ZzlXABpi+lCA06fNU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893776; c=relaxed/simple; bh=ZKjmg1MtBFOISkDUMyTeytnGcAdAAATDapDdHX79doQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=OlgU2Beb/MAixrBF9d8CniZOeVEBB56p/yQxmBjhgrDpcodgJu1lmbYfzGpVtJHWS+Yli5n+FM+v51Eq1CKfQHZX6nDR3cM7U+IaNdxij9YSnf0WWsNb9DAtP3ifL4IdusQXirI1Id8crfGLe4R2e4iJKhoMbs90/ZaF4snVcRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=NtKJBg3E; arc=fail smtp.client-ip=40.107.22.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="NtKJBg3E" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EeC+NfazkdKVsZEXy+eIyBv1r+W/1dFPndPPVEIauj05/h19cguDfpWxoFma3ZSfh7hjuRIiBaN04DBjujwJpaXnmoGxv89bwnzdx/jHce6dqT6M0Dg9VsTkiJCOuXi+PXb31Obbbscj2MqUjnIlKfINgciGhq9trrBsdEQlqUc+/6vdoN3Oy7Oybl+DR0dxQ1+3gseQPTMw2eHdKWP5+YD3cSigB9Yb+gYWB4aLRxi2DR1T5NACJ2IRWthw4OKAXhuAhIvRcL5B5kB4FspUuyHn0XbOgvKW5n50s3O0uXm4I6SnhOkPWucd0wyhap6vmsyWKT8wARhDxYOzbKwdlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ukcfnak6rASj1mOqRwYrxQ2oQzH5Bwejo3Xly8lLTrQ=; b=wB29f7EcuCWHP7IQcXJoAd6u/aN0JnFIy/SdSRY6OOQdPkJs041KTCR/djxq16CaBNFb4p9XxvKTrO3t5ecrEpezIn1E3wXc07Czc8d6a6A68I+nGHX56uA5KrwdaBYi9d/r5wqazvIL72FdjMwmzWBWEgVMZriI+K/Z6yqg7eGnzP60NZa1wwofTkSNsiRVVSSWgIa1mop3upWQ0OLt69mPgQUg271EFsAIcaRtAEpuwDY3niosKaVlZ99UpBIxhoNH8atTYAJ/vKic/cA61jM5Of6jxM7wPNboYvhWkOw9tlIjLToo6b9lM73A/+9YsuWhIO/rM5jgrNOxeKCkHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukcfnak6rASj1mOqRwYrxQ2oQzH5Bwejo3Xly8lLTrQ=; b=NtKJBg3EGttxxA9nZ55BpiDOyMVPOopPHXo2Afp1VKK2bLtQxEI9Rgyd5DeyQK9BGUmWgv16I3by1GR21cVkUbru+2nNIjS47r8tWTWpTg4PLt8oYjTrBYuzW2MT3cAluG/RsZ3uiL06zpZK7w8KSVtvyCdMMS/5Is7YPK8orGn9R3AGtDBDYpUdsBpk3aX8MVdI+KqTouIjnufZyYl9f7czq3fxAD3m3rcmPMlf8jEo9kZmAdOHIA9dQC29rE6Sf5Ikc2MiEH4vLyJZI8gwzhi0/QxF3t+mGIHVz5j0jioxx9vRT7pgmlh5T1q842SgUqJ13aEviRUWSEZ3Z3+S3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:46 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:46 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:21 +0800 Subject: [PATCH v2 09/12] rtc: pm8xxx: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-9-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1049; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=GvTygPs23OU+WJ4Ssa5ar7+WSYAkUwf2a/2JL3pAL9Y=; b=JPMab25FiuphWW4zg1wpUHsKfC8j4X4PmEXhMG8FlB//Cag8g4nboWS7yj9Rm1f9sO6jqHfMb iu/i03TNnEhDEbRkTdAsJEVEhnN6H6MmGZg2Oh/wuw9wXjT9YcZ2lzK X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 47b8be2a-229a-43b3-2ae0-08dd2bd2985b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NkRmYkxoVkNtRmdXR091QTdhMWJ6Z2tuLzdOMUd3RTJRbU1LakR1KzdCMm95?= =?utf-8?B?YXI0SXZMbWdHTHhqZWhzcFRPbnBiSVN6Q0ZvTHpEQ3QybGFJNTRjSjFqa0NE?= =?utf-8?B?L2doVnlRWk5NYmVLY2VRN2cwZTJST0hsbE1BYVAweEo5cVhJK2duQWxwVWVv?= =?utf-8?B?YTBkOGV0OEc4VitOUGYzMEVKdnlId1JTNWl3V3JVR3NNK0d1V1hKbnpHOHpo?= =?utf-8?B?NEQ4RFljVHN4YURRY2MxMG1rcXN2RHAzT0xEYjF3OHFvdXFTNmE1SHdsQVhJ?= =?utf-8?B?Z1JvUlFhQ21xRG41RDU5TXlqMUxNOXMwZ1NMcGk3MVNocXN4N3lBOTdZdmha?= =?utf-8?B?dW5Ic2tkQXVzMml2cWhQeUV1RTdKMG9DanR1RDdLYTdvNmlCaGdlaDUrM0p6?= =?utf-8?B?U0VjQi9TdFAxcVZMcHB2OGJKVzQvT2lDNWVQYmxWT1Y5M3A0VUxuZnNsdTNQ?= =?utf-8?B?K0lPQjBBMlJIRUp1UGdUcnNYak5JUVdsN2RTaWlETFd4WFNzVUI4RW9tMFIw?= =?utf-8?B?Tmg4SmVmVEN6bWNpS2V2OTNmclgxSGZxVzhyd1VRdHUrSFdFVEM4NkRNNlgw?= =?utf-8?B?Tk9LSlBtMmRRY243dkwvd1ZQdGc3MVJSMzIzdVY4RU1IbktKM09uTEVZMVAx?= =?utf-8?B?RFZMamwyUW44MkplNmpxK0o3Nnh6UHZLYnc0TzB4Ry9MU1lGaHFOUjJkL2Iz?= =?utf-8?B?RHViY09WeGJsNi9hZm1rMUdhUmowcDV0bGg5SDVMbkZ3UzZSMEkrZGwxbHVt?= =?utf-8?B?VE93TTFZQXQyc0liUVM0cUxtUkZiQnpqSTFlaGs2b096T1NBTDlWMFlnK3JS?= =?utf-8?B?Tzkyd01icHhTWkt6Nk1Ka0EvT0dGUWtDQVQ2OENCdDlzTTlYYUJMbTdwRXgr?= =?utf-8?B?TE82WW1UeWNSMENtdVZJK3A4bWJJMnVOSDA5cHQ0Q0JYd2x1dzdrL3hqbis1?= =?utf-8?B?NEY3ek9BVG1OQ0dERUhZRDV5NFZnNmhMYzZ1N3k0QmJzckc4WHd2MFNiL3hI?= =?utf-8?B?SHV3R3dFODhmRXorbis0cExhK2s5SDM4S0ZaNFhYR3A2eUdnYlh3WCtUNWM2?= =?utf-8?B?NStPRmZYcGdEdFJpY1QxRDNLT1hIaWhWK1o2RUtFQ1drRXRQRXNTUTloaFdY?= =?utf-8?B?U05Udm9jYzVTdXBSdGFweWJKMmo3cWw0NjdPdlhra2ZmVUlBZkJPMXQvNHI5?= =?utf-8?B?WXBzd3lpMTQ1dEpLQVR0THV3NXBiQ2EvTTBpMlBURTdONGVydE8rdDVIamtj?= =?utf-8?B?c3g2d3JLUUo0NUZORExBQzRBRGR4L3ZlSU4rbDEyaWhOUkNBUFpBVjRHYkZS?= =?utf-8?B?SWlvaXFiMWlYVzVpczJuejBBVEI1bTc5cTJBTW9PYWp6Y0VlLzhzeVhXUnpp?= =?utf-8?B?by9TaVBYV0I3elMwaFRVSmNkMHpGMlh5UHU5N0lOVnhsQ1laa1FPcEhFVDlm?= =?utf-8?B?bXdOeUdtdjdvUnZZS3NaM0NaQnpuM3JqblZzelpWZ0dsMEVBVlBtY1NFSzF1?= =?utf-8?B?T1lwTnlVYjRPaE5hK0FPczdvZVo2bUJ3UCtZdUJzNDRUSDEzTm1CRzdLMmw1?= =?utf-8?B?RnBJQzQ1bTBNSnB6Z1Q1amxpbE1hd1RCbnJFdlI0eFhmbWMyRVdjcVc1ank1?= =?utf-8?B?VEVRUGFHajZuQThRbFBuNFNxRTBwNTA5ek9UT3VHMllkSWkxWmdNWno0SWZM?= =?utf-8?B?c3lxNzIzUFdRVGZTUURxRHhaVHJ5cFFaV3FoZktNajNqZHJmREl0cmNUZGdL?= =?utf-8?B?YUZqTUp2SnkreGVhUDNKVWpRcXlTenFIVU1pZ290aWRwS2dzUTdHcWVGVjJP?= =?utf-8?B?L21IRUFwVTNhSkFDSUEzK1NrSWJCQTdabkw3a2JoYy9WUllPdjl5NVdWUENX?= =?utf-8?B?Uk1GVkZMMXN3bDdRTStBN3d4ZkVvQUxIUFlheHZlNDUxYlRlbU40WUJyZ2xE?= =?utf-8?B?alF1VnliajJwSHFvNVg2N2hSVGJlaVNLZzRlWm5aYnRHblRrQ3NjUzIyRjh2?= =?utf-8?B?UTlKaDJ2cjh3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3ZvZzhveVBoV2o5cE1iQmdORkJDblVUSThhWlk2TjBvdzBBSC9UanBXR3pl?= =?utf-8?B?bk5xM0toWWo5OFRNZStqZ2I2b2YvbVdKQkEzdm1pMStoeVhPMFpWaytQdE1u?= =?utf-8?B?NmxUM3lCQmxmMXFyQjkvdHRNaFZOSm12TFMyR1lQWHF4M2VYeWhJM1dUVFh3?= =?utf-8?B?d0tDMDlLcm5LZ0h0R0J1UW9NU05zdThBYWJDRjFQblg2T1dKUkFoSzBma3pj?= =?utf-8?B?M3dxOGNXRlQrZHBuOU42enFoWjZMRzgvTWo5cVdTSVUyZm4rTHl6bTREQktO?= =?utf-8?B?S2tYVEtzcFk2RXBJeUcycmhQL2JBOWJOS0k4V3BwN2RjZXhnRFA2WU9uMG5S?= =?utf-8?B?bFQvNDZITEZnOTNYYVN2WTNMQ2l0anV0WGlOSE82MVh4UWpqUnM1SzE4TzAv?= =?utf-8?B?T0h4Vk9JTlhSQk9qRkoxSCsxUG9iUXp5L1hYNUlrQURmamw1UmZScmJoMDhO?= =?utf-8?B?Z0tsejZnQm1vM3NmVFR2akN4TDFmVjdIWHlTYjhqa1kraVZEcGQrbCsyTkxE?= =?utf-8?B?OFVRaGhOQ01LMFdvYXkzVndRMWNrZElGemttdmRUNUpBN3p5Q1c2TUJFam9o?= =?utf-8?B?anNNOEVUQXpvaHAzbXFoVnJ4RTBxMHBndTVsOTdRemwyVHJjMEhtM2orNjc0?= =?utf-8?B?dUJ1M2JwTEZoVzNUVDM5cFpZOE1JZ2FGS3h5VXBhK000bUR2bG0yT0g5ZnND?= =?utf-8?B?QjlyUnZTazh6bTUwS3p1bEJENTA5YTZ0bFZCYmRudHRHS3dWY29nM3YwREtq?= =?utf-8?B?eCt4bWdqR25HemFzMFNLTGJjc3dYTnpuK0Jld1FPaFZGdG1VU1Nzb1hNTlAz?= =?utf-8?B?ZEg1ZHNFZjg4RWRTUGlsWEFMWmVESkY1V1RhdmUvMUNmMVd3L3IvZmFFdnFo?= =?utf-8?B?UHVqTi91Y096dm05YkZ5S0Z0VERVdjMvbGxzLzI1ejVKaHU1K3dOSzlqS0gr?= =?utf-8?B?NEZhV2MrS2VwVXdBUFNiTVFEMzg4VnFnaVVVS29WU2kzNFh3NE5FRHZ6RjhP?= =?utf-8?B?bitUNW5pVnBMNUVQOEFuY1NySW1ROE1OQ2hOYU1WMkladEhCQkNxcjJxeHlr?= =?utf-8?B?cFhQaitsQmxEYU5aeGRtNTJ5TkorYVl3QVNRbVdRSHdVV0dISWlTeDM0U0M0?= =?utf-8?B?Q3F1cWFMMGJOL3hKaGt6WDlJaDl1RGdNR0hSNTgrSmtCd292MUM5akhUUkln?= =?utf-8?B?VEVtQzFRT0xxdVJKaDNnU0ZWaUM0S2Jab3FDT3p5OHcwbC9LdU4wa0FDQ3Uy?= =?utf-8?B?MFRuNlEyM3JhU1ZrYmExTGk0MGgyZWloTmltZmdCbnNEcEhjSWQxZmlqU0Fx?= =?utf-8?B?LzBJeUFLWXF2L2pNcWNJT0lrRFoyRG1SQjkzOWpWTjRweE5tZmNzYjYxeFp0?= =?utf-8?B?b2k3NFFNZ2p2Tk42VkM0ZlNCQmoybkRuY3pJcVBnR0xNbzhxTTZTQUVNNUk1?= =?utf-8?B?R1VSZGN2aWdaNWRzWEtJQXlLZEsrRXFTVmUxb2ZVNk8xRzFzb2dRbUhHZ042?= =?utf-8?B?T3pKRWR2Vzk2S0ljMnhoSDZVcmdWUU4reWk0dUp4TlVMdkZydlBydWVYTm0z?= =?utf-8?B?eHpCa3NlMzBVMlpLTEt4TmtJL3Frai8rMjN1NWhhU054RTRNT2drRE5PNnNZ?= =?utf-8?B?bnIvNUY5WWNkNG56UTE2RXRTSjh4YnFDZm5iQS82YWFJRWIwL1QzNnhHOEVF?= =?utf-8?B?YzAzK3VwY2tYUDRMMzhLUjFidVVQZUhxdk9ad0lGNVIrVjhYRFRQelpkUDlN?= =?utf-8?B?ZWxKd3pUaTZwTTh0c0pkZ1R1SWZaSDAxczllcE5xZ1hHaWtMWW95WlAwMEQz?= =?utf-8?B?OTZsS1hVSGF1M2tYYW8wRlUzSC94NERiMHVPZ2ZnWHNWVDZFRExpbkRkb3k1?= =?utf-8?B?S2hMMmxRakdmUVczcXFEdHVERVFkY3k0UExRL1dLTklGa1YvOUdNeFh6eXIz?= =?utf-8?B?SHBjNlBxb2w0M1lZYlh1cVdvOTl0dkVqQVpxaUJ0MjBraWRxbERqMUZYVTlS?= =?utf-8?B?MHhUU2p6WGlYci8xaEZrOGVFS3FRWVJrdWRQdHc2Q0tEREF3WFd6T3RCVVEw?= =?utf-8?B?ZU5PZEhvNllFd2IrOXMxSHArMVlHc0U1WFBDVmQ4a3h5VnVWTXNPMmNGbG55?= =?utf-8?Q?IotRMBB2M0a38Fmdkkg0VT6YK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47b8be2a-229a-43b3-2ae0-08dd2bd2985b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:46.4576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q5Lh40lqSLsdrDSJw2rae9QAHrJbyEHMLWXM7lLzA09cYN8S6y6ee7bR5+SvM7ZYvUMdwDroOR8zAL/Y3whlQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan Reviewed-by: Linus Walleij --- drivers/rtc/rtc-pm8xxx.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c index 2f32187ecc8d3276a451a317ab83446b7b04ecc8..f1b620b168fcca8c640e4beaaf7= e8c17776c5ed9 100644 --- a/drivers/rtc/rtc-pm8xxx.c +++ b/drivers/rtc/rtc-pm8xxx.c @@ -523,21 +523,11 @@ static int pm8xxx_rtc_probe(struct platform_device *p= dev) if (rc) return rc; =20 - rc =3D dev_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); - if (rc) - return rc; - - return 0; -} - -static void pm8xxx_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); + return devm_pm_set_wake_irq(&pdev->dev, rtc_dd->alarm_irq); } =20 static struct platform_driver pm8xxx_rtc_driver =3D { .probe =3D pm8xxx_rtc_probe, - .remove =3D pm8xxx_remove, .driver =3D { .name =3D "rtc-pm8xxx", .of_match_table =3D pm8xxx_id_table, --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899911D364C; Fri, 3 Jan 2025 08:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893780; cv=fail; b=IqvxlOrSBw4qmO1pvAaqNuS55uP6Ph/OSfjp3RNgG/yEhU2JfaPdFzLZwIcG3jgVyPhypPTNH+XuraWX8tUpjw5FsDOoEpDeQ4Hd1ZL/zjcubH0sGbEHuxC9BsuHFdtp3vYQsJEqTcF9IiffhsF+6Fg5nYbUbuO7yYuyNQLcNuc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893780; c=relaxed/simple; bh=gHY2BHYvxVzRpPgRTgubI5fi64I6Ubu6MUDTYIfuE+U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=RFKqQQTOjhuQOgFF/d/GhLS/S0kxC2HKjdw29AZ09nbLE1Lam6emhr04O1lw7l7NfqoSqY6QpVGWrSWdgqEvlFPEV617XsXB9nT7a8qrLQYV7GWQ+GKllK91vfjy8BoJagsY0TCQetEiXq1zwTXwAuICio8oGCm8bXLsez/aBss= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=rk6kpXg0; arc=fail smtp.client-ip=40.107.20.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="rk6kpXg0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Md4A0Ls1ch7WKaYvjrmUH8MtpM5feWLHNXE5kVDeHYgnNZrgL4gjrJP6rU82LxzViMnBey/0PtSq2aXc+Lau+KC6ze+UEKEdy3x9CPfHkpDUD9yU5syIK/WIiUDm5gXOGXdvuNcNvrGdwX4Be7W+s++NXN/0upTVk0uyBT9IxLjV4wIBrDXumBrao/qW4HtDgYToyB5D/zSN1unrAMJSnvwOfMjtDEwQFRDpAT9R2bQZD6YuX/r2azSXYhinG0nisu6Gb3E2/m7T+0/X762y4KR12KW7rIK9LS2b2LMKWAj9+fQEoN4doRQTc/0zWBffHjmZ9VUFMIs47twkTrCdIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=NNyLgFPlTYgh8Khp4SfPZnGrCwaurFZMGzo5PMIBgbrV/vUGgsFS6GjKniBd6v9xYKLN19f3qAxqPH7850qCpr17fWCneAQFTRiqmHhmkYG2/1gk1zrF6mE1tWYkmtHSHQdsHR1Y7k/xx6PEoIp2llHMBn9cMFdiBxo6RdKVoq4XebnBCOfsbuRD56WUv+NcYaMxv1hiv0/Wvfibjwf0nqQB+10vadmzcEs2UOalC4jtPvthc6/sFo9BmPNQJX2OjaUayCMjm5iedj3I9A8dF1lt4sFb7vdId+Wp5XaV+9V+G8Kjy6bTCHM3TLTEHMacbcQDRjv0VLDRRtHV7ZCIfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XjUzsRVsWfUKGqcMfcInIdzIFU4EDALwy1w62++QsnY=; b=rk6kpXg0jJzsrvHsjOIt/T91wiNyt7KcPzFMabciOPVCuo8zwckPgPfWCU3nYbNtuVyGmAT4CV7feR7EigFGLZvXRa9yWB3ZG2/REEXkAo+IY6xRQkBsiLL2PVG6pqVAdBljO6lfUCdu4bJLsjnQnCkTgh/KrO70q5Ac67GMZdzqBzVkO8qIWrh1D8+zMZQB5jxppH4AF3gizJxUFCrCtmXPJC51RUMcGlydsuGrL3CsmSJrmTCtc4XRvq0YqwfABPXYfvkaZbJn7yoQ+mMvn1k6q5zEj4851UHFlwcW37dlnSfj9PL8xBoBVSmkNiJgBaHEbOXmkxY2uybvddWBhA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:51 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:51 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:22 +0800 Subject: [PATCH v2 10/12] rtc: ab8500: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-10-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1597; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=rISyYCuz8yJRuvtcynWqye8n/ybIJ7leHy6yEB7pHHU=; b=xaSOBF7rbPCPOPpRk8B72PtGMEon0vCPZFSnnNt5H6V3KsWLbwrLyvuss/Olw4WIEYNlzcdnV X7R5cOLpQU1By5c59CRK+xFOdl3nMqOGeDn4fIgj1jykTG6IMhvHt0D X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b3111a9-45d3-429d-94b0-08dd2bd29c03 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cDZxMVVMTFBwWHRIMFMrMm5ia3JsazI0dW9qNmUyY011a1l5enZrNkszOGZx?= =?utf-8?B?L0hTemkzbThDQVlhZGZ5cENmcTg5QkFIUlVTcnJ0NUhmREhXNFVsVDI3TkpT?= =?utf-8?B?WHV1TWlrWFB6TlB3REhhTE51OTI1ODRnN1Y5dGZtb2QrS1J4SU9nQnY1WDhS?= =?utf-8?B?SDdteFZDbzVkcjlkbDdFeExJY2pnemIxV1pEWEJGbVFTdyt6TnBGTjlSTnhL?= =?utf-8?B?SmRKUC83WDRndDJBeUk3R1JMOEFFZnVLVitrOWl5NmlxK2FLcjlKZ3BUQkFY?= =?utf-8?B?QnZ4d1Jia3ZNa1k1NnUvcWxwRlNkVHVienJ6ZXc4M0RhcC91REZqVnQ1dXhi?= =?utf-8?B?RnpQUi9BVXdaaFNXTzZ2R0pQTkZ1TmF2V3FUenlVODJaSnh4RUZyOXBaUHFt?= =?utf-8?B?ckVVMkZzL0dhcys5RHpzb0RvUWJIWldJTlhIeXFBQ3NNcHhUNVEvR0lHb0I3?= =?utf-8?B?OExvNS9MTmlVQ01BYzc4MENJWFdiRGN4czVUUGNSYnNhY0pvYmVTbnRocHAr?= =?utf-8?B?N0xTeVQrNzZhVE9qQXh1blRCMm9nVDQ4cW5YZkpRU0hxbzFCTHNxaHQ2VXQ1?= =?utf-8?B?RG5YZ0x5Ry9zdHhQSGJCejNrZzFZZktYS0IybFN0SHFsb2p2eTdiU3Bra3RY?= =?utf-8?B?NkkyaEgxYlR2SXFZTVdXcE01Y1R0RmdFVnhFRitScEtlOVhJYllqQ2VTR3hS?= =?utf-8?B?Z3dwdTNUSk9qcyszTEZKNzBWK3llSVFGODVQQW1ZSE8xVlpnd0VNcndESGVu?= =?utf-8?B?S1lzbjN5bXdXVkQrMllWMzhqYjIxQzlMOEJsa2Jrd3BiWVlRY0NUQllmM3Qz?= =?utf-8?B?eW01bitWVHl3elpzb2RSS3B4T2loMXpBOEcwUHNxUUl2a3lUME5TL0dGbzFt?= =?utf-8?B?KzAwSDBhZ2pvcWtqREhFK05PbDR2YXJuT1dSRXlQMkV3TFlqTjliQ0c4WmNz?= =?utf-8?B?WXM2dWVPd2NZNEN3KytFSDBnTUUwMHFiRFFMMVpnYTN5QUN2ZVFCTnhCQnVu?= =?utf-8?B?WGxESnJhazU3WUhRbFNvVkJUZGVsb2NLL3liakJ4KzJXbURrcXpncC8yUzlF?= =?utf-8?B?MVE5cWVsMDRFd2NzWno5U3dia1ZhTjVaWXFjM1h3a1hJZjNpeW91c1c5djYy?= =?utf-8?B?eS9KN2hHZlUyVUpMdXo0V3ZaMmpjUGswUUt4UnhmMTVCckovR3pYdTluYVJ0?= =?utf-8?B?VnNHY1cyaFd2R0dsdjRNVnZyUWlReEpDQ2VRUFJ2Y0xvSlZTc2lsY1VsNmla?= =?utf-8?B?V0RWODBza1lhc1pXVngvYUdNRXZWL08xV0svN29jaEJTVUNVQ1lEdTFCQ0ZI?= =?utf-8?B?RTNhbStjSHp3dkRjOVM2cTBNVnFwQTRaVGk2ZDhYdzFCeXF5MHpqTkJCYjIr?= =?utf-8?B?b05xbUYwWStrb2RXVjVLeGdLTWlxSWJybGtlVWVuQVlhVjh3a2F6cklBTXBG?= =?utf-8?B?THVtTDA4c3BmUElIOWQreElPa25Gam8zdkJlOUcyYXcvVStwZWp3QUFvU1dO?= =?utf-8?B?R3dPTWRFNG45b2JnbTdneWZsT01QYlBvbS9obmVGUlc4bm9FTWRqTUI5MWRl?= =?utf-8?B?NUdVcVFwbEM2dVBJQzk2QWRtc09lMzhkQTFnVWpxS09CSExVcG83b29vTUtK?= =?utf-8?B?KzJwSVJ2NzdkQWZ0UDBkR25FVFdlT25hVlFPSGFJd004QjhOQVNrUkJLWnZS?= =?utf-8?B?YjViUElnajJrYkZ1RGRRaXJwWEFtbXlLSFZLcCtKeG5mMm94bzRhdEIwUkZi?= =?utf-8?B?S21sRGtWR3p6Nnhlak1LQkU4b3dWK1IydWxvcHY3R2JPMUthd2lKejI0cFRG?= =?utf-8?B?RUNjQ3F0OHVNRzVGMkFrVWlWaTZlYzZDMkxzRWxtSitoek9tdTV4UFQ4UWMr?= =?utf-8?B?K1Rzcm9YU2ZyN1pMbGtNYkp3anlvYU5Dcm5yYVVEdkgvLzlqM2dIUFFZdy96?= =?utf-8?B?N081YTNzMk1HL1RKZXl4VVEwaDRUU2psaFozdjI2VEpNNTdvU1Y5SSt1MXZn?= =?utf-8?B?ay93TDlkdldnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEFzVjBIcTF6ZGQ5ak5LT3dnaTg5Q2lvQllBc0F4VzE5WE5WV2pqVVNiU3Qw?= =?utf-8?B?bjJKU2ExNDJqWFBnZWs0dTN2V2xXSXIyREs0V3l6ZWM0Z2JuUjhDdkhSNW9n?= =?utf-8?B?bXYzNjgvRitZZ0ZMSUdHVklMcTFYdW1oYThRSHh0WXZsWUsvQXFaL29LQWZL?= =?utf-8?B?NzNyMUt6RjBDcytBZkdMS1ZNb2N4Y25IZ1hLSSt2UVB2WWd3Z2I5bjkyM2Nr?= =?utf-8?B?cXRkc0hrcVhsVmpkMUVBbXVxNWhCeDNDWlRFZlBMUVZhUWcxdDRTQWhHbWJT?= =?utf-8?B?UTFVSmhvUTJ0VGtkZi9XaUVreGVGSXBSUzN5YnA4dldoN0NUOWFNeWlTdGFk?= =?utf-8?B?QzlMTmVHaXVJUXBDVHphb1VMVzlRSjhHY0Uyb2RkRUdpUnpDbkl3eFBvOWlW?= =?utf-8?B?WkZ5UEE4ZUFIVTRzTE0wbGl3aDZlZkNJRHgwdW5FNnYvZDh1Q2xJNS9BdVY0?= =?utf-8?B?SzJ3Njg0Vis2NUhCWGROVWo3WkJ5R1lrVXUrUElubHB2Ry9mMi9RMGRia1No?= =?utf-8?B?bVBVbXF4MWJhR3dTdUZjZ2JHb3E0aU1sN3YrTHVxOVVVcG5oUDZCSHkxbkY4?= =?utf-8?B?aFFYTnBzZGlkYnc3RkZwenlocU1MOEJDNFZ6S3R3a3gwaTBmUkNENVhYRXJJ?= =?utf-8?B?c29qY3NrT1FNZHcxYm5pcllkL0srQjFodTZlUHhuSjB4TytLSWxRcmFKdkZ1?= =?utf-8?B?L2t2WDJ5dGZhc1VRR2UxdmxkdUhHQXQvOUJTQzRJR3RlM1YyanRVZCtUV2ND?= =?utf-8?B?RE9KdWR3Tmk2am51NEVuUnBLM3BoU2RIMXBmTHJoNjJLemkvZ0FRTjdDd0pl?= =?utf-8?B?dzZGdVU2YUd3U2tydDRDMUVJWVhKNVpPUnk3SVArTC81cXE5d2NUZkY4eUhx?= =?utf-8?B?d2w3RmcwRTRaNGh6ZmllKzlzcnhSUUJIaWhDdjVTOGpJTGdlakp1VC9udVNp?= =?utf-8?B?U3lTamNZaGs5eVNDbWE4VkVGNzYyaU9KQmMyZ1B5YmZKQWZsS1VWcVhqTTZZ?= =?utf-8?B?SkhWbDhDOGhlR3NJZStaWHhZaVNlMEdMTjQxaWtjTU4vRWM2RnNnNkYzVXB3?= =?utf-8?B?L1M1VkdRbzJPcE5vdVBhbHM3eXphN3JhVGpzdlNVS0FwdUQvYWRKeGtabHVW?= =?utf-8?B?ODF3MVpzb083Rk16cGJuUGlMNk82d2dRZ01ETndieUI2eEJIUXVTcEdKTTRF?= =?utf-8?B?RTZWUzlYeHRhaXJXVUxRRFNOUWU5R0hsbzhiT202YnlOVXExV3pwWjVsNHpB?= =?utf-8?B?L1BOZDZTVWNsVjk3NjdZOE5xbGU3NFQzekNBbU9Sa1RCbFBDY25lclBpdU52?= =?utf-8?B?VmJScDEzT2V6WTFIakZKbFJ4dExoYWlFVDVSb3BiQ0swRTYyUDBGdEdwS0ls?= =?utf-8?B?dUFzK0wvaklxTHdJQmgzZ285bjJKRHlhN285Wk9hRFFuSUlZWjAvb1ZuZ1pC?= =?utf-8?B?QzdUVTVRU0g2RUNJRHo4T1QxVkdITWY2THNPR29IMDNWbDRtNjJNbEhjRURV?= =?utf-8?B?amEwRXhGUmlnRWFvZFlNNHhUZzdhQjZQeWh4YVlxN2JSbWV0U3Q1MHNsRDg1?= =?utf-8?B?T1hYRzY4ZHl6Q01tZ1BMUGZVQWdtY0Fyd1BJZTlVY00xU0QzbklCSTdudC9D?= =?utf-8?B?dUwxRWZsYTVISjRwejVibUlBcGtlNE1mMFNPSnFsdDByTjlHT3JFNCtBV3dS?= =?utf-8?B?SzVZTFlLTnE4T3NkL053VlIwR09SNFJidUFkbUFkUFo3SkxaOFV3MlhjRStz?= =?utf-8?B?NTZxaFZLK2I0eW84QTQ5d3ArY2FGMTN4a2J3SGNrTndHUVFFOUJCWFNCVnhV?= =?utf-8?B?bm1ZbnBFWHhVSytNQXozZXM4cno3cW9NOGJMc2lvQ3M1WmxJWDhhQmlHNHB1?= =?utf-8?B?KzdHVWVyeHFuaTRQejBlZnhVa3llQkJXQVJtc2ZzRk12R3Z6MjNMTjlBSlRM?= =?utf-8?B?cXdWZkF5MlNDRGxvYTVHcjFWUi9yN2VRd0xqNHBMUUxDR3JqVk1vWG1UMTFo?= =?utf-8?B?V3IydDVzNjMrUTNjMGFYU3dnaCtYRWJUanBoVWdIOGRySmlmcDdSZUZPMWNy?= =?utf-8?B?MkJsUWk4bDZVRFQyUTZUOWE4ZXQ2aTlSWVZPZTRyaml5N3VqdDJpYU5FUXIy?= =?utf-8?Q?UR42GJwqhDUltdIbwRZuHKbGj?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b3111a9-45d3-429d-94b0-08dd2bd29c03 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:51.8042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eBccr9Kg0zcivnKXlfIPzpufRiqn5RmXhVbU1IS84DVazBkSZe0kenEoQGKBxhRunqXQ2eAyxyPagxi6XvIKGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-ab8500.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 2dcda96f4a8ef727514c751322b84d8d2b382b75..ed2b6b8bb3bf8f99fef9f8bee96= 76f71f8a86d2a 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -361,7 +361,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) return -ENODEV; } =20 - device_init_wakeup(&pdev->dev, true); + devm_device_init_wakeup(&pdev->dev); =20 rtc =3D devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(rtc)) @@ -375,7 +375,7 @@ static int ab8500_rtc_probe(struct platform_device *pde= v) if (err < 0) return err; =20 - dev_pm_set_wake_irq(&pdev->dev, irq); + devm_pm_set_wake_irq(&pdev->dev, irq); platform_set_drvdata(pdev, rtc); =20 set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->features); @@ -392,18 +392,11 @@ static int ab8500_rtc_probe(struct platform_device *p= dev) return devm_rtc_register_device(rtc); } =20 -static void ab8500_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); -} - static struct platform_driver ab8500_rtc_driver =3D { .driver =3D { .name =3D "ab8500-rtc", }, .probe =3D ab8500_rtc_probe, - .remove =3D ab8500_rtc_remove, .id_table =3D ab85xx_rtc_ids, }; =20 --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2086.outbound.protection.outlook.com [40.107.241.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CE11CEAC6; Fri, 3 Jan 2025 08:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893786; cv=fail; b=Tmz/QGpv+q+fJASSnhNqb2UcP3nnCCaranZtyDxQeiZ7Zr3205cFrOumUpLG1Lgmx2YwmrurEEDw2nL3FiaXUppNUXAJJ2VsOadp9RHGDQgO5zXwrdBIb1njZ9hlpCtKAx0svk8ALKCir5SyfvAxOPtWDyYBuzy2+i+PvF58gx0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893786; c=relaxed/simple; bh=/EC8zCoNiyDgYUl3GWxR1c0E1R02p9BWvo/Wx1hJgus=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=jJpYjHWtxzIzbKs80usLAC4llMmXJS5OgVtRWAjkj31AwHlrcpxFeWyIgyIOOwde18wyTK6J2Yq4ZWouyTa3HSDls6vbl86DHoArtJXLVOeHlw3ucC30tIPXfCCDQDG054aMOjVwVQSMPjEcfTfRlY+9P/F86pyakJk5zDaO+fM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=fdyth0dH; arc=fail smtp.client-ip=40.107.241.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="fdyth0dH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=agKHHPyfrGCfx1/RmupgmGQhMk0tyWaM3hP+kHcOKnIvGBYN7pFNiq+1Dnll3ulGM7oH35XMgZQ+JpkCxcIS+bDxUMx5pZTDMl8rAwIIfrOPO8fHFyDdp2jys6TR/nlW943GEGzS2tC7q3bfeoEOhKwkz8KS5bucUQly9JjNttzb+HFIz/emWfl1OYabuafAr55aDwyUfsGzrXqB0yAV2620xj/cRLAfoeOHlb/vWvAQl7tE9js9DxlROY3sYs8aCSCvPuQ080pMR7dUxbtlg+iGMP25teToCT9rSU/eBw2OuoungZKYxx02CjmgFatIDiT8EcdelIesFZMdm7UAVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=KFWpXpecfbdDklWKQJShAadsHNCAfzS9k0xlz2emBIuTFumYWd6TriMe2U69HspmGoyreD5bxVZeq4BwoaKD9yQukeFDqOtYIWp7sMCyBvjJs9KUmXHKs1z9+ULYt3Fuv1F53USMx/jxdqCxLdy7NbgGqTeEM6787vqP8D4NSQgy7qQS5jB3gKi1AT2yEKsDEEzPy2JoicGcD67eihqYB+MV1DwTgawRb4LtLM8+A/oX2ejzI1fBhFi9OxNyrKkj0GM3gefxWeLULh4Mky3jBMWsHaOjt1yVFv9KiIKWXe74vUa6b7iLnYC+CrAPx7vXxAUFKlAgIFj3MpTzjno6lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=fdyth0dHKKfYgg5y0izdeQ9GTx/ypIiXzeY+cFZrLQMyvN2DqlvMKanwSi/AY5eM8h+P1pxMVrPeo1LoQiIdGzYUdBmP2801/p0o3cSX30JqGzNu87oE7gwYo4HCQAn4Ooh1T/uN8Epb39nrRoNSLXxqiLF1NZf8oA8YDWAZeIRuTeJEkvOKmYifR3zyLwjsujqW73ZBw6fRFcEo6T5BDZWU8DZvhnGEPM94RE+fHgBwuz09+u+3VZ9MCTTp4smx8QoSQYAnTaxkwlTHj9spuE28Eb3Ot4fG1wdN7YpWmAQER75UcUa7ZVAZ0KjH5bZaueS9U/1Q6gdgB/4r2Kw3BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:42:57 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:42:57 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:23 +0800 Subject: [PATCH v2 11/12] rtc: mpfs: Use devm_pm_set_wake_irq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-11-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1347; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7sZhYfT/a75JkuPsULgAYPAtV5pnc5lWQRqy0mNIenc=; b=pqdku+mazAjUpAScAyFxwTXob9j8RqYQyx11Y5TT6Khed5JfepTp0XYtWnVT8pAuswCVWDRMT m0ycP6frFQfBnZK6G/n8bGNw81H3gFP7Ep6EZzK7MuASSSJ+fCzeR3+ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e6d6526-2acb-423c-4460-08dd2bd29f2e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFhNUE9sZ3NWek4rcDZGSW9qdEdVcEFQUTNXMzAyWDFYVzZtSEhBbi83dUlP?= =?utf-8?B?eUUxZGloSG80Y0hnQWY4YldrS1RBeDc5UHVQaVhFMFBSQ0h6V05mK0EvdXV4?= =?utf-8?B?OU5LQTRMbWFTOGRjV0dFQnZTNmg1Q05zREJkNzRkaWloSStVeFgxQmdtR1BN?= =?utf-8?B?cXQ5eXptMFFkWkhtZWN3cUQzc3dKeVVML0FWRTMxNlptVTdRNDYvYm01LzBo?= =?utf-8?B?TU5oeU5TMFEwVGVlaDVUTXBwekpUdTFWeFNua2YwTnpYaDhtS3BaenBPczhv?= =?utf-8?B?VFVUS0lQSVIxQXRITzJMOXNYOTlGSUM2aEVDcldacHFSZThiZ3F0R29MZTk5?= =?utf-8?B?SDhJNWw4YXk3c0xKclhMQ3lhRXJ3aGZ1UXVNZWE1ZGhQOEU2Q1UvQmE1R04r?= =?utf-8?B?d0gvR2xkb21sV1Z1YWREZHMrVDdGWUFQSUVrd3hONmRpV0MvN3o3aFc0ZTlN?= =?utf-8?B?cHhrQU1aM25IWTFEdlNoc2tDTGhMZXZ1dThYdWlFcXFKdW82Wkl6TFQwVGk3?= =?utf-8?B?ZzJ6QWdrME5zRmhtOGI5M3ZYcDAwOEg0RjAxY3dBNU5uRy9tZlFmanUrdVVi?= =?utf-8?B?WHFjeW80YlZWS2c2Zlh5cUNtL0FJd2YyUWkrRFE4WUJ0QWlGOXpDWTBXL0Z1?= =?utf-8?B?a2xMLy9mQThaQVJ4Y1pnTFJhTmhvU0h1SDN2MVI4bis2emgrZFRuTUgwaThz?= =?utf-8?B?RzBnVlRFZFRjQlJ4S2krc2wxV0dJY1lMUmMyVlFQeXVqR3FYR3BlWTM0amo3?= =?utf-8?B?N1lielBVMmJYb2tnbjVmb2RmcEpTOTBZdHhYaE83WUYzdytib01DeE56cTA0?= =?utf-8?B?Q21DMEV0MVl3R3RlZEtON2oxTkZhQlZoQXVWTEp3bko4OS9Ia3JKRzl4MU1J?= =?utf-8?B?ektuWThlWlhyTVh2Y20zblZDdFBxc0ZtczJoeDU3NG92U1FDWmwwOW5MVk83?= =?utf-8?B?WHcvam42Mkl0dVJpRlRtVFBOYTUxdlRReGV2a3R2TUVCNzNVZ1dWRjEzZzln?= =?utf-8?B?bGF3aURYRnpMeDZuMzJOaGx5Tjhlb1YranYva0srK2dFNU5UOEdVWDlFVlhQ?= =?utf-8?B?VzBWNlIxK2lCSE8wY0xwWWhsUVYzeGx6RzlWdDZmaVFVM2l2VEt4VEdxTndu?= =?utf-8?B?SGdlYk1ocUtTOVZaeWJneHZyeUN4bU5UbEVaV3YwSy9Uc0Z5ZEtJUi9iWlQ4?= =?utf-8?B?NXZ3Q1F5Y0NhT3IwTitmVU8yZHpGOEtCbHlvWG9yc3poUDMyeFRNYnY2U0Mr?= =?utf-8?B?M1laVTRFSVlOSHZxTUpacXk1V2VpbEoxN2lBRCtEMWE0eG11WktDOElrL01Z?= =?utf-8?B?WHZFSmFTUlZyVis1OC9jZFE1STRkM2xtWkhJTFdjMmJ6U3l2Mm9DZkdIcDBy?= =?utf-8?B?U1BFSjVOdVpqeTJHOENuTDUrMkxZQWxOT3UvTVBaRVZCRlZNWHNpRS9iYjdO?= =?utf-8?B?WGhUSGExb2lNMXNiWmxubnU2WVZCc2NHUStnRVI0Q01mdE54Q2I5RUVlZWcr?= =?utf-8?B?UGVxN1RQU1hwY3pWNTBEd0VZbGk2VC9JSnoxcDZoVUZWVkUvZHVoVXB2akJK?= =?utf-8?B?ZXRQZi9lRTBqNjBXK1NNUFo5TmhIdVZsajRqMVNVNFVMNHphaitLdWtRNzFs?= =?utf-8?B?R25KVXh3eDMvejlmdHlLSXdaelpPa2lrcFRqenNyUExUdFV5S1RwUGlUVHFI?= =?utf-8?B?SHR0cFRvL2ZZYWlUenMxNEVhV05xQXczQU5tUElYRW5HQVRQYVE0MkxTWElu?= =?utf-8?B?VDZvZXFkOFBrc3MvNzViOGN1TmNibXZjaEErMTVFbjNIUmphcXc1Y3daWlNl?= =?utf-8?B?M29CdjRzRFdPRjZPbjFGMXl2UW01TUtFWW96VTAxOUFmc0VBVUFVVFVKMWlR?= =?utf-8?B?SFFUTmgyRHRFdU00bi9QaXdiRTBETldFbG9qcW9lRE8rTzRPK0ExYk5KSnJE?= =?utf-8?B?NENZMEIzb2hTeXlMVE92VG52YXpmUnpUNzMwa09wQWh3R0ZOSEhwbVlmTmdx?= =?utf-8?B?bmJuaEprYi93PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmN5dFViMTZrRVd1WEhpanJtdWtkZ1dYTjM3MFRINHBKRG1QZ0RGQlRjQ1ls?= =?utf-8?B?RzhPSlBtdUxMZFdiS3pvbFRNZG83cy9jNzZFMHNleXBSWnRzdzhRSEFOaDc0?= =?utf-8?B?bW1yZXJraG1PR05KaXFha3EyTTUwQk1TN3RteldFMWI3M0o5L1h2Tmt0WGt1?= =?utf-8?B?Z08wMVlQZDdBTzJ1d1B3UENzMW4rcDZ5QzJ1WW12QnA2aVZ1Qmo0SExlc1d2?= =?utf-8?B?VUpDYisyWi9kUmU4bUdvOGZWTWdLMlNNMWdoYWQ1K2NuSXQ2Z3FENi9HSll6?= =?utf-8?B?aFdCbW1Zbk92MnIzZ3p4OHo0MWRBb2JodmhLcTRHTG94azNaOVBtVHR2bFFF?= =?utf-8?B?QnZhcUR2SEw0Vy8vNWpYeHhpYzJTekNTa0N3a05qWkRvQUpLUExQUzFWU2x3?= =?utf-8?B?emtXbmtlQWZ0WDlPdTZGMGxKd2QyWDd5TStUZzJtc05aelZ3ekYxVWc2Nzky?= =?utf-8?B?SXpFZUV6NndHSFJQZ0lRZGNacjBKUndaRWo5am9XYjJTTmsraGtRSzJzVlJz?= =?utf-8?B?aVVPd3lsTzNuQ1JQdTVQbXdkWEU2b2lxWVlqZC85YnhJWHQ0bCtkeHZrSlQ5?= =?utf-8?B?ZXRaTEx4TG5uSjhmOXBqSUYrQitaTjd3NE1NUUtwWTdtNnZKUzZRSWRVd2Yr?= =?utf-8?B?amdTNERlYjJyRlFFWHR0Y0F4d1BNZDd3Wldmcnp3bzVmeVZDd2t6eXJxblJh?= =?utf-8?B?N0N6UFJwVlJhdk8zWFU2eHNxZ3VEdEFGWVNHV3JOVnRMSXNwVFVzd0w2T0c3?= =?utf-8?B?WnRsd05VbVFJMWpVMjV4NkJYc0VZRXl2TkV0cHlRZXEvY1UvRDlEb0tFQ1NT?= =?utf-8?B?QlFHcVp3MloyVzhvT3ljeFNiNkR3YlhVNlJYaE03UzQrSEJHZmdHSngzVWxI?= =?utf-8?B?RFBEZWovenJVZHlheWt0Q3V3bHpsUHdWZVA1Q3dLamFPZERwUXVFNGtDOHE4?= =?utf-8?B?a204aXpIN0liOTZQNVhaUEp2VEUvV3BZOXROalVRSUxoVnpSR2Uvdk5sR1ht?= =?utf-8?B?RWc2UnkrRDZ5VlRxM1lZa0pTRmcvNTFnY014TEZBNzVUUzFDN0hrKy8yZjQz?= =?utf-8?B?L0dCNm5HcHBJNWtBRWU5ejNUNzYvaFhHYThubXI3ZXhmN282NzVJdjZVMUhu?= =?utf-8?B?c1VpVnk5T0diK0JpZ2R5OGFrSjNRQWJWUjJyRmRsR3lJc2xEa1RESG8ydlg4?= =?utf-8?B?M1V0WkVZSnpOcmhvQnVsUFF0eUFZdWt1QWFPU0tnaW4rQ0xVc3pSbUl4SEM3?= =?utf-8?B?a0IyTU5OSzVuYmxaVVRuem9SQ3U1aXgrU21NczBYVmZoM3dpNHFlVngvUTRs?= =?utf-8?B?N1FmM0xWQ2dSSk8xZjRJN2tCdXUvQXZPa3kyNVBLZ2Exdkc0cTdHZ2lLeUdJ?= =?utf-8?B?bmRGSEI4S0EyWU1vVmJvVlMvaENsL01ubXpkMFh3VnJlWjhMa0JBT2pUVDlX?= =?utf-8?B?QXk0RUpKZitMSHp5Tk14TFpYSFJoaXlrVE8zbXgwaHhvRkV5ZkJtSzZhSm54?= =?utf-8?B?VTJCa2o0cnRvVkJPMVlGT3N1bkVzNWRhVU9VRU1jYkFkK3ErMmY0UGdlUjZx?= =?utf-8?B?WkovWUJmcmZacjB0eEpxdG1UOGJRMjdHdUF0WWhiQkZrMDNQZUwwSEFWS3RD?= =?utf-8?B?YnFhM0NLVlZrNXVnbjFwenYyMkZ4cnJUY0xtbDNnOTBmUVZQRzZPSjhsL3NR?= =?utf-8?B?dXFFMVhJdDlHV0Y5RVJBS1k5SUVjZ1NtM3JDaWdxVURXckZZNmI3ejJ5V3V5?= =?utf-8?B?SWVDb2o5UnljNUpxN3UybXJybVREd2pvMkFmYXFuc0dEZmNYS2tRZzRVaXdm?= =?utf-8?B?di8xQksrS0ZHWTRvbWRnQkkxUHRPYW1iSDdVb0VBQ2UrY2FxeHRMaG9MZ29M?= =?utf-8?B?VXNWQlJpdTJkYm1yUUlRUHFCaGFxZmgvUHEwRHJVeGM1bnQrMzIrRDlKd2ds?= =?utf-8?B?T0FjM2tUaVArY3NTWWVGMDBaNkVXVzlsblFHc0RuZGNGSEdMcXplK2F0Z0pD?= =?utf-8?B?R2pxQnZGVmUvUGZxVHJpN3FJbDM0UGViWHdnT2VwTzdoRGFaU2pIMkV4TExY?= =?utf-8?B?ZTlwdTFUZFVVVU5TMzlnTUJCdC9kUmg2QUNrNjlKZTdWOS9ZZm1GVGRONjEz?= =?utf-8?Q?k5ZtZ35/zwxY8fL2CpdWxawcy?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e6d6526-2acb-423c-4460-08dd2bd29f2e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:42:57.1509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AcKLnmumH38JFy6B8vQngVlbJeSSXnBV/m/ezhoyeuG+wTQhYa9/o71OXmuHdzKAKu3z/v7ZoBqFSAZUJjf9WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-mpfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index 3892b0f9917fa7bc4f732cfe2c2b2f548ba7429f..5a38649cbd43b3c6f2fec5db95c= 4f0013deb2a08 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -267,18 +267,13 @@ static int mpfs_rtc_probe(struct platform_device *pde= v) dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler); =20 device_init_wakeup(&pdev->dev, true); - ret =3D dev_pm_set_wake_irq(&pdev->dev, wakeup_irq); + ret =3D devm_pm_set_wake_irq(&pdev->dev, wakeup_irq); if (ret) dev_err(&pdev->dev, "failed to enable irq wake\n"); =20 return devm_rtc_register_device(rtcdev->rtc); } =20 -static void mpfs_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id mpfs_rtc_of_match[] =3D { { .compatible =3D "microchip,mpfs-rtc" }, { } @@ -288,7 +283,6 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match); =20 static struct platform_driver mpfs_rtc_driver =3D { .probe =3D mpfs_rtc_probe, - .remove =3D mpfs_rtc_remove, .driver =3D { .name =3D "mpfs_rtc", .of_match_table =3D mpfs_rtc_of_match, --=20 2.37.1 From nobody Thu Feb 12 23:04:09 2026 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2068.outbound.protection.outlook.com [40.107.20.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C34E1D4339; Fri, 3 Jan 2025 08:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893792; cv=fail; b=lRPLQ+lBWc8H5k6URjWlPGzxgGsNP7PzunQS1tgWVs+3Pmyua+r0ZsqjQ/AQNCw8rYFvEOwTp9FysrM+RjloEdZqSM9ZD1Nxmurp0DB1YEWoYmSrR3o77UzEKvAcDb8NG29f9oWSgW5YDWtOoEEWD0YOID4SLcq6ioP6lE/n1rc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735893792; c=relaxed/simple; bh=AcWk+DTl4vJlEoX1Fz1L2UUCItL1uFcWaPK5Bz+U1lU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=OOfFHxLxeq2nEqB1FEH4rFJBg0Ra345pVbbP98BkUIGm6p6h4IA2WeYxr58xNEb7pTbbegfl6r3HGzYCYVuARAsJtwlHwnJP8n37Brn1OY1M72IAw9GPzgMTbTa/mvXyyFYOPdMZpKotiTm+kEasQwkSz+xPA4u9o5zjenD2+AI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=vxTtPFsk; arc=fail smtp.client-ip=40.107.20.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="vxTtPFsk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zQWhPDj1ofOw6tAbwxQfq8y7SsMShquk/MtqtByTVkNA9Vc9pVvpZpP8Z6YJJv4bSZXruHE7oWL5E4dzNaVdYbobLU1yxv4nW/Dfx9K3RepTJcqJMdS0YHcPFfuoXlxm2/c3mE5aC6phLfiYB2yavJR/nYbBRLZ9RdgbviTSooASvh+KW0lGgd6/xq83zxTaR2Bm3eDbNa57Rl4fWlOjXTMphnBVcoy8WeO8w90u4Ouu/n2uEoLtx7Mpp6BS4xNeFZLIGT+1CJ2ihrqTqpnKMHJa6BXGCF+ZEFHCsnGIWAp6QwIi6H7h3No8CkrpgFzYZZxIbzq3Tbx5C4BwfC55EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=Ls1klEqDwOGqx+74HAzT8Q09y30G/aIXIA51Dkpc7iF09f18N16idakmdNhFM2Z/v6m342eFUMk2ML2f4saShR7xUgaeeujzH6q5M7lpgBFlKbMcFdRpjFgFv2TbD+anH0PZEvCKF9Pa56kSNcsLahu3FgS6n4fDAHP0HYglbC5q1RAr9CaG9zuTjrWmDnynvQzXeUh6s+tVa4fO5ooOyquSNvk3zD0ejj1YkTMKe8kZ9NeaHgmRfmScmsu56haPpBScnTc5ZIbtwTa4IthVBL+f4ZTcqT1olC/ZwKfT5eSxVXifGAZ3AKvNkPtbRmFPHe75pnlfdOKRJ3/ucmC8Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=vxTtPFskRMLEgHTyP/fgpcXoOnZE1EqlrYdZ2rMxNKdrjgULKw6PTiA0yxz3Uw/Bxxfmqg7Q8Q+D+JkkbClTC80gWGg0rdgqcIBvWqzD+Q7+R+/igdZgIU/OyKxyP+/wCOKnFCpoX3VY6brTJX0PM7bQ0bpxZK6tnj0rkNjKQ/kYhoCXxbWB0fqzaKPw8iv62R3HUYewE5VbJQekz/9REa1wkAqJhmccyUcrCSVBpF+C5Dq7NUpZ7ulQgUVrXw8w8+le7flSPCKKtNZmmaNT2hz1t4rM4yyN6rX9RCu+QfbAgPprYFeSk01dpoKE2dT0Dq7DwJIuUSLtu8dXblVBEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB7599.eurprd04.prod.outlook.com (2603:10a6:102:ea::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.14; Fri, 3 Jan 2025 08:43:02 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8314.013; Fri, 3 Jan 2025 08:43:02 +0000 From: "Peng Fan (OSS)" Date: Fri, 03 Jan 2025 16:41:24 +0800 Subject: [PATCH v2 12/12] rtc: pl031: Use resource managed API to simplify code Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-wake_irq-v2-12-e3aeff5e9966@nxp.com> References: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> In-Reply-To: <20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com> To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Dmitry Torokhov , Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735893689; l=1457; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=836X+TA/l2wfm7yon8oTf/+NEC4So+0tkKKh8ZKoqD0=; b=wPNPC7HHmF7S3u6pMjmQqPHx6RwH3WIKfRhJYkNt9qByWhu1R+qotgzVAjq/sEWPG4hhwi942 RKN2EzFG34NA0T/RCWXd5Lugy7TNOKAcYWyHlzqRweLvVc2ZyR8wknu X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0003.apcprd02.prod.outlook.com (2603:1096:4:194::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB7599:EE_ X-MS-Office365-Filtering-Correlation-Id: 89a94550-10e6-4f5c-c545-08dd2bd2a28c X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|921020|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WkFzZmsxcEJ4VWZMSVQ2RnlJblJ0QkE1SEdVUlkwc0grNnlNakQ3My9JWW4y?= =?utf-8?B?MkUwblA1Y0dyQnBacnlYZ0d1Rm1lY1NMd0lXZ2xETElSSENVS3FtSXpZdkpy?= =?utf-8?B?MGJvNVM2UVpmVzNpcExiR3VwSFpWbno3bVN1ZmoxSy9zYnpra2pLRkNhY1Y1?= =?utf-8?B?SDhzblpXTFJ0d2Y1Q0U2L2pmTThoT3FrUkFwQ3ZGL3cyaVFTNDd3ak40V1VR?= =?utf-8?B?TDNsSFM0MHJpSTdoQ1RONmlObG8zQysvSENlTnhwQlRGSXJRU0F2WkhWdmtW?= =?utf-8?B?N1lGdVZQZUJaOXFOS0FkV25obFU3Nm1MeFdLWEovSVdscXlFRW5QcitLcDdC?= =?utf-8?B?b3l6YzRmeDBjTDBIdEdSbDdNTWllQmZ4TVlKdjNmaE1ZMmhUalNuYlpqSEdv?= =?utf-8?B?b0lXalpyNkZ3NGo2WHAyTmUxdHFaeERtczZUVE5nanNkN3BWZUdqbVNBVytY?= =?utf-8?B?QURTSi9DQVEzWU94d0lwV2FIMEhXdWRSRURkckFvUmgwV2hWTkFLck5CU1lJ?= =?utf-8?B?ZmRRaVovTWpIREh5dTdCM3RFNXV5b0I4azZxRTJLclR5ZG9VZ0laZVJmU2w2?= =?utf-8?B?SGgrbDVDNWw5bEI2dHREVG9vUnhYWC95RFk2aGl3Q0FFejFqZXV5SjQ4QW5t?= =?utf-8?B?eWdDM1ZGSDZab25wM25QZjNETTA4NnFuc2piM0h0cFpjangxaE5aQ21oMmVS?= =?utf-8?B?ZjVGZSsvbjIxMWhBNlQ3U1JjL0VlZHlpczliaWdQMVA3b3o3b1N4V1BhbUl5?= =?utf-8?B?RTF3Z2dxLzFLRTNFQzFCMk4vc3d2Y3RIekxKRDQ3Ymh6cUFneWdBVTFtbVZy?= =?utf-8?B?ZjEwMDJ1aVpsSW5yc2Jtbk5PZkRNN01ONW90VlVtTGVWRXhDa0pKeXRZaTFx?= =?utf-8?B?NngreDlxdGNtKzRaM3ZNUlZEdkhwNXVtSlhqSXVzcG5yTm91WGlsK0lEMmgy?= =?utf-8?B?dVVJdkJTRFFpeWl2ZTRCV2loRTFIeTN0TXRFQ2diWEZxMERkVlZEdU0xTXM1?= =?utf-8?B?Q1Znd1hzcFBWdHA1RVVkMzFWT3MwWi9nRU5kMjRmeVkraXdicGsxam40UXB4?= =?utf-8?B?QWQ1SFdLa0hSSDJCVWVGR0ROdDliWno0emwvTXkvVTlKTHN1eHZBMFhsNCtD?= =?utf-8?B?Rnk5bjljQWZpOHcwNU9abVhCR3BhbDlpb0Q1cUg5dHovZnppRmxVcFlIajZI?= =?utf-8?B?Nm1zL0RaMDdITGFDdm8rRy8vaS9zODJCUGdsaDBZb3FLSTRSbEpOQlk2TS9E?= =?utf-8?B?M0RLSjBwZC9vSDZ6c3RyME04UEl5Uk5wcFY0aFBIRU85ZkRwdmE3Sm9YeTQw?= =?utf-8?B?YUFBcVVjaVBaRXR4NUlqMFdtUUI4S2Nab0lWWUpEVnFyWlZzbERIMGhvZUFB?= =?utf-8?B?Nk14WkNybGJEVEozOUIrWnVib1hmdSt2d3RwRGpCWWlOMFVCUHBpV3FGWE1w?= =?utf-8?B?L1EvUmJFSjZHWENTbGxjUG1samEyM2ZGQTAzak1jaTArejNCbWx0ZEtGWVRl?= =?utf-8?B?YTQ4RkRLTm1zM1ROa0pzcmdIZWkxemo3MG9lRUhWWFYvVWlsb3dnRGpGNGk5?= =?utf-8?B?OFpBaC9mSjVta2NPWmlyTjJZMjVHMHBRTHJXc0ZOdkdMdkJBQmlPMVR3bU82?= =?utf-8?B?ZFU0VnFVMUFTUW5MS25PZFNXbDZVVE1zVkxsVTVpMW15dTdkR1lVRGVkc2Qv?= =?utf-8?B?YlB4WS9TczF3MDdCWG9ER1NlSHUxZUlVbzRPS1dYcFFWT2ozS2JYMWxCdlRG?= =?utf-8?B?UjRmd3hkSmdIUHpQRG5KMEFqOHhyNGVVajdpOS9veU5ncUp4UGc2L0haS2xK?= =?utf-8?B?TUs1cGJUeUZSc3IxVW5WNFhqMUJ2bmJLY000WDUvUXFTY3NzN016Y0d5ak1t?= =?utf-8?B?anJpdE5Dc0h1UG80TlBBOGtTQW92U05HYWNYV2gyMzVxVTY4Y1ZmS3BOY2dn?= =?utf-8?B?SDVBQ3BDTGRmY2oydkJQbDA2SjNRQkVmSytVUWFGK01JOUdBYmpTdkV3aGI5?= =?utf-8?B?LzFyK1ZiOEFRPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(921020)(7053199007)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGkvekZpTVpVdXNUWnZuSFRqeG1JZFdQYWpOcFVTQ2lDWXRjaURSUkhlN2U5?= =?utf-8?B?N3JraStOSWhCN0VXVjN5OU43bkljei9TU1d4aDBoT3VKMTBsR0U2aVplc1Az?= =?utf-8?B?YzZkbCtkdDRjdVhiWUNFejVXYnk2dzdZVklRTVRhTUxKMXp4Zko0elVsbHhZ?= =?utf-8?B?Vk9ycGdHZkUrT1M5Q21IeEc0dXE3N29BZExza2EvZlR0NFlyWXBUNjhkNG9H?= =?utf-8?B?WEs4VElDbFN6Wi9BYzlYL2VRVXFEOUYyNHgweFlQTjJjT0d6L1FkUkptUTYx?= =?utf-8?B?UC9RS3hqTmVERjRESHBudTI3VjBYTWlKc1hFaXl3Q0NvSE81YXV1RnBYdTBm?= =?utf-8?B?ejY5bWpKNE90OFRrTHcxdWVmanp6ZlZHeFlLSWQ5UEh4ckxLUG5JUGNFWHpO?= =?utf-8?B?UUdONmU0UitrL3NERzVCSmdJbW1JaUFTbVQvRVlQbVFFQkFmTjVwOStiTmJp?= =?utf-8?B?bEMxcGY2em1HTlpsSUtVR3QyZ3dOMjFmZHE3VUdlQmdXN3MwbHUvdXVUa1BM?= =?utf-8?B?Snlidk55Mi9WMHpPU3VaUEFYRUdRR3dzTHhxdFFSOER0dHNPK2tvZTFqZ3FB?= =?utf-8?B?T1VTNndvbXd0cTZRV3RMSmp0ZWk0cXJ6WlBsWWdvd0FYY3N0R2FEYWIzRW5D?= =?utf-8?B?c0dXZlNBNE93dUhEY2JGN3pDK2tvQjE3QW1xSkNFNlo3SnpydTFvYmlaaHFz?= =?utf-8?B?V3p3cGZwRmt3QkQrdm1kdnlqWUtXZThab3N0eGhPWEFQdUlHWWUyNDBkeWVZ?= =?utf-8?B?dGpqZTFEcWNKN1ZsaEhJdFJqNndNeTZxcDBXd2lFZjBpeTg2ck5mRkRHbVlF?= =?utf-8?B?bkcydHNmdDc3bmFlcWFwbmcwc0l2NVpyUmxFdmtQeVBpbVlwQXVLc2hXWnBl?= =?utf-8?B?TUxtMlIvRm9GUjZOVHpveFhCVjNLOW5weE0vZjZ0SFJIYlErcnJTWnhHVTFG?= =?utf-8?B?OEhFQmtHd1ZVRDBQZUtQQ082U0FjOGhPeEZFbzd5akdFblNBcnZzU3NhTzYw?= =?utf-8?B?Nkw4Ri9BMHU4anh3dkZOaUgwRlYxeU1sQWVpR0Zod0t5TTVMcTBJRnI2d3k4?= =?utf-8?B?Y2psVFVqdVFXdzBlWmIraHVod0I5WS9QQXEweFFDcE5ObFo2TDZrZXdkcUtY?= =?utf-8?B?RWZobEtoQUsvVEhiTWt1d3VMbEdzS2VRQlM2UHEzZFd5NmtIalRNZVIzcGYx?= =?utf-8?B?bWNzSHVEdkdJUTJSbWxnZEtTdFFSYUo1b1RPSW9tS0tIc0lEUGtRVWIzUVVI?= =?utf-8?B?T3NGNGZGcG4wTnN2YitSb1RmQ0lqcW94OXFmeFVBME5KaUZqN0NQMWlQS0h1?= =?utf-8?B?Z0k2TWVsaGIycHREMjB2cEtYeTI4QlVCM1pnc3VIOWhMNkxuT2tXL3dCN1NP?= =?utf-8?B?WEpTSVpZcWo1cHBRWjF1L2JSQ0NVNWVqbGpzTWF4SklvQ3k0MXEzVTVZWFYr?= =?utf-8?B?UTk4bDJGYldaYy92YXExV0NITjdkczRHbWd0a3N3YURWQzV3Y2RLY2FOZ1hM?= =?utf-8?B?UU5aWEFxUlc4YVZUWmxkNTZCQUEvWW4zMHNBL2hFckNhVlFJWU1kS3VnMmZL?= =?utf-8?B?ZFFHdkdCL2QxZHV0SW1YNFYvWTQwSUJ5VitzekUwb29NY0tOeklUTmEwNGRs?= =?utf-8?B?VWZON215am5aN2N4MGZ5SWszVmFtWXdzbzIxa2NUUU9CL1N3ZzRUSG9yZnNY?= =?utf-8?B?ZkZNT1hjWVlBbXdwbERpcnR0S1phQmNOTlE3TjlsSXRIdHVKcHJzMVBhU1ZY?= =?utf-8?B?REZJUVFoakxUbmc1QmdLeGFTWHdNK0RrM3BCbmthM2tMSXQydFArdG5RZ2hZ?= =?utf-8?B?cFduSVJwenBuakhYWnh1SXlFWFBhcDZOMTd2S3NJczllVHIyQ0dYNnA0ZmMr?= =?utf-8?B?aW42b2pnT2V5YzRwd1F6S2F3YmVhTjZ4aWhYWjkwQnFoQnJSL1Zlc2xKbi9n?= =?utf-8?B?dkxBbGlITmpTaUEzdmFvcDNXalQ1WlVRUlNsRWJNalFrU3JvNjJzTjlHZWNQ?= =?utf-8?B?V01SbGROL0dMOWNOU2hmRU82OU8yeWNNRGhnU0hRVzl5dkE3b1I5Z2VHeGxJ?= =?utf-8?B?QnllQVJHd3VGV1BuTHFWNzNGOGNLSytwclNiMGZIRkQrSUU3QWhkeUNKY0xq?= =?utf-8?Q?IpLBTuQ/8LPSKkHrCC+Q6wSK3?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a94550-10e6-4f5c-c545-08dd2bd2a28c X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 08:43:02.8080 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vbRkWz8ZpFt7a5nsJBlpqqRsT9miE424tJjzPiFVpLHNJKjBfmnaampVFv6MfS9OdqFC6I3d4BehT/R/OnDJfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7599 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pl031.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index bad6a5d9c6839ca70905e3d46286b9729c1fd435..47bfc5395e5908b7722b9827639= 9120f1ba65af0 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -284,8 +284,6 @@ static void pl031_remove(struct amba_device *adev) { struct pl031_local *ldata =3D dev_get_drvdata(&adev->dev); =20 - dev_pm_clear_wake_irq(&adev->dev); - device_init_wakeup(&adev->dev, false); if (adev->irq[0]) free_irq(adev->irq[0], ldata); amba_release_regions(adev); @@ -350,7 +348,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) } } =20 - device_init_wakeup(&adev->dev, true); + devm_device_init_wakeup(&adev->dev); ldata->rtc =3D devm_rtc_allocate_device(&adev->dev); if (IS_ERR(ldata->rtc)) { ret =3D PTR_ERR(ldata->rtc); @@ -373,7 +371,7 @@ static int pl031_probe(struct amba_device *adev, const = struct amba_id *id) vendor->irqflags, "rtc-pl031", ldata); if (ret) goto out; - dev_pm_set_wake_irq(&adev->dev, adev->irq[0]); + devm_pm_set_wake_irq(&adev->dev, adev->irq[0]); } return 0; =20 --=20 2.37.1