From nobody Wed Feb 11 04:19:48 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1AD81CEAC0 for ; Fri, 3 Jan 2025 09:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735896109; cv=none; b=cLnPHrLOQmTR4oIRdse1b/5omGl2++gKR/NQNL1Prh5iBInB45NgUkiolyLbhqU5K9Npz2WQz31pzyOR3t0GbXtqZOJSqJPRFxLtvwoFLrqz0a9fDWuXUzZbnjkknBIRyvP/oVH+tej7sCfNcwt+NFKZYHsnUXQHfrLkidQlCKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735896109; c=relaxed/simple; bh=Cn/7/TPNYeOE+2g/2l424KGbAevrj9ZsheolFBBsRSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h++KoXefPXcza94akHXXmhd6WTdJmKuRMvocrOQFFsk+lqRLB3P+QAiy5u2RmFipQkBVDGAwKjsEYtMiK2rNsrU/fR71pa7W+VNlEhMDnT1Wkve26BOXGgXvjb/jTHPeKBaxSjJTEfNpB1jPY4Hk0azAU27YXuY9iIGVZnvDfhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=OE7msc0t; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="OE7msc0t" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aa6c0dbce1fso1661263166b.2 for ; Fri, 03 Jan 2025 01:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1735896102; x=1736500902; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rVDJte8gphg5oXk1BsgnY1RJiMM2PoJiarukFRgU+Eg=; b=OE7msc0teW3tzudu/hjt3cKTved7Ivx9UhvVNK8LkAY1T/qz4PjMxjg891RTucFn03 eUi3DXvwcUDXjEkmFEgy4Zx4Ve4pDdTZ0nr7nLqRI5aIcZzryWdEQPoQXsIKVlfPVhzR 96eLIi68QrgPUZd12d+3jRSGy52kOHVawZr7ekcfKwDo5ZWz+5zP8e+m8ZoXwywt0Vab pkp5pwfC84p2hLRjCyOsCuTPcloTuY8vB4KX9uApbiLoReCKbsOrt+SxU4cke0ZUYS/D b8r5c8A0oxSYKCTSWso/SVntBQ52VW5II0I+a0F+yVqRjHItYfdzFVWW0WwlzTWGDh7k YcWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735896102; x=1736500902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rVDJte8gphg5oXk1BsgnY1RJiMM2PoJiarukFRgU+Eg=; b=f8GHcanrgdyCo/NqpwpWw+uMFnENWdXFqbCBHvWcAPPan9QunIQ/evvMj58V1tZF0+ u4x27tSk3abYoezyLy9POWVcpaQuKW6blUJBVXsRd2aa5TGHnTMv+CGPPh6LEe7Run1H xuRgvl5WksRuPeLR4WsgD8yyu7ik1sgHxFatK8geaqsgPK7AO7vA3ogFCUUfw7Tri7F8 kc96byokjbu0tv2UJXte6Hvka4gRhVXUE2nHruowD2oG7EVmbvxn6NgBoAZFenwrW84R 2SScYb0LAJxKu5LIjpcmSq/DSMbjot9copZTJ1mUPa1Tf48fPvZqW7/I9yiHvv+BninQ rd3Q== X-Forwarded-Encrypted: i=1; AJvYcCXqSN4wCT01ONVzYvgK0DPIXtIESOcwIm6GJv8BlytI+eFzNh2OCJPokiQcvwyEtG2eA2j9hmvkJ9y9k8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxRH4uMqdrCtDtW7r1iWzLJQqWEKQJHh5kpQ9NKzxDumGMGY5GT oEPQtfJ6vM4ov4anLhR+jWjODYdlUgLb5yeI46XbvbWUZaLpKTJpmpn7L6thSR8= X-Gm-Gg: ASbGncuwjVbwpQGxUT3OME9VBLwiWeYvaYqfXS6SaOT9agb5euI5fidWh/ZMXHw+7fB bsKhRF8G0FEI2BLkZVxKWbBmGx9tPxLX2uiDj8DgkXS66uU+L+Z9f+rhQzMC/D3fmdktQOCZEEV 7+/xm5iagHhbqgzGRSpiX8M9bYPWsk+hKcMscPTRp2Gkt2NfoHfveYQo4gJbMELMHygzzY/ubFP NF6xEz/kpT9peu9Wyx4ZTvPM3MAGjUT5bOrcfSU1HATcckPWgHmRFqQuLfquoBNpL9qk/lmwS5Y rxra7N5PsAmep5w/dCnjy8m4/A== X-Google-Smtp-Source: AGHT+IEP0pqzjNcKpMLHv58TycLuFbHDFEPtWZPP5wVDvFEESvjEvQXGbmwzN1VeN1K9zq9lytBpOw== X-Received: by 2002:a05:6402:4405:b0:5d2:7199:ac2 with SMTP id 4fb4d7f45d1cf-5d81dd83e12mr112825622a12.2.1735896102436; Fri, 03 Jan 2025 01:21:42 -0800 (PST) Received: from [192.168.178.188] (31-151-138-250.dynamic.upc.nl. [31.151.138.250]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80679f0e4sm19235306a12.42.2025.01.03.01.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 01:21:41 -0800 (PST) From: Luca Weiss Date: Fri, 03 Jan 2025 10:21:35 +0100 Subject: [PATCH 1/2] Input: goodix-berlin - fix comment referencing wrong regulator Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-goodix-berlin-fixes-v1-1-b014737b08b2@fairphone.com> References: <20250103-goodix-berlin-fixes-v1-0-b014737b08b2@fairphone.com> In-Reply-To: <20250103-goodix-berlin-fixes-v1-0-b014737b08b2@fairphone.com> To: Bastien Nocera , Hans de Goede , Dmitry Torokhov , Jeff LaBundy , Neil Armstrong , Charles Wang , Jens Reidel Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 In the statement above AVDD gets enabled, and not IOVDD, so fix this copy-paste mistake. Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen= IC") Reported-by: Jens Reidel Signed-off-by: Luca Weiss Reviewed-by: Neil Armstrong --- drivers/input/touchscreen/goodix_berlin_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input= /touchscreen/goodix_berlin_core.c index 3fc03cf0ca23fdbe36028a6228030d3ffb8d3a09..e273fb8edc6b92bcbad0fd35223= a841d7da7d671 100644 --- a/drivers/input/touchscreen/goodix_berlin_core.c +++ b/drivers/input/touchscreen/goodix_berlin_core.c @@ -263,7 +263,7 @@ static int goodix_berlin_power_on(struct goodix_berlin_= core *cd) goto err_iovdd_disable; } =20 - /* Vendor waits 15ms for IOVDD to settle */ + /* Vendor waits 15ms for AVDD to settle */ usleep_range(15000, 15100); =20 gpiod_set_value_cansleep(cd->reset_gpio, 0); --=20 2.47.1 From nobody Wed Feb 11 04:19:48 2026 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BEFC1C07C4 for ; Fri, 3 Jan 2025 09:21:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735896112; cv=none; b=pY4umZe5k2cUz2wdtkU2GR2TX1s1PQxGMpQqes8U519nmLCHOuWWyyPscjEHRhPGeRG2KmTeTTqBWsRztwy4im2v2uIy20lz7Xb9Up2KglbeKeByPVRwEct20KNbyJcGxt73u28s7+nCksUkXU713QGUgRoJcAVb0C4paMcqSJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735896112; c=relaxed/simple; bh=bk69j7cQAZWUSCvUWp+LMn64ePfcekugWmm+4CcpgZo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OeAm4xBc09tM9gWSzLCqEGLXV1G5E4CpO/0qo4XCB2FcTRqmrcId7sLQglMzin/706JWms53/r6b99miU5hUgHxK7TgPfww6eNCVWooEqoBEzuagfAWF/PoG901EKlI41fP3kzNkahOXVDYpt2CsAAGXdVrfopqGlYkNFx0H42I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=zwC/z2t6; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="zwC/z2t6" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d647d5df90so5578190a12.2 for ; Fri, 03 Jan 2025 01:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1735896103; x=1736500903; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jY0TRDCrwLCuoqHobn/ChZNWc7XniF4TmDDu+w1tFQw=; b=zwC/z2t6lE/aHPL0yU0qB3SMOvlYEGa8W710O28bW8BB9y8iTD2xykBEB5hrj1CHF3 RzXq+CxbSGzAFS4sA/XKGlEtD9otBxI+hSml/514Ne7leOUoRosvVOJhOCAE6sqjMVMh H0Ans6qjLIclaJ3A2hiV80zodwn6W00Xa7KQyFG4vXUIJmeImrs9Jkfxw1fNuvCXYA5e kw+AgGEqFpVqcR0knEAFQ/T5FRrvjJMj6dUezHVR/vKvLLkuGsm7Rs1/hCKQnI/IqgD7 s9FKBCBA7lRSilOWWFUzDsizeMduGfUXINLrzQrJSzKI689s/qtO6+WM8Rr2gxj8Wa3m YeCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735896103; x=1736500903; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jY0TRDCrwLCuoqHobn/ChZNWc7XniF4TmDDu+w1tFQw=; b=O4ENmbidBj/ArbaokouBx1ZFJGSe/p3MCv7cFXOfrd0aDlHhGz25ep1WWL6mL0b+CY HM7H2pvCPETVqD/bM/qNmtR2SBz4jBnI24Qg38wrr2o0ZRl3CNqMk0yJfHprw7y5zdau Ma2nITE3gPei8i757fxPuL5ISfSTVNUwZ7xtXLt4nP2aTodt3/HuKctuDGZzSCDxXmBr kxwweN8mkveTLZy63Nf1b4AafaLt3ZGhOxRxpKo1NxBIHibougMWD1nALrlERud7ZYA6 zrjW42zXYxjaiheoYpSASV4Ui1x9TbxH5EqLqKUk66nH1wVy0gCAEguTd5/9/sI7rZ+g D3jQ== X-Forwarded-Encrypted: i=1; AJvYcCWJ4OFg80YhF7yLlZ7JJ8K+efKtySv9dTTi5rMjFl+UihZpsvh5ULKYQ+YFVyXyoD5pif3q7XUaVbicxEg=@vger.kernel.org X-Gm-Message-State: AOJu0YwGYMLrM3hP3wjztpaIuJA1S8BxlPuT38nMFMCmBIcrCrA9jf/x H8gvKt/2e7JX8Yizq8n9GtIR923VCYzoGKH2Hy4SX8tsKOYguBjKo/QiCezjlpo= X-Gm-Gg: ASbGncv5uFVBnfozJXihzM0I7zHr6bi1c0YU7H5f1exJfVZc3DzUylPZQtaTkDsNN+X R/1ZG3GgTSJLiBT1T7CX9KsbR2co9Xem6iDntM5TjbMPguHak46rAO2m7fstzP3oc633HzHtsNb Rf1fS/bKD3T3ixGl9rcagOlqaBJXZGrcIMmH5loaoKG48aa2kMJMOAvNNaCPq/JagfcpEFnVN+R QWCbVB57l7f3dcTFUZNWxk+acMvdXZ7qSc7EM4susl2T50uA9aKjKJWqw20ZXgsnYaK6jfTVvpT OQlH9d9Npe0LxwVBzlSU1ubp6w== X-Google-Smtp-Source: AGHT+IGCXFzPfanqGlEJoQDV1fyU2QHFADwXXJX1U6RXJVoelZD5Mwl85y29mdT44/KLplERiXN5YA== X-Received: by 2002:a05:6402:35d5:b0:5d0:e877:7664 with SMTP id 4fb4d7f45d1cf-5d81ddada54mr44288721a12.19.1735896103190; Fri, 03 Jan 2025 01:21:43 -0800 (PST) Received: from [192.168.178.188] (31-151-138-250.dynamic.upc.nl. [31.151.138.250]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80679f0e4sm19235306a12.42.2025.01.03.01.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jan 2025 01:21:42 -0800 (PST) From: Luca Weiss Date: Fri, 03 Jan 2025 10:21:36 +0100 Subject: [PATCH 2/2] Input: goodix-berlin - fix vddio regulator references Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-goodix-berlin-fixes-v1-2-b014737b08b2@fairphone.com> References: <20250103-goodix-berlin-fixes-v1-0-b014737b08b2@fairphone.com> In-Reply-To: <20250103-goodix-berlin-fixes-v1-0-b014737b08b2@fairphone.com> To: Bastien Nocera , Hans de Goede , Dmitry Torokhov , Jeff LaBundy , Neil Armstrong , Charles Wang , Jens Reidel Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss , stable@vger.kernel.org X-Mailer: b4 0.14.2 As per dt-bindings the property is called vddio-supply, so use the correct name in the driver instead of iovdd. The datasheet also calls the supply 'VDDIO'. Fixes: 44362279bdd4 ("Input: add core support for Goodix Berlin Touchscreen= IC") Cc: stable@vger.kernel.org Signed-off-by: Luca Weiss Reviewed-by: Neil Armstrong --- drivers/input/touchscreen/goodix_berlin_core.c | 24 ++++++++++++----------= -- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/input/touchscreen/goodix_berlin_core.c b/drivers/input= /touchscreen/goodix_berlin_core.c index e273fb8edc6b92bcbad0fd35223a841d7da7d671..7f8cfdd106fae03a6b197582bca= 4eb61f80182c6 100644 --- a/drivers/input/touchscreen/goodix_berlin_core.c +++ b/drivers/input/touchscreen/goodix_berlin_core.c @@ -165,7 +165,7 @@ struct goodix_berlin_core { struct device *dev; struct regmap *regmap; struct regulator *avdd; - struct regulator *iovdd; + struct regulator *vddio; struct gpio_desc *reset_gpio; struct touchscreen_properties props; struct goodix_berlin_fw_version fw_version; @@ -248,19 +248,19 @@ static int goodix_berlin_power_on(struct goodix_berli= n_core *cd) { int error; =20 - error =3D regulator_enable(cd->iovdd); + error =3D regulator_enable(cd->vddio); if (error) { - dev_err(cd->dev, "Failed to enable iovdd: %d\n", error); + dev_err(cd->dev, "Failed to enable vddio: %d\n", error); return error; } =20 - /* Vendor waits 3ms for IOVDD to settle */ + /* Vendor waits 3ms for VDDIO to settle */ usleep_range(3000, 3100); =20 error =3D regulator_enable(cd->avdd); if (error) { dev_err(cd->dev, "Failed to enable avdd: %d\n", error); - goto err_iovdd_disable; + goto err_vddio_disable; } =20 /* Vendor waits 15ms for AVDD to settle */ @@ -283,8 +283,8 @@ static int goodix_berlin_power_on(struct goodix_berlin_= core *cd) err_dev_reset: gpiod_set_value_cansleep(cd->reset_gpio, 1); regulator_disable(cd->avdd); -err_iovdd_disable: - regulator_disable(cd->iovdd); +err_vddio_disable: + regulator_disable(cd->vddio); return error; } =20 @@ -292,7 +292,7 @@ static void goodix_berlin_power_off(struct goodix_berli= n_core *cd) { gpiod_set_value_cansleep(cd->reset_gpio, 1); regulator_disable(cd->avdd); - regulator_disable(cd->iovdd); + regulator_disable(cd->vddio); } =20 static int goodix_berlin_read_version(struct goodix_berlin_core *cd) @@ -744,10 +744,10 @@ int goodix_berlin_probe(struct device *dev, int irq, = const struct input_id *id, return dev_err_probe(dev, PTR_ERR(cd->avdd), "Failed to request avdd regulator\n"); =20 - cd->iovdd =3D devm_regulator_get(dev, "iovdd"); - if (IS_ERR(cd->iovdd)) - return dev_err_probe(dev, PTR_ERR(cd->iovdd), - "Failed to request iovdd regulator\n"); + cd->vddio =3D devm_regulator_get(dev, "vddio"); + if (IS_ERR(cd->vddio)) + return dev_err_probe(dev, PTR_ERR(cd->vddio), + "Failed to request vddio regulator\n"); =20 error =3D goodix_berlin_power_on(cd); if (error) { --=20 2.47.1