From nobody Fri Feb 13 00:21:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A3A1A8408; Fri, 3 Jan 2025 06:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735887477; cv=none; b=ChlLRwjYluOlMvZiS5GxLl1UxFillmnValAJtgR1gpzmgYJNC5nlSDaIC+kJbylorsBfNFnqQScz62Dw/MyugiXwD4AI04Qx8G4lsMvJBQdkc4JP1/93oUCT5oN2GGWOUG1z4EGwPWCURbaDp0F01at5d1ZxYpy1v+5hRJvFxyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735887477; c=relaxed/simple; bh=xWOtZd9QNed85o0Q6wN7kE8LjYnQhkgBxc8B5iUR7zE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HwOZLzoiK4UucraEc80vnp0Zuikn7USQBzMJtQCrC1qMcJGmZUTjBoLJVUazPGmo180AgXixdYdbwn3rnLkfc9yKkI2tECoeOWhqsa1dTgqqNW8c6MVZmR8WR97+HqgsYX+py8dE0TXYYdXgubQme3WYvadyx8qpLIpje014iy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rxj1M3TF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rxj1M3TF" Received: by smtp.kernel.org (Postfix) with ESMTPS id B7DA6C4AF09; Fri, 3 Jan 2025 06:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735887476; bh=xWOtZd9QNed85o0Q6wN7kE8LjYnQhkgBxc8B5iUR7zE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=rxj1M3TFW/HtU9pYGfaQNNMR7TvIqcGS/pDd1EnFKL0G6CtWtFTqmZa+ZFIlBz7qh 4MbYf38DWWH1NmdFT46mMaunpxRCyJW1uXeB+H/wSEEm+lSVnKd+2iopjQPfyf6qBg uVdqQ69cQuWu5Uw980sg/xrUAIOyVMtOZB0JkjhiaRssO+AWaxzRbLL12Zi8HjCKIU Im+m2WfG4MzcOdO9ALJMZWAmAOKOkwCmH5e927EWxRUh4r4XkiUHcRjsI23HTCheLR QXl+ta2R9bLWkYctCspKUugZtyPGh8lgzohtTxE90Ig3ubxiDZnG91lsQt4GwZqseR Fj3mGoVhpdgVQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9379E77199; Fri, 3 Jan 2025 06:57:56 +0000 (UTC) From: PavithraUdayakumar-adi via B4 Relay Date: Fri, 03 Jan 2025 12:34:20 +0530 Subject: [PATCH v2 2/2] rtc:max31335: Add driver support for max31331 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250103-add_support_max31331_fix-v1-2-8ff3c7a81734@analog.com> References: <20250103-add_support_max31331_fix-v1-0-8ff3c7a81734@analog.com> In-Reply-To: <20250103-add_support_max31331_fix-v1-0-8ff3c7a81734@analog.com> To: Antoniu Miclaus , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jean Delvare , Guenter Roeck Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, PavithraUdayakumar-adi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1735887863; l=13847; i=pavithra.u@analog.com; s=20241220; h=from:subject:message-id; bh=b2Mzq2Y2EVY3JTaupuR0OEbiymE8ZzYUzKSjR7z+4r4=; b=REE/piPRG8L8WCNV6GehVpfGZ9A1YtWfBP9PHt+lFwoRACY9oK0VtKSRAEjnfHwTRrW4QD1IN 2q0fSq8ugIKDXsAd7glByoRR4p4YA6r1AOQ3ybDB5HnYNxnDPXWFV43 X-Developer-Key: i=pavithra.u@analog.com; a=ed25519; pk=RIhZrdpg71GEnmwm1eNn95TYUMDJOKVsFd37Fv8xf1U= X-Endpoint-Received: by B4 Relay for pavithra.u@analog.com/20241220 with auth_id=303 X-Original-From: PavithraUdayakumar-adi Reply-To: pavithra.u@analog.com From: PavithraUdayakumar-adi Add driver support for max31331 RTC chip. Signed-off-by: PavithraUdayakumar-adi --- drivers/rtc/rtc-max31335.c | 182 ++++++++++++++++++++++++++++++++---------= ---- 1 file changed, 131 insertions(+), 51 deletions(-) diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c index 3fbcf5f6b92ffd4581e9c4dbc87ec848867522dc..f2c094686b5a89aee8041f3f563= bb2cf9fc6275b 100644 --- a/drivers/rtc/rtc-max31335.c +++ b/drivers/rtc/rtc-max31335.c @@ -34,7 +34,7 @@ #define MAX31335_RTC_CONFIG2 0x06 #define MAX31335_TIMESTAMP_CONFIG 0x07 #define MAX31335_TIMER_CONFIG 0x08 -#define MAX31335_SECONDS_1_128 0x09 +#define MAX31335_SECONDS_1_128 0x09 #define MAX31335_SECONDS 0x0A #define MAX31335_MINUTES 0x0B #define MAX31335_HOURS 0x0C @@ -45,7 +45,7 @@ #define MAX31335_ALM1_SEC 0x11 #define MAX31335_ALM1_MIN 0x12 #define MAX31335_ALM1_HRS 0x13 -#define MAX31335_ALM1_DAY_DATE 0x14 +#define MAX31335_ALM1_DAY_DATE 0x14 #define MAX31335_ALM1_MON 0x15 #define MAX31335_ALM1_YEAR 0x16 #define MAX31335_ALM2_MIN 0x17 @@ -184,31 +184,88 @@ #define MAX31335_RAM_SIZE 32 #define MAX31335_TIME_SIZE 0x07 =20 +/* MAX31331 Register Map */ +#define MAX31331_RTC_CONFIG2 0x04 + #define clk_hw_to_max31335(_hw) container_of(_hw, struct max31335_data, cl= kout) =20 +/* Supported Maxim RTC */ +enum max_rtc_ids { + ID_MAX31331, + ID_MAX31335, + MAX_RTC_ID_NR +}; + +struct chip_desc { + u8 sec_reg; + u8 alarm1_sec_reg; + + u8 int_en_reg; + u8 int_status_reg; + + u8 ram_reg; + u8 ram_size; + + u8 temp_reg; + + u8 trickle_reg; + + u8 clkout_reg; +}; + struct max31335_data { + enum max_rtc_ids id; struct regmap *regmap; struct rtc_device *rtc; struct clk_hw clkout; + struct clk *clkin; + const struct chip_desc *chip; + int irq; }; =20 static const int max31335_clkout_freq[] =3D { 1, 64, 1024, 32768 }; =20 +static const struct chip_desc chip[MAX_RTC_ID_NR] =3D { + [ID_MAX31331] =3D { + .int_en_reg =3D 0x01, + .int_status_reg =3D 0x00, + .sec_reg =3D 0x08, + .alarm1_sec_reg =3D 0x0F, + .ram_reg =3D 0x20, + .ram_size =3D 32, + .trickle_reg =3D 0x1B, + .clkout_reg =3D 0x04, + }, + [ID_MAX31335] =3D { + .int_en_reg =3D 0x01, + .int_status_reg =3D 0x00, + .sec_reg =3D 0x0A, + .alarm1_sec_reg =3D 0x11, + .ram_reg =3D 0x40, + .ram_size =3D 32, + .temp_reg =3D 0x35, + .trickle_reg =3D 0x1D, + .clkout_reg =3D 0x06, + }, +}; + static const u16 max31335_trickle_resistors[] =3D {3000, 6000, 11000}; =20 static bool max31335_volatile_reg(struct device *dev, unsigned int reg) { + struct max31335_data *max31335 =3D dev_get_drvdata(dev); + const struct chip_desc *chip =3D max31335->chip; + /* time keeping registers */ - if (reg >=3D MAX31335_SECONDS && - reg < MAX31335_SECONDS + MAX31335_TIME_SIZE) + if (reg >=3D chip->sec_reg && reg < chip->sec_reg + MAX31335_TIME_SIZE) return true; =20 /* interrupt status register */ - if (reg =3D=3D MAX31335_STATUS1) + if (reg =3D=3D chip->int_status_reg) return true; =20 - /* temperature registers */ - if (reg =3D=3D MAX31335_TEMP_DATA_MSB || reg =3D=3D MAX31335_TEMP_DATA_LS= B) + /* temperature registers if valid*/ + if (chip->temp_reg && (reg =3D=3D chip->temp_reg || reg =3D=3D chip->temp= _reg + 1)) return true; =20 return false; @@ -227,7 +284,7 @@ static int max31335_read_time(struct device *dev, struc= t rtc_time *tm) u8 date[7]; int ret; =20 - ret =3D regmap_bulk_read(max31335->regmap, MAX31335_SECONDS, date, + ret =3D regmap_bulk_read(max31335->regmap, max31335->chip->sec_reg, date, sizeof(date)); if (ret) return ret; @@ -262,7 +319,7 @@ static int max31335_set_time(struct device *dev, struct= rtc_time *tm) if (tm->tm_year >=3D 200) date[5] |=3D FIELD_PREP(MAX31335_MONTH_CENTURY, 1); =20 - return regmap_bulk_write(max31335->regmap, MAX31335_SECONDS, date, + return regmap_bulk_write(max31335->regmap, max31335->chip->sec_reg, date, sizeof(date)); } =20 @@ -273,7 +330,7 @@ static int max31335_read_alarm(struct device *dev, stru= ct rtc_wkalrm *alrm) struct rtc_time time; u8 regs[6]; =20 - ret =3D regmap_bulk_read(max31335->regmap, MAX31335_ALM1_SEC, regs, + ret =3D regmap_bulk_read(max31335->regmap, max31335->chip->alarm1_sec_reg= , regs, sizeof(regs)); if (ret) return ret; @@ -292,11 +349,11 @@ static int max31335_read_alarm(struct device *dev, st= ruct rtc_wkalrm *alrm) if (time.tm_year >=3D 200) alrm->time.tm_year +=3D 100; =20 - ret =3D regmap_read(max31335->regmap, MAX31335_INT_EN1, &ctrl); + ret =3D regmap_read(max31335->regmap, max31335->chip->int_en_reg, &ctrl); if (ret) return ret; =20 - ret =3D regmap_read(max31335->regmap, MAX31335_STATUS1, &status); + ret =3D regmap_read(max31335->regmap, max31335->chip->int_status_reg, &st= atus); if (ret) return ret; =20 @@ -320,18 +377,18 @@ static int max31335_set_alarm(struct device *dev, str= uct rtc_wkalrm *alrm) regs[4] =3D bin2bcd(alrm->time.tm_mon + 1); regs[5] =3D bin2bcd(alrm->time.tm_year % 100); =20 - ret =3D regmap_bulk_write(max31335->regmap, MAX31335_ALM1_SEC, + ret =3D regmap_bulk_write(max31335->regmap, max31335->chip->alarm1_sec_re= g, regs, sizeof(regs)); if (ret) return ret; =20 reg =3D FIELD_PREP(MAX31335_INT_EN1_A1IE, alrm->enabled); - ret =3D regmap_update_bits(max31335->regmap, MAX31335_INT_EN1, + ret =3D regmap_update_bits(max31335->regmap, max31335->chip->int_en_reg, MAX31335_INT_EN1_A1IE, reg); if (ret) return ret; =20 - ret =3D regmap_update_bits(max31335->regmap, MAX31335_STATUS1, + ret =3D regmap_update_bits(max31335->regmap, max31335->chip->int_status_r= eg, MAX31335_STATUS1_A1F, 0); =20 return 0; @@ -341,23 +398,33 @@ static int max31335_alarm_irq_enable(struct device *d= ev, unsigned int enabled) { struct max31335_data *max31335 =3D dev_get_drvdata(dev); =20 - return regmap_update_bits(max31335->regmap, MAX31335_INT_EN1, + return regmap_update_bits(max31335->regmap, max31335->chip->int_en_reg, MAX31335_INT_EN1_A1IE, enabled); } =20 static irqreturn_t max31335_handle_irq(int irq, void *dev_id) { struct max31335_data *max31335 =3D dev_id; - bool status; - int ret; + struct mutex *lock =3D &max31335->rtc->ops_lock; + int ret, status; + + mutex_lock(lock); =20 - ret =3D regmap_update_bits_check(max31335->regmap, MAX31335_STATUS1, - MAX31335_STATUS1_A1F, 0, &status); + ret =3D regmap_read(max31335->regmap, max31335->chip->int_status_reg, &st= atus); if (ret) - return IRQ_HANDLED; + goto exit; + + if (FIELD_GET(MAX31335_STATUS1_A1F, status)) { + ret =3D regmap_update_bits(max31335->regmap, max31335->chip->int_status_= reg, + MAX31335_STATUS1_A1F, 0); + if (ret) + goto exit; =20 - if (status) rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF); + } + +exit: + mutex_unlock(lock); =20 return IRQ_HANDLED; } @@ -404,7 +471,7 @@ static int max31335_trickle_charger_setup(struct device= *dev, =20 i =3D i + trickle_cfg; =20 - return regmap_write(max31335->regmap, MAX31335_TRICKLE_REG, + return regmap_write(max31335->regmap, max31335->chip->trickle_reg, FIELD_PREP(MAX31335_TRICKLE_REG_TRICKLE, i) | FIELD_PREP(MAX31335_TRICKLE_REG_EN_TRICKLE, chargeable)); @@ -418,7 +485,7 @@ static unsigned long max31335_clkout_recalc_rate(struct= clk_hw *hw, unsigned int reg; int ret; =20 - ret =3D regmap_read(max31335->regmap, MAX31335_RTC_CONFIG2, ®); + ret =3D regmap_read(max31335->regmap, max31335->chip->clkout_reg, ®); if (ret) return 0; =20 @@ -444,28 +511,31 @@ static int max31335_clkout_set_rate(struct clk_hw *hw= , unsigned long rate, struct max31335_data *max31335 =3D clk_hw_to_max31335(hw); unsigned int freq_mask; int index; + int ret; =20 index =3D find_closest(rate, max31335_clkout_freq, ARRAY_SIZE(max31335_clkout_freq)); freq_mask =3D __roundup_pow_of_two(ARRAY_SIZE(max31335_clkout_freq)) - 1; =20 - return regmap_update_bits(max31335->regmap, MAX31335_RTC_CONFIG2, - freq_mask, index); + ret =3D regmap_update_bits(max31335->regmap, max31335->chip->clkout_reg, + freq_mask, index); + + return ret; } =20 static int max31335_clkout_enable(struct clk_hw *hw) { struct max31335_data *max31335 =3D clk_hw_to_max31335(hw); =20 - return regmap_set_bits(max31335->regmap, MAX31335_RTC_CONFIG2, - MAX31335_RTC_CONFIG2_ENCLKO); + return regmap_set_bits(max31335->regmap, max31335->chip->clkout_reg, + MAX31335_RTC_CONFIG2_ENCLKO); } =20 static void max31335_clkout_disable(struct clk_hw *hw) { struct max31335_data *max31335 =3D clk_hw_to_max31335(hw); =20 - regmap_clear_bits(max31335->regmap, MAX31335_RTC_CONFIG2, + regmap_clear_bits(max31335->regmap, max31335->chip->clkout_reg, MAX31335_RTC_CONFIG2_ENCLKO); } =20 @@ -475,7 +545,7 @@ static int max31335_clkout_is_enabled(struct clk_hw *hw) unsigned int reg; int ret; =20 - ret =3D regmap_read(max31335->regmap, MAX31335_RTC_CONFIG2, ®); + ret =3D regmap_read(max31335->regmap, max31335->chip->clkout_reg, ®); if (ret) return ret; =20 @@ -500,7 +570,7 @@ static int max31335_nvmem_reg_read(void *priv, unsigned= int offset, void *val, size_t bytes) { struct max31335_data *max31335 =3D priv; - unsigned int reg =3D MAX31335_TS0_SEC_1_128 + offset; + unsigned int reg =3D max31335->chip->ram_reg + offset; =20 return regmap_bulk_read(max31335->regmap, reg, val, bytes); } @@ -509,7 +579,7 @@ static int max31335_nvmem_reg_write(void *priv, unsigne= d int offset, void *val, size_t bytes) { struct max31335_data *max31335 =3D priv; - unsigned int reg =3D MAX31335_TS0_SEC_1_128 + offset; + unsigned int reg =3D max31335->chip->ram_reg + offset; =20 return regmap_bulk_write(max31335->regmap, reg, val, bytes); } @@ -533,7 +603,7 @@ static int max31335_read_temp(struct device *dev, enum = hwmon_sensor_types type, if (type !=3D hwmon_temp || attr !=3D hwmon_temp_input) return -EOPNOTSUPP; =20 - ret =3D regmap_bulk_read(max31335->regmap, MAX31335_TEMP_DATA_MSB, + ret =3D regmap_bulk_read(max31335->regmap, max31335->chip->temp_reg, reg, 2); if (ret) return ret; @@ -576,9 +646,10 @@ static int max31335_clkout_register(struct device *dev) struct max31335_data *max31335 =3D dev_get_drvdata(dev); int ret; =20 - if (!device_property_present(dev, "#clock-cells")) - return regmap_clear_bits(max31335->regmap, MAX31335_RTC_CONFIG2, - MAX31335_RTC_CONFIG2_ENCLKO); + if (!device_property_present(dev, "#clock-cells")) { + regmap_clear_bits(max31335->regmap, max31335->chip->clkout_reg, + MAX31335_RTC_CONFIG2_ENCLKO); + } =20 max31335->clkout.init =3D &max31335_clk_init; =20 @@ -599,12 +670,14 @@ static int max31335_clkout_register(struct device *de= v) return 0; } =20 +/* 6.1 probe() function still uses the second struct i2c_device_id argumen= t */ static int max31335_probe(struct i2c_client *client) { struct max31335_data *max31335; #if IS_REACHABLE(HWMON) struct device *hwmon; #endif + const struct chip_desc *match; int ret; =20 max31335 =3D devm_kzalloc(&client->dev, sizeof(*max31335), GFP_KERNEL); @@ -616,7 +689,11 @@ static int max31335_probe(struct i2c_client *client) return PTR_ERR(max31335->regmap); =20 i2c_set_clientdata(client, max31335); - + match =3D i2c_get_match_data(client); + if (!match) + return -ENODEV; + max31335->chip =3D match; + max31335->id =3D max31335->chip - chip; max31335->rtc =3D devm_rtc_allocate_device(&client->dev); if (IS_ERR(max31335->rtc)) return PTR_ERR(max31335->rtc); @@ -639,6 +716,8 @@ static int max31335_probe(struct i2c_client *client) dev_warn(&client->dev, "unable to request IRQ, alarm max31335 disabled\n"); client->irq =3D 0; + } else { + max31335->irq =3D client->irq; } } =20 @@ -648,19 +727,17 @@ static int max31335_probe(struct i2c_client *client) max31335_nvmem_cfg.priv =3D max31335; ret =3D devm_rtc_nvmem_register(max31335->rtc, &max31335_nvmem_cfg); if (ret) - return dev_err_probe(&client->dev, ret, - "cannot register rtc nvmem\n"); + return dev_err_probe(&client->dev, ret, "cannot register rtc nvmem\n"); =20 #if IS_REACHABLE(HWMON) - hwmon =3D devm_hwmon_device_register_with_info(&client->dev, client->name, - max31335, - &max31335_chip_info, - NULL); - if (IS_ERR(hwmon)) - return dev_err_probe(&client->dev, PTR_ERR(hwmon), - "cannot register hwmon device\n"); + if (max31335->chip->temp_reg) { + hwmon =3D devm_hwmon_device_register_with_info(&client->dev, client->nam= e, max31335, + &max31335_chip_info, NULL); + if (IS_ERR(hwmon)) + return dev_err_probe(&client->dev, PTR_ERR(hwmon), + "cannot register hwmon device\n"); + } #endif - ret =3D max31335_trickle_charger_setup(&client->dev, max31335); if (ret) return ret; @@ -669,15 +746,17 @@ static int max31335_probe(struct i2c_client *client) } =20 static const struct i2c_device_id max31335_id[] =3D { - { "max31335" }, - { } + { "max31331", (kernel_ulong_t)&chip[ID_MAX31331] }, + { "max31335", (kernel_ulong_t)&chip[ID_MAX31335] }, + {} }; =20 MODULE_DEVICE_TABLE(i2c, max31335_id); =20 static const struct of_device_id max31335_of_match[] =3D { - { .compatible =3D "adi,max31335" }, - { } + { .compatible =3D "adi,max31331", .data =3D &chip[ID_MAX31331] }, + { .compatible =3D "adi,max31335", .data =3D &chip[ID_MAX31335] }, + {} }; =20 MODULE_DEVICE_TABLE(of, max31335_of_match); @@ -693,5 +772,6 @@ static struct i2c_driver max31335_driver =3D { module_i2c_driver(max31335_driver); =20 MODULE_AUTHOR("Antoniu Miclaus "); +MODULE_AUTHOR("Saket Kumar Purwar "); MODULE_DESCRIPTION("MAX31335 RTC driver"); MODULE_LICENSE("GPL"); --=20 2.25.1