From nobody Thu Dec 18 00:09:52 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C29A194AE8 for ; Thu, 2 Jan 2025 12:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735820137; cv=none; b=nVv1cym5E26SRu4ScnsCkRFY3GxI/DC+mN1vMXb7pM1KjfyhRzcx2B8T9mCVS4pdbu8Fz1uKbRf/gByE5RkVaKKePj1pA9Lofw0U8adrFiEoy+mIp25RToearxnqlwIV4Gdq+Kxg1jKHSpsjUV0YesWrNIHTDIH/GhyAFRlwa3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735820137; c=relaxed/simple; bh=DXQ2A41Ak0f8c/Srx/US/xMIqRF+hrTTRWNqwbb/UY0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AkT/mAmuluareoM096X9IuSrntKqKSKnfUCtgdNjyK7oC50jYfXUw7i65holSffgDsOoynIepUclJWPCkJl+sBc7rJSwcwT7u3pVmWlTrzB0XCIgQw7AK32G9kt9VgUhsG1SmlNrQjx1TbKEe5zsu1YDRVBmt4vxcXmykZ/i90c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=DOjzHNj3; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="DOjzHNj3" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3862d6d5765so6679768f8f.3 for ; Thu, 02 Jan 2025 04:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1735820133; x=1736424933; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=49Zbfez2Uv+GwEi9/KdRDU2/n1SiCvCfPSvq3xfobnQ=; b=DOjzHNj3pXuc5qguM8G1DfSHc1qrwHMe8r2yB3hPjLv3MS3UW+Z9CiERhCTHWxOkCs 1djDjLtnEA9G0IpBsnF/ltuPT+bRIXaU/0jUH58ys6AWbbbEFhbxoKnSd7WeoKzQVZM+ jSAl7fMH5+ysJyMoSO1R9um+NdvSq91J7oXOWVvzSueYV4GLSenri959pZnRnrKnAgD4 8dVGdKhDMQEvWys8gpRGgb7XBGn5rzfJtUEK4ae6Th/r5ApZAtmV0VpD/o7+ua8ej3Z7 5bEOKCi/ajdVQHx4th2G863Cx2cCGKoWv+bDLT6Mh4CTBbRAF1GiW3nf9BydIFSURAyW JIlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735820133; x=1736424933; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=49Zbfez2Uv+GwEi9/KdRDU2/n1SiCvCfPSvq3xfobnQ=; b=t40iakIoU4gfe1ok9qE0m6shIbmTthPYUYyLYM+HYQ2r1HAxkB9GSyjUHHT/ro0tkk ZP7mqAisZfRa2RImzcS67EMYG5Fg2AN434JjdyUF+Dzn6g0srh849T2iGQnt32c97AaY cVrVczZuLZwVTVCO2VJ04dzrES2f08vqF7ALPyhSpYw8xwLu3etxkd4CHgXTxX/LHFXe Hrs8AsX+PjrKLwOc9rOb4L7vsEY962rNwn4XcZQGUYc71z7+3hK9/bN52dd37p9HJ8RG F60cdF0Vx0DoJsq2D16W35OtUuNt57B+W2whfQb1faerO35RmRILIfc+6ZiKxxBftRBb id+A== X-Forwarded-Encrypted: i=1; AJvYcCWnfr69J/D7Wt9z+KV+Ubtz9Epb/BSq90xwnsU6AGb2Z6e+GoXpIHpOUA0uZEfgwG6TcVJJS6LkQ/gBdn4=@vger.kernel.org X-Gm-Message-State: AOJu0YwllCYw1sMn82tQIWW/AF7MT9oQYQ9BjkeryxL424pO/rSjaokz WQuoBSrXF4zz5PPd07MWhmAFWqMyQ3EjHZBpqGyXwjlcIpHZGxV+YtDjqQNV8pU= X-Gm-Gg: ASbGncuNEZi7YqIWe2I1A8qMpFAtmmMrWcLYlvZwGRBRjNPUz4ePU1N/XeyGpYcaODh BSWJuQdILw6JM0PhgUNOtpNuZvoJ3yJEm8yCyXpXkSF4coBvvdtEJbK7sLAPmq40DHSDN+i0nm7 WiIoJM6khucXjsplEGWZeFfGFj6AgH0pX3AAx4HL+BQ/+hFk8G7bOkb3umZaQmigPSe19hWmRTq AyULTR4nJ/Tcxf2ah+aLGMmht3TWqY/BPK0vaLZw0dgq4RbJTl5oN8k X-Google-Smtp-Source: AGHT+IEQcymUaT5z7OHfgOJIsMrGBipMq4M5GLXMYW2IFgD9r2VMIYMv0E5DtI+X27G8zzsAsvqv/w== X-Received: by 2002:a05:6000:1fac:b0:385:eecb:6f02 with SMTP id ffacd0b85a97d-38a2220045bmr34868448f8f.28.1735820133226; Thu, 02 Jan 2025 04:15:33 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:427d:f084:4f4e:ff78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c832e74sm37475445f8f.30.2025.01.02.04.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 04:15:32 -0800 (PST) From: Bartosz Golaszewski To: Manivannan Sadhasivam , Stephan Gerhold Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2] power: sequencing: qcom-wcn: explain why we need the WLAN_EN GPIO hack Date: Thu, 2 Jan 2025 13:15:30 +0100 Message-ID: <20250102121530.26993-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Bartosz Golaszewski With the recent rework of the PCI power control code, the workaround for the wlan-enable GPIO - where we don't set a default (low) state in the power sequencing driver, but instead request the pin as-is - should no longer be needed but some platforms still fail to probe the WLAN controller. This is caused by the Qcom PCIe controller and needs a workaround in the controller driver so add a FIXME to eventually remove the hack from this driver once this is done. Signed-off-by: Bartosz Golaszewski --- Changes in v2: - reword the FIXME comment as advised by Manivannan drivers/power/sequencing/pwrseq-qcom-wcn.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/seq= uencing/pwrseq-qcom-wcn.c index cc03b5aaa8f2..e8f5030f2639 100644 --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c @@ -396,6 +396,13 @@ static int pwrseq_qcom_wcn_probe(struct platform_devic= e *pdev) return dev_err_probe(dev, PTR_ERR(ctx->bt_gpio), "Failed to get the Bluetooth enable GPIO\n"); =20 + /* + * FIXME: This should actually be GPIOD_OUT_LOW, but doing so would + * cause the WLAN power to be toggled, resulting in PCIe link down. + * Since the PCIe controller driver is not handling link down currently, + * the device becomes unusable. So we need to keep this workaround until + * the link down handling is implemented in the controller driver. + */ ctx->wlan_gpio =3D devm_gpiod_get_optional(dev, "wlan-enable", GPIOD_ASIS); if (IS_ERR(ctx->wlan_gpio)) --=20 2.45.2