From nobody Wed Feb 11 02:06:24 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CC372942A for ; Wed, 1 Jan 2025 16:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735750481; cv=none; b=dybQ5HZUF6pJuMHGADcuN7F4mG2Fkd1kgE9pWBpzCabMxungonWPGMF5wqKnRc6G95AVlQMTD52PLfhfvbyI+hWZD9Ex3h31CHySvYI7K3aUNh88bjb/+2cI9nvEOPJVwIOWLUJIFen0JtqvIuD3I/q+E11HPO+nZc9A/ZLi+Dk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735750481; c=relaxed/simple; bh=+RcNmhnkEsdH6uo4r8t7ttE/smBqGVaoIpHCxe+b1WE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qlANfJdOqU2GcpfYs7Fl3btQ/4/CARytbPlVyOvVfbnau8ZKPpqtXXgHoHxtxcVoI/HPajtvfUrG4N3hHe76xgMeCwCI0ztT9yyGreMyZdoxgQ6YMftJNmF3oh3z/3I5yTbubdYoGS1V4YXlNWw3Hh+wfAchBFejvnq3Nn9S2TE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HJ4HYrlm; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HJ4HYrlm" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2164b662090so126527145ad.1 for ; Wed, 01 Jan 2025 08:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735750479; x=1736355279; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MoFjR/MKzzzRhLqHo8T1r3BXq+t5l3KwBD2b5YYL7u0=; b=HJ4HYrlm51NhlpdyMFu4eoJhWINjD12zQzhxXN5qqEkHbRoINkAT4fTvgyCB0C/Ocq sNgC0XluGebbiJIT4Qh/Auf5/q2CpY+guTJPIYHPa9SKiuZpsJAZdD5LMbCKUq+Sp9OA pyfzfRjQdakltFrWdEh0UQCoqcWOgEQDkWcRwLxKxLoNw/hcomNU+P9yGmtHznFQC8lz FTF/dUAgQX8skDeWGrnJTXNV2B/bE3JCq2Idxd8jqX9vNqr8b3P5/1H5B6KaYNUnaW6x CLeYG3FFgdq2Id0fN0mEbA+A5LWiPcQr2SURP8ELWLo+oTGZowznI7NMcfmQwDQk/LsZ Lq2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735750480; x=1736355280; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MoFjR/MKzzzRhLqHo8T1r3BXq+t5l3KwBD2b5YYL7u0=; b=i8jlgrvg5xIgg/DC0QRYZkLPhJkiAd13fdjZ2uityOh6A48EAq8lCni7LDotpCFbUb pdhM7tmgjIETWXkEHL8CkTPbbmS4obPDladUqCL9bZSL6f41gjBhQxA+YqDD+owd0zc8 8vuT9KvGK+eeUmCPPkPVfW8jPc76eNbhiIL2ZDfhUQASvN0goq4Co6Z621qWs34N1OJC cX/gwSGBaZR52eoFKHq18TyRGNwjwgWD33MC+8QuXTWS61TZuZEz9MuFCIZn4RWvQkyK Vwm36NtD7tnxRMj/5cJt7iZ9SmcDooof+HXXJBlalyC58J9mG/y9pn+vD9nZomiC14Iv 4Uag== X-Forwarded-Encrypted: i=1; AJvYcCWkxtTiWuueACyJMNFQh13UlBM9dYzRBIAh2HfZC8o2daaMaDvBZjW0YSRKY2vfxMcUS2kXtPHjp90tT3s=@vger.kernel.org X-Gm-Message-State: AOJu0YwB/gEHwMrpXFPBN5eHAGO678e1JmuV4ccX8vnLxTmrtHtU+r8u jPbj3Pv9j5vPajpz3G89Tubhb7348Mk3DnjIKYTULUSdKyl3o6i+ X-Gm-Gg: ASbGncvSjD4QM8s73xFjsBn5skc+FveHgYUHNeDgR4HjfyvTVIV5E0AMkzrGjcfRAzP 9AArJyBGfPSMAhihH1ozl9cysLOap9Qlg5gEQgOGiMr3G1fVtk+E1TwVwc+LT8uM9twc/PN/nYu dMu02vFFC5ecy6tfDdAKBmD/WA8Sf7HZ0TDrbv19p4Mg9H0kgK9EzTzxZUw2B5J6Mb4l872DGxE O3z7yeqExk2JXXwiVjHY/4lMTmdeWStrhpIqfLGLoEEgShsHspH+khMspjNyP43r2aYgDp6UXLr f/d3IR8d86pYAR81UJXmSaMPf7oTnNMHZhmKOF8UgwgheyP4NWddXTh6nQ== X-Google-Smtp-Source: AGHT+IHMUq9m7Pa+p28xL7Y4yTQxRpQMDNRKgKdqdN2X2tl1kuw5gYpAg+6O87gcnn76mRH+kM1IWg== X-Received: by 2002:a05:6a21:6da4:b0:1e0:ce11:b0ce with SMTP id adf61e73a8af0-1e5e080289emr76657066637.35.1735750479599; Wed, 01 Jan 2025 08:54:39 -0800 (PST) Received: from cosmo-ubuntu-2204.dhcpserver.bu9bmc.local (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842aba72f39sm17456536a12.5.2025.01.01.08.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jan 2025 08:54:38 -0800 (PST) From: Cosmo Chou To: minyard@acm.org, quan@os.amperecomputing.com Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, chou.cosmo@gmail.com, cosmo.chou@quantatw.com, potin.lai@quantatw.com Subject: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup Date: Thu, 2 Jan 2025 00:54:31 +0800 Message-Id: <20250101165431.2113407-1-chou.cosmo@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure the new command is not lost when complete_response() is triggered. Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") Signed-off-by: Cosmo Chou --- drivers/char/ipmi/ssif_bmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c index a14fafc583d4..7a4f52987a7d 100644 --- a/drivers/char/ipmi/ssif_bmc.c +++ b/drivers/char/ipmi/ssif_bmc.c @@ -579,7 +579,6 @@ static void process_request_part(struct ssif_bmc_ctx *s= sif_bmc) static void process_smbus_cmd(struct ssif_bmc_ctx *ssif_bmc, u8 *val) { /* SMBUS command can vary (single or multi-part) */ - ssif_bmc->part_buf.smbus_cmd =3D *val; ssif_bmc->msg_idx =3D 1; memset(&ssif_bmc->part_buf.payload[0], 0, MAX_PAYLOAD_PER_TRANSACTION); =20 @@ -596,6 +595,7 @@ static void process_smbus_cmd(struct ssif_bmc_ctx *ssif= _bmc, u8 *val) if (ssif_bmc->aborting) ssif_bmc->aborting =3D false; } + ssif_bmc->part_buf.smbus_cmd =3D *val; } =20 static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val) --=20 2.34.1