From nobody Sun Feb 8 21:27:34 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD2E919D884 for ; Mon, 30 Dec 2024 19:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585802; cv=none; b=Lh5k7+goFK442qWQQXcay6EDZ9KiUTAagJgFLumj6s/xb0njfwiVCcLjPxGUvzTdfGpANHctCB0Mdq6bMtTno12yAxynoGKGSOCy3TtV5DWYd4Zsmw9rWceExH1ovU45uaGrqdzEzakcX6TKNN3ToWt3pJ/OlcAZjXAAolP7dos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585802; c=relaxed/simple; bh=cE62QEV/KBVbpuEXEN04Haz247wnPx6ZbxQNPO1vYBI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=P0f/VmkTG2XSsyrqoL52yNm8OKfnclgfbwZQqUH8OW77sQ/Vq1ZUv68/XzEEUYPHUUozkiIuWvxYFzQ7A+rfww7wmnLZBzbjj8/CSXNacBFiToDGvuhY2WNy2bGyaPil/GQLJ9wQyJUbdWxWeQMJ+qEa+oFzBWIu33vCIEe9c6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RszxYv7T; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RszxYv7T" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-215607278acso10737045ad.1 for ; Mon, 30 Dec 2024 11:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585800; x=1736190600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yOUO9YPsefTgfIOt0AUjXALb7a4R9PKwgM8CDJeJtxk=; b=RszxYv7TE56LYZaNlAvfMnuZdSE8Ef7lfeQI9uaMwwx0vy3pV5Zfl5z5kZy/0rT80l drZ5e/nSyWIDqiTvC+fWh7JN+WxK/l9Wp8EudvgjSdWekJiBGcvtR881hpHHWGvmV73g 0qphnIqfmPF5RalITjfRYRuHyFbCJeE9U7d4WQQZhn/xLe1k5SKub/Yj2Lz/mvdPYSjm UkII/q7sWG448H7zo8nrpQnr0HTSwwru5eP2ni/pSSNIVv6DIIuyUhBA0E+luMNIvtz3 ofQozBdn/R5UHejZdg2Qs2fDQDJS3b7hDCH9dQ8kgVhmdvn7h5vTc/TcLGDDpEZ8w+zA 7r2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585800; x=1736190600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yOUO9YPsefTgfIOt0AUjXALb7a4R9PKwgM8CDJeJtxk=; b=wtMrIhKowRI1LV+u7kxbrjQa5nPFl6yBQkqS/D9PcYv3YOiaSMB6OjWK9c5MVbxZY2 BPsLUL+A0yD4LWiNrPtMLiZzhqXZDfBvg5/ikA/Qgm4YBBYU8f1wJSsAcJOyk2O+uu8Q hqhY1YyrodfJsl3+gnHNJWQJ7lJKNpS9Tod5SzWGObcnskROfu21Ny8ZTSWSN+XVx4ya nqj7dTVma3gLLQ4FyxjcM+jdu8ZxmvY10xSp+1w9SbKoFUcaPaWnGONtQDttmJuyIZjc r/3fLyc1I3HTOZq9wg0srCuAlmNqpHVHVgoMdQnU98uQ7HVWm9vw2ufkcQd5YDsE8VBh HSBA== X-Forwarded-Encrypted: i=1; AJvYcCUbeXRvocqzSeRM3NO4+fZnCwgVjznlnhJMAgpBk+BBpZXmK3CqFzElbSyqsrREut7dGIkABnuqTOmoQXU=@vger.kernel.org X-Gm-Message-State: AOJu0YxW3WeDcUAFaQARph1r5MeTI4LGiH5mW0Wc2AnhCCuSrDR3TInQ yR1PysoGaoCcYXj8d1C5C651e0fAxIOvPl2Ek5dSKwy3ZuDycCNO X-Gm-Gg: ASbGncszaUt2syz7AKwwfqEEESTP/s7KZfwxspOS9d7zRyahthsVgTkFphSfa7fSCcU F6w85XX+BgFCs+wVan4hJ/mndTg/eYvZd40JO/axupH8wydId6kKW/e6mc3R6LER0461rvFZpc8 3E3OCa2HUnUeE6eTHSdFmeWlN7JxC+icgDiUjrKG8mALd4CDPY94JdQC4sqikWcbY1szHGIgJbx DuN48/BLpbFpGI+noR+bYbbV/nyx25mP+Idd7gwkLYgJuQceQP75QE= X-Google-Smtp-Source: AGHT+IHpjjH9niowQTZF88GunjXK3G9QKnriFbYqrDJc/MYzo+JYu1+AdCCZCrxWNN09hylMh9tXzw== X-Received: by 2002:a17:902:ea05:b0:216:282d:c691 with SMTP id d9443c01a7336-219e6f1d288mr190075575ad.13.1735585800007; Mon, 30 Dec 2024 11:10:00 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:59 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 07/15] staging: gpib: fmh: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:27 +0530 Message-Id: <20241230185633.175690-8-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous platform driver, pci and gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Add pr_err() statements indicating the fail and also the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 47 ++++++++++++++++++++---- 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpi= b/fmh_gpib/fmh_gpib.c index 62791db1c34a..90108ce0304a 100644 --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c @@ -1691,23 +1691,54 @@ static int __init fmh_gpib_init_module(void) =20 result =3D platform_driver_register(&fmh_gpib_platform_driver); if (result) { - pr_err("fmh_gpib: platform_driver_register failed!\n"); + pr_err("fmh_gpib: platform_driver_register failed: error =3D %d\n", resu= lt); return result; } =20 result =3D pci_register_driver(&fmh_gpib_pci_driver); if (result) { - pr_err("fmh_gpib: pci_driver_register failed!\n"); - return result; + pr_err("fmh_gpib: pci_register_driver failed: error =3D %d\n", result); + goto err_pci_driver; + } + + result =3D gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE); + if (result) { + pr_err("fmh_gpib: gpib_register_driver failed: error =3D %d\n", result); + goto err_unaccel; + } + + result =3D gpib_register_driver(&fmh_gpib_interface, THIS_MODULE); + if (result) { + pr_err("fmh_gpib: gpib_register_driver failed: error =3D %d\n", result); + goto err_interface; } =20 - gpib_register_driver(&fmh_gpib_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE); + result =3D gpib_register_driver(&fmh_gpib_pci_unaccel_interface, THIS_MOD= ULE); + if (result) { + pr_err("fmh_gpib: gpib_register_driver failed: error =3D %d\n", result); + goto err_pci_unaccel; + } + + result =3D gpib_register_driver(&fmh_gpib_pci_interface, THIS_MODULE); + if (result) { + pr_err("fmh_gpib: gpib_register_driver failed: error =3D %d\n", result); + goto err_pci; + } =20 - pr_info("fmh_gpib\n"); return 0; + +err_pci: + gpib_unregister_driver(&fmh_gpib_pci_unaccel_interface); +err_pci_unaccel: + gpib_unregister_driver(&fmh_gpib_interface); +err_interface: + gpib_unregister_driver(&fmh_gpib_unaccel_interface); +err_unaccel: + pci_unregister_driver(&fmh_gpib_pci_driver); +err_pci_driver: + platform_driver_unregister(&fmh_gpib_platform_driver); + + return result; } =20 static void __exit fmh_gpib_exit_module(void) --=20 2.34.1