From nobody Mon Feb 9 08:34:15 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A16519D08F for ; Mon, 30 Dec 2024 19:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585799; cv=none; b=nNfqheil+YIyP5h++hNf6GIAjpBzDmcak5yXx8reYvzcO9aIKx937J8gtS5kkYiZz2hKM8cYqtJt8+q+1ukKA9+JxhBEKgWlhkGubUIj29nVVJG60CtcJlzIqrc0QzlXQ9T2wQ3Vu2rws3+dqEkFq3hiX406ciyRdzBfQN+sKw4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585799; c=relaxed/simple; bh=U0LR+ju8rwEbUYvjjB6dvQR6mgJyl8PNHTJ4E1BXUaA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eYnKf/FPanGlHlmqQP925d6h2HtCzr1sBbZng5Kn3WY4PAbhJdIhCDxWwQaT1iU3T02nCW2RA2ZeP0y9tKtSyPdtRk6RffCVQwK/0bBTVKTOddxCI17Hxk1E3s82ufXvOmTpSeOdrgCJGK2ffmzNermsZPvQMAkbWOCxE9D13to= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TlVphKJA; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TlVphKJA" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21634417587so14138255ad.3 for ; Mon, 30 Dec 2024 11:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585797; x=1736190597; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+zv7i60pcLCEcQ9vMbRN2C0yUlcmBpSBVzEJlgDdTbc=; b=TlVphKJADllQwLuPb5tS3FbrjOWN7tM0UoLNNjg9fsrhIhNOHTV69gzw1fYu25WF2z LkWhFGvAmIv781vHGk5xAo/n8/TvoRoaYF7efz0P8z7iE5PrgjBNBATT4xLyRVLkKCnM DzDTZqQY9M02jfJ5kxah5zUdddUI1NBNNsqBjIqjehtnFmhEHY7VG6wU8DHWgBhZBguQ 9619+JNFkqD8tyIVBLvSX/CVdA4Fwxxcgx0vevsIXEIrdPIhq0VnjygxhQ593YE4oDoQ GLkWH48SdHAU0Z2nPXkdAeyTrgqMFuFumyTQS6O4trScqG0l5cMrmHATWgHfbpn5qTOL Zz4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585797; x=1736190597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+zv7i60pcLCEcQ9vMbRN2C0yUlcmBpSBVzEJlgDdTbc=; b=MJ7YzH/dtXzgf786RahzF4Y4ZKuVsrcA6wZAbWUVQfCkf9guYNCcxrneVT/SEaauQ1 0MCWNsylK7ack1KlfBxNcl+5m1o1oVzLlNOB/oKKyNiQSVKsJagCthNzFkduV8M/r8dD +QnsOToQFs7GhDHWuVcdJgFDVy+9On+759aLzlyeQuV2jacsYpNssywZXKWp3jkSta9L y6gV4YXgLeK00CKiKTuTLjzNDuI98jv9O+dRU2V3LAv2ZsulfOcSD2Gm62BfNa2kOF9R 2LOvX/IBAHXz4MFzT18kkFhEdRdbZZRx9z0BJmOqbOcDTlDdoIr49oY+B1DPRM8YPkH3 c7bg== X-Forwarded-Encrypted: i=1; AJvYcCVXv6QuZX2RKDW6SjWAj7K6Nn/DdfFpgULGjS1gggWnIKbm3WQUy8Ti3YwxdhwDJNtJ/38iFUc+wpnfTeE=@vger.kernel.org X-Gm-Message-State: AOJu0YxcHyd1Crvtvo5uPdCP6RcSdkFBKvxW4/03i8Ve8br+VoVGsQsS s9kbWSZIYdf5R0EnF74Q0YH/GjD4E8Wt8m6B4I8Xc/xe/HrQsDok X-Gm-Gg: ASbGncup/wLcTU+1yU+aPkh70ogVF769cMc88d4lvOyfY/ej2QF3hvCeBDC5FRC3tyR p9r7YIZkfwIMZAstKnrwI9AM9usS1io1a6J46OsB9qZM62jPYSHJBH5132W1e8SwhkRppJibcgi qdrMBWQu3KG0pWggi32xlsbd0ixaeJYO3no9GA9B05wRizs/OqMjB/KALtrin995NYtLUrpsGgN 4JZBV3JaLRuQsZB4QK5fs76Z1NN2q1ea8pGFqMrpNhUeW3aVgr3Fss= X-Google-Smtp-Source: AGHT+IESURIwhmTQzoLDKjU6WGUghIO19RfXoTDwFuDIcqeb8wizB7GqrbdJmywOf0ZpuK58FeSNZg== X-Received: by 2002:a17:902:ebc2:b0:215:9137:32f8 with SMTP id d9443c01a7336-219e6f27555mr190945685ad.15.1735585797408; Mon, 30 Dec 2024 11:09:57 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:57 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 06/15] staging: gpib: fluke: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:26 +0530 Message-Id: <20241230185633.175690-7-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous platform driver and gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Add pr_err() statements indicating the fail and the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/eastwood/fluke_gpib.c | 32 ++++++++++++++++++---- 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/g= pib/eastwood/fluke_gpib.c index 3f938ab0c84d..875b3adcb584 100644 --- a/drivers/staging/gpib/eastwood/fluke_gpib.c +++ b/drivers/staging/gpib/eastwood/fluke_gpib.c @@ -1155,16 +1155,38 @@ static int __init fluke_init_module(void) =20 result =3D platform_driver_register(&fluke_gpib_platform_driver); if (result) { - pr_err("fluke_gpib: platform_driver_register failed!\n"); + pr_err("fluke_gpib: platform_driver_register failed: error =3D %d\n", re= sult); return result; } =20 - gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE); - gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE); - gpib_register_driver(&fluke_interface, THIS_MODULE); + result =3D gpib_register_driver(&fluke_unaccel_interface, THIS_MODULE); + if (result) { + pr_err("fluke_gpib: gpib_register_driver failed: error =3D %d\n", result= ); + goto err_unaccel; + } + + result =3D gpib_register_driver(&fluke_hybrid_interface, THIS_MODULE); + if (result) { + pr_err("fluke_gpib: gpib_register_driver failed: error =3D %d\n", result= ); + goto err_hybrid; + } + + result =3D gpib_register_driver(&fluke_interface, THIS_MODULE); + if (result) { + pr_err("fluke_gpib: gpib_register_driver failed: error =3D %d\n", result= ); + goto err_interface; + } =20 - pr_info("fluke_gpib\n"); return 0; + +err_interface: + gpib_unregister_driver(&fluke_hybrid_interface); +err_hybrid: + gpib_unregister_driver(&fluke_unaccel_interface); +err_unaccel: + platform_driver_unregister(&fluke_gpib_platform_driver); + + return result; } =20 static void __exit fluke_exit_module(void) --=20 2.34.1