From nobody Sun Feb 8 21:27:09 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D5DE19C57C for ; Mon, 30 Dec 2024 19:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585796; cv=none; b=PRvYx6TC3X0eQZgo0NCrwWVFjHkPouYCBSXDR/yUrXeGujL0GV9zy/LNSTS9fgBygngl4GVvfCHUsX9Hh9HXEPsQ2IuFpr79Byq9npgGQtLU3MO5l6f2Xiz7Cmr5HN3CANylvluevMKHKKyPIQV2Tnw5OE9Jm82tshkWHz8jxWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585796; c=relaxed/simple; bh=+/U6TP0u4+L0ticmjRX+UP8OM1S6krGy8xWAWPiUEKE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b9RUpsfSkSNe4prMSOrpYwdOmuCgTjtsK9Q8AWRRYUbLRIf6Hn5dKeXJ6yhVx3g+gvoX9BXHuxh2iZWLS26Tr5nnt+GUmhHxD26Nq/GyWo3kOGyyv2Pp6tb0xj4zCxcPkL8X5UW02mNGENbXx5kGcOUI8vRtMjSfx2UzhAVHfcM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BifKCEMs; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BifKCEMs" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2162b5d2e1fso15350975ad.3 for ; Mon, 30 Dec 2024 11:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585795; x=1736190595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oT5isU+QbLuiUavKN59sWsElBo1xMBVRc25NaB2S0Ro=; b=BifKCEMs5p50iozoN8Dxwh+snSd+Z2xTq3eOMKLMKScrU+A8iMaVXX0Y/xHbTbUU+N hfyxDM3TYCoB05yytR/d93eC2/UjZ9y9020NG14XU+zEh1yTISq2OQ1ePU/59hL7v/h5 VspKMY2oJ2crUa7QVm8zLTDUN36C0eA+I+t3xd8iWgL1Yk2ftksFN2TdLrLcSkRmh1pA 6tuoTjmQd871Qc9As9BQ4wknZKG6E0bQcQUWFRAuIxqkgi5X894biORpF6LSjcl765xZ jlNAdEOcGTVgJKzfEijJcwzid1h1IgjtdgEGp735AaDgSDFIl00xNgrpt/KePg+5gaej xiDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585795; x=1736190595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oT5isU+QbLuiUavKN59sWsElBo1xMBVRc25NaB2S0Ro=; b=VN0yuuXufS9zXLfb6y73ICMxRPi1aOw2x8CWdIBcOfSL4sIN/pzJkRq79ETjy4P8H/ I74yXKqnFiN7Exe1uOLGjuoxrjPPr/K9kY0tmCNVQSBUNqvthq2s7YcJOC8sDctSeh3n 2iD4LhP+5r2LbLAZ9AMZ4irq9X/2Onp9aygxkY3/VYiKHSlq2T+qdqjPF8tHez9X72g8 9C2TlLI9JxAGD9VIGULIeBDYKffz2iLQ1xYW3r4576dbMQN5xltSYnv7++97J9f2/sqz fDaoQzimTr+fpDBlKaW+BlZ4X4zqNYLoVeZfmOn6KAW+YyQYRIJbbgCpBRvrjd0CM8Vq dd6Q== X-Forwarded-Encrypted: i=1; AJvYcCUTaiczm2DOdMda4FC/7KaIGtFknZ7VBzUy0KwWsFNiPJkfoYk8S6gILr4wqMfZTJJc/w/rDkZbU+YlcY8=@vger.kernel.org X-Gm-Message-State: AOJu0YzHuqd96J8FBWRh4QqrlWgheAQZvJJMFd4F7U/8sfhShmpujrZ6 SPGUkq7LtPheD6HJopkwtASOSlmB/e3wjMLm2/sG08wFMwA3dg9X X-Gm-Gg: ASbGncvEk2j157fjKq610OtlupLhlZdg5VCZujroyhdkiFreCmCASyc8NRIn4gHOwnn qpOEdGXYIOB3cypgYsrbpciM9WGI8vsb+QNyxq8CiXqQE4nwt4S2iQ2phHYGYwEXc0t20tuGIgN IhfaJ9anTzDX4LWn0A7kgb2m/rjMVzI7FHRrRw+3LLH89zFF47GWQLqgxxcl2n0kpDOmUtwzNFt vCJRlD88K70Qw5w8DRSeQpwixrpAvLsT8pCFM/NtsEvUJcv5FslYk4= X-Google-Smtp-Source: AGHT+IHY/qiDc4ESBgY9biNcH91XNLwJ0wzCiwd+E9nfO4KdooIKN/6Kym6OcqndVAqo2gvhOdyEXQ== X-Received: by 2002:a17:902:c40b:b0:216:6590:d477 with SMTP id d9443c01a7336-219e6e854c7mr199666195ad.2.1735585794810; Mon, 30 Dec 2024 11:09:54 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:54 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 05/15] staging: gpib: cec: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:25 +0530 Message-Id: <20241230185633.175690-6-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail and result in a semi-registered module and does not return an error value if it fails. Unregister the pci registering function in case gpib_register_driver() fails and return the error value. Add pr_err() statements indicating the fail and also the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/cec/cec_gpib.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec= /cec_gpib.c index 3dc933deb401..e5b0941872f5 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -365,11 +365,15 @@ static int __init cec_init_module(void) =20 result =3D pci_register_driver(&cec_pci_driver); if (result) { - pr_err("cec_gpib: pci_driver_register failed!\n"); + pr_err("cec_gpib: pci_register_driver failed: error =3D %d\n", result); return result; } =20 - gpib_register_driver(&cec_pci_interface, THIS_MODULE); + result =3D gpib_register_driver(&cec_pci_interface, THIS_MODULE); + if (result) { + pr_err("cec_gpib: gpib_register_driver failed: error =3D %d\n", result); + return result; + } =20 return 0; } --=20 2.34.1