From nobody Mon Feb 9 08:34:16 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60EF519C57C for ; Mon, 30 Dec 2024 19:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585791; cv=none; b=AQYgdeVDf/vjsMM2b+yqYCM40wUfHEq8T060swaCb8KU+7w5CyfsZCwp6uEd0WaCku44lhKDcumsULriCW1hnYEN99mbgeweUaLRumO6uPOHImoVHAqTHVh3bY23XuNK3QkU/oNc5/id3+j3tlLJIVftlmNvNb20ugKZ5p61jY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585791; c=relaxed/simple; bh=S7a8wX9Yexy2sv2AYTieFKxnvfJmcnoAKN16sspLSGg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gV7rh1AVvBzpK6Gb8XZdSI20DqP0AHgQQirslsGO7mrfuf3NKUTbWOKBJFDCbS06Fv1F603PCmP6xjQ8M3Pc5kYlM4ulJuW4u52fsifxOXDwAjdrFcRBcjc0BIG1Tt5WsRmQtzMosDT+GxYz6tDbeTdPtqe1Xp4q9ikREWYgngw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hvr6bo+5; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hvr6bo+5" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2161a4f86a3so11256575ad.1 for ; Mon, 30 Dec 2024 11:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585790; x=1736190590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eLKyEu22nnn6LeqdD3A+og9HGlmTSWryEARLiqriBEs=; b=Hvr6bo+5Yq3U+pUrtoFu0cqtJt875PZMUweqR/k7qBGXMVSn0fn0khfb04ir19NUSj NQ7fxVEaFrNn+OvVttGFg6Ed5B7FeU4XxUyd/lTsgFmyjA+6PAM6HXmEc/9qEelw9JIE Md8QhweAJHWl9+K2PNLqaajsRKnWyAtWAfTu8YLSZ2hA/lEZdjKzX+j/kENe8GjbtQ4h FEx0f9ABTVCa+VJrynWcLC8cTTUx5og283m+k5l8aQuusy8rx+UvxtAppmzRpK4BQq0w or3MzlFxyT1T5lGQyefdKPussxMiGWNYW7YTN3E1Ji8l/D7HSsX8DbpOLaRkPKvcv3n1 7+mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585790; x=1736190590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLKyEu22nnn6LeqdD3A+og9HGlmTSWryEARLiqriBEs=; b=ZLQRkDNgzwmFACRT1l167PndPclwfR0wx0xZq2UxqLW3um6ufScteEzdom4FhZ8o4D BugWwH3d9icRpNSV1xR5gG4MP/7MJoBd6vxeEnES+jN5v59akcncxlkvAZTIPf2zpMKa tF2Aw+Iu/MHBsfJBC0GdRpWd/VhaBO5Z9vb54s4RWtNC+QRl7A+Hfc7OcbQ7HluyuIZm hqa73prbwtziG/TunRVuTITLgyWBYDuCGfshZamN2OtZS2uAG1i4GvoMQ0AplmY8iiqm btsDwhw89+zXRk5TykpxHJi/Hf6ErXqP72X5MpUqi9iNhSdk8Be1sZyz3o6eEFW3oM5s motw== X-Forwarded-Encrypted: i=1; AJvYcCV7gTpcoCPuJANz3t80KcRW0laoPzlAJv1B2CUxgRYpg9hbANZRVBd1t8CaVBmODo6ACYdZcCfDviUcZk8=@vger.kernel.org X-Gm-Message-State: AOJu0YzutsA2KRcwxoSxZJ2exG2vx8sYptAn7kJKpBJjojSByTmhu5VV 28H4Nc1IKqv9L5PjkX7FSuO5HX0bZTKpR9J7hhwjGiYMTOGzmPZW X-Gm-Gg: ASbGncv6yD+SkV9T2caCFxwNvNUl7Ods8WVWo+PrZFFL6ZCXIFJXJVM9+1hT4dvRzZC YCPMnBZFwk8rYEnxKeloESsKLt+RTWywQ/zn5L9M/pJvin3oe6IzQdo0nWSwkUVXCwmrm8aC2P/ lSxkBbiQmfhj3hd8xhXgHX6IqSiCuJp4kV2OG5fMrD4I6mKjyi4P7OkdIWc4QT/T4B80bALMYBu oCu7bEKV9bOJjsXBd5VeKoos/CXxKCXxx2UYPyJnZLLe2NiTdEQPd0= X-Google-Smtp-Source: AGHT+IETBKn1g7dh/TqzXpdQ9VNn+VSziUBcWMQBOqCxTYoBaRx9cGA1TzG/PUhWcDrlHOhE7tfxHQ== X-Received: by 2002:a17:902:f644:b0:215:94ef:6071 with SMTP id d9443c01a7336-219e6f2707amr187942205ad.14.1735585789667; Mon, 30 Dec 2024 11:09:49 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:49 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 03/15] staging: gpib: agilent_82357a: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:23 +0530 Message-Id: <20241230185633.175690-4-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usb_register() function can fail and returns an error value which is not returned. The function gpib_register_driver() can also fail which can result in semi-registered module. In case gpib_register_driver() fails unregister the previous usb driver registering function. Return the error value if gpib_register_driver() or usb_register() functions fail. Add pr_err when registering driver fails also indicating the error value. Signed-off-by: Nihar Chaithanya --- .../staging/gpib/agilent_82357a/agilent_82357a.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers= /staging/gpib/agilent_82357a/agilent_82357a.c index bf05fb4a736b..261fb6d2e991 100644 --- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c @@ -1691,12 +1691,24 @@ static struct usb_driver agilent_82357a_bus_driver = =3D { static int __init agilent_82357a_init_module(void) { int i; + int ret; =20 pr_info("agilent_82357a_gpib driver loading"); for (i =3D 0; i < MAX_NUM_82357A_INTERFACES; ++i) agilent_82357a_driver_interfaces[i] =3D NULL; - usb_register(&agilent_82357a_bus_driver); - gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE); + + ret =3D usb_register(&agilent_82357a_bus_driver); + if (ret) { + pr_err("agilent_82357a: usb_register failed: error =3D %d\n", ret); + return ret; + } + + ret =3D gpib_register_driver(&agilent_82357a_gpib_interface, THIS_MODULE); + if (ret) { + pr_err("agilent_82357a: gpib_register_driver failed: error =3D %d\n", re= t); + usb_deregister(&agilent_82357a_bus_driver); + return ret; + } =20 return 0; } --=20 2.34.1