From nobody Mon Feb 9 08:34:15 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5A4519ADB0 for ; Mon, 30 Dec 2024 19:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585789; cv=none; b=g5vCb1PLjq0rEHJVgRwWArUOAWCfsa8rzoWm910/htFQsCJTgm/lCJtfGYKYCP29w19TtT24K81fdSIni8AjFBpF2PYdHxd8qjyu6egUg1rGct1ZFsPvFMmCXFSaK5OF5C71ATANPPSYFpnXjW6kTjH85s+5te4JDiZ29KIF4sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585789; c=relaxed/simple; bh=hRTC7gQvIpANVJnSEuSyOS2BqBnaStyxOCR43evHXn8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gplDqnKawcMs8HRWulzN7qd7ViCUvWxK6PNHmfjPaBvf3gwBuUeQGgqkBWM4sblUJmxouwHKAJDgK6uxS29L2wx/5gMWdLT1DD/+f1XOqK/VyabkXeD1J2JMBQK2U+kAFh9uuT4etvDBbhEfxe98SxLCCVIFbEL2PuvEI29ZDug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J+Jm7AId; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J+Jm7AId" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2ee94a2d8d0so1859099a91.2 for ; Mon, 30 Dec 2024 11:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585787; x=1736190587; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mhujBAMi711rX4sFChpTBKWquP7CuLAwL+h0gUNEzis=; b=J+Jm7AIdgD9cUFhBO15eoi7ZlDD+OyEOLyBYEjwliveeCTYJkeHHWYGJUMufMq28qS eWQt9AGVDS51PYcHMd4tX/Suc8GWHjicCF3GaXpGy1oWfuisbiBs1vIvP0ED3+sVjJf3 bpW9MqXMZ2DFVvkhS7gcm2HSdJn1oMkdgzYfAoG9MvedmSLEkJ9TEhGT1nLPri3ITM9i /TTnptOykDYUUarnHc5j1dAeQOZ9rbwiPV9ivjpwCabNSkB2/gnsi1cnkY3hcfBSH0/G LpzO3E8izxC/RQWWczlCVaHB5IydUwq0StPq1dP7gwD1BijrfykRnbAzPikDkIGcDMwX trxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585787; x=1736190587; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mhujBAMi711rX4sFChpTBKWquP7CuLAwL+h0gUNEzis=; b=OF95F2HJRQYuKDWF+vu2nNF4ywbB7LZf8dlV/BxNdejCEkx1q79ibuf3wFe+jC7cCC 3cWY/Rr3RUvrMFD4u7zgjsndXZfmMJygGb/zZjuOv9u/RhHQIgb/FwAKX7bD+lGLGdXn UMSkt1z0plRVEfX4PQE84KfyBHvKM3XsbIuI1QgxVB5kMk91IZjW0hHGEM+HTfQ82vSL H5sbnY4/QnMw7CdNpKLKuq8oXGaTP1CQ1zr4RoY2/CeZ8N9QbVE+xm2avanUjfcz2f5+ Ynl4BZCzINbLzuEeLODiPd510exX0pUk349JP0J4zLxdCY9xMYo1r704DpBXwCntB0KT rwMQ== X-Forwarded-Encrypted: i=1; AJvYcCUeueR7TG11OZwR4II0Pij50WbM2FEX1jIG1LjXrUt5mPDYVd9YwchK33/nx0aMO80yA66IGFx8nXnfT24=@vger.kernel.org X-Gm-Message-State: AOJu0YyBfYrc8uqVI/SIz81Vu8aKjUiORKJFqWHUyNn+3FSS3RAmOwf7 t9J+mR+iQDWGfkEMhtUTxwznCbw8Pxq0SoIsTBqT8IwOo8/pbxr12bxt7g== X-Gm-Gg: ASbGncsb9aI8GuLuEHyoX7ciNnZKovKV3EKkUHxCKgZ6WeqQw3gVqNnLdESsUVLrHsr XB1cTHWIixtIrfj8/Z/oVgDYnNybT3V8u359NeRG2O+XP0TSF+8IozgGMYPzzgAOarakO0fmUNp 2bqLcOQQ8nY7tYupt0Z0uGceeWu+1WleKTgHmvzzAI+NJhLAfn1icziCARN/e3PYgUw7YjCr7U6 NkM0N6GT3V6EPb2dcWhea6YOvwB2R5OR7OeiD/LBOhsGDS9SlKut68= X-Google-Smtp-Source: AGHT+IF9/qByqpXKB+Ti9k6vfHKX4HuRQ4HiRR8hZaip/iJ7Kkkyt/0UlDlW6w0S3pRMjLiWcZPoxQ== X-Received: by 2002:a17:90b:2f46:b0:2ee:a558:b6bf with SMTP id 98e67ed59e1d1-2f452efc09dmr20433792a91.8.1735585787122; Mon, 30 Dec 2024 11:09:47 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:46 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 02/15] staging: gpib: agilent_82350b: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:22 +0530 Message-Id: <20241230185633.175690-3-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail which can result in semi-registered module. In case gpib_register_driver() fails unregister the previous gpib and pci registering functions, return the error value. Add pr_err() when registering driver fails also indicate the error value. Signed-off-by: Nihar Chaithanya --- .../gpib/agilent_82350b/agilent_82350b.c | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers= /staging/gpib/agilent_82350b/agilent_82350b.c index 53006d0cc79c..e9c1f0100b2a 100644 --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c @@ -910,13 +910,30 @@ static int __init agilent_82350b_init_module(void) =20 result =3D pci_register_driver(&agilent_82350b_pci_driver); if (result) { - pr_err("agilent_82350b: pci_driver_register failed!\n"); + pr_err("agilent_82350b: pci_register_driver failed: error =3D %d\n", res= ult); return result; } =20 - gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_MODULE); - gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); + result =3D gpib_register_driver(&agilent_82350b_unaccel_interface, THIS_M= ODULE); + if (result) { + pr_err("agilent_82350b: gpib_register_driver failed: error =3D %d\n", re= sult); + goto err_unaccel; + } + + result =3D gpib_register_driver(&agilent_82350b_interface, THIS_MODULE); + if (result) { + pr_err("agilent_82350b: gpib_register_driver failed: error =3D %d\n", re= sult); + goto err_interface; + } + return 0; + +err_interface: + gpib_unregister_driver(&agilent_82350b_unaccel_interface); +err_unaccel: + pci_unregister_driver(&agilent_82350b_pci_driver); + + return result; } =20 static void __exit agilent_82350b_exit_module(void) --=20 2.34.1