From nobody Mon Feb 9 15:59:14 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52DC7199235 for ; Mon, 30 Dec 2024 19:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585786; cv=none; b=ugdRsO5e+B8tCcYtgvhrw4b60u6eHVK8W+OWsM/CE9J3a1HKydfCqaqpB1A0t+1net+gK6aoyqloqdfah5p0KlGCVrIrJ7QznRlKDaffZMNRZpOCoImBCgjO+zIsLQyX9Js5qHQ5CnGFqyXEe/eo0fILNZxqvcp9TaN+EHhKuio= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585786; c=relaxed/simple; bh=inEhfls+rd5SvLmjK1jyBzMZzSokzL7jOsUV1xrZHjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CtdeyK7svKFkvh5VhSLQmsXlFLd1IBv4FtstFhUInIRpw0t5nNVKnsJvz/88zGjIw85wR9N2/gq3F2W3F8BMvh3hu/IHIelnU+6VHczjdBWDRUU67GT/VAf+cMrhTq6So4gozT79yj7KUkNIsVdRkxmgPeGgdZJaZLY9b3I0Mqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GmV+Do6v; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GmV+Do6v" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2161a4f86a3so11256445ad.1 for ; Mon, 30 Dec 2024 11:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585784; x=1736190584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IAsHzXTlNC3UmvdMU6pJZD9xh8CT7SmzOJpjswVS2/Y=; b=GmV+Do6vi8AeunZqO2IH/ny1ElYY4NRd0pnx6Wc636aGiJdsBgiB0eKoiJOikEP1fG EfQxR4jF6www9yeahl2Dtrw2WEvE5ENZhYRdOOrt0PBY39uCwjD0pvN9OBqJ432qABGk /tUIhtU95gYBTl0GjvfZ8Ep+5SY45bqfy3ooUaKS3A7LA0rbiCc2Yo8ufIaZPDE8lCwr ++1P40/MkrxjtQM3IR1Uivqf8So1cepQcFRTnZGcI4S4MnjirehaKvCwZnu6NoJgTtVR 9V5ErNWp9iqgLEyZRtYuz+ybctrF+BBnviaUDLyq48qqMaaEwBQt491bfJlmc93pvFkb 5p7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585784; x=1736190584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IAsHzXTlNC3UmvdMU6pJZD9xh8CT7SmzOJpjswVS2/Y=; b=Nstgt87mU4cPFX7mHNymlROjE3dkoXy0jmmrsj9CSX1FjfQijmWPCoh3abz9gVh04G RQQDTd6PbwfujwSXBGH+yXYJKKWq4Onuu5kLl2PlfBQN6taSAleYd3ypA6lG2/uJpzMF B7duonM0S/sourZa0k1HduJEEcv20xPmGi/mBH/M2Aq7fFgGYFaRQuqOMBIDlMr0hQ9/ gxl5lzYSecwJ9CzNRRLnAczWUCAX3hmJPU9zVVUMYU2mfRBDh7Uv+2LLI1LLhAJqOZlM Qw6d2yPHYknyfodEQkjrGwjKgpUf7ndDMnSAPy0pbNOBc7tHFyQ0Y078n1H7NKF+YqPG rfnw== X-Forwarded-Encrypted: i=1; AJvYcCWdPm3onOvcqmf/V7KCPV+LwwYOIQi6OzhEwK14yh3YPLgFy3eRJo2k+HQuhNv9B20CZ3+qYtyzC30or8I=@vger.kernel.org X-Gm-Message-State: AOJu0YxUABVE2vLLrR6Bwd8o/AQLeos3I4M/Slo1AaF7j7f/kQgIF9CI Uq3QKolBaqdUSV+fUcxJPDvPRxLyi9oX43IwgfYViV7N0hQBQ4W/ X-Gm-Gg: ASbGncvaNsM57nkEu+Q8wATgeRGBhKOOtKB3kn0MjnxQ2DhCstZdx8158jRWk3Glwa8 0lFu/jBft+nV4c4g2gvegKAIfJv65j0KzPyqIvsd/PIrNvL6dgb5C3QPUus/rUV0kGdqfgQtWUl UHCxTlWNWXKygaVmPyahT7M3KaiVxO2t94fd98K+2gdIU42UFHoiBfn4DA11RwTxQHLYDn5Lgsa 3DTL1zhD7IWjC07JHhz5kLNICWuP5FOs1FZJUDDF933fe5YKLahowo= X-Google-Smtp-Source: AGHT+IG2Am3uEs46mNP4pINCD1qD41B8MIb1NgNJxANN4KQ/6lMIiTFpYbJkGodGiLYXkHYQG7r4lw== X-Received: by 2002:a17:902:c402:b0:216:4339:70f with SMTP id d9443c01a7336-219e6eb45ecmr178090045ad.8.1735585784580; Mon, 30 Dec 2024 11:09:44 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:09:44 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 01/15] staging: gpib: Modify gpib_register_driver() to return error if it fails Date: Tue, 31 Dec 2024 00:26:21 +0530 Message-Id: <20241230185633.175690-2-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail if kmalloc() fails, but it doesn't return any error if that happens. Modify the function to return error i.e int. Return the appropriate error code if it fails. Remove the pr_info() statement. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/common/gpib_os.c | 7 ++++--- drivers/staging/gpib/include/gpibP.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/c= ommon/gpib_os.c index 405237d8cb47..07795df3b721 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2094,18 +2094,19 @@ void init_gpib_descriptor(gpib_descriptor_t *desc) atomic_set(&desc->io_in_progress, 0); } =20 -void gpib_register_driver(gpib_interface_t *interface, struct module *prov= ider_module) +int gpib_register_driver(gpib_interface_t *interface, struct module *provi= der_module) { struct gpib_interface_list_struct *entry; =20 entry =3D kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) - return; + return -ENOMEM; =20 entry->interface =3D interface; entry->module =3D provider_module; list_add(&entry->list, ®istered_drivers); - pr_info("gpib: registered %s interface\n", interface->name); + + return 0; } EXPORT_SYMBOL(gpib_register_driver); =20 diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/in= clude/gpibP.h index 5fc42b645ab7..d0cd42c1a0ad 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -17,7 +17,7 @@ #include #include =20 -void gpib_register_driver(gpib_interface_t *interface, struct module *mod); +int gpib_register_driver(gpib_interface_t *interface, struct module *mod); void gpib_unregister_driver(gpib_interface_t *interface); struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, uns= igned int vendor_id, unsigned int device_id, struct pci_dev *from); --=20 2.34.1