From nobody Sun Feb 8 21:26:44 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB7FD1B0428 for ; Mon, 30 Dec 2024 19:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585821; cv=none; b=igzANuvRtROmepeibS0ZOsFmvSl6QpMe5mlj2eZKq8trGG68yqX9E7V7OWuK6w8k2qj0i4ClFt0Cb9TrN+keqnVIC8QgIx8bQhlRHX7PZmLOJVxogoWCBEY8kMH+O0rU2QyIgp4RGYlo7VQZN4Oym+2JA4u38fuGGl+LrOnRyag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585821; c=relaxed/simple; bh=KPXSXRlBPRMJiHBCXI6kuUDpKB9leNo+bj39A4iYM/M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YHCSHMN3nWnxS2qkVsWGu01YVyElmmqUGHhONwTwq0b6xHEaBYSUfjfzfHXtt0iZ7yzT5akAbdbZmr24atlGpaK6T+J+tCAvBXFwoYJpkC2OSUGBehOgx7Fp/hJm3lsH7jYic7Zz6eAd+TLKuYyz25QTANFVOM7WIwmVImwwZ3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OPttE5i6; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OPttE5i6" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2162699e0ccso13926615ad.0 for ; Mon, 30 Dec 2024 11:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585818; x=1736190618; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i+RtJVGqmy9jZtYoNReryShDgdjIDGmle0Bm8XSJeeM=; b=OPttE5i6yM6SHmI45mKneJU2rjdjLUJ369f+PWRjn4byyJiYfZX25qH54kx7HalNJT aj9Vb0ayfiVo4cMrJUNPNTXD5wVcy6J/BbSz5l1EllSDQaFbir3q5WaPrOzWeg0YlQMF w7ZiRx0Q+fSn9VHVHbm5iPwXRJJyqoMnfIs/amOIV9WTsSvspoRdYIhaa7vo+Ln9hc0L tqEjDQXehwkS7RrfVeyt0Wp9cCd8cyDPy5q19QwyLRfEM9qBxRZ5lZoFmMlnZEWWE5xk 4F0LXhT9z/td9GUe1QGVRliV9QkUrqt9I+SaA8bEbCZiTtUt/taiT0mi1waJkSufoAXL +Ecw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585818; x=1736190618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i+RtJVGqmy9jZtYoNReryShDgdjIDGmle0Bm8XSJeeM=; b=MjvkbYOzpzFNA1fukiKU1RCTmv8JDgEo85ACiYzd0Bnv/kQMqePOiH1HQXzwo0jKcg lhGpPk17XNHCgRB4n0wdVB8zbPBeXm/GNaPfmm2ZNcKyVKFu5FrasoquCS8cHzCodkpo Wqz0qU9pjNt+B1eK/gas33VD+qTOy3d4Ps9Ie5IqDyLMPZ3UwfO4/EZhNKxSbts41lak gQapk5JRtC3g/eDaZsMLuJlnAkbgxfNFLlQbs9QZLm8jenl2ZCG3mGW05Vtn1FIvGkTF XD94jmrwZNQcdQCMoiMRJ60K98M4HFDAQvw4L2F53xgC1i21FV/GU52GiLX0Jt09sc+7 S4CA== X-Forwarded-Encrypted: i=1; AJvYcCVNqC47dklO9/HUYpuatM1by7TqAqDp6ZuIGcWzW0DswsyDtiDpnxfqX6+3mgI+8ZsXiObYjQEH/qjHofg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy12VnK0G/6tZ7Y/biSBBWz2YGX+aq+gIw/2iGR3Hx8xeTyNK2e VKqzRuOIBDh2T5XX7dXLfsTjKoK1LxtH6ekN/qLUm2x7L/1P5hLW X-Gm-Gg: ASbGnctB/WE+hYKVffAmFEInyqrcHVKSNbkt3/eLTp6GMFpYSwd435yHRvsO47d4g4M 5a3MdwvoCzW0xI0ZoJgxaN3izPMPjJE+TizZa2qxIrNlngVp8jYAygnzkFm6BG/eGoLJkAnbsvn YCuVUtCbmQhWFObiNd8ZNZKapbQ4sXOokVVZyiojtHWXztHpLfcmYK1AgZ0v8Ut/dKcV6JZeKww Mc7H1RjGyDndTIFy5/N7qf5QD+l75HedwHacViyJMwADAp7plUtJJ0= X-Google-Smtp-Source: AGHT+IGBiIZXCO3lxy5cPikGgYE0wWN5YV97YMPv75GMxPeGW6irlOBjjMtZCu94t81s0U0kQ9b5xw== X-Received: by 2002:a17:902:e848:b0:215:740b:d3ec with SMTP id d9443c01a7336-219e6f1db38mr191724365ad.14.1735585818107; Mon, 30 Dec 2024 11:10:18 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:10:17 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 14/15] staging: gpib: pc2: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:34 +0530 Message-Id: <20241230185633.175690-15-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail, resulting in a semi-registered module and does not return an error value if it fails. Unregister the previous gpib registering functions if subsequent gpib_register_driver() fail and return the error value. Add pr_err() statements indicating the fail and error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/pc2/pc2_gpib.c | 38 ++++++++++++++++++++++++++--- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/pc2/pc2_gpib.c b/drivers/staging/gpib/pc2= /pc2_gpib.c index 7b3b34f47341..a9aae563f60a 100644 --- a/drivers/staging/gpib/pc2/pc2_gpib.c +++ b/drivers/staging/gpib/pc2/pc2_gpib.c @@ -635,12 +635,42 @@ void pc2_2a_detach(gpib_board_t *board) =20 static int __init pc2_init_module(void) { - gpib_register_driver(&pc2_interface, THIS_MODULE); - gpib_register_driver(&pc2a_interface, THIS_MODULE); - gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE); - gpib_register_driver(&pc2_2a_interface, THIS_MODULE); + int ret; + + ret =3D gpib_register_driver(&pc2_interface, THIS_MODULE); + if (ret) { + pr_err("pc2_gpib: gpib_register_driver failed: error =3D %d\n", ret); + return ret; + } + + ret =3D gpib_register_driver(&pc2a_interface, THIS_MODULE); + if (ret) { + pr_err("pc2_gpib: gpib_register_driver failed: error =3D %d\n", ret); + goto err_pc2a; + } + + ret =3D gpib_register_driver(&pc2a_cb7210_interface, THIS_MODULE); + if (ret) { + pr_err("pc2_gpib: gpib_register_driver failed: error =3D %d\n", ret); + goto err_cb7210; + } + + ret =3D gpib_register_driver(&pc2_2a_interface, THIS_MODULE); + if (ret) { + pr_err("pc2_gpib: gpib_register_driver failed: error =3D %d\n", ret); + goto err_pc2_2a; + } =20 return 0; + +err_pc2_2a: + gpib_unregister_driver(&pc2a_cb7210_interface); +err_cb7210: + gpib_unregister_driver(&pc2a_interface); +err_pc2a: + gpib_unregister_driver(&pc2_interface); + + return ret; } =20 static void __exit pc2_exit_module(void) --=20 2.34.1