From nobody Tue Feb 10 02:59:33 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0541B0F3C for ; Mon, 30 Dec 2024 19:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585817; cv=none; b=HjVOfMJ+y7syNCs/u/L98Mi85u89XklhuaE5QCieBW3xZYnHDeJ2bmgN4dvhydPILeWWFjrG8bWyEW3D33b+UIIYhXxMZjVEm26ei8vShJkn9i+V7Sa+7DGZBHf4sOhphLjqpETY5V4ZMAafM2iPO+213McXHIs0ARckBYpV9z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585817; c=relaxed/simple; bh=YMqc4H3fgdJVkppKOUIV9sXcrnbeGdblny71kyRvo4c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XMr7MhZRYN+jfLM5wgGCxFnHBro40ctqdo3C4ppAUWSOk3ICxevbdML5OUZ2GxAqsrf35CU1A0sKGwRONpnsuK+NJLrM9zgIceRCy/i9NnJ5PcjBQ/lGcQZEXTfJLawYieE0W4u0zyMcBwPabm9B8sBrgnYRvdRYCFZDi3iK9ow= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sw0BSHeJ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sw0BSHeJ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2162699e0ccso13926555ad.0 for ; Mon, 30 Dec 2024 11:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585815; x=1736190615; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2sVOBVrwEeE+JJiB+YOksNrh6jAvMviZPje1pPppbw=; b=Sw0BSHeJB8Vocw6le+H2vxMCUMt8MHUOS1LYOMIQ2E5aG0nItXjKpuhKkfKnqmWffJ bxiodvCqfrbGKskIGXK3BkIStpTe1UG8OIbXbtCMeE+dg/QyBEK0kbu0TxNBGWlE4dpL ogXwP3TYpaL3PNC9IQwLZlDMhcxNxQdVCLOYxdPy1mjI/8trZTT/WPNOegffGJjiSTSl L+vd2UQIJv1xF2g3xjoxbS7rluEAFRhc8k7sTxXtGyoNmSecjbx61PZoDpr8vvDptsPo 5wPcGayW4RKMzSOVp0Lp1CHF7jN81+fNjxR/03Dx8GWgLLXWElfGHhWnzJWvyQR/qggo hDbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585815; x=1736190615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2sVOBVrwEeE+JJiB+YOksNrh6jAvMviZPje1pPppbw=; b=FnKau9EAxVRI1EbRe63rGqEttKQ1vRTTRpT6Txj6aKstbubaa+mWYw0oPgrhpD1VcM L+asfGr/+GLb+xz8dZNp7RECDCdnILhaJXaukvvt5vIo9GWXZ1y1thWDjfC+XZb6zZQw Jjf4mISA+K6usZIJdbgFddsvpSbMLelMW3ddpZfgBI4DtcBGrRKXul+IhNdDE/3d7xeg RjUlwQ1AjG6RZhfPmYBKoM8StYrrhQ9nKZa9SMLjwWPiUHXT9v6i3mcuWAy4wa9HWkkB gHKe8cPpDB7qZa4ufwiYxKLmGuKA53Xyjlps0pAwkw5FWzosrskXnOvz4DrNvWAO5J8v VpAQ== X-Forwarded-Encrypted: i=1; AJvYcCXhlkcYzDs33o/XBo9KOiDtU+2d5iG8KGESvEr2x9vYCA7sx/ClKJnL2/e4QHEAaDzSIJyolKndJR/8hUg=@vger.kernel.org X-Gm-Message-State: AOJu0YwnHD96OUW/pzLjsPq2tyvNuOcPiKrlazsmV0SsTn54tnGTAGyJ 2gaDs3PcEVHxdPxq0sFRHrlSLAemJwMX/Fi0WH8aD59LTXkHVtGo X-Gm-Gg: ASbGncvnu562/mAwe9vVR1l2vfjB4DHGIrcwhBXslueImjTBOm1kcZKqh+POQSaPrFL i7auAwTqnaOCANnNDdjMRkDL1n7+yBrJ28cJagJT0b+LFIv/HH1pdhoTuwqVePTpNRHWJSaaN8y C46TnmJUkOik5/ttfI4oFKAq7RfWClmYCw8XpW3NG+FlfeE9Dh7MT11p/NkQwfTmcYzRHCIRGkR uO7gRYnrs0Gf6iGx+J5OfeiXD/ktd7aa4iNHWJ8SVieGEeKTDemSKg= X-Google-Smtp-Source: AGHT+IHnajyFEDG6mFVW8FWpXBUQF0MsBPPHjjNZiErai7Shi6fRF4Zdw2iiQMPTdQCda6s1ZqNVPg== X-Received: by 2002:a17:902:c951:b0:216:1d5a:f348 with SMTP id d9443c01a7336-219e6f09036mr199112775ad.11.1735585815438; Mon, 30 Dec 2024 11:10:15 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:10:15 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 13/15] staging: gpib: ni_usb: Handle gpib_register_driver() errors Date: Tue, 31 Dec 2024 00:26:33 +0530 Message-Id: <20241230185633.175690-14-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The usb_register() function can fail and returns an error value which is not returned. The function gpib_register_driver() can also fail which can result in semi-registered module. In case gpib_register_driver() fails unregister the previous usb driver registering function. Return the error value if gpib_register_driver() or usb_register() functions fail. Add pr_err() statements indicating the fail and error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gp= ib/ni_usb/ni_usb_gpib.c index b7b6fb1be379..b1b9598c3b33 100644 --- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c +++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c @@ -2619,12 +2619,23 @@ static struct usb_driver ni_usb_bus_driver =3D { static int __init ni_usb_init_module(void) { int i; + int ret; =20 pr_info("ni_usb_gpib driver loading\n"); for (i =3D 0; i < MAX_NUM_NI_USB_INTERFACES; i++) ni_usb_driver_interfaces[i] =3D NULL; - usb_register(&ni_usb_bus_driver); - gpib_register_driver(&ni_usb_gpib_interface, THIS_MODULE); + + ret =3D usb_register(&ni_usb_bus_driver); + if (ret) { + pr_err("ni_usb_gpib: usb_register failed: error =3D %d\n", ret); + return ret; + } + + ret =3D gpib_register_driver(&ni_usb_gpib_interface, THIS_MODULE); + if (ret) { + pr_err("ni_usb_gpib: gpib_register_driver failed: error =3D %d\n", ret); + return ret; + } =20 return 0; } --=20 2.34.1