From nobody Sun Feb 8 21:27:06 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793261B0428 for ; Mon, 30 Dec 2024 19:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585814; cv=none; b=T+knEn6bL1BfAp2Fay3O9LA62T4PRM3aps5m23QfV/ZE0BRsWXfvOfzn3uIOGRfQdv3PLwec1JnVvmvnlW+2X6pM7z6WT+Q8DY9PxCyT1Ajui7evN/NnOpxXQYc35d6jYgpqwLCOv0lcbn3t1wRQIprfTDIumzyJEwYgMdAojAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735585814; c=relaxed/simple; bh=bryvN6+ttkW0iQP98mReS5unZVw3gunWkrBDholDReM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JJlJJb9uL2gPU3sXvDq3/gp/Y6YByv9V6ZxWg/3VD23aIRcCn99N30pa6YgsYd5eeMuPaEXqQVAx3uHI1Tir/hj6xEVCRI0unhlejSOAFRUNdJihW7nvQUGj9/XA4Z78/rGrCv5hvtKcRs5p1D1h+ipSOz1OxK4IXcpIjjF88tk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e5Aq2+Vs; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e5Aq2+Vs" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2162699e0ccso13926515ad.0 for ; Mon, 30 Dec 2024 11:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735585813; x=1736190613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XgdsETXzbb58Msi7wLGZzMbq/x8TvmIWWt76a/4RotQ=; b=e5Aq2+VsIDxMbpDEEr/EGl/vaVut4bbxdTHpM6m5bhbSGW4qlQj+8T8AthRsWAs6t/ XVy0pH9Z6aa7fM2+hVPBw4xAkYjrAmnywQnx2GRN1HTXtBW9xsvrz0e5GruAtVaulV6Z IluTzPNSvY3MG2L/zJ6UhdBtnNR3/ORMkVPxaKYbKF6NiqVVMIZ8AfJAxosrbg/nnVi5 YYskFX782sZ0bZ+CrEwh0pOduEwbnZ1obg6YDG3Ci322xoig872/rcpFL1bQFV/zAMuW T3uZdSMZLQK88np/56iV1gAT9FKawUG0ii2y/NcZo5vEhAB/xnfOlaGdimOORVoCuXck D8RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735585813; x=1736190613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XgdsETXzbb58Msi7wLGZzMbq/x8TvmIWWt76a/4RotQ=; b=W/d0E26G0MXUTf0BhSPfIXW+FUi7IJiX7PTWY0NhZyflTipMVF/uxIEG0E6fKWVcq/ f4X1lj5Q+avbqaZ9jTd6oiQMDTkRGQwgxaDtFpgO4hPbzAhWT6RxyJBJuJ+UV61fXYve 0My2MvW+t2kNx53ly2QEgnNeFT3Jfa3PAbhJUcKwXUP/riqgRC7JgNPIeiAEtfDEqK8L qP48oHXAogeKyEuLeu8DjILfHsaS/jRSA0kR/bRVzvZHxaAf8GlL4n6r3G1R6+rnBMkA TrXBZQkC4nrakFR20g7sps9wwhyGfKqhUKKOQ6j5iOpBeYZ5qRAJfbRwIM1j6TD1ivNe fkFA== X-Forwarded-Encrypted: i=1; AJvYcCUDOFJ0ac5HDiRpI0qjJWgeZpZr9tfIskPqHQMhM3zop3FpMVjKPPbdKeJtjxd/W9k0iuZHN3Y6AgB8sow=@vger.kernel.org X-Gm-Message-State: AOJu0YznAvO8oQM2SH3JmIPnj2uCB4rjxJcJYm6+4deEfWZHe6dECN6M Lov0xvh+yJjwnu3EsQ3TFp1NkNweK80DpsdBhg0IMawZ6PySrtsA X-Gm-Gg: ASbGncsVdQ6W73/GWkW9C61MoMlvB9SLX614btItgglgcQmkTBR/XnJPj7v6scSOrk3 njf4KyEuPvUhZ5PMDh0c8gYWKc4T/Z+hZXHyi16gLw335RXMNFwAd4dOy1KCScsuPhEK1uWgeVZ rD7SF7H78lk/UYv29cCkxz17FI9oAmboHpTuTgutTAQWrymw0cAB6niuzJeCK8pprwIa+lj+B8a z2cZ/wf4fbyTMyNhq14R318kvBEGwNqWb5EEO35ZBnPvRXTfXODKKo= X-Google-Smtp-Source: AGHT+IFEZDT0ZZZpAkuuwgyTJG0aVUCftQTdq8RZZXS1UgwHG70xom4o6GAMN0sSNki6+CrsR71DHg== X-Received: by 2002:a17:903:228d:b0:215:a96d:ec36 with SMTP id d9443c01a7336-219e6e9a86fmr185039395ad.5.1735585812880; Mon, 30 Dec 2024 11:10:12 -0800 (PST) Received: from ice.. ([171.76.81.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc964f09sm182886795ad.26.2024.12.30.11.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2024 11:10:12 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v6 12/15] staging: gpib: lpvo_usb: Return error value from gpib_register_driver() Date: Tue, 31 Dec 2024 00:26:32 +0530 Message-Id: <20241230185633.175690-13-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241230185633.175690-1-niharchaithanya@gmail.com> References: <20241230185633.175690-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gpib_register_driver() can fail and does not return an error value if it fails. Return the error value if gpib_register_driver() fails. Add pr_err() statement indicating the fail and error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/s= taging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c index 796c3a5be545..5e279d41e3f9 100644 --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c @@ -1181,7 +1181,11 @@ static int usb_gpib_init_module(struct usb_interface= *interface) return rv; =20 if (!assigned_usb_minors) { - gpib_register_driver(&usb_gpib_interface, THIS_MODULE); + rv =3D gpib_register_driver(&usb_gpib_interface, THIS_MODULE); + if (rv) { + pr_err("lpvo_usb_gpib: gpib_register_driver failed: error =3D %d\n", rv= ); + goto exit; + } } else { /* check if minor is already registered - maybe useless, but if * it happens the code is inconsistent somewhere --=20 2.34.1